@dsivd/prestations-ng 14.5.15 → 14.5.16-beta1

package/CHANGELOG.md

@@ -25,7 +25,16 @@ A change is considered **breaking** if you have to change your code or update yo
     -   adding a new constructor argument in one of our service is OK, if you just have to update your constructor's signature and your call to `super(...)`
 
 ---
+## [14.5.16]
 
+### Updated
+
+- [session-info.service.ts](projects/prestations-ng/src/sdk-session-info/session-info.service.ts)
+  - `SessionInfoData` data getter now depends on `neverConnected` attribute to avoid unnecessary calls to sessionInfo api (PRESTAKIT-364). 
+  - To retrieve `SessionInfoData` data from api url, you need to explicitly set `neverConnected` attribute to `false`.
+
+- [foehn-page.component.ts](projects/prestations-ng/src/foehn-page/foehn-page.component.ts)
+  - `@Input() neverConnected` is now set to `false` by default to retrieve `SessionInfoData` data for backwards compatibility purposes.
 
 ## [14.5.15]
 ### Added

package/bundles/dsivd-prestations-ng.umd.js

@@ -867,52 +867,79 @@
 
     var SESSION_INFO_API_URL = 'api/sessionInfo/data';
     var SessionInfo = /** @class */ (function () {
-        function SessionInfo(http) {
+        function SessionInfo(http, growlService, ngZone) {
             this.http = http;
+            this.growlService = growlService;
+            this.ngZone = ngZone;
+            this.neverConnected_ = new rxjs.BehaviorSubject(undefined);
         }
         Object.defineProperty(SessionInfo.prototype, "data", {
             get: function () {
                 var _this = this;
-                if (this.neverConnected_) {
-                    return rxjs.of(null);
-                }
-                else {
-                    if (!this.pulling_) {
-                        this.pulling_ = this.http
-                            .get(SESSION_INFO_API_URL)
-                            .pipe(operators.map(function (r) {
-                            if (r) {
-                                return (_this.sessionData = r);
-                            }
-                            return null;
-                        }), operators.shareReplay(1));
+                return this.neverConnected_.asObservable().pipe(operators.tap(function () {
+                    if (_this.timeoutLogError) {
+                        clearTimeout(_this.timeoutLogError);
                     }
-                    return this.pulling_;
-                }
+                }), operators.switchMap(function (neverConnected) {
+                    if (neverConnected !== false) {
+                        if (neverConnected === undefined) {
+                            _this.logErrorNeverConnectedIsNotSet();
+                        }
+                        if (!_this.onMicroTaskEmptyPulling_) {
+                            // Need 'onMicrotaskEmpty' to avoid 'ExpressionChangedAfterItHasBeenCheckedError'
+                            _this.onMicroTaskEmptyPulling_ = _this.ngZone.onMicrotaskEmpty.pipe(operators.first(), operators.map(function () { return null; }), operators.shareReplay(1));
+                        }
+                        return _this.onMicroTaskEmptyPulling_;
+                    }
+                    else {
+                        if (!_this.pulling_) {
+                            _this.pulling_ = _this.http
+                                .get(SESSION_INFO_API_URL)
+                                .pipe(operators.catchError(function () {
+                                var message = 'Impossible de récupérer les informations de la personne connectée';
+                                _this.growlService.addWithType(GrowlType.DANGER, message);
+                                return rxjs.of(null);
+                            }), operators.map(function (r) {
+                                if (r) {
+                                    return (_this.sessionData = r);
+                                }
+                                return null;
+                            }), operators.shareReplay(1));
+                        }
+                        return _this.pulling_;
+                    }
+                }));
             },
             enumerable: false,
             configurable: true
         });
         Object.defineProperty(SessionInfo.prototype, "neverConnected", {
             get: function () {
-                return this.neverConnected_;
+                return this.neverConnected_.getValue();
             },
             set: function (neverConnected) {
-                this.neverConnected_ = neverConnected;
+                this.neverConnected_.next(neverConnected);
             },
             enumerable: false,
             configurable: true
         });
+        SessionInfo.prototype.logErrorNeverConnectedIsNotSet = function () {
+            // Use of setTimeout to avoid unnecessary error log
+            this.timeoutLogError = setTimeout(function () {
+                console.error("Error: 'neverConnected' is not set. " +
+                    'Find more at https://dsi-vd.github.io/prestations-ng/CHANGELOG.md#_14_5_16_');
+            }, 2000);
+        };
         return SessionInfo;
     }());
-    SessionInfo.ɵfac = i0__namespace.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: SessionInfo, deps: [{ token: i1__namespace.HttpClient }], target: i0__namespace.ɵɵFactoryTarget.Injectable });
+    SessionInfo.ɵfac = i0__namespace.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: SessionInfo, deps: [{ token: i1__namespace.HttpClient }, { token: GrowlBrokerService }, { token: i0__namespace.NgZone }], target: i0__namespace.ɵɵFactoryTarget.Injectable });
     SessionInfo.ɵprov = i0__namespace.ɵɵngDeclareInjectable({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: SessionInfo, providedIn: 'root' });
     i0__namespace.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: SessionInfo, decorators: [{
                 type: i0.Injectable,
                 args: [{
                         providedIn: 'root'
                     }]
-            }], ctorParameters: function () { return [{ type: i1__namespace.HttpClient }]; } });
+            }], ctorParameters: function () { return [{ type: i1__namespace.HttpClient }, { type: GrowlBrokerService }, { type: i0__namespace.NgZone }]; } });
 
     var GesdemHandlerService = /** @class */ (function () {
         function GesdemHandlerService(http, growlService, validationHandlerService, router, route, errorHandlerService, sessionInfo) {
@@ -3262,12 +3289,14 @@
             else {
                 this._validationHandlerService.shouldDisplayErrors(true);
             }
-            this.sendForFormConcurrentSafe.subscribe(function () { return _this.onFormSent(goToNextPage); });
+            this.sendForFormConcurrentSafe
+                .pipe(operators.first())
+                .subscribe(function () { return _this.onFormSent(goToNextPage); });
         };
         AbstractPageComponent.prototype.transmit = function () {
             var _this = this;
             this._validationHandlerService.shouldDisplayErrors(true);
-            this.transmitConcurrentSafe.subscribe(function () {
+            this.transmitConcurrentSafe.pipe(operators.first()).subscribe(function () {
                 if (!_this._gesdemService.lastResponse.errors.length) {
                     _this._gesdemEventService.formTransmittedSubject.next(_this._gesdemService.lastResponse);
                     _this._navigation.next();
@@ -5738,6 +5767,7 @@
             this.sessionInfo = sessionInfo;
             this.foehnPageModalService = foehnPageModalService;
             this.sdkDictionaryService = sdkDictionaryService;
+            this.neverConnected = false;
             this.supportAlertEnabled = true;
             this.userConnectedAsDisplayed = true;
             this.confirmLeavingAlert = {