@ds-sfdc/sfparty 1.3.15 → 1.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ds-sfdc/sfparty",
-  "version": "1.3.15",
+  "version": "1.4.0",
   "description": "Salesforce metadata XML splitter for CI/CD",
   "type": "module",
   "repository": {
@@ -24,7 +24,6 @@
   "license": "BSD-3-Clause",
   "dependencies": {
     "axios": "^1.2.2",
-    "chai-as-promised": "^7.1.1",
     "cli-color": "^2.0.3",
     "cli-spinners": "^2.7.0",
     "convert-hrtime": "^5.0.0",
@@ -48,10 +47,8 @@
     "babel-jest": "^29.3.1",
     "husky": "^8.0.3",
     "jest": "^29.3.1",
-    "mocha": "^10.2.0",
     "nodemon": "^2.0.20",
-    "prettier": "^2.8.3",
-    "should": "^7.1.0"
+    "prettier": "^2.8.3"
   },
   "engines": {
     "node": ">=0.11"

package/src/index.js

@@ -4,6 +4,7 @@ import { spawnSync, spawn, execSync } from 'child_process'
 import fs from 'fs'
 import path from 'path'
 import yargs from 'yargs'
+import xml2js from 'xml2js'
 import { hideBin } from 'yargs/helpers'
 import winston from 'winston'
 import clc from 'cli-color'
@@ -22,6 +23,7 @@ import * as permsetDefinition from './meta/PermissionSets.js'
 import * as workflowDefinition from './meta/Workflows.js'
 import { checkVersion } from './lib/checkVersion.js'
 import * as git from './lib/gitUtils.js'
+import * as packageUtil from './lib/packageUtil.js'
 
 const processStartTime = process.hrtime.bigint()
 
@@ -109,7 +111,8 @@ let errorMessage = clc.red(
 		clc.whiteBright.bgRedBright('combine') +
 		'.',
 )
-
+let addPkg
+let desPkg
 displayHeader() // display header mast
 
 let checkYargs = false
@@ -254,7 +257,32 @@ yargs(hideBin(process.argv))
 			})
 			startProm.then((result) => {
 				global.git.enabled = result
-				combineHandler(argv, processStartTime)
+
+				if (global.git.enabled) {
+					let addManifest =
+						argv.package || 'manifest/package-party.xml'
+					let desManifest =
+						argv.destructive ||
+						'manifest/destructiveChanges-party.xml'
+
+					addPkg = new packageUtil.Package(addManifest)
+					desPkg = new packageUtil.Package(desManifest)
+					const prom1 = addPkg.getPackageXML(fileUtils)
+					const prom2 = desPkg.getPackageXML(fileUtils)
+
+					Promise.allSettled([prom1, prom2]).then((results) => {
+						const rejected = results.filter(
+							(p) => p.status === 'rejected',
+						)
+						if (rejected.length > 0) {
+							throw new Error(rejected[0].value)
+						} else {
+							combineHandler(argv, processStartTime)
+						}
+					})
+				} else {
+					combineHandler(argv, processStartTime)
+				}
 			})
 			startProm.catch((error) => {
 				global.displayError(error, true)
@@ -565,6 +593,10 @@ function combineHandler(argv, startTime) {
 					fs,
 				})
 			}
+			if (global.git.enabled) {
+				addPkg.savePackage(xml2js, fileUtils)
+				desPkg.savePackage(xml2js, fileUtils)
+			}
 			if (argv.type === undefined || argv.type.split(',').length > 1) {
 				let message = `Split completed in `
 				displayMessageAndDuration(startTime, message)
@@ -599,8 +631,6 @@ function processCombine(typeItem, argv) {
 		let name = argv.name
 		let all =
 			argv.type === undefined || name === undefined ? true : argv.all
-		let addManifest = argv.package
-		let desManifest = argv.destructive
 
 		sourceDir = path.join(
 			global.__basedir,
@@ -680,13 +710,13 @@ function processCombine(typeItem, argv) {
 		processList.forEach((metaDir) => {
 			const metadataItem = new metadataCombine.Combine({
 				metadataDefinition: typeObj.definition,
-				sourceDir: sourceDir,
-				targetDir: targetDir,
-				metaDir: metaDir,
+				sourceDir,
+				targetDir,
+				metaDir,
 				sequence: promList.length + 1,
 				total: processed.total,
-				addManifest: addManifest,
-				desManifest: desManifest,
+				addPkg,
+				desPkg,
 			})
 			const metadataItemProm = metadataItem.combine()
 			promList.push(metadataItemProm)

package/src/party/combine.js

@@ -15,7 +15,6 @@ const processed = {
 	current: 0,
 	type: undefined,
 }
-
 export class Combine {
 	#type = undefined
 	#root = undefined
@@ -33,8 +32,7 @@ export class Combine {
 		mtime: undefined,
 	}
 	#json = {}
-	#addPkg = undefined
-	#desPkg = undefined
+	#diffOnly = false
 
 	constructor(config) {
 		this.metadataDefinition = config.metadataDefinition
@@ -43,9 +41,8 @@ export class Combine {
 		this.metaDir = config.metaDir
 		this.sequence = config.sequence
 		this.total = config.total
-		this.addManifest = config.addManifest || 'manifest/package-party.xml'
-		this.desManifest =
-			config.desManifest || 'manifest/destructiveChanges-party.xml'
+		this.addPkg = config.addPkg
+		this.desPkg = config.desPkg
 	}
 
 	get metadataDefinition() {
@@ -86,6 +83,12 @@ export class Combine {
 	combine() {
 		return new Promise((resolve, reject) => {
 			const that = this
+			that.#diffOnly =
+				global.metaTypes[that.metadataDefinition.alias].add.files
+					.length > 0 ||
+				global.metaTypes[that.metadataDefinition.alias].remove.files
+					.length > 0
+
 			if (!fileUtils.directoryExists({ dirPath: that.sourceDir, fs }))
 				reject(`Path does not exist: ${that.sourceDir}`)
 			let types = ['directories', 'singleFiles', 'main']
@@ -111,38 +114,39 @@ export class Combine {
 				that.#json[key] = undefined
 			})
 
-			if (global.git.enabled) {
-				that.#addPkg = new packageUtil.Package(that.addManifest)
-				that.#desPkg = new packageUtil.Package(that.desManifest)
-				const prom1 = that.#addPkg.getPackageXML(fileUtils)
-				const prom2 = that.#desPkg.getPackageXML(fileUtils)
-
-				Promise.allSettled([prom1, prom2]).then((results) => {
-					const rejected = results.filter(
-						(p) => p.status === 'rejected',
-					)
-					if (rejected.length > 0) {
-						reject(rejected[0].value)
-					} else {
-						resolve(processStart(that))
-					}
-				})
-			} else {
-				resolve(processStart(that))
-			}
+			resolve(processStart(that))
 		})
 
 		function processStart(that) {
-			let success = getXML(that)
+			let success = processParts(that)
 			if (success) {
 				if (
 					!that.metadataDefinition.packageTypeIsDirectory &&
 					global.git.enabled
 				) {
-					that.#addPkg.addMember(that.#root, that.#fileName.shortName)
+					if (
+						!that.#diffOnly ||
+						global.metaTypes[that.metadataDefinition.alias].add
+							.files.length > 0
+					) {
+						that.addPkg.addMember(
+							that.#root,
+							that.#fileName.shortName,
+						)
+					}
+
+					if (
+						that.#diffOnly &&
+						global.metaTypes[that.metadataDefinition.alias].remove
+							.files.length > 0
+					) {
+						that.desPkg.addMember(
+							that.#root,
+							that.#fileName.shortName,
+						)
+					}
 				}
 				saveXML(that)
-				if (global.git.enabled) savePackageXML(that)
 				return true
 			} else {
 				logUpdate(
@@ -168,20 +172,14 @@ export class Combine {
 					!that.metadataDefinition.packageTypeIsDirectory &&
 					global.git.enabled
 				) {
-					that.#desPkg.addMember(that.#root, that.#fileName.shortName)
+					that.desPkg.addMember(that.#root, that.#fileName.shortName)
 				}
-				deleteFile(that.#fileName.fullName)
-				if (global.git.enabled) savePackageXML(that)
+				deleteFile(that, that.#fileName.fullName)
 				return 'deleted'
 			}
 		}
 
-		function savePackageXML(that) {
-			that.#addPkg.savePackage(xml2js, fileUtils)
-			that.#desPkg.savePackage(xml2js, fileUtils)
-		}
-
-		function getXML(that) {
+		function processParts(that) {
 			if (processed.type != that.#root) {
 				processed.current = 0
 				processed.type = that.#root
@@ -320,11 +318,28 @@ export class Combine {
 					processFile(that, key, fileObj)
 				})
 			}
+
+			const filteredArray = global.metaTypes[
+				that.metadataDefinition.alias
+			].remove.files.filter((filePath) =>
+				filePath.startsWith(
+					path.join(that.sourceDir, that.metaDir, key),
+				),
+			)
+			filteredArray.forEach((file) => {
+				const fileObj = {
+					shortName: path.basename(file),
+					fullName: file,
+				}
+				processFile(that, key, fileObj)
+			})
+
 			return true
 		}
 
-		function deleteFile(fileName) {
+		function deleteFile(that, fileName) {
 			fileUtils.deleteFile(fileName)
+			fileUtils.deleteDirectory(path.join(that.sourceDir, that.metaDir))
 		}
 
 		function processFile(
@@ -349,6 +364,16 @@ export class Combine {
 				)
 			}
 
+			const diffFiles = global.metaTypes[
+				that.metadataDefinition.alias
+			].add.files.concat(
+				global.metaTypes[that.metadataDefinition.alias].remove.files,
+			)
+
+			if (that.#diffOnly) {
+				if (!diffFiles.includes(fileObj.fullName)) return true
+			}
+
 			if (!fileUtils.fileExists({ filePath: fileObj.fullName, fs })) {
 				// File does not exist
 				// If file is main.yaml, then return false to indicate that the XML file should be deleted
@@ -375,19 +400,19 @@ export class Combine {
 						path.dirname(fileObj.fullName).split('/').pop() in
 							that.metadataDefinition.package
 					) {
-						that.#desPkg.addMember(
+						that.desPkg.addMember(
 							that.metadataDefinition.package[
-								that.#fileName.shortName +
-									'.' +
-									path
-										.dirname(fileObj.fullName)
-										.split('/')
-										.pop()
+								path.dirname(fileObj.fullName).split('/').pop()
 							],
-							fileObj.shortName.replace(`.${global.format}`, ''),
+							that.#fileName.shortName +
+								'.' +
+								fileObj.shortName.replace(
+									`.${global.format}`,
+									'',
+								),
 						)
 					} else if (that.metadataDefinition.packageTypeIsDirectory) {
-						that.#desPkg.addMember(
+						that.desPkg.addMember(
 							that.#root,
 							fileObj.shortName.replace(`.${global.format}`, ''),
 						)
@@ -459,16 +484,16 @@ export class Combine {
 					path.dirname(fileObj.fullName).split('/').pop() in
 						that.metadataDefinition.package
 				) {
-					that.#addPkg.addMember(
+					that.addPkg.addMember(
 						that.metadataDefinition.package[
-							that.#fileName.shortName +
-								'.' +
-								path.dirname(fileObj.fullName).split('/').pop()
+							path.dirname(fileObj.fullName).split('/').pop()
 						],
-						fileObj.shortName.replace(`.${global.format}`, ''),
+						that.#fileName.shortName +
+							'.' +
+							fileObj.shortName.replace(`.${global.format}`, ''),
 					)
 				} else if (that.metadataDefinition.packageTypeIsDirectory) {
-					that.#addPkg.addMember(
+					that.addPkg.addMember(
 						that.#root,
 						fileObj.shortName.replace(`.${global.format}`, ''),
 					)