@drzl/validation-core 2.1.0 → 3.0.0

package/dist/index.cjs

@@ -100362,12 +100362,11 @@ function validateAffix(affix, schemaSuffix) {
 }
 
 // src/index.ts
-function isGeneratedColumn(c5, primaryKeyColumns) {
-  return c5.isGenerated || primaryKeyColumns.includes(c5.name);
+function isGeneratedColumn(c5, _primaryKeyColumns = []) {
+  return c5.isGenerated;
 }
 function insertColumns(table) {
-  const pkCols = table.primaryKey?.columns ?? [];
-  return table.columns.filter((c5) => !isGeneratedColumn(c5, pkCols));
+  return table.columns.filter((c5) => !isGeneratedColumn(c5));
 }
 function updateColumns(table) {
   const pkCols = table.primaryKey?.columns ?? [];

package/dist/index.d.cts

@@ -223,7 +223,21 @@ interface ValidationRenderer<TOptions extends ValidationGenerateOptions = Valida
     renderIndex?(analysis: Analysis, opts?: TOptions): string;
     generate(opts: TOptions): Promise<string[]>;
 }
-declare function isGeneratedColumn(c: Column, primaryKeyColumns: string[]): boolean;
+/**
+ * Whether the database generates this column's value, so it cannot be written.
+ *
+ * `primaryKeyColumns` is accepted for backwards compatibility and no longer consulted. It used
+ * to make every primary key count as generated, which dropped it from the insert schema whether
+ * or not the database supplied it. Right for a MySQL autoincrement column; wrong for a Postgres
+ * `integer('id').primaryKey()`, which Postgres does not generate, and for any natural key such
+ * as `text('slug').primaryKey()`. Those inserts became impossible to express: the required
+ * column was simply absent, with no way to provide it.
+ *
+ * Being a key says nothing about who supplies the value. `isGenerated` marks a column that
+ * cannot be written; `hasDefault` marks one that need not be, and those stay in the schema as
+ * optional.
+ */
+declare function isGeneratedColumn(c: Column, _primaryKeyColumns?: string[]): boolean;
 declare function insertColumns(table: Table): Column[];
 declare function updateColumns(table: Table): Column[];
 declare function selectColumns(table: Table): Column[];

package/dist/index.d.ts

@@ -223,7 +223,21 @@ interface ValidationRenderer<TOptions extends ValidationGenerateOptions = Valida
     renderIndex?(analysis: Analysis, opts?: TOptions): string;
     generate(opts: TOptions): Promise<string[]>;
 }
-declare function isGeneratedColumn(c: Column, primaryKeyColumns: string[]): boolean;
+/**
+ * Whether the database generates this column's value, so it cannot be written.
+ *
+ * `primaryKeyColumns` is accepted for backwards compatibility and no longer consulted. It used
+ * to make every primary key count as generated, which dropped it from the insert schema whether
+ * or not the database supplied it. Right for a MySQL autoincrement column; wrong for a Postgres
+ * `integer('id').primaryKey()`, which Postgres does not generate, and for any natural key such
+ * as `text('slug').primaryKey()`. Those inserts became impossible to express: the required
+ * column was simply absent, with no way to provide it.
+ *
+ * Being a key says nothing about who supplies the value. `isGenerated` marks a column that
+ * cannot be written; `hasDefault` marks one that need not be, and those stay in the schema as
+ * optional.
+ */
+declare function isGeneratedColumn(c: Column, _primaryKeyColumns?: string[]): boolean;
 declare function insertColumns(table: Table): Column[];
 declare function updateColumns(table: Table): Column[];
 declare function selectColumns(table: Table): Column[];

package/dist/index.js

@@ -166,12 +166,11 @@ function validateAffix(affix, schemaSuffix) {
 }
 
 // src/index.ts
-function isGeneratedColumn(c, primaryKeyColumns) {
-  return c.isGenerated || primaryKeyColumns.includes(c.name);
+function isGeneratedColumn(c, _primaryKeyColumns = []) {
+  return c.isGenerated;
 }
 function insertColumns(table) {
-  const pkCols = table.primaryKey?.columns ?? [];
-  return table.columns.filter((c) => !isGeneratedColumn(c, pkCols));
+  return table.columns.filter((c) => !isGeneratedColumn(c));
 }
 function updateColumns(table) {
   const pkCols = table.primaryKey?.columns ?? [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@drzl/validation-core",
-  "version": "2.1.0",
+  "version": "3.0.0",
   "private": false,
   "license": "Apache-2.0",
   "type": "module",
@@ -11,7 +11,7 @@
   ],
   "sideEffects": false,
   "dependencies": {
-    "@drzl/analyzer": "^1.4.0"
+    "@drzl/analyzer": "^1.5.0"
   },
   "devDependencies": {
     "tsup": "^8.5.0",