@droponair/sdk-js 0.24.0 → 0.24.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.24.2
+
+- Fix: E2EE group message decryption failed because the decrypt AAD bound `recipientId` to the group id instead of the receiving user's own id (which is what the sender encrypts against). Now matches the sender and the other SDKs. Requires sdk-be that preserves the sender timestamp on group notifications.
+
+## 0.24.1
+
+- Fix: incoming frame classifier misrouted server-pushed Event and Broadcast frames as group messages (protobuf field overlap), so `onBroadcast` never fired and events like `LIMIT_REACHED` were swallowed. Event is now probed with a strict type check before group/broadcast/ack, and group notifications additionally require `senderDeviceId`.
+
 All notable changes to the DropOnAir JS SDK will be documented in this file.
 
 This project follows [Semantic Versioning](https://semver.org/).

package/dist/core/messaging-client.js

@@ -1580,7 +1580,12 @@ class MessagingClient {
                 plaintext = await this.cryptoService.decrypt(myPayload.encryptedPayload, sharedKey, {
                     messageId: notif.messageId,
                     senderId: notif.fromUserId,
-                    recipientId: notif.groupId,
+                    // AAD recipientId is the receiving user's own id — this MUST match the
+                    // sender's encrypt AAD, which binds recipientId to the target member's
+                    // userId (memberId). Using notif.groupId here (the previous value) never
+                    // matched, so E2EE group messages failed GCM auth on decrypt. android /
+                    // ios / unity already bind this to the recipient's own id.
+                    recipientId: this.currentUserId,
                     timestamp: notif.timestamp,
                 });
             }

package/dist/transport/protobuf-codec.js

@@ -307,6 +307,14 @@ class ProtobufCodec {
         if (asGroupCall) {
             return { kind: 'groupCall', data: asGroupCall };
         }
+        // Event (LIMIT_REACHED, ERROR, CONNECTED, ...). Probed before groupMessage /
+        // broadcast / ack: an event carrying metadata (field 3) otherwise satisfies
+        // their messageId+groupId+fromUserId / broadcastId shape and gets misrouted.
+        // The strict type check keeps real UUID-bearing frames out of this branch.
+        const asEvent = this.tryDecodeEvent(payload);
+        if (asEvent) {
+            return { kind: 'event', data: asEvent };
+        }
         // Group message notification (per-member stripped payload from server)
         const asGroupMsg = this.tryDecodeGroupMessageNotification(payload);
         if (asGroupMsg) {
@@ -325,10 +333,6 @@ class ProtobufCodec {
         if (asAck) {
             return { kind: 'ack', data: asAck };
         }
-        const asEvent = this.tryDecodeEvent(payload);
-        if (asEvent) {
-            return { kind: 'event', data: asEvent };
-        }
         throw new Error('Unsupported inbound protobuf frame');
     }
     tryDecodeEnvelope(payload) {
@@ -395,7 +399,12 @@ class ProtobufCodec {
     tryDecodeEvent(payload) {
         try {
             const decoded = EventType.decode(payload);
-            if (!decoded.type) {
+            // Event.type is a SCREAMING_SNAKE_CASE enum string (e.g. LIMIT_REACHED).
+            // A GroupMessageNotification, BroadcastNotification, or Ack decoded here
+            // carries a UUID (messageId / broadcastId) in field 1, which never matches
+            // this shape — so this reliably rejects those overlapping frame types and
+            // lets Event be probed before them.
+            if (!decoded.type || !/^[A-Z][A-Z0-9_]*$/.test(decoded.type)) {
                 return null;
             }
             return decoded;
@@ -442,7 +451,11 @@ class ProtobufCodec {
             // decodes as a group notification (its type lands in groupId) and steals
             // status acks before the Ack probe. Real group notifications always carry
             // fromUserId; acks have no field 3.
-            if (!decoded.messageId || !decoded.groupId || !decoded.fromUserId) {
+            // Require senderDeviceId (field 8, string). A BroadcastNotification (field 8 =
+            // sequenceNumber, int32) or an Event (no field 8) otherwise satisfies the
+            // messageId+groupId+fromUserId shape and is misrouted here. The server always
+            // sets senderDeviceId on group notifications.
+            if (!decoded.messageId || !decoded.groupId || !decoded.fromUserId || !decoded.senderDeviceId) {
                 return null;
             }
             return {

package/dist/version.d.ts

@@ -7,7 +7,7 @@
  *   MINOR, additive feature (e.g. multi-device payloads, new call event type)
  *   PATCH, bug-fix / perf improvement with no wire or API change
  */
-export declare const SDK_VERSION = "0.24.0";
+export declare const SDK_VERSION = "0.24.2";
 /**
  * Binary encrypted-payload format version.
  * Included as the first byte of every encrypted payload so receivers can

package/dist/version.js

@@ -10,7 +10,7 @@ exports.PROTOCOL_VERSION = exports.PAYLOAD_FORMAT_VERSION = exports.SDK_VERSION
  *   MINOR, additive feature (e.g. multi-device payloads, new call event type)
  *   PATCH, bug-fix / perf improvement with no wire or API change
  */
-exports.SDK_VERSION = '0.24.0';
+exports.SDK_VERSION = '0.24.2';
 /**
  * Binary encrypted-payload format version.
  * Included as the first byte of every encrypted payload so receivers can

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@droponair/sdk-js",
-  "version": "0.24.0",
+  "version": "0.24.2",
   "description": "DropOnAir SDK for end-to-end encrypted messaging",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",