@droponair/sdk-js 0.23.1 → 0.23.2

package/CHANGELOG.md

@@ -6,6 +6,14 @@ This project follows [Semantic Versioning](https://semver.org/).
 
 ---
 
+## [0.23.2], 2026-06-04
+
+### Fixed
+
+- **Status acks (SERVER_RECEIVED / DELIVERED / PROCESSED) were mis-decoded and never reached the app.** Inbound `Ack {messageId, type}` frames were being decoded as `GroupMessageNotification` (the ack's `type` lands in the notification's `groupId`, field 2) because the group-notification / group-ack / broadcast decode guards only checked fields 1-2, which an ack satisfies. They now also require field 3 (`fromUserId` / `type` / `publisherId`), which every real group/broadcast frame carries but an ack lacks, so acks fall through to the ack decoder. This regressed in 0.22.1: making `GroupMessageNotification` decodable (the AttachmentRef fix) removed the decode-time throw that previously let acks fall through. Net effect of the bug: a sender's message never advanced past "sending" even though it was delivered. Also hardened the inbound frame handler to never drop the channel on an undecodable frame.
+
+---
+
 ## [0.23.1], 2026-06-01
 
 ### Fixed

package/dist/core/messaging-client.js

@@ -1779,7 +1779,16 @@ class MessagingClient {
                 }
             });
             transport.onFrame(async (bytes) => {
-                const frame = this.codec.decodeFrame(bytes);
+                // Defensive: a single undecodable/unknown frame must not reject the
+                // handler (which would silently drop it and could wedge inbound state).
+                let frame;
+                try {
+                    frame = this.codec.decodeFrame(bytes);
+                }
+                catch (err) {
+                    this.logError('frame_decode_failed', { bytes: bytes.length, error: String(err?.message ?? err) });
+                    return;
+                }
                 if (frame.kind === 'event') {
                     if (frame.data.type === 'LIMIT_REACHED') {
                         this.rateLimited = true;

package/dist/transport/protobuf-codec.js

@@ -419,7 +419,10 @@ class ProtobufCodec {
     tryDecodeBroadcastNotification(payload) {
         try {
             const decoded = BroadcastNotificationType.decode(payload);
-            if (!decoded.broadcastId || !decoded.channelId) {
+            // Require publisherId (field 3): an Ack {messageId(1), type(2)} otherwise
+            // decodes as a broadcast (type lands in channelId, field 3 empty). Real
+            // broadcasts always carry a publisherId.
+            if (!decoded.broadcastId || !decoded.channelId || !decoded.publisherId) {
                 return null;
             }
             return {
@@ -435,7 +438,11 @@ class ProtobufCodec {
     tryDecodeGroupMessageNotification(payload) {
         try {
             const decoded = GroupMessageNotificationType.decode(payload);
-            if (!decoded.messageId || !decoded.groupId) {
+            // Require fromUserId (field 3): an Ack {messageId(1), type(2)} otherwise
+            // decodes as a group notification (its type lands in groupId) and steals
+            // status acks before the Ack probe. Real group notifications always carry
+            // fromUserId; acks have no field 3.
+            if (!decoded.messageId || !decoded.groupId || !decoded.fromUserId) {
                 return null;
             }
             return {
@@ -455,7 +462,10 @@ class ProtobufCodec {
     tryDecodeGroupAck(payload) {
         try {
             const decoded = GroupAckType.decode(payload);
-            if (!decoded.messageId || !decoded.groupId) {
+            // Require type (field 3): an Ack {messageId(1), type(2)} otherwise decodes
+            // as a GroupAck (its type lands in groupId, field 3 stays empty). Real
+            // GroupAcks always carry a type.
+            if (!decoded.messageId || !decoded.groupId || !decoded.type) {
                 return null;
             }
             return decoded;

package/dist/version.d.ts

@@ -7,7 +7,7 @@
  *   MINOR, additive feature (e.g. multi-device payloads, new call event type)
  *   PATCH, bug-fix / perf improvement with no wire or API change
  */
-export declare const SDK_VERSION = "0.23.1";
+export declare const SDK_VERSION = "0.23.2";
 /**
  * Binary encrypted-payload format version.
  * Included as the first byte of every encrypted payload so receivers can

package/dist/version.js

@@ -10,7 +10,7 @@ exports.PROTOCOL_VERSION = exports.PAYLOAD_FORMAT_VERSION = exports.SDK_VERSION
  *   MINOR, additive feature (e.g. multi-device payloads, new call event type)
  *   PATCH, bug-fix / perf improvement with no wire or API change
  */
-exports.SDK_VERSION = '0.23.1';
+exports.SDK_VERSION = '0.23.2';
 /**
  * Binary encrypted-payload format version.
  * Included as the first byte of every encrypted payload so receivers can

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@droponair/sdk-js",
-  "version": "0.23.1",
+  "version": "0.23.2",
   "description": "DropOnAir SDK for end-to-end encrypted messaging",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",