@drip-apex/sdk 0.1.0 → 0.3.0

package/src/targeting-parity-corpus.json

@@ -0,0 +1,559 @@
+[
+  {
+    "name": "wildcard path",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "/products/*",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "scheme-less host and path",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "shop.test/products/serum",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "query subset ignores extras",
+    "url": "https://shop.test/search?q=serum&page=2",
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "/search?q=serum",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "hash is matched when specified",
+    "url": "https://shop.test/pages/about#team",
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "/pages/about#team",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "contains",
+    "url": "https://shop.test/collections/summer-sale",
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "matchType": "contains",
+          "pattern": "summer-sale",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "legacy escaped contains",
+    "url": "https://shop.test/products/red.shirt",
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "matchType": "contains",
+          "pattern": "red\\.shirt",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "regex recognized from type",
+    "url": "https://shop.test/products/123",
+    "targeting": {
+      "url": [
+        {
+          "type": "regex",
+          "pattern": "^/products/[0-9]+$",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "matchType regex remains simple",
+    "url": "https://shop.test/products/123",
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "matchType": "regex",
+          "pattern": "^/products/[0-9]+$",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "simple matching is case insensitive",
+    "url": "https://shop.test/Products/Serum",
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "/products/serum",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "regex matching is case sensitive",
+    "url": "https://shop.test/Products/Serum",
+    "targeting": {
+      "url": [
+        {
+          "type": "regex",
+          "pattern": "^/products/serum$",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "regex lookahead",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "url": [
+        {
+          "type": "regex",
+          "pattern": "^/products/(?=serum)serum$",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "regex lookbehind",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "url": [
+        {
+          "type": "regex",
+          "pattern": "^/products/(?<=products/)serum$",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "regex backreference",
+    "url": "https://shop.test/products/serum/serum",
+    "targeting": {
+      "url": [
+        {
+          "type": "regex",
+          "pattern": "^/products/(serum)/\\1$",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "quantified backreference is server indeterminate",
+    "url": "https://shop.test/aaaa!",
+    "targeting": {
+      "url": [
+        {
+          "type": "regex",
+          "pattern": "^(a+)\\1+$",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": true,
+      "serverIndeterminate": true
+    }
+  },
+  {
+    "name": "catastrophic regex is server indeterminate",
+    "url": "https://shop.test/a!",
+    "targeting": {
+      "url": [
+        {
+          "type": "regex",
+          "pattern": "^(a+)+$",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": true,
+      "serverIndeterminate": true
+    }
+  },
+  {
+    "name": "invalid regex fails",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "url": [
+        {
+          "type": "regex",
+          "pattern": "[invalid(",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "host agnostic include matching storefront origin",
+    "url": "https://shop.test/products/serum",
+    "storefrontOrigins": ["https://shop.test"],
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "/products/*",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "host agnostic include rejects another origin",
+    "url": "https://other.test/products/serum",
+    "storefrontOrigins": ["https://shop.test"],
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "/products/*",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "scheme-prefixed rule names host",
+    "url": "https://other.test/products/serum",
+    "storefrontOrigins": [
+      "https://shop.test"
+    ],
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "https://other.test/products/*",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "regex-prefixed absolute rule names host",
+    "url": "https://other.test/products/serum",
+    "storefrontOrigins": [
+      "https://shop.test"
+    ],
+    "targeting": {
+      "url": [
+        {
+          "type": "regex",
+          "pattern": "^https?:\\/\\/other\\.test/products/.*$",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "embedded query URL remains host agnostic",
+    "url": "https://other.test/products?return=https://example.com",
+    "storefrontOrigins": [
+      "https://shop.test"
+    ],
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "/products?return=https://example.com",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "protocol-relative rule names host",
+    "url": "https://other.test/products/serum",
+    "storefrontOrigins": [
+      "https://shop.test"
+    ],
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "//other.test/products/*",
+          "include": true
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "page rule bare string child stays raw",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "pageRules": [
+        {
+          "id": "raw-string",
+          "include": true,
+          "includeRules": ["/products/serum"]
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "page rule legacy alias child stays raw",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "pageRules": [
+        {
+          "id": "raw-alias",
+          "include": true,
+          "includeRules": [
+            {
+              "type": "url_contains",
+              "value": "products/serum"
+            }
+          ]
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "disabled include block fails gate",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "pageRules": [
+        {
+          "id": "disabled",
+          "disabled": true,
+          "include": true,
+          "includeRules": ["/products/*"]
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "js-only page block counts as rules",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "pageRules": [
+        {
+          "id": "js-only",
+          "include": true,
+          "advancedCondition": {
+            "code": "return true"
+          }
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "exclude takes precedence",
+    "url": "https://shop.test/products/sale",
+    "targeting": {
+      "url": [
+        {
+          "type": "simple",
+          "pattern": "/products/*",
+          "include": true
+        },
+        {
+          "type": "simple",
+          "pattern": "/products/sale",
+          "include": false
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "legacy segment reference without expanded rule fails closed",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "segments": [
+        {
+          "id": "segment-a"
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  },
+  {
+    "name": "legacy segment reference with ID-matched expanded rule passes discriminator",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "segments": [
+        {
+          "id": "segment-a"
+        }
+      ],
+      "segmentRules": [
+        {
+          "id": "segment-a",
+          "rules": {
+            "operator": "and",
+            "conditions": []
+          }
+        }
+      ]
+    },
+    "expect": {
+      "sdk": true,
+      "server": true
+    }
+  },
+  {
+    "name": "partially expanded legacy segment references fail closed",
+    "url": "https://shop.test/products/serum",
+    "targeting": {
+      "segments": [
+        {
+          "id": "segment-a"
+        },
+        {
+          "id": "segment-b"
+        }
+      ],
+      "segmentRules": [
+        {
+          "id": "segment-a",
+          "rules": {
+            "operator": "and",
+            "conditions": []
+          }
+        }
+      ]
+    },
+    "expect": {
+      "sdk": false,
+      "server": false
+    }
+  }
+]

package/src/targeting-parity-corpus.test.ts

@@ -0,0 +1,18 @@
+import { describe, expect, it } from "vitest";
+import corpus from "./targeting-parity-corpus.json";
+import { matchesTargeting } from "./targeting";
+import type { Targeting } from "./types";
+
+describe("server targeting parity corpus", () => {
+  for (const entry of corpus) {
+    it(entry.name, () => {
+      expect(
+        matchesTargeting(entry.targeting as Targeting, {
+          url: entry.url,
+          attributes: {},
+          hostAgnosticIncludeOrigin: entry.storefrontOrigins,
+        }),
+      ).toBe(entry.expect.sdk);
+    });
+  }
+});

package/src/targeting.detailed.test.ts

@@ -4,6 +4,20 @@ import { evaluateTargetingGates, evaluateTargetingGatesDetailed } from "./target
 import type { Targeting } from "./types";
 
 describe("evaluateTargetingGatesDetailed", () => {
+  it("includes failed device conditions in QA builds", async () => {
+    const qaBuild = await build({
+      entryPoints: ["src/targeting.ts"], bundle: true, format: "esm", platform: "node", write: false,
+      define: { __DRIP_QA_BUILD__: "true" },
+    });
+    const moduleUrl = `data:text/javascript;base64,${Buffer.from(qaBuild.outputFiles[0].text).toString("base64")}`;
+    const qaTargeting = await import(/* @vite-ignore */ moduleUrl) as typeof import("./targeting");
+    const result = qaTargeting.evaluateTargetingGatesDetailed({
+      segmentRules: [{ id: "device", rules: { version: 1, operator: "and", conditions: [{ signal: "device.type", operator: "equals", value: "mobile" }] } }],
+    }, { url: "https://shop.test", attributes: { "device.type": "desktop" } });
+    expect(result.conditions).toContainEqual(expect.objectContaining({
+      signal: "device.type", expected: "mobile", actual: "desktop", status: "failed",
+    }));
+  });
   it("uses aggregate targeting gates with empty conditions for live builds", async () => {
     const liveBuild = await build({
       entryPoints: ["src/targeting.ts"],
@@ -330,6 +344,81 @@ describe("evaluateTargetingGatesDetailed", () => {
     }));
   });
 
+  it("labels an empty JS-condition result as a segment mismatch", () => {
+    const diagnostics = evaluateTargetingGatesDetailed({
+      segmentRules: [{
+        id: "empty-js",
+        name: "Returning customers",
+        rules: {
+          version: 1,
+          operator: "and",
+          conditions: [{
+            signal: "url.query",
+            operator: "equals",
+            value: "campaign=spring",
+            js: { code: "return '';" },
+          }],
+        },
+      }],
+    }, { url: "https://shop.test/", attributes: {} });
+
+    expect(diagnostics.conditions).toContainEqual(expect.objectContaining({
+      id: "segment:empty-js:0",
+      status: "failed",
+      reason: "segment_mismatch",
+    }));
+  });
+
+  it("reports required and detected device values and distinguishes unresolved signals", () => {
+    const targeting: Targeting = {
+      segmentRules: [{
+        id: "device-audience",
+        rules: {
+          version: 1,
+          operator: "and",
+          conditions: [{ signal: "device.type", operator: "equals", value: "mobile" }],
+        },
+      }],
+    };
+
+    const mismatch = evaluateTargetingGatesDetailed(targeting, {
+      url: "https://shop.test/",
+      attributes: { "device.type": "desktop" },
+    });
+    expect(mismatch.conditions).toContainEqual(expect.objectContaining({
+      id: "segment:device-audience:0",
+      status: "failed",
+      reason: "segment_mismatch",
+      signal: "device.type",
+      expected: "mobile",
+      actual: "desktop",
+    }));
+
+    const unresolved = evaluateTargetingGatesDetailed(targeting, {
+      url: "https://shop.test/",
+      attributes: { "device.type": "" },
+    });
+    expect(unresolved.conditions).toContainEqual(expect.objectContaining({
+      id: "segment:device-audience:0",
+      status: "failed",
+      reason: "signal_unresolved",
+      signal: "device.type",
+      expected: "mobile",
+      actual: "",
+    }));
+
+    const missing = evaluateTargetingGatesDetailed(targeting, {
+      url: "https://shop.test/",
+      attributes: {},
+    });
+    expect(missing.conditions).toContainEqual(expect.objectContaining({
+      id: "segment:device-audience:0",
+      reason: "signal_unresolved",
+      expected: "mobile",
+      actual: "",
+    }));
+  });
+
   it("marks audience conditions skipped after a page failure", () => {
     const targeting: Targeting = {
       url: [{ type: "simple", pattern: "/products/*" }],
@@ -440,4 +529,20 @@ describe("evaluateTargetingGatesDetailed", () => {
       }
     `);
   });
+
+  it("names unexpanded legacy segment references in audience diagnostics", () => {
+    const diagnostics = evaluateTargetingGatesDetailed({
+      segments: [{ id: "legacy-segment" }],
+    }, {
+      url: "https://shop.test/",
+      attributes: {},
+    });
+
+    expect(diagnostics.matched).toBe(false);
+    expect(diagnostics.gates).toContainEqual(expect.objectContaining({
+      id: "audience",
+      status: "failed",
+      reason: "segments_unexpanded",
+    }));
+  });
 });