@drip-apex/sdk 0.1.0 → 0.2.0

package/src/commerce-price.ts

@@ -1,5 +1,9 @@
 import type { Assignment, CommercePriceSettings } from "./types";
-import { formatCentsLike, parseDisplayedCents } from "./money";
+import {
+  currencyExponent,
+  formatCentsLike,
+  parseDisplayedCents,
+} from "./money";
 
 type PriceAssignmentAuthorization = (assignment: Assignment) => boolean;
 
@@ -23,8 +27,6 @@ type ShopifyWindow = Window & {
   };
 };
 
-const ZERO_DECIMAL =
-  /^(BIF|CLP|DJF|GNF|ISK|JPY|KMF|KRW|PYG|RWF|UGX|VND|VUV|XAF|XOF|XPF)$/;
 let observer: MutationObserver | null = null;
 let rootObserver: MutationObserver | null = null;
 let variantForm: HTMLFormElement | null = null;
@@ -147,6 +149,13 @@ function activeExperiments(
   )
     return [];
   const currency = w.Shopify.currency?.active;
+  if (typeof currency !== "string") return [];
+  let minorUnits: number;
+  try {
+    minorUnits = currencyExponent(currency);
+  } catch {
+    return [];
+  }
   const pageVariantIds = new Set(
     meta.product.variants
       .filter((variant) => variant.id != null)
@@ -176,7 +185,7 @@ function activeExperiments(
       adjustments &&
       targetsCurrentProduct
     ) {
-      active.push({ experiment, assignment, currency });
+      active.push({ experiment, assignment, currency, minorUnits });
     }
   }
   return active;
@@ -275,6 +284,50 @@ function treatmentUnits(value: string, minorUnits: number): number | null {
   return Number.isSafeInteger(units) ? units : null;
 }
 
+function shopifyStoredMinorUnits(
+  value: number,
+  minorUnits: number,
+  shopifyStoredScale: number,
+): number | null {
+  if (
+    !Number.isFinite(value) ||
+    value < 0 ||
+    !Number.isSafeInteger(minorUnits) ||
+    minorUnits < 0 ||
+    !Number.isSafeInteger(shopifyStoredScale) ||
+    shopifyStoredScale <= 0
+  ) {
+    return null;
+  }
+  const match = /^(\d+)(?:\.(\d+))?(?:e([+-]?\d+))?$/i.exec(value.toString());
+  if (!match) return null;
+  const fraction = match[2] ?? "";
+  const exponent = Number(match[3] ?? 0);
+  if (!Number.isSafeInteger(exponent)) return null;
+  const digits = `${match[1]}${fraction}`;
+  const decimalScale = fraction.length - exponent;
+  const scaleDelta = minorUnits - decimalScale;
+  let scaledDigits: string;
+  if (scaleDelta >= 0) {
+    scaledDigits = digits + "0".repeat(scaleDelta);
+  } else {
+    const discardedLength = -scaleDelta;
+    if (discardedLength > digits.length) {
+      if (/[^0]/.test(digits)) return null;
+      scaledDigits = "0";
+    } else {
+      const discarded = digits.slice(digits.length - discardedLength);
+      if (/[^0]/.test(discarded)) return null;
+      scaledDigits = digits.slice(0, digits.length - discardedLength) || "0";
+    }
+  }
+  const scaled = Number(scaledDigits);
+  if (!Number.isSafeInteger(scaled) || scaled % shopifyStoredScale !== 0) {
+    return null;
+  }
+  return scaled / shopifyStoredScale;
+}
+
 function replaceNumericText(
   value: string,
   targets: Map<number, number>,
@@ -443,15 +496,14 @@ function swapPass(): void {
     const variants = (window as ShopifyWindow).ShopifyAnalytics?.meta?.product
       ?.variants;
     if (!active.length || !Array.isArray(variants)) return;
-    const currency = active[0]!.currency;
-    const minorUnits = ZERO_DECIMAL.test(currency) ? 0 : 2;
-    // ShopifyAnalytics keeps prices on Shopify's two-decimal stored scale even
-    // when the storefront formats a zero-decimal currency such as JPY.
-    const shopifyStoredScale = minorUnits ? 1 : 100;
+    const minorUnits = active[0]!.minorUnits;
+    // ShopifyAnalytics uses Shopify's fixed two-decimal stored scale. This
+    // scale is independent of the display currency's ISO-4217 exponent.
+    const shopifyStoredScale = 100;
     const published = new Map<string, number>();
     for (const variant of variants) {
       const price = Number(variant.price);
-      if (variant.id != null && Number.isSafeInteger(price) && price >= 0)
+      if (variant.id != null && Number.isFinite(price) && price >= 0)
         published.set(String(variant.id), price);
     }
     const selectedByVariant = new Map<string, string>();
@@ -514,16 +566,17 @@ function swapPass(): void {
         fixedPricePerUnit,
         minorUnits,
       );
+      const sourceDisplayAmount = source == null
+        ? null
+        : shopifyStoredMinorUnits(source, minorUnits, shopifyStoredScale);
       // The display plane must mirror the Cart Transform's decrease-only
       // invariant. Invalid, equal, or higher treatment prices fail closed.
       if (
-        source == null ||
+        sourceDisplayAmount == null ||
         treatmentDisplayAmount == null ||
-        treatmentDisplayAmount * shopifyStoredScale >= source
+        treatmentDisplayAmount >= sourceDisplayAmount
       )
         continue;
-      if (source % shopifyStoredScale) continue;
-      const sourceDisplayAmount = source / shopifyStoredScale;
       const existing = targets.get(sourceDisplayAmount);
       targets.set(
         sourceDisplayAmount,
@@ -539,10 +592,9 @@ function swapPass(): void {
       if (compare.mode !== "set") continue;
       const source = published.get(id);
       const compareAmount = treatmentUnits(compare.amount, minorUnits);
-      const sourceAmount =
-        source != null && source % shopifyStoredScale === 0
-          ? source / shopifyStoredScale
-          : null;
+      const sourceAmount = source == null
+        ? null
+        : shopifyStoredMinorUnits(source, minorUnits, shopifyStoredScale);
       const displayedAmount =
         sourceAmount == null ? null : targets.get(sourceAmount) || sourceAmount;
       if (
@@ -610,9 +662,12 @@ function swapPass(): void {
         const source = selectedVariantId
           ? published.get(selectedVariantId)
           : undefined;
+        const sourceDisplayAmount = source == null
+          ? null
+          : shopifyStoredMinorUnits(source, minorUnits, shopifyStoredScale);
         // The current price is read from Shopify and is never replaced for a
         // compare-at-only arm. Only add merchant-authored reference framing.
-        if (amount != null && source != null) {
+        if (amount != null && sourceDisplayAmount != null) {
           const eligible = containers.filter(
             (container) =>
               !isElementLinkedToDifferentProduct(container, productHandle),
@@ -636,7 +691,6 @@ function swapPass(): void {
               container.parentElement?.insertBefore(node, container);
               compareAtNodes.push(node);
             }
-            const sourceDisplayAmount = source / shopifyStoredScale;
             const currentText = container.textContent ?? "";
             const parsedCurrent = parseDisplayedCents(currentText, minorUnits);
             // A node whose text still holds several amounts is not safe to

package/src/commerce-shipping.test.ts

@@ -500,6 +500,59 @@ describe("commerce shipping messaging", () => {
     ).toBe("fixed");
   });
 
+  it("cancels queued placement checks and cannot re-arm them after teardown", async () => {
+    vi.useFakeTimers();
+    applyCommerceShipping(settings("banner"), assignments);
+    await vi.runAllTimersAsync();
+    expect(document.querySelector("[data-apex-shipping]")).not.toBeNull();
+
+    document.body.append(document.createElement("div"));
+    await Promise.resolve();
+    expect(vi.getTimerCount()).toBeGreaterThan(0);
+
+    cleanupCommerceShipping();
+    expect(vi.getTimerCount()).toBe(0);
+    await vi.advanceTimersByTimeAsync(100);
+    expect(document.querySelector("[data-apex-shipping]")).toBeNull();
+
+    document.body.append(document.createElement("div"));
+    await Promise.resolve();
+    expect(vi.getTimerCount()).toBe(0);
+  });
+
+  it("ignores a placement-observer callback delivered after teardown", async () => {
+    vi.useFakeTimers();
+    const callbacks: MutationCallback[] = [];
+    vi.stubGlobal(
+      "MutationObserver",
+      class {
+        constructor(callback: MutationCallback) {
+          callbacks.push(callback);
+        }
+        observe() {}
+        disconnect() {}
+        takeRecords() {
+          return [];
+        }
+      },
+    );
+    applyCommerceShipping(settings("banner"), assignments);
+    await vi.runAllTimersAsync();
+    expect(document.querySelector("[data-apex-shipping]")).not.toBeNull();
+    expect(callbacks.length).toBeGreaterThan(0);
+
+    cleanupCommerceShipping();
+    expect(vi.getTimerCount()).toBe(0);
+    // Simulate a mutation record queued before disconnect() but delivered
+    // after teardown: the stale callback must not re-arm placement work.
+    for (const callback of callbacks) {
+      callback([], {} as MutationObserver);
+    }
+    expect(vi.getTimerCount()).toBe(0);
+    await vi.advanceTimersByTimeAsync(100);
+    expect(document.querySelector("[data-apex-shipping]")).toBeNull();
+  });
+
   it("re-reads after cart mutations without replacing their response", async () => {
     applyCommerceShipping(settings(), assignments);
     await flush();

package/src/commerce-shipping.ts

@@ -4,6 +4,7 @@ import {
   findCartDrawerContainer,
   installCartDrawerOpenListener,
 } from "./surface-signals";
+import { currencyExponent } from "./money";
 
 type ShopifyWindow = Window & {
   Shopify?: {
@@ -108,17 +109,7 @@ export function isShippingCartEligibilityConfirmed(
 
 function currencyMinorUnits(currency: string): number | null {
   try {
-    const units = new Intl.NumberFormat("en", {
-      style: "currency",
-      currency,
-    }).resolvedOptions().maximumFractionDigits;
-    return typeof units === "number" &&
-      Number.isInteger(units) &&
-      units >= 0 &&
-      // ISO 4217 tops out at exponent 4 (CLF, UYW).
-      units <= 4
-      ? units
-      : null;
+    return currencyExponent(currency);
   } catch {
     return null;
   }
@@ -386,6 +377,9 @@ async function refreshCart(
 
 function installPlacementObserver(active: ActiveShipping): void {
   placementObserver = new MutationObserver(() => {
+    // A mutation record may already be queued when teardown disconnects the
+    // observer. Do not let that stale callback re-arm placement work.
+    if (current !== active) return;
     if (placementCheckTimer !== null) return;
     placementCheckTimer = window.setTimeout(() => {
       placementCheckTimer = null;

package/src/compact-store.ts

@@ -0,0 +1,15 @@
+export function decodeCompactStore(raw: string | null, width: 2 | 3): Record<string, unknown[]> {
+  if (!raw) return {};
+  try {
+    const parsed = JSON.parse(raw) as unknown;
+    if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return {};
+    const out: Record<string, unknown[]> = {};
+    for (const [key, value] of Object.entries(parsed)) {
+      if (!Array.isArray(value) || value.length < width || typeof value[0] !== "string" || typeof value[1] !== "number" || (width === 3 && typeof value[2] !== "number")) continue;
+      out[key] = value;
+    }
+    return out;
+  } catch {
+    return {};
+  }
+}