@dreki-gg/pi-plan-mode 0.5.0 → 0.5.1

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @dreki-gg/pi-plan-mode
 
+## 0.5.1
+
+### Patch Changes
+
+- [`8e9aa09`](https://github.com/dreki-gg/pi-extensions/commit/8e9aa0963fe81286e9c5972f6a9d666645807f1a) Thanks [@jalbarrang](https://github.com/jalbarrang)! - fix(plan-mode): allow safe bash commands that were incorrectly blocked in plan mode
+
+  Three fixes to `isSafeCommand`:
+
+  - Allow `mkdir -p .plans/` since the planner needs to create plan directories
+  - Fix redirect pattern to not false-positive on stderr redirects like `2>/dev/null`
+  - Split piped commands and validate each segment independently, so `curl ... | grep ... | head` works correctly
+
 ## 0.5.0
 
 ### Minor Changes

package/extensions/plan-mode/utils.test.ts

@@ -0,0 +1,110 @@
+import { describe, expect, test } from 'bun:test';
+import { isSafeCommand } from './utils.js';
+
+describe('isSafeCommand', () => {
+  // ── Commands that SHOULD be allowed ──────────────────────────────────────
+  describe('allowed commands', () => {
+    test('mkdir -p .plans/<name>', () => {
+      expect(isSafeCommand('mkdir -p .plans/monorepo-src-migration')).toBe(true);
+    });
+
+    test('mkdir .plans/<name>', () => {
+      expect(isSafeCommand('mkdir .plans/my-plan')).toBe(true);
+    });
+
+    test('curl with 2>/dev/null pipe chain', () => {
+      expect(
+        isSafeCommand(
+          `curl -sL "https://effect.website/docs/platform/introduction/" 2>/dev/null | grep -oP '(?<=href=")[^"]*' | grep -iE "(http|server|rpc)" | head -20`,
+        ),
+      ).toBe(true);
+    });
+
+    test('curl with 2>/dev/null simple', () => {
+      expect(
+        isSafeCommand(
+          `curl -s "https://raw.githubusercontent.com/Effect-TS/effect/main/packages/platform/README.md" 2>/dev/null | head -100`,
+        ),
+      ).toBe(true);
+    });
+
+    test('simple ls', () => {
+      expect(isSafeCommand('ls -la')).toBe(true);
+    });
+
+    test('git status', () => {
+      expect(isSafeCommand('git status')).toBe(true);
+    });
+
+    test('git log', () => {
+      expect(isSafeCommand('git log --oneline -10')).toBe(true);
+    });
+
+    test('find piped to grep', () => {
+      expect(isSafeCommand('find . -name "*.ts" | grep -v node_modules')).toBe(true);
+    });
+
+    test('cat piped to head', () => {
+      expect(isSafeCommand('cat README.md | head -50')).toBe(true);
+    });
+
+    test('rg (ripgrep)', () => {
+      expect(isSafeCommand('rg "pattern" src/')).toBe(true);
+    });
+
+    test('grep with context', () => {
+      expect(isSafeCommand('grep -rn "export" src/ | head -20')).toBe(true);
+    });
+
+    test('npm list', () => {
+      expect(isSafeCommand('npm list --depth=0')).toBe(true);
+    });
+
+    test('curl piped to jq', () => {
+      expect(isSafeCommand('curl -s https://api.example.com | jq .name')).toBe(true);
+    });
+  });
+
+  // ── Commands that SHOULD be blocked ──────────────────────────────────────
+  describe('blocked commands', () => {
+    test('rm -rf', () => {
+      expect(isSafeCommand('rm -rf node_modules')).toBe(false);
+    });
+
+    test('mkdir outside .plans/', () => {
+      expect(isSafeCommand('mkdir -p src/new-dir')).toBe(false);
+    });
+
+    test('stdout redirect to file', () => {
+      expect(isSafeCommand('echo "hello" > file.txt')).toBe(false);
+    });
+
+    test('append redirect', () => {
+      expect(isSafeCommand('echo "hello" >> file.txt')).toBe(false);
+    });
+
+    test('git commit', () => {
+      expect(isSafeCommand('git commit -m "test"')).toBe(false);
+    });
+
+    test('npm install', () => {
+      expect(isSafeCommand('npm install lodash')).toBe(false);
+    });
+
+    test('mv file', () => {
+      expect(isSafeCommand('mv old.ts new.ts')).toBe(false);
+    });
+
+    test('sudo anything', () => {
+      expect(isSafeCommand('sudo ls')).toBe(false);
+    });
+
+    test('cp file', () => {
+      expect(isSafeCommand('cp a.ts b.ts')).toBe(false);
+    });
+
+    test('touch file', () => {
+      expect(isSafeCommand('touch newfile.ts')).toBe(false);
+    });
+  });
+});

package/extensions/plan-mode/utils.ts

@@ -24,7 +24,8 @@ const DESTRUCTIVE_PATTERNS = [
   /\btruncate\b/i,
   /\bdd\b/i,
   /\bshred\b/i,
-  /(^|[^<])>(?!>)/,
+  // stdout redirect — but NOT stderr redirects like 2>/dev/null or 2>&1
+  /(?<!\d)>(?!>|&)/,
   />>/,
   /\bnpm\s+(install|uninstall|update|ci|link|publish)/i,
   /\byarn\s+(add|remove|install|publish)/i,
@@ -117,10 +118,70 @@ const SAFE_PATTERNS = [
   /^\s*tasklist\b/,
 ];
 
+/**
+ * Check if a command is safe for plan mode.
+ *
+ * For simple commands, checks that the command starts with a safe pattern and
+ * doesn't contain destructive patterns. For piped commands, each segment is
+ * checked individually. Special exceptions allow `mkdir -p` for `.plans/` paths.
+ */
 export function isSafeCommand(command: string): boolean {
-  const isDestructive = DESTRUCTIVE_PATTERNS.some((p) => p.test(command));
-  const isSafe = SAFE_PATTERNS.some((p) => p.test(command));
-  return !isDestructive && isSafe;
+  // Special case: allow mkdir for .plans/ directory (planner needs this)
+  if (/^\s*mkdir\s+(-p\s+)?\.plans(\/|\\|\s|$)/.test(command)) {
+    return true;
+  }
+
+  // Split piped commands and check each segment independently
+  const segments = splitPipeSegments(command);
+  return segments.every((seg) => {
+    const trimmed = seg.trim();
+    const isDestructive = DESTRUCTIVE_PATTERNS.some((p) => p.test(trimmed));
+    const isSafe = SAFE_PATTERNS.some((p) => p.test(trimmed));
+    return !isDestructive && isSafe;
+  });
+}
+
+/**
+ * Split a command on unquoted pipe (`|`) characters.
+ * Respects single/double quotes and escaped characters.
+ */
+function splitPipeSegments(command: string): string[] {
+  const segments: string[] = [];
+  let current = '';
+  let inSingle = false;
+  let inDouble = false;
+  let escaped = false;
+
+  for (const ch of command) {
+    if (escaped) {
+      current += ch;
+      escaped = false;
+      continue;
+    }
+    if (ch === '\\') {
+      current += ch;
+      escaped = true;
+      continue;
+    }
+    if (ch === "'" && !inDouble) {
+      inSingle = !inSingle;
+      current += ch;
+      continue;
+    }
+    if (ch === '"' && !inSingle) {
+      inDouble = !inDouble;
+      current += ch;
+      continue;
+    }
+    if (ch === '|' && !inSingle && !inDouble) {
+      segments.push(current);
+      current = '';
+      continue;
+    }
+    current += ch;
+  }
+  if (current) segments.push(current);
+  return segments;
 }
 
 // ── Plan extraction ─────────────────────────────────────────────────────────

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dreki-gg/pi-plan-mode",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Two-phase planning workflow for pi — plan with claude-opus-4-6:medium, execute with gpt-5.5:low, with .plans/ file-based handoff",
   "keywords": [
     "pi-package"