@dreb/coding-agent 2.46.0 → 2.47.0

package/dist/core/agent-session.js

@@ -883,7 +883,12 @@ export class AgentSession {
     }
     /** Emit extension events based on agent events */
     async _emitExtensionEvent(event) {
-        if (!this._extensionRunner)
+        // The runner is created unconditionally (so built-in tools like ask_user
+        // always have a UI context). When no extensions are loaded there are no
+        // handlers to invoke — return synchronously to avoid inserting an extra
+        // await tick per event, which would otherwise delay the final agent_end
+        // emission past when prompt() resolves.
+        if (!this._extensionRunner || !this._extensionRunner.hasExtensions)
             return;
         if (event.type === "agent_start") {
             this._turnIndex = 0;
@@ -2443,9 +2448,15 @@ export class AgentSession {
         const wrappedExtensionTools = this._extensionRunner
             ? wrapRegisteredTools(allCustomTools, this._extensionRunner)
             : [];
+        // Give base tools a per-execution extension context so built-ins like
+        // ask_user can reach ctx.ui. createContext() snapshots hasUI at call time,
+        // so print/RPC-without-host modes degrade to the no-op UI (hasUI === false).
+        const baseToolCtxFactory = this._extensionRunner
+            ? () => this._extensionRunner.createContext()
+            : undefined;
         const toolRegistry = new Map(Array.from(this._baseToolDefinitions.values()).map((definition) => [
             definition.name,
-            wrapToolDefinition(definition),
+            wrapToolDefinition(definition, baseToolCtxFactory),
         ]));
         for (const tool of wrappedExtensionTools) {
             toolRegistry.set(tool.name, tool);
@@ -2544,12 +2555,11 @@ export class AgentSession {
                 extensionsResult.runtime.flagValues.set(name, value);
             }
         }
-        const hasExtensions = extensionsResult.extensions.length > 0;
-        const hasCustomTools = this._customTools.length > 0;
-        this._extensionRunner =
-            hasExtensions || hasCustomTools
-                ? new ExtensionRunner(extensionsResult.extensions, extensionsResult.runtime, this._cwd, this.sessionManager, this._modelRegistry)
-                : undefined;
+        // The runner also owns the cross-surface UI context used by built-in
+        // tools such as ask_user. Create it even when no third-party extensions
+        // are loaded; otherwise ordinary TUI/Dashboard sessions give base tools
+        // no ctx.ui and ask_user can never open its dialog.
+        this._extensionRunner = new ExtensionRunner(extensionsResult.extensions, extensionsResult.runtime, this._cwd, this.sessionManager, this._modelRegistry);
         if (this._extensionRunnerRef) {
             this._extensionRunnerRef.current = this._extensionRunner;
         }
@@ -2572,6 +2582,7 @@ export class AgentSession {
                 "subagent",
                 "wait",
                 "search",
+                "ask_user",
                 "skill",
                 "tasks_update",
                 "suggest_next",