@dreb/coding-agent 2.4.2 → 2.4.4

package/dist/core/resource-loader.js

@@ -1,7 +1,6 @@
 import { existsSync, mkdirSync, readdirSync, readFileSync, statSync } from "node:fs";
 import { homedir } from "node:os";
 import { join, resolve, sep } from "node:path";
-import chalk from "chalk";
 import { CONFIG_DIR_NAME, getAgentDir } from "../config.js";
 import { loadThemeFromPath } from "../modes/interactive/theme/theme.js";
 import { findGitRoot } from "./git-root.js";
@@ -12,7 +11,7 @@ import { loadPromptTemplates } from "./prompt-templates.js";
 import { SettingsManager } from "./settings-manager.js";
 import { loadSkills } from "./skills.js";
 import { createSourceInfo } from "./source-info.js";
-function resolvePromptInput(input, description) {
+function resolvePromptInput(input, description, diagnostics) {
     if (!input) {
         return undefined;
     }
@@ -21,7 +20,11 @@ function resolvePromptInput(input, description) {
             return readFileSync(input, "utf-8");
         }
         catch (error) {
-            console.error(chalk.yellow(`Warning: Could not read ${description} file ${input}: ${error}`));
+            diagnostics?.push({
+                type: "warning",
+                message: `Could not read ${description} file ${input}: ${error}`,
+                path: input,
+            });
             return input;
         }
     }
@@ -30,7 +33,7 @@ function resolvePromptInput(input, description) {
 function stripHtmlComments(content) {
     return content.replace(/<!--[\s\S]*?-->/g, "");
 }
-function loadContextFilesFromDir(dir) {
+function loadContextFilesFromDir(dir, diagnostics) {
     const candidates = ["AGENTS.md", "CLAUDE.md", join(".claude", "CLAUDE.md"), join(".dreb", "CONTEXT.md")];
     const results = [];
     for (const filename of candidates) {
@@ -43,13 +46,13 @@ function loadContextFilesFromDir(dir) {
                 });
             }
             catch (error) {
-                console.error(chalk.yellow(`Warning: Could not read ${filePath}: ${error}`));
+                diagnostics?.push({ type: "warning", message: `Could not read ${filePath}: ${error}`, path: filePath });
             }
         }
     }
     return results;
 }
-function loadRulesFromDir(dir, contextFiles, seenPaths, depth = 0) {
+function loadRulesFromDir(dir, contextFiles, seenPaths, depth = 0, diagnostics) {
     if (depth > 10)
         return;
     let entries;
@@ -57,13 +60,13 @@ function loadRulesFromDir(dir, contextFiles, seenPaths, depth = 0) {
         entries = readdirSync(dir, { withFileTypes: true });
     }
     catch (error) {
-        console.error(chalk.yellow(`Warning: Could not read rules directory ${dir}: ${error}`));
+        diagnostics?.push({ type: "warning", message: `Could not read rules directory ${dir}: ${error}`, path: dir });
         return;
     }
     for (const entry of entries) {
         const fullPath = join(dir, entry.name);
         if (entry.isDirectory() && !entry.isSymbolicLink()) {
-            loadRulesFromDir(fullPath, contextFiles, seenPaths, depth + 1);
+            loadRulesFromDir(fullPath, contextFiles, seenPaths, depth + 1, diagnostics);
         }
         else if (entry.isFile() && entry.name.endsWith(".md") && !seenPaths.has(fullPath)) {
             try {
@@ -82,12 +85,16 @@ function loadRulesFromDir(dir, contextFiles, seenPaths, depth = 0) {
                 contextFiles.push({ path: fullPath, content: stripHtmlComments(content) });
             }
             catch (error) {
-                console.error(chalk.yellow(`Warning: Could not read rule ${fullPath}: ${error}`));
+                diagnostics?.push({
+                    type: "warning",
+                    message: `Could not read rule ${fullPath}: ${error}`,
+                    path: fullPath,
+                });
             }
         }
     }
 }
-function loadProjectContextFiles(options = {}) {
+function loadProjectContextFiles(options = {}, diagnostics) {
     const resolvedCwd = options.cwd ?? process.cwd();
     const resolvedAgentDir = options.agentDir ?? getAgentDir();
     const contextFiles = [];
@@ -109,7 +116,7 @@ function loadProjectContextFiles(options = {}) {
                 }
             }
             catch (error) {
-                console.error(chalk.yellow(`Warning: Could not read ${filePath}: ${error}`));
+                diagnostics?.push({ type: "warning", message: `Could not read ${filePath}: ${error}`, path: filePath });
             }
         }
     }
@@ -118,7 +125,7 @@ function loadProjectContextFiles(options = {}) {
     let currentDir = resolvedCwd;
     const root = resolve("/");
     while (true) {
-        const dirFiles = loadContextFilesFromDir(currentDir);
+        const dirFiles = loadContextFilesFromDir(currentDir, diagnostics);
         const newFiles = dirFiles.filter((f) => !seenPaths.has(f.path));
         for (const file of newFiles) {
             seenPaths.add(file.path);
@@ -141,10 +148,14 @@ function loadProjectContextFiles(options = {}) {
     for (const rulesDir of rulesSearchDirs) {
         if (existsSync(rulesDir)) {
             try {
-                loadRulesFromDir(rulesDir, contextFiles, seenPaths);
+                loadRulesFromDir(rulesDir, contextFiles, seenPaths, 0, diagnostics);
             }
             catch (error) {
-                console.error(chalk.yellow(`Warning: Could not read rules from ${rulesDir}: ${error}`));
+                diagnostics?.push({
+                    type: "warning",
+                    message: `Could not read rules from ${rulesDir}: ${error}`,
+                    path: rulesDir,
+                });
             }
         }
     }
@@ -159,7 +170,7 @@ const MEMORY_INDEX_MAX_LINES = 200;
 export function encodeClaudeProjectPath(absolutePath) {
     return absolutePath.replace(/[/_]/g, "-");
 }
-function readMemoryIndex(dir) {
+function readMemoryIndex(dir, diagnostics) {
     const indexPath = join(dir, "MEMORY.md");
     try {
         if (!existsSync(indexPath))
@@ -167,17 +178,21 @@ function readMemoryIndex(dir) {
         const content = readFileSync(indexPath, "utf-8");
         const lines = content.split("\n");
         if (lines.length > MEMORY_INDEX_MAX_LINES) {
-            console.error(chalk.yellow(`Warning: ${indexPath} has ${lines.length} lines, truncated to ${MEMORY_INDEX_MAX_LINES}. Consider cleaning up older entries.`));
+            diagnostics?.push({
+                type: "warning",
+                message: `${indexPath} has ${lines.length} lines, truncated to ${MEMORY_INDEX_MAX_LINES}. Consider cleaning up older entries.`,
+                path: indexPath,
+            });
             return lines.slice(0, MEMORY_INDEX_MAX_LINES).join("\n");
         }
         return content;
     }
     catch (error) {
-        console.error(chalk.yellow(`Warning: Could not read ${indexPath}: ${error}`));
+        diagnostics?.push({ type: "warning", message: `Could not read ${indexPath}: ${error}`, path: indexPath });
         return undefined;
     }
 }
-function loadMemoryIndexes(options) {
+function loadMemoryIndexes(options, diagnostics) {
     const resolvedCwd = options.cwd ?? process.cwd();
     const projectRoot = findGitRoot(resolvedCwd) ?? resolvedCwd;
     const drebRoot = options.agentDir ? resolve(options.agentDir, "..") : join(homedir(), ".dreb");
@@ -190,22 +205,22 @@ function loadMemoryIndexes(options) {
     const globalSources = [];
     const projectSources = [];
     // Load dreb memory (primary)
-    const drebGlobal = readMemoryIndex(globalMemoryDir);
+    const drebGlobal = readMemoryIndex(globalMemoryDir, diagnostics);
     if (drebGlobal) {
         globalSources.push({ content: drebGlobal, dir: globalMemoryDir, source: "dreb" });
     }
-    const drebProject = globalMemoryDir !== projectMemoryDir ? readMemoryIndex(projectMemoryDir) : undefined;
+    const drebProject = globalMemoryDir !== projectMemoryDir ? readMemoryIndex(projectMemoryDir, diagnostics) : undefined;
     if (drebProject) {
         projectSources.push({ content: drebProject, dir: projectMemoryDir, source: "dreb" });
     }
     // Load Claude Code memory (read-only, compat)
-    const claudeGlobal = readMemoryIndex(claudeGlobalMemoryDir);
+    const claudeGlobal = readMemoryIndex(claudeGlobalMemoryDir, diagnostics);
     if (claudeGlobal) {
         globalSources.push({ content: claudeGlobal, dir: claudeGlobalMemoryDir, source: "claude" });
     }
     // Only load Claude project memory if it's a different path than Claude global
     if (claudeProjectMemoryDir !== claudeGlobalMemoryDir) {
-        const claudeProject = readMemoryIndex(claudeProjectMemoryDir);
+        const claudeProject = readMemoryIndex(claudeProjectMemoryDir, diagnostics);
         if (claudeProject) {
             projectSources.push({ content: claudeProject, dir: claudeProjectMemoryDir, source: "claude" });
         }
@@ -252,6 +267,7 @@ export class DefaultResourceLoader {
     memoryIndexes;
     systemPrompt;
     appendSystemPrompt;
+    contextDiagnostics;
     lastSkillPaths;
     extensionSkillSourceInfos;
     extensionPromptSourceInfos;
@@ -301,6 +317,7 @@ export class DefaultResourceLoader {
             projectMemoryDir: join(this.cwd, ".dreb", "memory"),
         };
         this.appendSystemPrompt = [];
+        this.contextDiagnostics = [];
         this.lastSkillPaths = [];
         this.extensionSkillSourceInfos = new Map();
         this.extensionPromptSourceInfos = new Map();
@@ -320,6 +337,9 @@ export class DefaultResourceLoader {
     getThemes() {
         return { themes: this.themes, diagnostics: this.themeDiagnostics };
     }
+    getContextDiagnostics() {
+        return this.contextDiagnostics;
+    }
     getAgentsFiles() {
         return { agentsFiles: this.agentsFiles };
     }
@@ -359,6 +379,7 @@ export class DefaultResourceLoader {
         }
     }
     async reload() {
+        this.contextDiagnostics = [];
         const resolvedPaths = await this.packageManager.resolve();
         const cliExtensionPaths = await this.packageManager.resolveExtensionSources(this.additionalExtensionPaths, {
             temporary: true,
@@ -392,6 +413,7 @@ export class DefaultResourceLoader {
                 }
             }
             catch {
+                // stat failed — path may not exist yet; use as-is
                 return resource.path;
             }
             const skillFile = join(resource.path, "SKILL.md");
@@ -449,27 +471,36 @@ export class DefaultResourceLoader {
             : this.mergePaths([...enabledThemes, ...cliEnabledThemes], this.additionalThemePaths);
         this.lastThemePaths = themePaths;
         this.updateThemesFromPaths(themePaths, metadataByPath);
-        const agentsFiles = { agentsFiles: loadProjectContextFiles({ cwd: this.cwd, agentDir: this.agentDir }) };
+        const agentsFiles = {
+            agentsFiles: loadProjectContextFiles({ cwd: this.cwd, agentDir: this.agentDir }, this.contextDiagnostics),
+        };
         const resolvedAgentsFiles = this.agentsFilesOverride ? this.agentsFilesOverride(agentsFiles) : agentsFiles;
         this.agentsFiles = resolvedAgentsFiles.agentsFiles;
         // Load memory indexes and ensure global memory directory exists.
         // Wrapped in try/catch so memory loading failures degrade gracefully rather than crashing the session.
         try {
-            this.memoryIndexes = loadMemoryIndexes({ cwd: this.cwd, agentDir: this.agentDir });
+            this.memoryIndexes = loadMemoryIndexes({ cwd: this.cwd, agentDir: this.agentDir }, this.contextDiagnostics);
             try {
                 mkdirSync(this.memoryIndexes.globalMemoryDir, { recursive: true });
             }
             catch (error) {
-                console.error(chalk.yellow(`Warning: Could not create memory directory ${this.memoryIndexes.globalMemoryDir}: ${error}. Memory saves to this directory will fail.`));
+                this.contextDiagnostics.push({
+                    type: "warning",
+                    message: `Could not create memory directory ${this.memoryIndexes.globalMemoryDir}: ${error}. Memory saves to this directory will fail.`,
+                    path: this.memoryIndexes.globalMemoryDir,
+                });
             }
         }
         catch (error) {
-            console.error(chalk.yellow(`Warning: Could not load memory indexes: ${error}. Session will start without memory context.`));
+            this.contextDiagnostics.push({
+                type: "warning",
+                message: `Could not load memory indexes: ${error}. Session will start without memory context.`,
+            });
         }
-        const baseSystemPrompt = resolvePromptInput(this.systemPromptSource ?? this.discoverSystemPromptFile(), "system prompt");
+        const baseSystemPrompt = resolvePromptInput(this.systemPromptSource ?? this.discoverSystemPromptFile(), "system prompt", this.contextDiagnostics);
         this.systemPrompt = this.systemPromptOverride ? this.systemPromptOverride(baseSystemPrompt) : baseSystemPrompt;
         const appendSource = this.appendSystemPromptSource ?? this.discoverAppendSystemPromptFile();
-        const resolvedAppend = resolvePromptInput(appendSource, "append system prompt");
+        const resolvedAppend = resolvePromptInput(appendSource, "append system prompt", this.contextDiagnostics);
         const baseAppend = resolvedAppend ? [resolvedAppend] : [];
         this.appendSystemPrompt = this.appendSystemPromptOverride
             ? this.appendSystemPromptOverride(baseAppend)
@@ -625,12 +656,20 @@ export class DefaultResourceLoader {
                 return { path: filePath, source: "local", scope: "project", origin: "top-level", baseDir: root };
             }
         }
+        let baseDir;
+        try {
+            baseDir = statSync(normalizedPath).isDirectory() ? normalizedPath : resolve(normalizedPath, "..");
+        }
+        catch {
+            // Path doesn't exist (deleted file, broken symlink, race condition) — fall back to parent dir
+            baseDir = resolve(normalizedPath, "..");
+        }
         return {
             path: filePath,
             source: "local",
             scope: "temporary",
             origin: "top-level",
-            baseDir: statSync(normalizedPath).isDirectory() ? normalizedPath : resolve(normalizedPath, ".."),
+            baseDir,
         };
     }
     mergePaths(primary, additional) {
@@ -706,6 +745,7 @@ export class DefaultResourceLoader {
                         isFile = statSync(join(dir, entry.name)).isFile();
                     }
                     catch {
+                        // Broken symlink — skip entry
                         continue;
                     }
                 }