@dreb/coding-agent 2.23.0 → 2.25.0

package/dist/core/agent-session.js

@@ -35,7 +35,7 @@ import { isSensitivePath } from "./sensitive-paths.js";
 import { CURRENT_SESSION_VERSION, getLatestCompactionEntry } from "./session-manager.js";
 import { createSyntheticSourceInfo } from "./source-info.js";
 import { buildSystemPrompt } from "./system-prompt.js";
-import { createAllToolDefinitions, getRunningBackgroundAgents, } from "./tools/index.js";
+import { createAllToolDefinitions, discoverAgentTypes, getRunningBackgroundAgents, } from "./tools/index.js";
 import { expandSkillContent } from "./tools/skill.js";
 import { createToolDefinitionFromAgentTool, wrapToolDefinition } from "./tools/tool-definition-wrapper.js";
 // ============================================================================
@@ -404,7 +404,7 @@ export class AgentSession {
         if (cancelled) {
             parts.push("This agent was cancelled by the user.");
         }
-        if (!cancelled && result.exitCode !== 0) {
+        if (!cancelled && (result.exitCode !== 0 || result.errorMessage)) {
             parts.push(`Error: ${result.errorMessage || "unknown"}`);
         }
         if (result.output) {
@@ -530,6 +530,27 @@ export class AgentSession {
         ];
         this.warnInSession(`Resource loading issues:\n${lines.join("\n")}`);
     }
+    /**
+     * Detect agentModels settings keys that reference agents which no longer exist
+     * (e.g. an upstream agent was renamed or removed) and surface a LOUD warning.
+     *
+     * Such keys are silently ignored during resolution — getAgentModelsForAgent
+     * never matches them — so without this check a stale override would vanish
+     * with no signal to the user. The agent-name keys must match exactly how
+     * discoverAgentTypes keys agents (case-sensitive, e.g. "Explore"), which is
+     * the same lookup getAgentModelsForAgent uses.
+     */
+    warnStaleAgentModelKeys() {
+        const configured = Object.keys(this.settingsManager?.getAgentModels() ?? {});
+        if (configured.length === 0)
+            return;
+        const discovered = discoverAgentTypes(this._cwd);
+        const staleKeys = configured.filter((key) => !discovered.has(key));
+        if (staleKeys.length === 0)
+            return;
+        this.warnInSession(`agentModels settings reference unknown agent(s): ${staleKeys.join(", ")}. ` +
+            "These overrides will be ignored. Check for typos or renamed/removed agents.");
+    }
     /**
      * Surface a warning in the session so both the human and the AI agent can see it.
      * During streaming: steers the warning as a user message into the conversation.
@@ -756,6 +777,17 @@ export class AgentSession {
             };
             await this._extensionRunner.emit(extensionEvent);
         }
+        else if (event.type === "length_retry") {
+            const extensionEvent = {
+                type: "length_retry",
+                attempt: event.attempt,
+                maxAttempts: event.maxAttempts,
+                previousMaxTokens: event.previousMaxTokens,
+                nextMaxTokens: event.nextMaxTokens,
+                discardedPartial: event.discardedPartial,
+            };
+            await this._extensionRunner.emit(extensionEvent);
+        }
         else if (event.type === "tool_execution_start") {
             const extensionEvent = {
                 type: "tool_execution_start",
@@ -2284,6 +2316,7 @@ export class AgentSession {
                     parentProvider: () => this.model?.provider,
                     parentModel: () => this.model?.id,
                     modelRegistry: this._modelRegistry,
+                    getAgentModelsForAgent: (name) => this.settingsManager?.getAgentModelsForAgent(name),
                     onBackgroundStart: (agentId, agentType, taskSummary) => {
                         this._emit({ type: "background_agent_start", agentId, agentType, taskSummary });
                     },