@drdoc-com/pi-drdoc 1.0.2 → 1.0.4

package/README.md

@@ -60,11 +60,18 @@ Example:
 /drdoc_login https://drdoc.com demo password "" 1
 ```
 
-And signout/signout:
+And signout/logout:
 ```bash
 /drdoc_logout
 ```
 
+### Pi Agent Tool Calling
+
+Example:
+```
+Suche im Dr.DOC Archiv "rec" alle Rechnungen von Firma Amazon aus diesem Jahr.
+```
+
 ## Configuration
 
 The plugin utilizes configuration options supplied by the Dr.DOC client or environment variables.
@@ -77,10 +84,19 @@ The plugin utilizes configuration options supplied by the Dr.DOC client or envir
 | `DRDOC_CONFIG_DIR` (alt. `PI_CONFIG_DIR`) | Custom directory for config files | `~/.pi/agent` |
 | `DRDOC_DOWNLOAD_DIR` | Custom directory for downloaded files | `~/.drdoc/downloads` |
 | `DRDOC_IGNORE_SSL` | Ignore TLS/SSL Errors (Set `NODE_TLS_REJECT_UNAUTHORIZED=0`) | `` |
+| `DRDOC_AI_FS` | Dr.DOC IMPORT_ASCII FieldSelection Name for Field Descriptions. | `STD_AI_INVOICE_IN`, `DD_FIELD_DESC`, `STD_FIELD_DESC` |
 | `DRDOC_DEBUG` | Enable Debugging | `` |
 
 ---
 
+### Security Notes
+* Pi Agent is designed as a **personal** AI agent. Users must operate their own private Pi Agent instance rather than using an instance hosted on the Dr.DOC Web Server.
+* Credential Persistence (/drdoc_login): When using the Dr.DOC AI Chat with Pi configured as the AI endpoint (via `@drdoc-com/pi-openai-api-wrapper`), the `/drdoc_login` command *MUST NOT* be executed. Authentication credentials within the Pi Agent instance are persistent and could potentially be exposed to other users sharing the same instance.
+* Dedicated Service Account: Use a dedicated Dr.DOC user account with limited permissions (e.g. *Datensatzspezifische Berechtigungen*) based on the principle of least privilege (*"need-to-know"*) specifically for AI tasks and the `/drdoc_login` command.
+* Containerized Deployment: Whenever possible, run Pi Agent inside an isolated container environment (e.g., Docker, Podman) to ensure process isolation and security boundaries.
+
+---
+
 ## License
 
 This project is licensed under the Apache License 2.0.

package/package.json

@@ -1,17 +1,17 @@
 {
   "name": "@drdoc-com/pi-drdoc",
-  "version": "1.0.2",
+  "version": "1.0.4",
   "description": "Dr.DOC DMS Integration Package for PI Agent",
   "type": "module",
   "license": "Apache License 2.0",
   "keywords": [
     "pi-package",
     "pi-agent",
-    "drdoc",
     "rest-api",
     "skill",
-    "dms",
-    "Dr.DOC"
+    "drdoc",
+    "Dr.DOC",
+    "dms"
   ],
   "private": false,
   "pi": {
@@ -31,7 +31,7 @@
   "author": "Dr.DOC GmbH, DE-80802 Munich",
   "devDependencies": {
     "typescript": "^7.0.2",
-    "@types/node": "^26.2.0"
+    "@types/node": "^24.0.0"
   },
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": "*"

package/src/drdoc-client.ts

@@ -163,7 +163,8 @@ export class DrDocClient {
     try {
       const dataToSave = JSON.stringify(this.config, null, 2);
       fs.writeFileSync(this.storageFilePath, dataToSave, "utf-8");
-      msgLog('DD Anmeldedaten wurden gespeichert unter: ', this.storageFilePath);
+      if (process.env.DRDOC_DEBUG)
+        msgLog('Dr.DOC Anmeldedaten wurden gespeichert unter: ', this.storageFilePath);
     } catch (error) {
       throw new Error(`Fehler beim Speichern der Anmeldedaten: ${error instanceof Error ? error.message : String(error)}`);
     }
@@ -192,8 +193,11 @@ export class DrDocClient {
     if (setCookie) {
       const match = setCookie.match(/uid=([^;]+)/);
       if (match) {
+        const oldCookieValue = this.config.sessionCookie;
         this.config.sessionCookie = `uid=${match[1]}`;
-        // this.saveCredentials(this.config);
+        // bei Cookie Änderung, Cookie uid explizit abspeichern
+        if (oldCookieValue != this.config.sessionCookie)
+          this.saveCredentials();
       }
     }
   }
@@ -330,11 +334,13 @@ export class DrDocClient {
       // Dauerhaftes Speichern der gesamten DrDocConfig nach erfolgreichem Login
       this.saveCredentials();
 
-      msgLog('DD: Sign in OK:', this.config);
+      if (process.env.DRDOC_DEBUG)
+        msgLog('DD: Sign in OK: ', JSON.stringify(this.config));
     }
     else {
-
-      console.warn('DD: Sign in ERR:', this.config);
+      //if (process.env.DRDOC_DEBUG)
+      if (process.env.DRDOC_DEBUG)
+        msgLog('DD: Sign in ERROR: ' + JSON.stringify(this.config));
     }
 
     return response;
@@ -349,11 +355,14 @@ export class DrDocClient {
 
     // Überprüfung auf erfolgreiche Anmeldung
     if (response && !response.HasError) {
-      msgLog('DD: State OK:', this.config);
+      if (process.env.DRDOC_DEBUG)
+        msgLog('Dr.DOC: State OK:', this.config);
       return true;
     }
     else {
-      msgError('DD: State ERR:', this.config);
+      msgError('Bitte erneut anmelden mit Slash Command `/drdoc_login`');
+      if (process.env.DRDOC_DEBUG)
+        msgLog('Dr.DOC: State ERROR: ' + JSON.stringify(this.config));
       return false;
     }
   }

package/src/index.ts

@@ -17,7 +17,7 @@ export default function (pi: any): void {
 
   // Login
   pi.registerCommand("drdoc_login", {
-    description: "Benutzer anmelden in Dr.DOC über die REST API und speichert die Session.",
+    description: "Benutzer anmelden in Dr.DOC über die REST API und speichert die Session: `/drdoc_login <baseUrl> <username> <password> <totp> <ignoreSSL:1,0>`",
     handler: async (args: string, ctx: any) => {
       // Entfernen leerer Strings nach dem String-Split
       const parts = args.trim().split(/\s+/); //.filter(Boolean);
@@ -34,18 +34,18 @@ export default function (pi: any): void {
       try {
         //initializeDrDocClient({ baseUrl, username, password, totp, ignoreSSL });
         //const client = new DrDocClient({ baseUrl, username, password, totp, ignoreSSL });
-        const client = await getClient({ baseUrl, username, password, totp, ignoreSSL: (ignoreSSL == '1' || ignoreSSL == 'true') });
+        const client = await getClient({ baseUrl, username, password, totp, ignoreSSL: (ignoreSSL == '1' || ignoreSSL == 'true') }, true);
         if (process.env.DRDOC_DEBUG)
           msgLog('Client: ', client);
 
-        const response = await client.signin(username, password, totp);
+        /*const response = await client.signin(username, password, totp);
 
         if (response.HasError) {
           msgError(`Anmeldung fehlgeschlagen: ${response.Error?.Message}`);
           return;
         }
 
-        msgInfo("Erfolgreich an Dr.DOC angemeldet. Die Session ist aktiv.");
+        msgInfo("Erfolgreich an Dr.DOC angemeldet. Die Session ist aktiv.");*/
       } catch (err: any) {
         msgError(`Fehler bei der Verbindung: ${err.message}`);
       }

package/src/tools.ts

@@ -11,13 +11,27 @@ let clientInstance: DrDocClient | null = null;
  */
 export async function getClient(config: DrDocConfig = {} as DrDocConfig, force: Boolean = false): Promise<DrDocClient> {
   if (!clientInstance || force) {
-    msgInfo('getClient: init instance');
+    if (process.env.DRDOC_DEBUG)
+      msgInfo('getClient: init instance');
     clientInstance = new DrDocClient(config);
+
     // Verbindung testen
-    if (await clientInstance.state())
-      msgInfo('getClient: state ok');
+    if (await clientInstance.state()) {
+      msgInfo('Bereits in Dr.DOC angemeldet. Die Session ist aktiv.');
+    }
     else {
-      throw new Error("getClient: DrDocClient ist nicht initialisiert. Bitte vorher den Befehl /drdoc_login ausführen.");
+      const response = await clientInstance.signin(config.username, config.password, config.totp);
+      if (response.HasError)
+        throw new Error("getClient: DrDocClient ist nicht initialisiert. Bitte vorher den Befehl /drdoc_login ausführen.");
+
+      msgInfo("Erfolgreich an Dr.DOC angemeldet. Die Session ist aktiv.");
+
+      // Verbindung testen
+      /*if (await clientInstance.state())
+        msgInfo('getClient: state ok');
+      else {
+
+      }*/
     }
   }
   return clientInstance;
@@ -138,8 +152,10 @@ export const drdocTools = [
       if (process.env.DRDOC_DEBUG)
         msgLog('drdoc_properties_fields:', args);
       return safeExecuteClient(["archive"], args, async (client, safeArgs) => {
-        const defNameArray = ['STD_AI_INVOICE_IN', 'DD_FIELD_DESC', 'STD_FIELD_DESC'];
+        const defNameArray = [process.env.DRDOC_AI_FS, 'STD_AI_INVOICE_IN', 'DD_FIELD_DESC', 'STD_FIELD_DESC'];
         for (let defName of defNameArray) {
+          if (!defName)
+            continue;
           const fs = await client.getFieldSelection(safeArgs.archive, "IMPORT_ASCII", defName);
           if (process.env.DRDOC_DEBUG)
             msgLog('props:', fs);
@@ -183,8 +199,8 @@ Beispiele für Suchoperatoren:
 Datumsformat: DD.MM.YYYY
 Zahlenformat: 0.00
 Variablen:
-- %DY% Variable für Datumsbereich im aktuellen/diesen Jahr
-- %DMY% Variable für Datumsbereich im aktuellen/diesen Monat
+- %DY% Variable für Datumsbereich im aktuellen/diesen Jahr (wird z.B. zu: *.2021)
+- %DMY% Variable für Datumsbereich im aktuellen/diesen Monat (wird z.B. zu: *.01.2021)
 - %DWY% Variable für Datumsbereich in der aktuellen/diesen Woche (7 Tage)
 - %B% Variable für angemeldeten Benutzer
 - %D% Variable für aktuelles Datum (heutiger Tag)