@drawbridge/drawbridge-agents 0.1.70 → 0.1.71

package/.claude-template/skills/drawbridge-asana-comment/SKILL.md

@@ -64,6 +64,10 @@ Write for the person reading it, not for the repo.
   the interface labels them. Not your paraphrase, not the variable name. If the button says
   Send, write Send.
 - **Quote user-facing copy exactly**, so they can match it against what is on screen.
+  Double quotes mean "one of our labels", and the comment tool refuses the post if a
+  double-quoted label was not seen by a walk in the last day (`npm run walk` in
+  drawbridge-tests) and exists nowhere in the family's source. A third-party label, a mail
+  client's button, a Shopify admin page, goes in 'single quotes' and is not checked.
 - Use their words for their bug. If they called it a prize notification, it is a prize
   notification, not a lead-facing transactional send.
 

package/.claude-template/skills/drawbridge-feature/SKILL.md

@@ -83,4 +83,4 @@ posted. The handoff comment is refused by the QA gate while this session changed
 | Reading the story and graph before coding | `hooks/consult-docs-gate.js` on the first source edit |
 | Updating the story when anchored code changed | `hooks/drift-check.js` at turn end |
 | QA on dev | `hooks/qa-gate.js` on the Asana comment |
-| Walking before naming a button | `drawbridge-asana-ship-handoff`, every quoted label from the walk output |
+| Walking before naming a button | `hooks/qa-gate.js` on every Asana comment: a "double-quoted" label must appear in a walk record from the last day or in family source |

package/README.md

@@ -45,7 +45,7 @@ hooks/
   drift-check.js            ← Stop hook (wired via .claude-template/settings.json)
   consult-docs-record.js    ← PostToolUse hook: remembers a docs page read / graph query per session
   consult-docs-gate.js      ← PreToolUse hook: refuses the first source edit until both happened
-  qa-gate.js                ← PreToolUse hook on the Asana comment tool: a session that changed code needs a clean QA report
+  qa-gate.js                ← PreToolUse hook on the Asana comment tool: every "quoted label" must have been walked or exist in source; a session that changed code needs a clean QA report
   guard-superpowers-docs.js ← PreToolUse hook: plans/specs go to drawbridge-docs
 ```
 

package/hooks/qa-gate.js

@@ -41,11 +41,10 @@ const readJson = (file) => {
   }
 }
 
-const findReport = (cwd, task) => {
+const findFamilyRoot = (cwd) => {
   let dir = cwd
   for (let depth = 0; depth < 4; depth += 1) {
-    const candidate = path.join(dir, 'drawbridge-tests', 'results', 'qa', task + '.json')
-    if (fs.existsSync(candidate)) return candidate
+    if (fs.existsSync(path.join(dir, 'drawbridge-tests'))) return dir
     const parent = path.dirname(dir)
     if (parent === dir) break
     dir = parent
@@ -53,19 +52,97 @@ const findReport = (cwd, task) => {
   return null
 }
 
+const findReport = (cwd, task) => {
+  const root = findFamilyRoot(cwd)
+  if (!root) return null
+  const candidate = path.join(root, 'drawbridge-tests', 'results', 'qa', task + '.json')
+  return fs.existsSync(candidate) ? candidate : null
+}
+
+// --- Quoted labels must have been seen -------------------------------------
+//
+// A "double-quoted" string in a comment is a label on OUR screens and is checked:
+// it must appear in a walk record from the last day (drawbridge-tests/results/walk/
+// *.json, written by npm run walk) or, failing that, in the family's source. A
+// 'single-quoted' string is a third-party label (Outlook's buttons, a Shopify
+// admin page) or spoken words, and is not checked. Darren, 2026-09-23: no more
+// "buttons or functions that don't exist".
+
+const SOURCE_REPOS = [ 'drawbridge-app-web', 'drawbridge-components', 'drawbridge-share', 'drawbridge-api', 'drawbridge-utils', 'drawbridge-shopify-app', 'drawbridge-website', 'drawbridge-emails' ]
+
+const quotedLabels = (text) => {
+  const found = new Set()
+  const re = /"([^"\n]{1,120})"|“([^”\n]{1,120})”/g
+  let match
+  while ((match = re.exec(text)) !== null) found.add((match[1] || match[2]).trim())
+  return Array.from(found).filter(Boolean)
+}
+
+const walkedLabels = (root) => {
+  const dir = path.join(root, 'drawbridge-tests', 'results', 'walk')
+  const seen = []
+  if (!fs.existsSync(dir)) return seen
+  for (const name of fs.readdirSync(dir)) {
+    if (!name.endsWith('.json')) continue
+    const file = path.join(dir, name)
+    try {
+      if (Date.now() - fs.statSync(file).mtimeMs > MAX_AGE_MS) continue
+      const record = JSON.parse(fs.readFileSync(file, 'utf8'))
+      for (const key of [ 'buttons', 'headings', 'inputs', 'links', 'tableHeaders', 'title' ]) {
+        const value = record[key]
+        if (Array.isArray(value)) seen.push(...value.map(String))
+        else if (typeof value === 'string') seen.push(value)
+      }
+    } catch (error) {
+      // an unreadable record proves nothing
+    }
+  }
+  return seen
+}
+
+const inSource = (root, label) => {
+  const { spawnSync } = require('child_process')
+  const dirs = SOURCE_REPOS.map((name) => path.join(root, name)).filter((dir) => fs.existsSync(dir))
+  if (!dirs.length) return false
+  const result = spawnSync('grep', [
+    '-rFq', '--include=*.js', '--include=*.jsx', '--include=*.ts', '--include=*.tsx', '--include=*.json', '--include=*.hbs', '--include=*.md',
+    '--exclude-dir=node_modules', '--exclude-dir=.next', '--exclude-dir=dist', '--exclude-dir=.git', '--exclude-dir=.claude',
+    '--', label, ...dirs
+  ], { encoding: 'utf8' })
+  return result.status === 0
+}
+
+const unseenLabels = (cwd, text) => {
+  const root = findFamilyRoot(cwd)
+  if (!root) return []
+  const labels = quotedLabels(text)
+  if (!labels.length) return []
+  const walked = walkedLabels(root).map((value) => value.toLowerCase())
+  return labels.filter((label) => {
+    const needle = label.toLowerCase()
+    if (walked.some((value) => value.includes(needle))) return false
+    return !inSource(root, label)
+  })
+}
+
 const run = () => {
   const input = readStdin()
 
   if (input.tool_name !== 'mcp__claude_ai_Asana__add_comment') process.exit(0)
   if (!input.session_id) process.exit(0)
 
+  const cwd = input.cwd || process.cwd()
+  const toolInput = input.tool_input || {}
+
+  // Every comment, code changed or not: a quoted label has to exist.
+  const unseen = unseenLabels(cwd, String(toolInput.html_text || toolInput.text || ''))
+  if (unseen.length) deny('A label in this comment was never seen: ' + unseen.map((label) => '"' + label + '"').join(', ') + '. Walk the page (npm run walk in drawbridge-tests) and quote the label as it prints, or use \'single quotes\' for a third-party label such as a mail client\'s button.')
+
   const seen = readJson(markerPath(input.session_id)) || {}
   if (!seen.edited) process.exit(0)
 
-  const task = String((input.tool_input || {}).task_id || '')
+  const task = String(toolInput.task_id || '')
   if (!task) process.exit(0)
-
-  const cwd = input.cwd || process.cwd()
   const file = findReport(cwd, task)
   const how = 'Dispatch the drawbridge-qa agent with the story file(s), task ' + task + ' and the dev organization id; it writes drawbridge-tests/results/qa/' + task + '.json. Fix every fail and run it again before commenting.'
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@drawbridge/drawbridge-agents",
-  "version": "0.1.70",
+  "version": "0.1.71",
   "description": "Shared agent-instruction content (rules, code style, conventions) for the drawbridge-* monorepo.",
   "license": "UNLICENSED",
   "publishConfig": {