@drarzter/kafka-client 0.6.3 → 0.6.4

package/dist/index.js

@@ -563,7 +563,7 @@ async function executeWithRetry(fn, ctx, deps) {
       }
     } else {
       const cap = Math.min(backoffMs * 2 ** (attempt - 1), maxBackoffMs);
-      await sleep(Math.random() * cap);
+      await sleep(Math.floor(Math.random() * cap));
     }
   }
 }
@@ -937,7 +937,8 @@ var KafkaClient = class {
   kafka;
   producer;
   txProducer;
-  retryTxProducers = /* @__PURE__ */ new Set();
+  /** Maps transactionalId → Producer for each active retry level consumer. */
+  retryTxProducers = /* @__PURE__ */ new Map();
   consumers = /* @__PURE__ */ new Map();
   admin;
   logger;
@@ -1203,18 +1204,32 @@ var KafkaClient = class {
           this.consumerCreationOptions.delete(cGroupId);
           this.logger.log(`Retry consumer disconnected: group "${cGroupId}"`);
         }
+        const txId = `${cGroupId}-tx`;
+        const txProducer = this.retryTxProducers.get(txId);
+        if (txProducer) {
+          await txProducer.disconnect().catch(() => {
+          });
+          this.retryTxProducers.delete(txId);
+        }
       }
       this.companionGroupIds.delete(groupId);
     } else {
-      const tasks = Array.from(this.consumers.values()).map(
-        (c) => c.disconnect().catch(() => {
-        })
-      );
+      const tasks = [
+        ...Array.from(this.consumers.values()).map(
+          (c) => c.disconnect().catch(() => {
+          })
+        ),
+        ...Array.from(this.retryTxProducers.values()).map(
+          (p) => p.disconnect().catch(() => {
+          })
+        )
+      ];
       await Promise.allSettled(tasks);
       this.consumers.clear();
       this.runningConsumers.clear();
       this.consumerCreationOptions.clear();
       this.companionGroupIds.clear();
+      this.retryTxProducers.clear();
       this.logger.log("All consumers disconnected");
     }
   }
@@ -1222,6 +1237,12 @@ var KafkaClient = class {
    * Query consumer group lag per partition.
    * Lag = broker high-watermark − last committed offset.
    * A committed offset of -1 (nothing committed yet) counts as full lag.
+   *
+   * Returns an empty array when the consumer group has never committed any
+   * offsets (freshly created group, `autoCommit: false` with no manual commits,
+   * or group not yet assigned). This is a Kafka protocol limitation:
+   * `fetchOffsets` only returns data for topic-partitions that have at least one
+   * committed offset. Use `checkStatus()` to verify broker connectivity in that case.
    */
   async getConsumerLag(groupId) {
     const gid = groupId ?? this.defaultGroupId;
@@ -1270,7 +1291,7 @@ var KafkaClient = class {
       tasks.push(this.txProducer.disconnect());
       this.txProducer = void 0;
     }
-    for (const p of this.retryTxProducers) {
+    for (const p of this.retryTxProducers.values()) {
       tasks.push(p.disconnect());
     }
     this.retryTxProducers.clear();
@@ -1289,6 +1310,14 @@ var KafkaClient = class {
     this.logger.log("All connections closed");
   }
   // ── Graceful shutdown ────────────────────────────────────────────
+  /**
+   * NestJS lifecycle hook — called automatically when the host module is torn down.
+   * Drains in-flight handlers and disconnects all producers, consumers, and admin.
+   * `KafkaModule` relies on this method; no separate destroy provider is needed.
+   */
+  async onModuleDestroy() {
+    await this.disconnect();
+  }
   /**
    * Register SIGTERM / SIGINT handlers that drain in-flight messages before
    * disconnecting. Call this once after constructing the client in non-NestJS apps.
@@ -1439,7 +1468,7 @@ var KafkaClient = class {
       }
     });
     await p.connect();
-    this.retryTxProducers.add(p);
+    this.retryTxProducers.set(transactionalId, p);
     return p;
   }
   async ensureTopic(topic2) {
@@ -1468,6 +1497,12 @@ var KafkaClient = class {
         `Cannot use ${mode} on consumer group "${gid}" \u2014 it is already running with ${oppositeMode}. Use a different groupId for this consumer.`
       );
     }
+    if (existingMode === mode) {
+      const callerName = mode === "eachMessage" ? "startConsumer" : "startBatchConsumer";
+      throw new Error(
+        `${callerName}("${gid}") called twice \u2014 this group is already consuming. Call stopConsumer("${gid}") first or pass a different groupId.`
+      );
+    }
     const consumer = getOrCreateConsumer(
       gid,
       fromBeginning,
@@ -1682,11 +1717,7 @@ var KafkaModule = class {
       global: options.isGlobal ?? false,
       module: KafkaModule,
       imports: [import_core2.DiscoveryModule],
-      providers: [
-        kafkaClientProvider,
-        KafkaModule.buildDestroyProvider(token),
-        KafkaExplorer
-      ],
+      providers: [kafkaClientProvider, KafkaExplorer],
       exports: [kafkaClientProvider]
     };
   }
@@ -1702,11 +1733,7 @@ var KafkaModule = class {
       global: asyncOptions.isGlobal ?? false,
       module: KafkaModule,
       imports: [...asyncOptions.imports || [], import_core2.DiscoveryModule],
-      providers: [
-        kafkaClientProvider,
-        KafkaModule.buildDestroyProvider(token),
-        KafkaExplorer
-      ],
+      providers: [kafkaClientProvider, KafkaExplorer],
       exports: [kafkaClientProvider]
     };
   }
@@ -1728,15 +1755,6 @@ var KafkaModule = class {
     await client.connectProducer();
     return client;
   }
-  static buildDestroyProvider(token) {
-    return {
-      provide: `${token}_DESTROY`,
-      useFactory: (client) => ({
-        onModuleDestroy: () => client.disconnect()
-      }),
-      inject: [token]
-    };
-  }
 };
 KafkaModule = __decorateClass([
   (0, import_common3.Module)({})