@dragonshorn-studios/elyseum-cli 1.0.8 → 1.0.10

package/dist/commands/diff-coverage-command.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"diff-coverage-command.d.ts","sourceRoot":"","sources":["../../src/commands/diff-coverage-command.ts"],"names":[],"mappings":"AAYA,OAAO,EAAE,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAChD,OAAe,EAAE,YAAY,EAAE,MAAM,WAAW,CAAC;AAMjD,qBAAa,mBAAoB,YAAW,OAAO;IACjD,IAAI,EAAE,MAAM,CAAmB;IAC/B,MAAM,CAAC,EAAE,YAAY,CA2BnB;gBACU,QAAQ,EAAE,UAAU;IAInB,GAAG,CAAC,IAAI,EAAE,GAAG,GAAG,OAAO,CAAC,IAAI,CAAC;YAqI5B,qBAAqB;YA2JrB,iBAAiB;YAajB,eAAe;CA4E9B"}
+{"version":3,"file":"diff-coverage-command.d.ts","sourceRoot":"","sources":["../../src/commands/diff-coverage-command.ts"],"names":[],"mappings":"AAYA,OAAO,EAAE,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAChD,OAAe,EAAE,YAAY,EAAE,MAAM,WAAW,CAAC;AAMjD,qBAAa,mBAAoB,YAAW,OAAO;IACjD,IAAI,EAAE,MAAM,CAAmB;IAC/B,MAAM,CAAC,EAAE,YAAY,CA2BnB;gBACU,QAAQ,EAAE,UAAU;IAInB,GAAG,CAAC,IAAI,EAAE,GAAG,GAAG,OAAO,CAAC,IAAI,CAAC;YAqI5B,qBAAqB;YAgLrB,iBAAiB;YAajB,eAAe;CA4E9B"}

package/dist/index.js

@@ -24993,6 +24993,10 @@ class GithubPRCommentCoverageReporter {
                 type: "int",
                 default: 50,
             },
+            "fail-action-on-quality-gate": {
+                help: "Mark the check as failed if the quality gate is not met",
+                action: "store_true",
+            },
         };
     }
     report(diffCoverage) {
@@ -25011,6 +25015,7 @@ class GithubPRCommentCoverageReporter {
             "reporter.coverage.quality-gate-fail",
             "reporter.coverage.github-pr-comment.quality-gate-fail",
         ], 50);
+        const failActionOnQualityGate = Config$1.getInstance().getFirst(["reporter.coverage.github-pr-comment.fail-action-on-quality-gate"], false);
         const commentFilePath = Config$1.getInstance().getFirst(["reporter.coverage.github-pr-comment.comment-file-path"], "coverage/github.pr.coverage.md");
         const annotationFilePath = Config$1.getInstance().getFirst(["reporter.coverage.github-pr-comment.annotation-file-path"], "coverage/github.pr.annotations.json");
         let repoName = process.env.GITHUB_REPOSITORY || "";
@@ -25088,13 +25093,25 @@ class GithubPRCommentCoverageReporter {
         let annotations = [];
         if (createAnnotations) {
             for (const file of diffCoverage.files) {
+                for (let lineBlock of file.lines.details || []) {
+                    if (lineBlock.hit === 0) {
+                        annotations.push({
+                            path: file.file,
+                            start_line: lineBlock.start,
+                            end_line: lineBlock.end,
+                            annotation_level: qualityGateFailed ? "failure" : "warning",
+                            title: "Lines not covered",
+                            message: `Lines not covered`,
+                        });
+                    }
+                }
                 for (let functionDetails of file.functions.details || []) {
                     if (functionDetails.hit === 0) {
                         annotations.push({
                             path: file.file,
                             start_line: functionDetails.line,
                             end_line: functionDetails.line,
-                            annotation_level: qualityGateFailed ? "warning" : "warning",
+                            annotation_level: qualityGateFailed ? "failure" : "warning",
                             title: "Function not covered",
                             message: `Function ${functionDetails.name} not covered`,
                         });
@@ -25106,7 +25123,7 @@ class GithubPRCommentCoverageReporter {
                             path: file.file,
                             start_line: branchDetails.line,
                             end_line: branchDetails.line,
-                            annotation_level: qualityGateFailed ? "warning" : "warning",
+                            annotation_level: qualityGateFailed ? "failure" : "warning",
                             title: "Branch not covered",
                             message: `Branch not covered`,
                         });
@@ -25121,7 +25138,9 @@ class GithubPRCommentCoverageReporter {
             head_sha: diffCoverage.headSha,
             status: "completed",
             conclusion: qualityGateFailed
-                ? "neutral"
+                ? failActionOnQualityGate
+                    ? "failure"
+                    : "neutral"
                 : qualityGateWarning
                     ? "neutral"
                     : "success",
@@ -54446,11 +54465,29 @@ class DiffCoverageCommand {
             let changedLineNumbers = new Set();
             let changedLineCount = 0;
             for (let hunk of file.diff.hunks) {
+                let hunkLine = 0;
                 for (let line = hunk.newStart; line < hunk.newStart + hunk.newLines; line++) {
+                    if (hunk.lines) {
+                        if (hunk.lines[hunkLine].startsWith("-")) {
+                            continue;
+                        }
+                        else if (hunk.lines[hunkLine].startsWith("+")) {
+                            // ignore comment lines
+                            const changedLine = hunk.lines[hunkLine].replace(/^\+/, "");
+                            if (changedLine.trim().startsWith("//") ||
+                                changedLine.trim() === "" ||
+                                changedLine.trim().startsWith("/*") ||
+                                changedLine.trim().startsWith("*")) {
+                                continue;
+                            }
+                        }
+                    }
                     changedLineNumbers.add(line);
+                    hunkLine++;
                 }
-                changedLineCount += hunk.newLines;
             }
+            changedLineCount = changedLineNumbers.size;
+            Logger.debug(`Changed line count for file ${normalizedPath}: ${changedLineCount}`);
             let coveredLines = 0;
             let coveredFunctions = 0;
             let totalFunctions = 0;