@dra2020/district-analytics 4.3.3 → 4.3.6

package/dist/cli.js

@@ -89327,7 +89327,7 @@ exports.scoreCountySplitting = scoreCountySplitting;
 function countySplitThreshold(nCounties, nDistricts) {
     const m = C.allowableSplitsMultiplier();
     const worst = C.countySplittingRange()[1];
-    const nAllowableSplits = Math.min(m * (nDistricts - 1));
+    const nAllowableSplits = Math.min(m * (nDistricts - 1), nCounties);
     const threshold = ((nAllowableSplits * worst) + ((nCounties - nAllowableSplits) * 1.0)) / nCounties;
     return threshold;
 }
@@ -90217,7 +90217,7 @@ function exceedsMaximumThreshold(Mf) {
     return Mf > threshold;
 }
 function calcProportionalDistricts(proportion, nDistricts) {
-    // TODO - Bump up to get a statewide proportion on the bubble to rate one district?
+    // TODO - Maybe bump up to get a statewide proportion on the bubble to rate one district?
     const roundUp = 0.0;
     const fractional = proportion * nDistricts;
     const integral = Math.round(fractional + roundUp);
@@ -90366,14 +90366,14 @@ const normalize_1 = __webpack_require__(/*! ./normalize */ "./src/normalize.ts")
 * S# [estS] (S_V) = the estimated Democratic seats, using seat probabilities
 * S% [estSf] = the estimated Democratic seat share fraction, calculated as S# / N
 
-* BS_50 [bS50] = Seat bias as a fraction of N <<< TODO - RENAME
-* BV_50 [bV50] = Votes bias as a fraction <<< TODO - RENAME
+* BS_50 [bS50] = Seat bias as a fraction of N
+* BV_50 [bV50] = Votes bias as a fraction
 * decl [decl] = Declination
-* GS [gSym] = Global symmetry <<< TODO - RENAME
+* GS [gSym] = Global symmetry
 
 * EG [EG] = Efficiency gap as a fraction
-* BS_V [bSV] = Seats bias @ <V> (geometric) <<< TODO
-* PR [prop] = Disproportionality <<< TODO - RENAME
+* BS_V [bSV] = Seats bias @ <V> (geometric)
+* PR [prop] = Disproportionality
 * MM [mMs] = Mean – median difference using statewide Vf
 * TO [tOf] = Turnout bias
 * MM' [mMd] = Mean – median difference using average district v
@@ -90417,7 +90417,7 @@ function scorePartisan(Vf, VfArray, options) {
     const bias = estBias(estSf, bestSf);
     const biasScore = scorebias(bias, Vf, estSf);
     const unearnedS = estUnearnedSeats(bestS, estS);
-    const impactScore = scoreImpact(unearnedS, Vf, N);
+    const impactScore = scoreImpact(unearnedS, Vf, estSf, N);
     // Calculate additional alternate metrics for reference
     // NOTE - Use the uncompressed seat probability function
     const inferredSVpoints = bAlternateMetrics ? inferSVpoints(Vf, VfArray, shift) : undefined;
@@ -90549,22 +90549,27 @@ function adjustBias(Vf, bias, extra) {
 }
 exports.adjustBias = adjustBias;
 // Normalize unearned seats
-function scoreImpact(rawUE, Vf, N) {
-    // Adjust impact to incorporate an acceptable winner's bonus based on Vf
-    const extra = extraBonus(Vf);
-    const adjustedBias = adjustBias(Vf, rawUE / N, extra);
-    const adjustedImpact = adjustedBias * N;
-    // Then normalize
-    const _normalizer = new normalize_1.Normalizer(adjustedImpact);
-    const worst = C.unearnedThreshold();
-    const best = 0.0;
-    _normalizer.positive();
-    _normalizer.clip(worst, best);
-    _normalizer.unitize(worst, best);
-    _normalizer.invert();
-    _normalizer.rescale();
-    const score = _normalizer.normalizedNum;
-    return score;
+function scoreImpact(rawUE, Vf, Sf, N) {
+    if (isAntimajoritarian(Vf, Sf)) {
+        return 0;
+    }
+    else {
+        // Adjust impact to incorporate an acceptable winner's bonus based on Vf
+        const extra = extraBonus(Vf);
+        const adjustedBias = adjustBias(Vf, rawUE / N, extra);
+        const adjustedImpact = adjustedBias * N;
+        // Then normalize
+        const _normalizer = new normalize_1.Normalizer(adjustedImpact);
+        const worst = C.unearnedThreshold();
+        const best = 0.0;
+        _normalizer.positive();
+        _normalizer.clip(worst, best);
+        _normalizer.unitize(worst, best);
+        _normalizer.invert();
+        _normalizer.rescale();
+        const score = _normalizer.normalizedNum;
+        return score;
+    }
 }
 exports.scoreImpact = scoreImpact;
 function isAntimajoritarian(Vf, Sf) {