@dra2020/district-analytics 2.0.0 → 2.0.3

package/dist/district-analytics.js

@@ -190,19 +190,14 @@ class AnalyticsSession {
         // Convert them into a (possibly empty) list of features
         let discontiguousDistrictFeatures = { type: 'FeatureCollection', features: [] };
         if (!(U.isArrayEmpty(discontiguousDistrictIDs))) {
-            for (let i = 0; i < discontiguousDistrictIDs.length; i++) {
-                let poly = this.districts.getShape(i);
-                discontiguousDistrictFeatures.features.push(poly);
+            for (let id of discontiguousDistrictIDs) {
+                let poly = this.districts.getDistrictShapeByID(id);
+                if (poly)
+                    discontiguousDistrictFeatures.features.push(poly);
             }
         }
         return discontiguousDistrictFeatures;
     }
-    // TODO - DASHBOARD: Delete, when cut over to the new analytics UI.
-    // Prepare a scorecard for rendering
-    // NOTE - This assumes that analyzePlan() has been run!
-    // prepareScorecard(): any {
-    //   return doPrepareScorecard(this);
-    // }
     // HELPERS USED INTERNALLY
     // Get an individual test, so you can drive UI with the results.
     getTest(testID) {
@@ -218,12 +213,6 @@ class AnalyticsSession {
         // Return a pointer to the the test entry for this test
         return this.tests[testID];
     }
-    // TODO - DASHBOARD: Delete, when cut over to the new analytics UI.
-    // Prepare test results for rendering
-    // NOTE - This assumes that analyzePlan() has been run!
-    // prepareTestLog(): any {
-    //   return doPrepareTestLog(this);
-    // }
     // NOTE - Not sure why this has to be up here.
     populationDeviationThreshold() {
         return 1 - this.testScales[4 /* PopulationDeviation */]['scale'][0];
@@ -301,7 +290,16 @@ class Districts {
         this._shapes = ds;
         this.statistics = this.initStatistics();
     }
-    getShape(i) { return this._shapes.features[i]; }
+    getDistrictShapeByID(id) {
+        // NOTE - Find the district shape by ID (not index)
+        // return this._shapes.features[id]; 
+        for (let f of this._shapes.features) {
+            if (f.properties && (f.properties.id == id)) {
+                return f;
+            }
+        }
+        return undefined;
+    }
     getGeoProperties(i) {
         // Make sure the district shape exists & has geo properties
         if (i in this._geoProperties)
@@ -431,8 +429,8 @@ class Districts {
                 });
                 // COMPUTE DERIVED VALUES
                 // Population deviation % and equal population (boolean) by district.
-                // Don't set the values for the dummy unassigned district.
-                let popDevPct = null;
+                // Default the value for the dummy unassigned district to 0%.
+                let popDevPct = 0 / targetSize;
                 if (i > 0) {
                     popDevPct = (totalPop - targetSize) / targetSize;
                     bEqualPop = (popDevPct <= deviationThreshold);
@@ -772,7 +770,12 @@ class Graph {
         // Ignore the lengths of the shared borders (the values), for now
         // Protect against getting a GEOID that's not in the graph
         if (U.keyExists(node, this._graph)) {
-            return U.getObjectKeys(this._graph[node]);
+            // NOTE - CONTIGUITY GRAPHS
+            // Handle both unweighted & weighted neighbors
+            let n = this._graph[node];
+            let l = (n instanceof Array) ? n : U.getObjectKeys(n);
+            return l;
+            // return U.getObjectKeys(this._graph[node]);
         }
         else
             return [];
@@ -1366,9 +1369,9 @@ function doPolsbyPopper(s, bLog = false) {
 exports.doPolsbyPopper = doPolsbyPopper;
 // HELPER TO EXTRACT PROPERTIES OF DISTRICT SHAPES
 function extractDistrictProperties(s, bLog = false) {
+    // NOTE - I am assuming that district IDs are integers 1–N
     for (let i = 1; i <= s.state.nDistricts; i++) {
-        let j = i - 1; // TODO - TERRY: How do you get away w/o this?!?
-        let poly = s.districts.getShape(j);
+        let poly = s.districts.getDistrictShapeByID(i);
         // Guard against no shape for empty districts AND null shapes
         let polyOptions = { noLatitudeCorrection: true };
         let bNull = (!Poly.polyNormalize(poly, polyOptions));
@@ -2452,8 +2455,10 @@ const testDefns = {
 //   Raw numeric analytics, such as population deviation, compactness, etc. are
 //   normalized as part of creating a scorecard, so the code to normalize results
 //   is encapsulated here.
-// Configure scale parameters for normalizing each raw test result
-//   This needs to be separate from the scorecard configuration info above,
+// Configure scale parameters for normalizing each raw test result.
+//   Scales consist of a minimum & a maximum *raw* value. If the values get
+//   inverted (to make bigger better), these will switch.
+//   This process needs to be separate from the test configuration info above,
 //   because some scales need access to the analytics session object.
 function doConfigureScales(s) {
     // Scale defn for PopulationDeviation
@@ -2925,7 +2930,6 @@ function doIsContiguous(s, bLog = false) {
 exports.doIsContiguous = doIsContiguous;
 // Are the features in a district fully connected?
 function isConnected(districtGeos, graph) {
-    // export function isConnected(districtGeos: Set<string>, graph: T.ContiguityGraph): boolean {
     // TODO - TERRY, why does this constructor need a <T> type specification?
     let visited = new Set();
     let toProcess = [];