@dr.pogodin/eslint-configs 0.2.0 → 0.2.2

package/README.md

@@ -100,8 +100,10 @@ combined and extended as necessary for the needs of host projects.
 [`configs.javascript`]: #configsjavascript
 
 Intended for JavaScript code, it applies to the files [ESLint] considers as
-JavaScript by default: `**/*.js`, `**/*.cjs`, `**/*.mjs`; and it applies to
-them the following rule sets:
+JavaScript by default: `**/*.js`, `**/*.cjs`, `**/*.mjs`, as well as to any
+other files matched by other config objects in your config (_i.e._ it does not
+include `files` key, see [ESLint docs for related configuration details](https://eslint.org/docs/latest/use/configure/configuration-files#specifying-files-and-ignores));
+and it applies to them the following rule sets:
 
 - [ESLint Core Rules](https://eslint.org/docs/latest/rules) —
   the `recommended` rule set, with minor overrides, and many additional rules

package/config/javascript.js

@@ -2,6 +2,7 @@
 
 import { defineConfig } from 'eslint/config';
 import importPlugin from 'eslint-plugin-import';
+
 import perfectionist from 'eslint-plugin-perfectionist';
 import { Alphabet } from 'eslint-plugin-perfectionist/alphabet';
 
@@ -280,19 +281,14 @@ function newConfig({ noPerf } = {}) {
     // eslint-disable-next-line import/no-named-as-default-member
     extentions.push(perfectionist.configs['recommended-custom']);
 
-    // TODO: For now it is disabled because of the following Perfectionist bug:
-    // https://github.com/azat-io/eslint-plugin-perfectionist/issues/688
-    // and we'll keep using "import/order" rule here until the issue is addressed.
-    rules['perfectionist/sort-imports'] = 'off';
-    rules['import/order'] = ['error', {
-      groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
-    }];
-
     settings.perfectionist = {
       alphabet: Alphabet.generateRecommendedAlphabet()
         .placeAllWithCaseBeforeAllWithOtherCase('uppercase')
+        .placeCharacterBefore({ characterAfter: '-', characterBefore: '/' })
         .getCharacters(),
       ignoreCase: false,
+      newlinesBetween: 'ignore',
+      newlinesInside: 'ignore',
       partitionByNewLine: true,
     };
   }

package/config/jest.js

@@ -17,9 +17,7 @@ export default defineConfig([{
     'jest/no-conditional-in-test': 'error',
     'jest/no-confusing-set-timeout': 'error',
     'jest/no-duplicate-hooks': 'error',
-    'jest/no-error-equal': 'error',
     'jest/no-test-return-statement': 'error',
-    'jest/no-unnecessary-assertion': 'error',
     'jest/no-unneeded-async-expect-function': 'error',
     'jest/no-untyped-mock-factory': 'error',
     'jest/padding-around-after-all-blocks': 'error',
@@ -44,11 +42,22 @@ export default defineConfig([{
     'jest/prefer-to-have-been-called-times': 'error',
     'jest/prefer-todo': 'error',
     'jest/require-to-throw-message': 'error',
-    'jest/valid-expect-with-promise': 'error',
     'jest/valid-mock-module-path': 'error',
 
     'no-console': 'off',
 
     '@typescript-eslint/unbound-method': 'off',
   },
+}, {
+  // NOTE: These rules require type information, hence they are applied for TS
+  // files only.
+  names: 'dr.pogodin/jest/typescript',
+
+  files: ['**/ts', '**/tsx'],
+  plugins: { jest: pluginJest },
+  rules: {
+    'jest/no-error-equal': 'error',
+    'jest/no-unnecessary-assertion': 'error',
+    'jest/valid-expect-with-promise': 'error',
+  },
 }]);

package/config/react.js

@@ -1,7 +1,6 @@
 import { defineConfig } from 'eslint/config';
 
 import jsxA11y from 'eslint-plugin-jsx-a11y';
-import perfectionist from 'eslint-plugin-perfectionist';
 import react from 'eslint-plugin-react';
 import reactHooks from 'eslint-plugin-react-hooks';
 
@@ -18,7 +17,6 @@ export default defineConfig([{
     },
   },
   plugins: {
-    perfectionist,
     react,
   },
   settings: {
@@ -28,14 +26,6 @@ export default defineConfig([{
   },
 
   rules: {
-    // Rules provided by "eslint-plugin-perfectionist"
-    // NOTE: Not necessary when default JS config is used, which already
-    // includes it... but we keep it around to avoid any changes for consumers
-    // who may include this config without our default JS/TS one.
-    'perfectionist/sort-jsx-props': ['error', {
-      type: 'natural',
-    }],
-
     // Rules provided by "eslint-plugin-jsx-a11y".
     'jsx-a11y/anchor-ambiguous-text': 'error',
     'jsx-a11y/control-has-associated-label': 'error',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dr.pogodin/eslint-configs",
-  "version": "0.2.0",
+  "version": "0.2.2",
   "description": "ESLint configurations for TypeScript and/or React projects",
   "type": "module",
   "main": "./config/index.js",