@dr.pogodin/eslint-configs 0.0.5 → 0.0.7

package/README.md

@@ -146,12 +146,15 @@ and it applies to them the following rule sets:
   the `recommended` rule set, with minor overrides, and many additional rules
   enabled.
 
-- [eslint-plugin-react-hooks](https://www.npmjs.com/package/eslint-plugin-react-hooks) —
-  all rules enabled.
-
 Additionally, it applies to all other files matched by any other [ESLint]
-configuration object, to forbid using JSX syntax in files with extensions
-different from `.jsx` or `.tsx`.
+configuration object; and it applies to them the following rule sets:
+
+- [eslint-plugin-react-hooks](https://www.npmjs.com/package/eslint-plugin-react-hooks)
+  — all rules enabled (it has to apply to all files, as hooks do not have
+  to live ony inside JSX or TSX files exclusively).
+
+- the rule that forbids using JSX syntax in files with extensions different from
+  `.jsx` or `.tsx`.
 
 ### `configs.typescript`
 [`configs.typescript`]: #configstypescript

package/config/javascript.js

@@ -71,6 +71,9 @@ export default defineConfig([{
     'import/no-unused-modules': 'error',
     'import/no-useless-path-segments': 'error',
     'import/no-webpack-loader-syntax': 'error',
+    'import/order': ['error', {
+      groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
+    }],
 
     // These rules are provided by "@stylistic/eslint-plugin",
     // and (re-)configured for our taste, somewhat differently from
@@ -212,7 +215,9 @@ export default defineConfig([{
     'no-new-wrappers': 'error',
     'no-object-constructor': 'error',
     'no-octal-escape': 'error',
-    'no-param-reassign': 'error',
+    'no-param-reassign': ['error', {
+      props: true,
+    }],
     'no-promise-executor-return': 'error',
     'no-proto': 'error',
     'no-return-assign': 'error',
@@ -222,6 +227,7 @@ export default defineConfig([{
     'no-shadow': 'error',
     'no-template-curly-in-string': 'error',
     'no-throw-literal': 'error',
+    'no-unassigned-vars': 'error',
     'no-undef-init': 'error',
     'no-underscore-dangle': 'error',
     'no-unmodified-loop-condition': 'error',
@@ -256,6 +262,17 @@ export default defineConfig([{
     'require-atomic-updates': 'error',
     'require-await': 'error',
     'require-yield': 'error',
+
+    // TODO: Disabled for now, as there is one thing I don't like about it:
+    // in TypeScript it sorts type imports together with other imported members,
+    // while I'd prefer to have all type member imports first, followed by other
+    // imported members after.
+    /*
+    'sort-imports': ['error', {
+      ignoreDeclarationSort: true,
+    }],
+    */
+
     'sort-keys': ['error', 'asc', {
       allowLineSeparatedGroups: true,
     }],

package/config/jest.js

@@ -39,6 +39,8 @@ export default defineConfig([{
     'jest/prefer-todo': 'error',
     'jest/require-to-throw-message': 'error',
 
+    'no-console': 'off',
+
     '@typescript-eslint/unbound-method': 'off',
   },
 }]);

package/config/react.js

@@ -18,7 +18,6 @@ export default defineConfig([{
   },
   plugins: {
     react,
-    'react-hooks': reactHooks,
   },
   settings: {
     react: {
@@ -101,20 +100,33 @@ export default defineConfig([{
     'react/sort-comp': 'error',
     'react/style-prop-object': 'error',
     'react/void-dom-elements-no-children': 'error',
-
-    // Rules provided by eslint-plugin-react-hooks.
-    'react-hooks/exhaustive-deps': 'error',
-    'react-hooks/rules-of-hooks': 'error',
+  },
+}, {
+  files: ['**/*.jsx'],
+  name: 'dr.pogodin/react/jsx',
+  rules: {
+    // This is our preferred naming scheme for pure JSX code (i.e., non-TypeScript).
+    'react/function-component-definition': ['error', {
+      namedComponents: 'function-declaration',
+      unnamedComponents: 'arrow-function',
+    }],
   },
 }, {
   name: 'dr.pogodin/react/global',
   plugins: {
     react,
+    'react-hooks': reactHooks,
   },
   rules: {
     'react/jsx-filename-extension': ['error', {
       allow: 'as-needed',
       extensions: ['.jsx', '.tsx'],
     }],
+
+    // Rules provided by eslint-plugin-react-hooks; they should be applied to
+    // all files, as hooks do not have to live exclusively in .jsx / .tsx files
+    // alongside JSX syntax!
+    'react-hooks/exhaustive-deps': 'error',
+    'react-hooks/rules-of-hooks': 'error',
   },
 }]);

package/config/typescript.js

@@ -52,6 +52,7 @@ export default tsEsLint.config(
       '@typescript-eslint/no-mixed-enums': 'error',
       '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
       '@typescript-eslint/no-redeclare': 'error',
+      '@typescript-eslint/no-unnecessary-type-conversion': 'error',
 
       // NOTE: The core rule variant reports incorrect errors on TypeScript
       // code, thus disabled.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dr.pogodin/eslint-configs",
-  "version": "0.0.5",
+  "version": "0.0.7",
   "description": "ESLint configurations for TypeScript and/or React projects",
   "type": "module",
   "main": "./config/index.js",
@@ -31,19 +31,19 @@
   "dependencies": {
     "@babel/eslint-parser": "^7.27.1",
     "@babel/eslint-plugin": "^7.27.1",
-    "@babel/preset-env": "^7.27.1",
+    "@babel/preset-env": "^7.27.2",
     "@babel/preset-react": "^7.27.1",
     "@babel/preset-typescript": "^7.27.1",
-    "@eslint/js": "^9.26.0",
-    "@stylistic/eslint-plugin": "^4.1.0",
-    "eslint": "^9.26.0",
-    "eslint-import-resolver-typescript": "^4.3.4",
+    "@eslint/js": "^9.27.0",
+    "@stylistic/eslint-plugin": "^4.4.0",
+    "eslint": "^9.27.0",
+    "eslint-import-resolver-typescript": "^4.3.5",
     "eslint-plugin-import": "^2.31.0",
     "eslint-plugin-jest": "^28.11.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
     "eslint-plugin-react": "^7.37.4",
     "eslint-plugin-react-hooks": "^5.2.0",
     "typescript": "^5.7.0",
-    "typescript-eslint": "^8.31.1"
+    "typescript-eslint": "^8.32.1"
   }
 }