@dpesch/mantisbt-mcp-server 1.8.0 → 1.8.2

package/CHANGELOG.md

@@ -11,6 +11,20 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 
 ---
 
+## [1.8.2] – 2026-03-27
+
+### Fixed
+- HTTP transport (`TRANSPORT=http`): race condition when multiple sequential requests arrive quickly (e.g. `initialize` followed immediately by `ping`). The `res.on('close')` handler that calls `transport.close()` fires asynchronously, so the next request could arrive while the previous transport was still registered — causing `connect()` to throw "Already connected". Fixed by calling `await server.close()` before each `server.connect()` call (a no-op when not connected). Also added a `res.headersSent` guard in the error handler to prevent a secondary "Cannot set headers after they are sent" error from closing the socket without a response.
+
+---
+
+## [1.8.1] – 2026-03-27
+
+### Fixed
+- `MANTIS_BASE_URL` values ending in `/api/rest` (as shown in README examples) caused a doubled path (`/api/rest/api/rest/...`) and broke all API calls. A new `normalizeBaseUrl()` helper strips the `/api/rest` suffix (and any trailing slash) on startup. Both formats are now accepted: `https://your-mantis.example.com` and `https://your-mantis.example.com/api/rest`.
+
+---
+
 ## [1.8.0] – 2026-03-27
 
 ### Added

package/README.de.md

@@ -65,7 +65,7 @@ npm run build
 
 | Variable | Pflicht | Standard | Beschreibung |
 |---|---|---|---|
-| `MANTIS_BASE_URL` | ✅ | – | Basis-URL der MantisBT REST API |
+| `MANTIS_BASE_URL` | ✅ | – | Basis-URL der MantisBT-Installation. Beide Formate werden akzeptiert: `https://deine-mantis-instanz.example.com` und `https://deine-mantis-instanz.example.com/api/rest` — das `/api/rest`-Suffix wird automatisch normalisiert. |
 | `MANTIS_API_KEY` | ✅ | – | API-Token für die Authentifizierung |
 | `MANTIS_CACHE_DIR` | – | `~/.cache/mantisbt-mcp` | Verzeichnis für den Metadaten-Cache |
 | `MANTIS_CACHE_TTL` | – | `3600` | Cache-Lebensdauer in Sekunden |

package/README.md

@@ -65,7 +65,7 @@ npm run build
 
 | Variable | Required | Default | Description |
 |---|---|---|---|
-| `MANTIS_BASE_URL` | ✅ | – | Base URL of the MantisBT REST API |
+| `MANTIS_BASE_URL` | ✅ | – | Base URL of your MantisBT installation. Both `https://your-mantis.example.com` and `https://your-mantis.example.com/api/rest` are accepted — the `/api/rest` suffix is normalized automatically. |
 | `MANTIS_API_KEY` | ✅ | – | API token for authentication |
 | `MANTIS_CACHE_DIR` | – | `~/.cache/mantisbt-mcp` | Directory for the metadata cache |
 | `MANTIS_CACHE_TTL` | – | `3600` | Cache lifetime in seconds |

package/dist/client.js

@@ -1,4 +1,16 @@
 // ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+/**
+ * Normalise a MANTIS_BASE_URL so that it never ends with "/api/rest" or a
+ * trailing slash.  The client always appends "/api/rest/<path>" itself, so
+ * users who follow README examples that include "/api/rest" in the URL must
+ * not end up with a doubled prefix.
+ */
+export function normalizeBaseUrl(url) {
+    return url.replace(/\/api\/rest\/?$/, '').replace(/\/$/, '');
+}
+// ---------------------------------------------------------------------------
 // MantisApiError
 // ---------------------------------------------------------------------------
 export class MantisApiError extends Error {
@@ -15,7 +27,7 @@ export class MantisClient {
     resolvedCredentials;
     constructor(baseUrlOrFactory, apiKeyOrObserver, responseObserver) {
         if (typeof baseUrlOrFactory === 'string') {
-            this.resolvedCredentials = { baseUrl: baseUrlOrFactory.replace(/\/$/, ''), apiKey: apiKeyOrObserver };
+            this.resolvedCredentials = { baseUrl: normalizeBaseUrl(baseUrlOrFactory), apiKey: apiKeyOrObserver };
             this.responseObserver = responseObserver;
         }
         else {
@@ -29,7 +41,7 @@ export class MantisClient {
     async getCredentials() {
         if (!this.resolvedCredentials) {
             const { baseUrl, apiKey } = await this.credentialFactory();
-            this.resolvedCredentials = { baseUrl: baseUrl.replace(/\/$/, ''), apiKey };
+            this.resolvedCredentials = { baseUrl: normalizeBaseUrl(baseUrl), apiKey };
         }
         return this.resolvedCredentials;
     }

package/dist/config.js

@@ -2,6 +2,7 @@ import { readFile } from 'node:fs/promises';
 import { homedir } from 'node:os';
 import { join, dirname } from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { normalizeBaseUrl } from './client.js';
 // ---------------------------------------------------------------------------
 // .env.local loader
 // ---------------------------------------------------------------------------
@@ -85,7 +86,7 @@ export async function getConfig() {
             `Set the environment variables MANTIS_BASE_URL and MANTIS_API_KEY.`);
     }
     cachedConfig = {
-        baseUrl: baseUrl.replace(/\/$/, ''), // strip trailing slash
+        baseUrl: normalizeBaseUrl(baseUrl),
         apiKey,
         ...readNonCredentialConfig(),
     };

package/dist/index.js

@@ -107,13 +107,20 @@ async function runHttp() {
                         sessionIdGenerator: undefined,
                         enableJsonResponse: true,
                     });
-                    res.on('close', () => transport.close());
+                    res.on('close', () => { void transport.close(); });
+                    // Disconnect from any previous transport before connecting the new one.
+                    // The res.on('close') handler above closes the transport asynchronously,
+                    // but the next request may arrive before it fires — causing connect() to
+                    // throw "Already connected". Explicitly closing first avoids that race.
+                    await server.close();
                     await server.connect(transport);
                     await transport.handleRequest(req, res, body);
                 }
                 catch {
-                    res.writeHead(400, { 'Content-Type': 'application/json' });
-                    res.end(JSON.stringify({ error: 'Bad Request' }));
+                    if (!res.headersSent) {
+                        res.writeHead(400, { 'Content-Type': 'application/json' });
+                        res.end(JSON.stringify({ error: 'Bad Request' }));
+                    }
                 }
             });
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dpesch/mantisbt-mcp-server",
-  "version": "1.8.0",
+  "version": "1.8.2",
   "mcpName": "io.github.dpesch/mantisbt-mcp-server",
   "description": "MCP server for MantisBT REST API – read and manage bug tracker issues",
   "author": "Dominik Pesch",

package/scripts/hooks/pre-push.mjs

@@ -10,7 +10,8 @@
 //   3. Filters every commit between anchor and tip in order (oldest first)
 //   4. Builds a proper filtered chain anchored to the actual remote tip
 //   5. Pushes the filtered tip with --force
-//   6. Exits 1 to block git's unfiltered push
+//   6. Exits 2 to block git's unfiltered push
+//      Exit codes: 0 = no Codeberg refs, 1 = error, 2 = success (filtered push done)
 //
 // Branches are processed before tags so the shaMap is available for tags
 // that point to commits already processed as part of the branch.
@@ -110,6 +111,16 @@ rl.on('close', () => {
   const branches = lines.filter(l => l.split(' ')[2]?.startsWith('refs/heads/'));
   const others   = lines.filter(l => !l.split(' ')[2]?.startsWith('refs/heads/'));
 
+  // Batch-fetch all tags from Codeberg (single ls-remote call, ref → sha).
+  const remoteTagsRaw = gitOptional(`ls-remote --tags "${remoteUrl}"`);
+  const remoteTagMap = new Map(
+    remoteTagsRaw
+      ? remoteTagsRaw.split('\n').filter(Boolean)
+          .map(l => { const [sha, ref] = l.split(/\s+/); return [ref, sha]; })
+          .filter(([ref]) => ref)
+      : []
+  );
+
   // localSha → filteredSha, accumulated across all refs in this push.
   const shaMap = {};
   let pushed = 0;
@@ -123,6 +134,17 @@ rl.on('close', () => {
 
     const label = remoteRef.replace('refs/heads/', '').replace('refs/tags/', '');
 
+    if (remoteRef.startsWith('refs/tags/')) {
+      if (remoteTagMap.has(remoteRef)) {
+        console.log(`  ↷ ${label} already on Codeberg — skipping`);
+        continue;
+      }
+      if (!gitOptional(`rev-parse --verify "${localSha}"`)) {
+        console.warn(`  ⚠ ${label} — commit ${localSha.slice(0, 8)} not found locally, skipping`);
+        continue;
+      }
+    }
+
     // If this commit was already filtered as part of a branch push, reuse it.
     if (localSha in shaMap) {
       try {
@@ -136,9 +158,11 @@ rl.on('close', () => {
       continue;
     }
 
-    // Get the actual current SHA on Codeberg for this ref.
-    const lsOut = gitOptional(`ls-remote "${remoteUrl}" "${remoteRef}"`);
-    const actualRemoteSha = lsOut ? lsOut.split(/\s+/)[0] : '';
+    // Tags: existing ones were skipped above, so only new tags reach here — no remote anchor.
+    // Branches: query individually to find the incremental anchor for filtered chain building.
+    const actualRemoteSha = remoteRef.startsWith('refs/tags/')
+      ? ''
+      : (gitOptional(`ls-remote "${remoteUrl}" "${remoteRef}"`)?.split(/\s+/)[0] ?? '');
 
     if (!actualRemoteSha) {
       // New ref on Codeberg — filter the tip with no parent.
@@ -166,15 +190,8 @@ rl.on('close', () => {
           shaMap[sha] = makeFilteredCommit(sha, filteredTree, mappedParents);
         }
       } else {
-        // Fallback: anchor not found.
-        // If the remote SHA doesn't exist locally (filtered commit from a prior push),
-        // tags can be safely skipped (immutable — already correct on Codeberg).
-        // Branches fall back to orphan filtering (best effort).
+        // Fallback: anchor not found — branch only (tags exit early above).
         const remoteExists = !!gitOptional(`rev-parse --verify "${actualRemoteSha}"`);
-        if (!remoteExists && remoteRef.startsWith('refs/tags/')) {
-          console.log(`  ↷ ${label} already on Codeberg — skipping`);
-          continue;
-        }
         console.warn(`  ⚠ Could not find local base for ${label}, filtering tip only`);
         shaMap[localSha] = makeFilteredCommit(localSha, filterTree(localSha), remoteExists ? [actualRemoteSha] : []);
       }
@@ -199,5 +216,5 @@ rl.on('close', () => {
 
   if (pushed === 0) process.exit(0);
   console.log('→ Filtered push complete. Blocking unfiltered push.');
-  process.exit(1);
+  process.exit(2); // 2 = success (filtered push done, unfiltered blocked); 1 = error
 });

package/server.json

@@ -3,12 +3,12 @@
   "name": "io.github.dpesch/mantisbt-mcp-server",
   "title": "MantisBT MCP Server",
   "description": "MantisBT MCP server – manage issues, notes, files, tags, and relationships. With semantic search.",
-  "version": "1.8.0",
+  "version": "1.8.2",
   "packages": [
     {
       "registryType": "npm",
       "identifier": "@dpesch/mantisbt-mcp-server",
-      "version": "1.8.0",
+      "version": "1.8.2",
       "runtimeHint": "npx",
       "transport": {
         "type": "stdio"

package/tests/client.test.ts

@@ -56,6 +56,28 @@ describe('MantisClient – URL building', () => {
     });
   });
 
+  it('strips /api/rest suffix when user includes it in the base URL', () => {
+    const fetchMock = vi.fn().mockResolvedValue(makeResponse(200, '{}'));
+    vi.stubGlobal('fetch', fetchMock);
+
+    const client = new MantisClient('https://mantis.example.com/api/rest', 'token123');
+    return client.get('issues/42').then(() => {
+      const calledUrl: string = fetchMock.mock.calls[0][0] as string;
+      expect(calledUrl).toBe('https://mantis.example.com/api/rest/issues/42');
+    });
+  });
+
+  it('strips /api/rest/ (with trailing slash) from base URL', () => {
+    const fetchMock = vi.fn().mockResolvedValue(makeResponse(200, '{}'));
+    vi.stubGlobal('fetch', fetchMock);
+
+    const client = new MantisClient('https://mantis.example.com/api/rest/', 'token123');
+    return client.get('issues/42').then(() => {
+      const calledUrl: string = fetchMock.mock.calls[0][0] as string;
+      expect(calledUrl).toBe('https://mantis.example.com/api/rest/issues/42');
+    });
+  });
+
   it('appends defined query parameters', () => {
     const fetchMock = vi.fn().mockResolvedValue(makeResponse(200, '{}'));
     vi.stubGlobal('fetch', fetchMock);

package/tests/config.test.ts

@@ -40,24 +40,44 @@ beforeEach(() => {
 
 describe('getConfig() – ENV variables', () => {
   it('reads baseUrl and apiKey from environment variables', async () => {
-    vi.stubEnv('MANTIS_BASE_URL', 'https://mantis.example.com/api/rest');
+    vi.stubEnv('MANTIS_BASE_URL', 'https://mantis.example.com');
     vi.stubEnv('MANTIS_API_KEY', 'env-api-key');
 
     const getConfig = await freshGetConfig();
     const config = await getConfig();
 
-    expect(config.baseUrl).toBe('https://mantis.example.com/api/rest');
+    expect(config.baseUrl).toBe('https://mantis.example.com');
     expect(config.apiKey).toBe('env-api-key');
   });
 
   it('strips trailing slash from baseUrl', async () => {
+    vi.stubEnv('MANTIS_BASE_URL', 'https://mantis.example.com/');
+    vi.stubEnv('MANTIS_API_KEY', 'key');
+
+    const getConfig = await freshGetConfig();
+    const config = await getConfig();
+
+    expect(config.baseUrl).toBe('https://mantis.example.com');
+  });
+
+  it('strips /api/rest suffix from baseUrl when user includes it', async () => {
+    vi.stubEnv('MANTIS_BASE_URL', 'https://mantis.example.com/api/rest');
+    vi.stubEnv('MANTIS_API_KEY', 'key');
+
+    const getConfig = await freshGetConfig();
+    const config = await getConfig();
+
+    expect(config.baseUrl).toBe('https://mantis.example.com');
+  });
+
+  it('strips /api/rest/ (with trailing slash) from baseUrl', async () => {
     vi.stubEnv('MANTIS_BASE_URL', 'https://mantis.example.com/api/rest/');
     vi.stubEnv('MANTIS_API_KEY', 'key');
 
     const getConfig = await freshGetConfig();
     const config = await getConfig();
 
-    expect(config.baseUrl).toBe('https://mantis.example.com/api/rest');
+    expect(config.baseUrl).toBe('https://mantis.example.com');
   });
 
   it('parses MANTIS_CACHE_TTL as a number', async () => {