@downcity/agent 1.1.23 → 1.1.32

package/src/plugin/builtins/task/runtime/Store.ts

@@ -0,0 +1,253 @@
+/**
+ * Task storage (disk-backed).
+ *
+ * 关键点（中文）
+ * - Task 的“唯一来源”是 `./.downcity/task/<taskId>/task.md`
+ * - list/read/write 都只围绕 markdown 文件与目录结构，不引入数据库
+ * - 运行产物目录：`./.downcity/task/<taskId>/<timestamp>/...`
+ */
+
+import fs from "fs-extra";
+import path from "node:path";
+import type { ShipTaskDefinitionV1, ShipTaskFrontmatterV1 } from "@/plugin/builtins/task/types/Task.js";
+import { parseTaskMarkdown, buildTaskMarkdown } from "./Model.js";
+import {
+  deriveTaskIdFromTitle,
+  isValidTaskId,
+  getTaskDir,
+  getTaskMdPath,
+  getTaskRootDir,
+  getTaskRunDir,
+  normalizeTaskId,
+} from "./Paths.js";
+
+/**
+ * Task 列表项（面向 UI/CLI 展示）。
+ */
+export type TaskListItem = {
+  taskId: string;
+  title: string;
+  description: string;
+  body?: string;
+  when: string;
+  status: string;
+  sessionId: string;
+  kind?: "agent" | "script";
+  review?: boolean;
+  taskMdPath: string;
+  lastRunTimestamp?: string;
+};
+
+/**
+ * 判断目录名是否为 run 时间戳格式。
+ */
+function isDirectoryNameTimestamp(name: string): boolean {
+  const s = String(name || "").trim();
+  if (!s) return false;
+  // 例如 20260209-083000-123
+  return /^\d{8}-\d{6}-\d{3}$/.test(s);
+}
+
+/**
+ * 列出全部任务。
+ *
+ * 算法（中文）
+ * - 遍历 `.downcity/task/*` 目录并解析每个 `task.md`。
+ * - 通过子目录时间戳推断 `lastRunTimestamp`。
+ */
+export async function listTasks(projectRoot: string): Promise<TaskListItem[]> {
+  const root = String(projectRoot || "").trim();
+  if (!root) return [];
+
+  const dir = getTaskRootDir(root);
+  await fs.ensureDir(dir);
+
+  let entries: Array<import("node:fs").Dirent> = [];
+  try {
+    entries = await fs.readdir(dir, { withFileTypes: true });
+  } catch {
+    entries = [];
+  }
+
+  const items: TaskListItem[] = [];
+  for (const entry of entries) {
+    if (!entry.isDirectory()) continue;
+    const taskId = String(entry.name || "").trim();
+    if (!taskId || taskId.startsWith(".")) continue;
+    if (!isValidTaskId(taskId)) continue;
+
+    const taskMdPath = getTaskMdPath(root, taskId);
+    let raw = "";
+    try {
+      raw = await fs.readFile(taskMdPath, "utf-8");
+    } catch {
+      continue;
+    }
+
+    const parsed = parseTaskMarkdown({
+      taskId,
+      markdown: raw,
+      taskMdPath,
+      projectRoot: root,
+    });
+    if (!parsed.ok) continue;
+
+    // last run: pick latest timestamp dir (lexicographic works for our timestamp format)
+    let lastRunTimestamp: string | undefined;
+    try {
+      const taskDir = getTaskDir(root, taskId);
+      const child = await fs.readdir(taskDir, { withFileTypes: true });
+      const ts = child
+        .filter((d) => d.isDirectory() && isDirectoryNameTimestamp(d.name))
+        .map((d) => d.name)
+        .sort()
+        .at(-1);
+      if (ts) lastRunTimestamp = ts;
+    } catch {
+      // ignore
+    }
+
+    items.push({
+      taskId,
+      title: parsed.task.frontmatter.title,
+      description: parsed.task.frontmatter.description,
+      ...(parsed.task.body ? { body: parsed.task.body } : {}),
+      when: parsed.task.frontmatter.when,
+      status: parsed.task.frontmatter.status,
+      sessionId: parsed.task.frontmatter.sessionId,
+      kind: parsed.task.frontmatter.kind || "agent",
+      ...(parsed.task.frontmatter.kind === "agent"
+        ? { review: Boolean(parsed.task.frontmatter.review) }
+        : {}),
+      taskMdPath: parsed.task.taskMdPath,
+      ...(lastRunTimestamp ? { lastRunTimestamp } : {}),
+    });
+  }
+
+  items.sort((a, b) => a.taskId.localeCompare(b.taskId));
+  return items;
+}
+
+/**
+ * 根据 title 解析 taskId。
+ *
+ * 关键点（中文）
+ * - 对外只暴露 title，因此运行/状态/删除链路需要先定位真实目录键。
+ * - 若磁盘中存在同 title 多定义，会拒绝并提示冲突。
+ */
+export async function resolveTaskIdByTitle(params: {
+  projectRoot: string;
+  title: string;
+}): Promise<string> {
+  const root = String(params.projectRoot || "").trim();
+  if (!root) throw new Error("projectRoot is required");
+  const title = String(params.title || "").trim();
+  if (!title) throw new Error("title is required");
+
+  const tasks = await listTasks(root);
+  const matched = tasks.filter((item) => String(item.title || "").trim() === title);
+  if (matched.length === 1) return matched[0].taskId;
+  if (matched.length > 1) {
+    throw new Error(`Duplicated task title found: "${title}". Please keep title unique.`);
+  }
+  return deriveTaskIdFromTitle(title);
+}
+
+/**
+ * 读取单个任务定义。
+ */
+export async function readTask(params: { taskId: string; projectRoot: string }): Promise<ShipTaskDefinitionV1> {
+  const root = String(params.projectRoot || "").trim();
+  if (!root) throw new Error("projectRoot is required");
+  const taskId = normalizeTaskId(params.taskId);
+
+  const taskMdPath = getTaskMdPath(root, taskId);
+  const raw = await fs.readFile(taskMdPath, "utf-8");
+  const parsed = parseTaskMarkdown({
+    taskId,
+    markdown: raw,
+    taskMdPath,
+    projectRoot: root,
+  });
+  if (!parsed.ok) throw new Error(parsed.error);
+  return parsed.task;
+}
+
+/**
+ * 删除单个任务目录（包含 task.md 与历史 run 产物）。
+ */
+export async function deleteTask(params: {
+  taskId: string;
+  projectRoot: string;
+}): Promise<{ taskId: string; taskDirPath: string }> {
+  const root = String(params.projectRoot || "").trim();
+  if (!root) throw new Error("projectRoot is required");
+  const taskId = normalizeTaskId(params.taskId);
+
+  const taskMdPath = getTaskMdPath(root, taskId);
+  const exists = await fs.pathExists(taskMdPath);
+  if (!exists) {
+    throw new Error(`Task not found: ${taskId}`);
+  }
+
+  const taskDir = getTaskDir(root, taskId);
+  await fs.remove(taskDir);
+  return {
+    taskId,
+    taskDirPath: path.relative(root, taskDir).split(path.sep).join("/"),
+  };
+}
+
+/**
+ * 写入任务定义（创建或覆盖 task.md）。
+ *
+ * 关键点（中文）
+ * - 默认禁止覆盖，需显式 `overwrite=true`。
+ */
+export async function writeTask(params: {
+  taskId: string;
+  frontmatter: ShipTaskFrontmatterV1;
+  body: string;
+  projectRoot: string;
+  overwrite?: boolean;
+}): Promise<{ taskId: string; taskMdPath: string }> {
+  const root = String(params.projectRoot || "").trim();
+  if (!root) throw new Error("projectRoot is required");
+  const taskId = normalizeTaskId(params.taskId);
+
+  const dir = getTaskDir(root, taskId);
+  const mdPath = getTaskMdPath(root, taskId);
+  await fs.ensureDir(dir);
+
+  const exists = await fs.pathExists(mdPath);
+  if (exists && !params.overwrite) {
+    throw new Error(`task.md already exists: ${path.relative(root, mdPath)}`);
+  }
+
+  const content = buildTaskMarkdown({
+    frontmatter: params.frontmatter,
+    body: params.body,
+  });
+  await fs.writeFile(mdPath, content, "utf-8");
+
+  return { taskId, taskMdPath: path.relative(root, mdPath).split(path.sep).join("/") };
+}
+
+/**
+ * 确保 run 目录存在并返回绝对/相对路径。
+ */
+export async function ensureRunDir(params: {
+  taskId: string;
+  timestamp: string;
+  projectRoot: string;
+}): Promise<{ runDir: string; runDirRel: string }> {
+  const root = String(params.projectRoot || "").trim();
+  if (!root) throw new Error("projectRoot is required");
+  const taskId = normalizeTaskId(params.taskId);
+  const runDir = getTaskRunDir(root, taskId, params.timestamp);
+  await fs.ensureDir(runDir);
+  return {
+    runDir,
+    runDirRel: path.relative(root, runDir).split(path.sep).join("/"),
+  };
+}

package/src/plugin/builtins/task/runtime/TaskActionExecution.ts

@@ -0,0 +1,276 @@
+/**
+ * TaskActionExecution：task service 的业务执行模块。
+ *
+ * 关键点（中文）
+ * - 这里只放 task 的领域执行逻辑，不放 CLI/API 声明。
+ * - task 定义变更后的 scheduler reload 通过回调注入，避免执行层依赖具体 service 实现。
+ */
+
+import type { AgentContext } from "@/core/AgentContextTypes.js";
+import type {
+  TaskCronRegisterResult,
+  TaskListActionPayload,
+  TaskSchedulerReloadResult,
+} from "@/plugin/builtins/task/types/TaskPluginTypes.js";
+import type {
+  TaskCreateRequest,
+  TaskDeleteRequest,
+  TaskRunRequest,
+  TaskSetStatusRequest,
+  TaskUpdateRequest,
+} from "@/plugin/builtins/task/types/TaskCommand.js";
+import {
+  createTaskDefinition,
+  deleteTaskDefinition,
+  listTaskDefinitions,
+  runTaskDefinition,
+  setTaskStatus,
+  updateTaskDefinition,
+} from "@/plugin/builtins/task/Action.js";
+
+const TASK_LOG_PREFIX = "[TASK]";
+
+function formatTaskLogMessage(message: string): string {
+  return `${TASK_LOG_PREFIX} ${message}`;
+}
+
+/**
+ * 任务定义变更后的 scheduler 重载端口。
+ */
+export type TaskSchedulerReloadPort = (params: {
+  /**
+   * 当前执行上下文。
+   */
+  context: AgentContext;
+  /**
+   * 触发本次 reload 的变更动作。
+   */
+  action: "create" | "update" | "delete" | "status";
+  /**
+   * 当前操作的任务标题。
+   */
+  title: string;
+}) => Promise<TaskSchedulerReloadResult>;
+
+/**
+ * 启动后的 task cron runtime 统计结果。
+ */
+export type { TaskCronRegisterResult } from "@/plugin/builtins/task/types/TaskPluginTypes.js";
+
+/**
+ * 任务定义变更后重载 scheduler。
+ *
+ * 关键点（中文）
+ * - 解决 create/update 后还沿用旧注册表的时序问题。
+ * - 重载失败不阻断主操作，仅记录 warning 供排查。
+ */
+export async function reloadTaskSchedulerAfterMutation(params: {
+  context: AgentContext;
+  action: "create" | "update" | "delete" | "status";
+  title: string;
+  reloadScheduler: (context: AgentContext) => Promise<TaskCronRegisterResult>;
+}): Promise<TaskSchedulerReloadResult> {
+  try {
+    const result = await params.reloadScheduler(params.context);
+    params.context.logger.info(
+      formatTaskLogMessage("Task scheduler reloaded after mutation"),
+      {
+        action: params.action,
+        title: params.title,
+        tasksFound: result.tasksFound,
+        jobsScheduled: result.jobsScheduled,
+      },
+    );
+    return {
+      reloaded: true,
+      tasksFound: result.tasksFound,
+      jobsScheduled: result.jobsScheduled,
+    };
+  } catch (error) {
+    const reason = String(error);
+    params.context.logger.warn(
+      formatTaskLogMessage("Task scheduler reload failed after mutation"),
+      {
+        action: params.action,
+        title: params.title,
+        error: reason,
+      },
+    );
+    return {
+      reloaded: false,
+      error: reason,
+    };
+  }
+}
+
+/**
+ * 执行 `task.list` action。
+ */
+export async function executeTaskListAction(params: {
+  context: AgentContext;
+  payload: TaskListActionPayload;
+}) {
+  return {
+    success: true,
+    data: await listTaskDefinitions({
+      projectRoot: params.context.rootPath,
+      ...(params.payload.status ? { status: params.payload.status } : {}),
+    }),
+  };
+}
+
+/**
+ * 执行 `task.create` action。
+ */
+export async function executeTaskCreateAction(params: {
+  context: AgentContext;
+  payload: TaskCreateRequest;
+  reloadSchedulerAfterMutation: TaskSchedulerReloadPort;
+}) {
+  const payload = params.payload;
+  const result = await createTaskDefinition({
+    projectRoot: params.context.rootPath,
+    request: payload,
+  });
+  if (!result.success) {
+    return {
+      success: false,
+      error: result.error || "task create failed",
+    };
+  }
+  const scheduler = await params.reloadSchedulerAfterMutation({
+    context: params.context,
+    action: "create",
+    title: String(result.title || payload.title || "").trim() || "unknown",
+  });
+  return {
+    success: true,
+    data: {
+      ...result,
+      scheduler,
+    },
+  };
+}
+
+/**
+ * 执行 `task.run` action。
+ */
+export async function executeTaskRunAction(params: {
+  context: AgentContext;
+  payload: TaskRunRequest;
+}) {
+  const result = await runTaskDefinition({
+    context: params.context,
+    projectRoot: params.context.rootPath,
+    request: params.payload,
+  });
+  if (!result.success) {
+    return {
+      success: false,
+      error: result.error || "task run failed",
+    };
+  }
+  return {
+    success: true,
+    data: result,
+  };
+}
+
+/**
+ * 执行 `task.delete` action。
+ */
+export async function executeTaskDeleteAction(params: {
+  context: AgentContext;
+  payload: TaskDeleteRequest;
+  reloadSchedulerAfterMutation: TaskSchedulerReloadPort;
+}) {
+  const payload = params.payload;
+  const result = await deleteTaskDefinition({
+    projectRoot: params.context.rootPath,
+    request: payload,
+  });
+  if (!result.success) {
+    return {
+      success: false,
+      error: result.error || "task delete failed",
+    };
+  }
+  const scheduler = await params.reloadSchedulerAfterMutation({
+    context: params.context,
+    action: "delete",
+    title: String(result.title || payload.title || "").trim() || "unknown",
+  });
+  return {
+    success: true,
+    data: {
+      ...result,
+      scheduler,
+    },
+  };
+}
+
+/**
+ * 执行 `task.update` action。
+ */
+export async function executeTaskUpdateAction(params: {
+  context: AgentContext;
+  payload: TaskUpdateRequest;
+  reloadSchedulerAfterMutation: TaskSchedulerReloadPort;
+}) {
+  const payload = params.payload;
+  const result = await updateTaskDefinition({
+    projectRoot: params.context.rootPath,
+    request: payload,
+  });
+  if (!result.success) {
+    return {
+      success: false,
+      error: result.error || "task update failed",
+    };
+  }
+  const scheduler = await params.reloadSchedulerAfterMutation({
+    context: params.context,
+    action: "update",
+    title: String(result.title || payload.title || "").trim() || "unknown",
+  });
+  return {
+    success: true,
+    data: {
+      ...result,
+      scheduler,
+    },
+  };
+}
+
+/**
+ * 执行 `task.status` action。
+ */
+export async function executeTaskStatusAction(params: {
+  context: AgentContext;
+  payload: TaskSetStatusRequest;
+  reloadSchedulerAfterMutation: TaskSchedulerReloadPort;
+}) {
+  const payload = params.payload;
+  const result = await setTaskStatus({
+    projectRoot: params.context.rootPath,
+    request: payload,
+  });
+  if (!result.success) {
+    return {
+      success: false,
+      error: result.error || "task status update failed",
+    };
+  }
+  const scheduler = await params.reloadSchedulerAfterMutation({
+    context: params.context,
+    action: "status",
+    title: String(result.title || payload.title || "").trim() || "unknown",
+  });
+  return {
+    success: true,
+    data: {
+      ...result,
+      scheduler,
+    },
+  };
+}