@dotdrelle/wiki-manager 0.15.48 → 0.15.49

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dotdrelle/wiki-manager",
-  "version": "0.15.48",
+  "version": "0.15.49",
   "description": "Agentic shell and orchestration cockpit for llm-wiki workspaces.",
   "license": "PolyForm-Noncommercial-1.0.0",
   "author": "dotrelle",
@@ -11,7 +11,7 @@
   },
   "scripts": {
     "start": "bun ./bin/wiki-manager.js",
-    "test": "node --test src/core/skillInvocation.test.js src/core/skillCompiler.test.js src/runtime/skillRun.test.js src/runtime/controlDrain.test.js src/runtime/controlCancellation.test.js src/cli/runtimeStartup.test.js src/cli/wiki-manager.test.js src/agent/graph.test.js src/agent/skillRecursion.test.js src/contracts/schemas.test.js src/core/activity.test.js src/core/env.test.js src/core/agentsCompose.test.js src/core/profileServiceStatus.test.js src/core/workspaceProfile.test.js src/core/buildInfo.test.js src/core/agentEvents.test.js src/core/skillChainView.test.js src/core/runtimeLog.test.js src/activity/activityAggregator.test.js src/graph/runGraphProjector.test.js src/core/workflow.test.js src/core/planPatch.test.js src/core/agentLoop.test.js src/core/plan.test.js src/core/mcp.test.js src/core/toolLoop.test.js src/core/documentIntake.test.js src/core/dockerCompose.test.js src/core/otherWorkspacesRunning.test.js src/core/wikiSetup.test.js src/core/wikiWorkspace.test.js src/core/wikirc.test.js src/core/workspaceInherit.test.js src/core/cacert.test.js src/core/composeOverrides.test.js src/core/setEnvValue.test.js src/core/commandFailure.test.js src/core/googleGrants.test.js src/core/modelFetch.test.js src/core/startupCheck.test.js src/core/queueStore.test.js src/orchestrator/agentRegistry.test.js src/orchestrator/capabilityRegistry.test.js src/orchestrator/capabilityResolver.test.js src/orchestrator/planValidator.test.js src/orchestrator/planIntegrator.test.js src/orchestrator/taskStatuses.test.js src/orchestrator/scheduler.test.js src/orchestrator/attemptManager.test.js src/orchestrator/resultAggregator.test.js src/orchestrator/approvalPolicy.test.js src/orchestrator/dispatcher.test.js src/orchestrator/objectiveResolver.test.js src/commands/slash.test.js src/shell/repl.test.js src/shell/setupWizardModality.test.js src/shell/setupWizardPlaceholders.test.js src/shell/setupWizardSuggestions.test.js src/shell/setupWizardDiscovery.test.js src/shell/wrapText.test.js src/runtime/lifecycle.test.js src/runtime/store.test.js src/runtime/workspaceIsolation.test.js src/runtime/controlMessages.test.js src/runtime/recoveryManager.test.js src/runtime/server.test.js src/runtime/supervisor.test.js src/runtime/delegation.test.js src/runtime/runner.test.js src/runtime/runner.e2e.test.js src/runtime/skillChain.e2e.test.js src/runtime/donna-contract.test.js src/runtime/auth.test.js",
+    "test": "node --test src/core/skillInvocation.test.js src/core/skillCompiler.test.js src/runtime/skillRun.test.js src/runtime/controlDrain.test.js src/runtime/controlCancellation.test.js src/cli/runtimeStartup.test.js src/cli/wiki-manager.test.js src/agent/graph.test.js src/agent/skillRecursion.test.js src/contracts/schemas.test.js src/core/activity.test.js src/core/env.test.js src/core/agentsCompose.test.js src/core/profileServiceStatus.test.js src/core/workspaceProfile.test.js src/core/buildInfo.test.js src/core/agentEvents.test.js src/core/skillChainView.test.js src/core/runtimeLog.test.js src/activity/activityAggregator.test.js src/graph/runGraphProjector.test.js src/core/workflow.test.js src/core/planPatch.test.js src/core/agentLoop.test.js src/core/plan.test.js src/core/mcp.test.js src/core/toolLoop.test.js src/core/documentIntake.test.js src/core/dockerCompose.test.js src/core/otherWorkspacesRunning.test.js src/core/wikiSetup.test.js src/core/wikiWorkspace.test.js src/core/wikirc.test.js src/core/workspaceInherit.test.js src/core/cacert.test.js src/core/composeOverrides.test.js src/core/setEnvValue.test.js src/core/commandFailure.test.js src/core/googleGrants.test.js src/core/modelFetch.test.js src/core/startupCheck.test.js src/core/queueStore.test.js src/orchestrator/agentRegistry.test.js src/orchestrator/capabilityRegistry.test.js src/orchestrator/capabilityResolver.test.js src/orchestrator/planValidator.test.js src/orchestrator/planIntegrator.test.js src/orchestrator/taskStatuses.test.js src/orchestrator/scheduler.test.js src/orchestrator/attemptManager.test.js src/orchestrator/resultAggregator.test.js src/orchestrator/approvalPolicy.test.js src/orchestrator/dispatcher.test.js src/orchestrator/objectiveResolver.test.js src/commands/slash.test.js src/shell/repl.test.js src/shell/setupWizardModality.test.js src/shell/setupWizardPlaceholders.test.js src/shell/setupWizardSuggestions.test.js src/shell/setupWizardDiscovery.test.js src/shell/wrapText.test.js src/runtime/lifecycle.test.js src/runtime/store.test.js src/runtime/workspaceIsolation.test.js src/runtime/controlMessages.test.js src/runtime/recoveryManager.test.js src/runtime/server.test.js src/runtime/supervisor.test.js src/runtime/delegation.test.js src/runtime/runner.test.js src/runtime/runner.e2e.test.js src/runtime/skillChain.e2e.test.js src/runtime/donna-contract.test.js src/runtime/approvals.test.js src/runtime/auth.test.js",
     "check-versions": "node scripts/check-versions.js",
     "prepack": "node scripts/check-versions.js",
     "prepublishOnly": "node scripts/check-versions.js",

package/src/core/buildInfo.json

@@ -1,4 +1,4 @@
 {
-  "version": "0.15.48",
-  "commit": "7290b94"
+  "version": "0.15.49",
+  "commit": "a0da71c"
 }

package/src/core/mcp.js

@@ -1,7 +1,7 @@
 import { existsSync, readFileSync } from 'node:fs';
 import { managerEnvFile, managerMcpEndpointsFile, readEnvFile } from './env.js';
 
-const WIKI_MANAGER_VERSION = '0.15.48';
+const WIKI_MANAGER_VERSION = '0.15.49';
 
 function envValue(key) {
   const filePath = managerEnvFile();

package/src/runtime/approvals.js

@@ -134,11 +134,23 @@ export function createApprovalManager(session, {
   function approve(request = {}) {
     const { approvalId = null, runId = null, itemId = null } = request;
     if (request.scope || request.planRevision != null || request.approvalClasses || request.approvalClass || request.taskId || request.groupId) {
+      const scope = normalizeGrantScope(request.scope);
+      // A run-scope grant must be bounded to a run. Without a runId it would
+      // read as a permanent, workspace-wide grant in `grantCoversTask` (its
+      // runId/revision/class checks all skip on null) — one bare `{scope:'run'}`
+      // could then unlock every mutating task of every run, forever. Fall back
+      // to the active run identity and refuse rather than mint an unbounded
+      // grant when there is none.
+      const effectiveRunId = request.runId ?? session._currentRunIdentity?.runId ?? null;
+      if (scope === 'run' && !effectiveRunId) {
+        return { approved: false, reason: 'run_scope_requires_runId' };
+      }
       const grant = normalizeApprovalGrant({
         ...request,
         id: request.id ?? request.approvalId ?? randomUUID(),
         workspaceId: request.workspaceId ?? request.workspace ?? session.workspace ?? null,
-        scope: normalizeGrantScope(request.scope),
+        scope,
+        runId: effectiveRunId,
         itemId: request.itemId ?? request.taskId ?? null,
         status: 'approved',
       });

package/src/runtime/approvals.test.js

@@ -0,0 +1,44 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+
+import { createApprovalManager } from './approvals.js';
+
+test('approve() refuses an unbounded run-scope grant', () => {
+  const manager = createApprovalManager({ workspace: 'docs' });
+  const result = manager.approve({ scope: 'run' });
+
+  assert.equal(result.approved, false);
+  assert.equal(result.reason, 'run_scope_requires_runId');
+});
+
+test('approve() bounds a bare run-scope grant to the active run identity', () => {
+  const manager = createApprovalManager({
+    workspace: 'docs',
+    _currentRunIdentity: { runId: 'run-1', workspace: 'docs' },
+  });
+  const result = manager.approve({ scope: 'run' });
+
+  assert.equal(result.approved, true);
+  assert.equal(result.runId, 'run-1');
+  assert.equal(result.scope, 'run');
+});
+
+test('approve() keeps an explicit runId even without a live run identity', () => {
+  const manager = createApprovalManager({ workspace: 'docs' });
+  const result = manager.approve({ scope: 'run', runId: 'run-2' });
+
+  assert.equal(result.approved, true);
+  assert.equal(result.runId, 'run-2');
+});
+
+test('approve() leaves task/tool/group grants unblocked by the run guard', () => {
+  const manager = createApprovalManager({ workspace: 'docs' });
+
+  const task = manager.approve({ scope: 'task', taskId: 'run-1:build' });
+  assert.equal(task.approved, true);
+  assert.equal(task.scope, 'task');
+
+  const group = manager.approve({ scope: 'group', groupId: 'publish' });
+  assert.equal(group.approved, true);
+  assert.equal(group.scope, 'group');
+});

package/src/runtime/server.js

@@ -541,6 +541,13 @@ export function startRuntimeServer({
         const runId = url.searchParams.get('runId') ?? body.runId ?? null;
         const purge = body.purge === true || url.searchParams.get('purge') === 'true';
         const context = await resolveContext({ workspace });
+        const resolvedWorkspace = context?.workspace ?? workspace ?? null;
+        if (purge && !runId && !resolvedWorkspace) {
+          // Purge is workspace-wide and destructive: without a scope it would
+          // wipe every workspace's history. Mirror /conversation/truncate.
+          sendJson(response, 400, { killed: false, reason: 'workspace_required' });
+          return;
+        }
         const result = await killRuntimeRuns(context, { workspace, runId, purge });
         publishState(context.workspace ?? workspace ?? null, context);
         sendJson(response, 202, result);

package/src/runtime/server.test.js

@@ -728,6 +728,57 @@ test('runtime server kill can target a specific run id', async (t) => {
   }
 });
 
+test('runtime server kill purge without workspace is refused', async (t) => {
+  let clearedArgs = null;
+  let handle;
+  try {
+    handle = await startRuntimeServer({
+      host: '127.0.0.1',
+      port: 0,
+      store: {
+        dbPath: ':memory:',
+        getState: () => ({ status: 'idle' }),
+        listEvents: () => [],
+        interruptRuns: () => 0,
+        cancelActiveTasksForInterruptedRuns: () => 0,
+        clearWorkspaceState: (args) => {
+          clearedArgs = args;
+          return { runs: 0, events: 0, queue: 0 };
+        },
+      },
+      session: {},
+      run: async () => {},
+    });
+  } catch (err) {
+    if (err?.code === 'EPERM') {
+      t.skip('network listen is not permitted in this sandbox');
+      return;
+    }
+    throw err;
+  }
+
+  try {
+    const unscoped = await fetch(`http://127.0.0.1:${handle.port}/kill`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({ purge: true }),
+    });
+    assert.equal(unscoped.status, 400);
+    assert.deepEqual(await unscoped.json(), { killed: false, reason: 'workspace_required' });
+    assert.equal(clearedArgs, null);
+
+    const scoped = await fetch(`http://127.0.0.1:${handle.port}/kill?workspace=docs`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({ purge: true }),
+    });
+    assert.equal(scoped.status, 202);
+    assert.equal(clearedArgs.workspace, 'docs');
+  } finally {
+    await handle.close();
+  }
+});
+
 test('runtime server state exposes active run identity while running', async (t) => {
   let releaseRun;
   const context = {