@dotdev/harmony-sdk 1.32.0 → 1.32.1

package/dist/helpers/index.d.ts

@@ -1,5 +1,5 @@
 import { AxiosInstance } from "axios";
-import { ApiError, RequestError } from "../errors";
+import { ApiError, HarmonyAPIError } from "../errors";
 import { ParamLimits, ServiceAlias } from "../modules";
 export * from "./utils";
 export declare abstract class ApiHelper {
@@ -26,7 +26,7 @@ export declare abstract class ApiHelper {
      * @returns {Promise<R>}
      */
     static sendServiceRequest<R>(serviceName: string, methodName: string | string[], sessionId: string, serviceAlias: ServiceAlias, axios: AxiosInstance, body?: string): Promise<R>;
-    static parseError(error: any): Promise<RequestError>;
+    static parseError(error: any): Promise<HarmonyAPIError>;
     /**
      * Extract error response from Harmony in XML format and convert it to JSON format for ease of debugging
      *

package/dist/helpers/index.js

@@ -1,7 +1,7 @@
 import axios from "axios";
 import { promisify } from "util";
 import { parseString } from "xml2js";
-import { RequestError } from "../errors";
+import { HarmonyAPIError, RequestError } from "../errors";
 import { logger } from "./logger";
 import { Utils } from "./utils";
 export * from "./utils";
@@ -98,6 +98,16 @@ export class ApiHelper {
         return response[responseMethodName][0];
     }
     static async parseError(error) {
+        // An already-parsed Harmony error (re-thrown up through a module-level
+        // catch) must pass through unchanged. Re-parsing it would hit the
+        // non-axios fallthrough below and discard its status/code, masking the
+        // real fault (e.g. a 500 "Invalid Session") behind the generic
+        // "Unexpected error" message before it reaches the caller. The first
+        // parse already logged this fault, so we deliberately don't re-log it
+        // here. [DAT-2135]
+        if (error instanceof HarmonyAPIError) {
+            return error;
+        }
         if (axios.isAxiosError(error)) {
             const status = error?.response?.status;
             const childLogger = logger.child({

package/dist/helpers/index.spec.js

@@ -1,6 +1,6 @@
 import axios from "axios";
 import { ApiHelper, checkParamLimits, TEST_HEADERS, Utils } from ".";
-import { RequestError } from "../errors";
+import { AuthenticationError, RequestError } from "../errors";
 import { ServiceAlias } from "../modules/shared/types";
 // Increase timeout due to Harmony API having long response time
 jest.setTimeout(999999);
@@ -235,6 +235,31 @@ describe("ApiHelper.parseError", () => {
         expect(result.status).toBeUndefined();
         expect(result.message).toBe("Unexpected error occurred during API request");
     });
+    it("returns an already-parsed HarmonyAPIError unchanged (no re-masking) [DAT-2135]", async () => {
+        // A module-level catch may re-parse an error that sendSoapRequest already
+        // turned into a RequestError carrying status/code. Re-parsing must NOT
+        // discard those — otherwise the real fault (e.g. a 500 "Invalid Session")
+        // is masked behind the generic "Unexpected error" message and never
+        // reaches the caller.
+        const alreadyParsed = new RequestError(`API request failed with status 500: {code: S:Server, name: Invalid Session., message: }`, { status: 500, code: "S:Server" });
+        const result = await ApiHelper.parseError(alreadyParsed);
+        expect(result).toBe(alreadyParsed);
+        expect(result.status).toBe(500);
+        expect(result.code).toBe("S:Server");
+        expect(result.message).toContain("Invalid Session.");
+    });
+    it("does not downgrade an already-parsed AuthenticationError [DAT-2135]", async () => {
+        // AuthenticationError is the other HarmonyAPIError subclass; a 401 session
+        // drop must keep its type and status, not be re-parsed into a RequestError.
+        const authErr = new AuthenticationError("Invalid Session.", {
+            status: 401,
+            code: "S:Server",
+        });
+        const result = await ApiHelper.parseError(authErr);
+        expect(result).toBe(authErr);
+        expect(result).toBeInstanceOf(AuthenticationError);
+        expect(result.status).toBe(401);
+    });
     it("preserves gift-card serial-number substring in message (backward-compat)", async () => {
         const err = makeAxiosError({
             response: { status: 400, data: GIFT_CARD_SERIAL_FAULT },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dotdev/harmony-sdk",
-  "version": "1.32.0",
+  "version": "1.32.1",
   "description": "Harmony API SDK",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",