@dooer/dooer-test-env 1.19.0 → 1.19.1

package/lib/command/env.js

@@ -5,6 +5,7 @@ const registry = require('../registry')
 const bankid = require('../bankid')
 const { generateCompose } = require('../compose/generate')
 const discovery = require('../discovery/client')
+const envSpec = require('../env-spec')
 
 // Every profile the generator emits (lib/compose/generate.js). `down` must name them all, or compose
 // silently leaves the profiled containers running.
@@ -21,11 +22,17 @@ const PROFILES = ['full', 'frontend', 'hq', 'booking']
 // found out was a bug that was already fixed. An npm install rewrites lib/, so its mtime moves ahead of a
 // compose file generated by the previous version, and a local edit to the generator does the same.
 // The compose file is a build artifact — anything hand-edited there was already lost on the next `db pull`.
+//
+// The environment spec counts as an input too. It carries the image tag of every service, so refreshing it
+// and NOT regenerating leaves the stack pinned to whatever versions it was born with — which is how the
+// local service-dooer-test-env sat at 3.1.1 while staging ran 3.2.1, and a purge failed with a foreign-key
+// error that had been fixed weeks earlier.
 function composeIsStale() {
   if (!fs.existsSync(rt.COMPOSE_FILE)) return true
   try {
-    const generator = require.resolve('../compose/generate')
-    return fs.statSync(generator).mtimeMs > fs.statSync(rt.COMPOSE_FILE).mtimeMs
+    const composedAt = fs.statSync(rt.COMPOSE_FILE).mtimeMs
+    const inputs = [require.resolve('../compose/generate'), require('../env-spec').SPEC_FILE]
+    return inputs.some((f) => fs.existsSync(f) && fs.statSync(f).mtimeMs > composedAt)
   } catch (_) {
     return false // never block `up` on a stat that failed
   }
@@ -153,6 +160,26 @@ module.exports = [
         for (const n of locals)
           console.log(`  ${n}  → host.docker.internal:${state.local[n].port}  (pid ${state.local[n].pid})`)
       }
+      // Version pins from `service deploy`. They live in docker-compose.override.yml and win over the
+      // generated compose file forever — so a pinned service silently stays behind while everything around
+      // it moves, and `up` looks like it worked. Flagged when the pin no longer matches the environment
+      // spec, because that is the case where it costs you: the local service-dooer-test-env sat on 3.1.1
+      // through a spec refresh, a regenerate and a --force-recreate, failing with a bug fixed weeks before.
+      const pins = state.deploy || {}
+      const names = Object.keys(pins)
+      if (names.length) {
+        console.log(chalk.yellow('\nPinned to a specific version (`service deploy`):'))
+        for (const n of names) {
+          const current = envSpec.imageFor(n)
+          const behind = current && current !== pins[n]
+          console.log(
+            `  ${n}  → ${pins[n]}` +
+              (behind ? chalk.yellow(`  ← the environment spec has ${current.split(':').pop()}`) : '')
+          )
+        }
+        console.log(chalk.gray('  clear a pin with: service deploy <name> <tag-from-the-spec>'))
+      }
+
       try {
         const reg = await discovery.list(rt.ROUTER_URL)
         const overrides = Object.keys((reg && reg.overrides) || {})

package/lib/copy.js

@@ -104,6 +104,9 @@ async function copyOrganization({ organizationId, sourceEnv, targetEnv, reason,
         `, ${refs.rowsInserted} inserted (the rest the target already had)`
     )
   }
+  // Places the closure could not reach. Printed even though the copy succeeded: each one is a reference
+  // that may dangle, and a limitation nobody is told about is the same as one nobody fixed.
+  for (const w of (refs && refs.warnings) || []) console.log(chalk.yellow(`  WARNING  ${w}`))
 
   // Rows whose foreign key points at a parent that did not come with them. The load runs with FK
   // enforcement off (no ordering of 336 tables satisfies every constraint), and Postgres never re-checks,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dooer/dooer-test-env",
-  "version": "1.19.0",
+  "version": "1.19.1",
   "description": "Run the whole Dooer backend locally (staging DB minus customers), copy/purge customers between environments, and shred — one CLI.",
   "license": "UNLICENSED",
   "repository": "Dooer/cli-dooer-test-env",