@dooboostore/simple-boot-http-server 1.0.32 → 1.0.34

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dooboostore/simple-boot-http-server",
-  "version": "1.0.32",
+  "version": "1.0.34",
   "license": "MIT",
   "type": "module",
   "main": "./dist/cjs/index.js",
@@ -55,16 +55,18 @@
     "SeoDH <adonis_84@naver.com> (https://github.com/SeoDH)",
     "tkyung (https://github.com/tkyungDev)",
     "Hoil-Gang (https://github.com/khl1154)",
-    "hwangsero (https://github.com/hwangsero)"
+    "hwangsero (https://github.com/hwangsero)",
+    "visualkhh <visualkhh@gmail.com> (https://github.com/visualkhh)"
   ],
-  "homepage": "https://github.com/dooboostore-develop/packages",
+  "homepage": "https://dooboostore-develop.github.io/package/simple-boot-http-server",
   "bugs": {
-    "url": "https://github.com/dooboostore-develop/packages",
+    "url": "https://github.com/dooboostore-develop/packages/issues",
     "email": "dooboostore@gmail.com"
   },
   "repository": {
     "type": "git",
-    "url": "https://github.com/dooboostore-develop/packages"
+    "url": "git+https://github.com/dooboostore-develop/packages.git",
+    "directory": "packages/@dooboostore/simple-boot-http-server"
   },
   "peerDependencies": {
     "reflect-metadata": "^0.2.2"
@@ -99,10 +101,10 @@
     "node-gzip": "^1.1.2",
     "ws": "^8.18.3",
     "@dooboostore/core": "1.0.33",
-    "@dooboostore/dom-render": "1.0.115",
-    "@dooboostore/core-node": "1.0.14",
     "@dooboostore/core-web": "1.0.14",
-    "@dooboostore/simple-boot": "1.0.60"
+    "@dooboostore/simple-boot": "1.0.60",
+    "@dooboostore/dom-render": "1.0.115",
+    "@dooboostore/core-node": "1.0.14"
   },
   "scripts": {
     "clean": "rm -rf dist",

package/src/SimpleBootHttpServer.ts

@@ -44,6 +44,27 @@ export class SimpleBootHttpServer extends SimpleApplication {
     this.sessionManager = new SessionManager(this.option);
   }
 
+  /**
+   * Final response flush that can never escape as an unhandled rejection.
+   * When the response is already gone (sent, closed, or destroyed mid-write),
+   * there is nobody left to send to, so gone-response write errors
+   * (ERR_HTTP_HEADERS_SENT, ERR_STREAM_ALREADY_FINISHED,
+   * ERR_STREAM_DESTROYED, ECONNRESET) are swallowed; anything else still throws.
+   */
+  private async safeResEnd(rr: RequestResponse): Promise<void> {
+    if (rr.resIsDone()) {
+      return;
+    }
+    try {
+      await rr.resEnd();
+    } catch (e: any) {
+      const code = e && (e.code || '');
+      if (code !== 'ERR_HTTP_HEADERS_SENT' && code !== 'ERR_STREAM_ALREADY_FINISHED' && code !== 'ERR_STREAM_DESTROYED' && code !== 'ECONNRESET') {
+        throw e;
+      }
+    }
+  }
+
 
   public run(otherInstanceSim?: Map<ConstructorType<any> | Function | SimConfig | symbol, any>) {
     otherInstanceSim ??= new Map<ConstructorType<any> | Function | SimConfig | symbol, any>();
@@ -95,7 +116,7 @@ export class SimpleBootHttpServer extends SimpleApplication {
         }
 
         if (!rr.resIsDone()) {
-          rr.resEnd();
+          await this.safeResEnd(rr);
         }
       });
       res.on('error', async () => {
@@ -113,7 +134,7 @@ export class SimpleBootHttpServer extends SimpleApplication {
         }
 
         if (!rr.resIsDone()) {
-          rr.resEnd();
+          await this.safeResEnd(rr);
         }
       });
 
@@ -390,7 +411,10 @@ export class SimpleBootHttpServer extends SimpleApplication {
         console.error('request error:', e);
         transactionManager?.catch(e);
         rr.resStatusCode(e instanceof HttpError ? e.status : HttpStatus.InternalServerError)
-        const execute = typeof this.option.globalAdvice === 'function' ? this.simstanceManager.getOrNewSim(this.option.globalAdvice) : this.option.globalAdvice;
+        const globalAdvice = this.option.globalAdvice;
+        // getOrNewSim takes { target }; passing the class directly
+        // destructures to undefined and silently disables globalAdvice.
+        const execute = typeof globalAdvice === 'function' ? this.simstanceManager.getOrNewSim({ target: globalAdvice }) : globalAdvice;
         if (!execute) {
           rr.resEnd();
           // rr.resEnd().catch(e => {
@@ -416,7 +440,7 @@ export class SimpleBootHttpServer extends SimpleApplication {
       }
 
       if (!rr.resIsDone()) {
-        rr.resEnd();
+        await this.safeResEnd(rr);
       }
     });
 

package/src/decorators/MethodMapping.ts

@@ -69,6 +69,7 @@ export function GET(configOrTarget?: Omit<MappingConfig, 'method'> | any, proper
     process({ method: HttpMethod.GET }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.GET;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -88,6 +89,7 @@ export function POST(configOrTarget?: Omit<MappingConfig, 'method'> | any, prope
     process({ method: HttpMethod.POST }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.POST;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -107,6 +109,7 @@ export function DELETE(configOrTarget?: Omit<MappingConfig, 'method'> | any, pro
     process({ method: HttpMethod.DELETE }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.DELETE;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -126,6 +129,7 @@ export function PUT(configOrTarget?: Omit<MappingConfig, 'method'> | any, proper
     process({ method: HttpMethod.PUT }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.PUT;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -145,6 +149,7 @@ export function PATCH(configOrTarget?: Omit<MappingConfig, 'method'> | any, prop
     process({ method: HttpMethod.PATCH }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.PATCH;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -164,6 +169,7 @@ export function OPTIONS(configOrTarget?: Omit<MappingConfig, 'method'> | any, pr
     process({ method: HttpMethod.OPTIONS }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.OPTIONS;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -183,6 +189,7 @@ export function HEAD(configOrTarget?: Omit<MappingConfig, 'method'> | any, prope
     process({ method: HttpMethod.HEAD }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.HEAD;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -202,6 +209,7 @@ export function TRACE(configOrTarget?: Omit<MappingConfig, 'method'> | any, prop
     process({ method: HttpMethod.TRACE }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.TRACE;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -221,6 +229,7 @@ export function CONNECT(configOrTarget?: Omit<MappingConfig, 'method'> | any, pr
     process({ method: HttpMethod.CONNECT }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.CONNECT;
       process(configOrTarget, target, propertyKey, descriptor);
     };