@dooboostore/simple-boot-http-server 1.0.31 → 1.0.33

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dooboostore/simple-boot-http-server",
-  "version": "1.0.31",
+  "version": "1.0.33",
   "license": "MIT",
   "type": "module",
   "main": "./dist/cjs/index.js",
@@ -101,8 +101,8 @@
     "@dooboostore/core": "1.0.33",
     "@dooboostore/dom-render": "1.0.115",
     "@dooboostore/core-node": "1.0.14",
-    "@dooboostore/simple-boot": "1.0.59",
-    "@dooboostore/core-web": "1.0.14"
+    "@dooboostore/core-web": "1.0.14",
+    "@dooboostore/simple-boot": "1.0.60"
   },
   "scripts": {
     "clean": "rm -rf dist",

package/src/SimpleBootHttpServer.ts

@@ -390,7 +390,10 @@ export class SimpleBootHttpServer extends SimpleApplication {
         console.error('request error:', e);
         transactionManager?.catch(e);
         rr.resStatusCode(e instanceof HttpError ? e.status : HttpStatus.InternalServerError)
-        const execute = typeof this.option.globalAdvice === 'function' ? this.simstanceManager.getOrNewSim(this.option.globalAdvice) : this.option.globalAdvice;
+        const globalAdvice = this.option.globalAdvice;
+        // getOrNewSim takes { target }; passing the class directly
+        // destructures to undefined and silently disables globalAdvice.
+        const execute = typeof globalAdvice === 'function' ? this.simstanceManager.getOrNewSim({ target: globalAdvice }) : globalAdvice;
         if (!execute) {
           rr.resEnd();
           // rr.resEnd().catch(e => {

package/src/decorators/MethodMapping.ts

@@ -69,6 +69,7 @@ export function GET(configOrTarget?: Omit<MappingConfig, 'method'> | any, proper
     process({ method: HttpMethod.GET }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.GET;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -88,6 +89,7 @@ export function POST(configOrTarget?: Omit<MappingConfig, 'method'> | any, prope
     process({ method: HttpMethod.POST }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.POST;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -107,6 +109,7 @@ export function DELETE(configOrTarget?: Omit<MappingConfig, 'method'> | any, pro
     process({ method: HttpMethod.DELETE }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.DELETE;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -126,6 +129,7 @@ export function PUT(configOrTarget?: Omit<MappingConfig, 'method'> | any, proper
     process({ method: HttpMethod.PUT }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.PUT;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -145,6 +149,7 @@ export function PATCH(configOrTarget?: Omit<MappingConfig, 'method'> | any, prop
     process({ method: HttpMethod.PATCH }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.PATCH;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -164,6 +169,7 @@ export function OPTIONS(configOrTarget?: Omit<MappingConfig, 'method'> | any, pr
     process({ method: HttpMethod.OPTIONS }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.OPTIONS;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -183,6 +189,7 @@ export function HEAD(configOrTarget?: Omit<MappingConfig, 'method'> | any, prope
     process({ method: HttpMethod.HEAD }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.HEAD;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -202,6 +209,7 @@ export function TRACE(configOrTarget?: Omit<MappingConfig, 'method'> | any, prop
     process({ method: HttpMethod.TRACE }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.TRACE;
       process(configOrTarget, target, propertyKey, descriptor);
     };
@@ -221,6 +229,7 @@ export function CONNECT(configOrTarget?: Omit<MappingConfig, 'method'> | any, pr
     process({ method: HttpMethod.CONNECT }, configOrTarget, propertyKey, descriptor);
   } else {
     return (target: any, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
+      configOrTarget = configOrTarget ?? {};
       configOrTarget.method = HttpMethod.CONNECT;
       process(configOrTarget, target, propertyKey, descriptor);
     };

package/src/models/RequestResponse.ts

@@ -22,6 +22,7 @@ import { FileUtils } from '@dooboostore/core-node';
 import { ConvertUtils as CoreConvertUtils } from '@dooboostore/core';
 import { ConvertUtils } from '@dooboostore/core-node';
 import {HttpMethod} from "../codes";
+import { BadRequestError } from '../errors/BadRequestError';
 
 type Config = { sessionManager?: SessionManager; option: HttpServerOption };
 
@@ -346,7 +347,14 @@ export class RequestResponse {
   }
 
   async reqBodyJsonData<T>(): Promise<T> {
-    return JSON.parse(await this.reqBodyStringData());
+    const raw = await this.reqBodyStringData();
+    try {
+      return JSON.parse(raw);
+    } catch (e: any) {
+      // Malformed JSON is a client error (400), not a server crash (500).
+      // Express-compatible: surface the parse failure as Bad Request.
+      throw new BadRequestError({ message: `Invalid JSON body: ${e?.message ?? e}` });
+    }
   }
 
   async reqBodyFormUrlData<T>(): Promise<T> {
@@ -372,7 +380,15 @@ export class RequestResponse {
 
   async reqBodyReqJsonBody(): Promise<ReqJsonBody> {
     const data = await this.reqBodyStringData();
-    return Object.assign(new ReqJsonBody(), data ? JSON.parse(data) : {});
+    if (!data) {
+      return Object.assign(new ReqJsonBody(), {});
+    }
+    try {
+      return Object.assign(new ReqJsonBody(), JSON.parse(data));
+    } catch (e: any) {
+      // Malformed JSON is a client error (400), not a server crash (500).
+      throw new BadRequestError({ message: `Invalid JSON body: ${e?.message ?? e}` });
+    }
   }
 
   resBodyJsonData<T>(): T | null {

package/src/option/HttpServerOption.ts

@@ -8,6 +8,7 @@ import { RequestResponse } from '../models/RequestResponse';
 import { SimpleBootHttpServer } from '../SimpleBootHttpServer';
 import { TransactionManager } from '@dooboostore/core';
 import { WebSocketEndPoint } from '../endpoints/WebSocketEndPoint';
+import { NotFoundError } from '../errors/NotFoundError';
 
 export type Listen = { port?: number, hostname?: string, backlog?: number, listeningListener?: (server: SimpleBootHttpServer, httpServer: HttpServer | HttpsServer) => void };
 
@@ -107,7 +108,13 @@ export class HttpServerOption extends SimOption {
     );
     this.globalAdvice = globalAdvice;
     this.fileUploadTempPath = fileUploadTempPath;
-    this.noSuchRouteEndPointMappingThrow = noSuchRouteEndPointMappingThrow;
+    // Unmatched routes must not fall through to "200 OK with empty body"
+    // like before. Default to 404 (Express-compatible); users can still
+    // override with their own noSuchRouteEndPointMappingThrow.
+    this.noSuchRouteEndPointMappingThrow =
+      noSuchRouteEndPointMappingThrow ??
+      ((rr: RequestResponse) =>
+        new NotFoundError({ message: `no route ${rr.reqMethod?.() ?? ''} ${rr.reqUrlPathName ?? ''}`.trim() }));
     this.transactionManagerFactory = transactionManagerFactory;
   }