@donkeylabs/mcp 0.4.6 → 0.4.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@donkeylabs/mcp",
-  "version": "0.4.6",
+  "version": "0.4.7",
   "description": "MCP server for AI-assisted development with @donkeylabs/server",
   "type": "module",
   "main": "./src/server.ts",

package/src/server.ts

@@ -516,6 +516,66 @@ async function generateProjectAnalysis(): Promise<string> {
     analysis += `- Not generated yet. Run \`donkeylabs generate\` after adding plugins/routes.\n`;
   }
 
+  // Generated API Client
+  const clientPath = projectConfig.clientOutput || (projectConfig.adapter === "sveltekit" ? "src/lib/api.ts" : null);
+  if (clientPath) {
+    const fullClientPath = join(projectRoot, clientPath);
+    analysis += `\n## Generated API Client\n`;
+    if (existsSync(fullClientPath)) {
+      analysis += `- Path: ${clientPath}\n`;
+
+      // Extract available methods from the client
+      const clientContent = readFileSync(fullClientPath, "utf-8");
+
+      // Find namespace properties (e.g., "health = {" or "users = {")
+      const namespaceMatches = [...clientContent.matchAll(/^\s+(\w+)\s*=\s*\{/gm)];
+      const namespaces: string[] = [];
+      for (const match of namespaceMatches) {
+        if (match[1] && !["sse", "constructor"].includes(match[1])) {
+          namespaces.push(match[1]);
+        }
+      }
+
+      if (namespaces.length > 0) {
+        analysis += `- Available namespaces: ${namespaces.join(", ")}\n`;
+      }
+
+      // Extract route type namespaces from "export namespace Routes {"
+      const routeTypesMatch = clientContent.match(/export namespace Routes \{([^}]+(?:\{[^}]*\}[^}]*)*)\}/s);
+      if (routeTypesMatch) {
+        const typeNamespaces = [...routeTypesMatch[1].matchAll(/export namespace (\w+)/g)].map(m => m[1]);
+        if (typeNamespaces.length > 0) {
+          analysis += `- Route types: Routes.${typeNamespaces.join(", Routes.")}\n`;
+        }
+      }
+
+      // SvelteKit-specific usage
+      if (projectConfig.adapter === "sveltekit") {
+        const importPath = clientPath.startsWith("src/lib/") ? "$lib/" + clientPath.slice(8).replace(/\.ts$/, "") : clientPath.replace(/\.ts$/, "");
+        analysis += `\n### Usage in SvelteKit\n`;
+        analysis += `\`\`\`typescript\n`;
+        analysis += `// +page.server.ts (SSR - direct calls, no HTTP)\n`;
+        analysis += `import { createApi } from '${importPath}';\n`;
+        analysis += `export const load = async ({ locals }) => {\n`;
+        analysis += `  const api = createApi({ locals });\n`;
+        analysis += `  const data = await api.${namespaces[0] || "namespace"}.methodName({});\n`;
+        analysis += `  return { data };\n`;
+        analysis += `};\n`;
+        analysis += `\`\`\`\n`;
+        analysis += `\n\`\`\`svelte\n`;
+        analysis += `<!-- +page.svelte (Browser - HTTP calls) -->\n`;
+        analysis += `<script>\n`;
+        analysis += `  import { createApi } from '${importPath}';\n`;
+        analysis += `  const api = createApi();\n`;
+        analysis += `</script>\n`;
+        analysis += `\`\`\`\n`;
+      }
+    } else {
+      analysis += `- Path: ${clientPath} (not generated yet)\n`;
+      analysis += `- Run \`donkeylabs generate\` to create the client\n`;
+    }
+  }
+
   return analysis;
 }
 
@@ -1098,6 +1158,48 @@ async function getArchitectureGuidance(args: { task: string }): Promise<string>
     guidance += `- **Browser:** HTTP calls automatically\n`;
   }
 
+  // Common mistakes section
+  guidance += `\n## ⚠️ Common Mistakes to Avoid\n\n`;
+
+  guidance += `### Database Queries\n`;
+  guidance += `- ❌ **NEVER use raw SQL** - always use Kysely query builder\n`;
+  guidance += `- ❌ \`db.execute(sql\\\`SELECT * FROM users\\\`)\` - WRONG\n`;
+  guidance += `- ✅ \`db.selectFrom("users").selectAll().execute()\` - CORRECT\n\n`;
+
+  guidance += `### After Making Changes\n`;
+  guidance += `- ❌ Forgetting to run \`generate_types\` after adding migrations\n`;
+  guidance += `- ❌ Forgetting to run \`generate_client\` after adding routes\n`;
+  guidance += `- ✅ Always regenerate types after schema/route changes\n\n`;
+
+  guidance += `### Plugin Registration\n`;
+  guidance += `- ❌ Creating a plugin but not registering it with \`server.registerPlugin()\`\n`;
+  guidance += `- ❌ Creating routes but not adding router with \`server.use()\`\n`;
+  guidance += `- ✅ Check server entry file to ensure plugin/router is registered\n\n`;
+
+  if (projectConfig.adapter === "sveltekit") {
+    guidance += `### SvelteKit-Specific\n`;
+    guidance += `- ❌ \`createApi()\` in +page.server.ts - WRONG (won't use direct calls)\n`;
+    guidance += `- ✅ \`createApi({ locals })\` in +page.server.ts - CORRECT\n`;
+    guidance += `- ❌ Importing from relative path instead of \`$lib/api\`\n`;
+    guidance += `- ✅ \`import { createApi } from '$lib/api'\`\n\n`;
+  }
+
+  guidance += `### Route Handlers\n`;
+  guidance += `- ❌ Putting business logic directly in route handlers\n`;
+  guidance += `- ✅ Delegate to plugin service methods, keep routes thin\n`;
+  guidance += `- ❌ Returning raw data without proper typing\n`;
+  guidance += `- ✅ Define output schema with Zod for type safety\n\n`;
+
+  guidance += `## 🛑 When to Stop and Ask the User\n\n`;
+  guidance += `**IMPORTANT:** If you're unsure about any of the following, STOP and ask the user before proceeding:\n\n`;
+  guidance += `- **Architecture decisions** - "Should this be a plugin or just a route?"\n`;
+  guidance += `- **Database schema design** - "What columns/relations do you need?"\n`;
+  guidance += `- **Naming conventions** - "What should this entity/route be called?"\n`;
+  guidance += `- **Business logic** - "How should this calculation/validation work?"\n`;
+  guidance += `- **Integration patterns** - "How does this connect to existing code?"\n`;
+  guidance += `- **Something doesn't work** - Don't keep trying different things, ask for help\n\n`;
+  guidance += `It's better to ask ONE clarifying question than to build something wrong and have to redo it.\n\n`;
+
   guidance += `\n## Documentation Resources\n`;
   guidance += `- \`donkeylabs://docs/database\` - Kysely queries, CRUD, joins, transactions\n`;
   guidance += `- \`donkeylabs://docs/plugins\` - Plugin patterns & When to Create a Plugin vs Route\n`;
@@ -1303,6 +1405,11 @@ ${registrationExample}
 // In your route handler:
 const result = ctx.plugins.${name}.hello();
 \`\`\`
+
+### ⚠️ Reminders
+- **Don't forget** to register the plugin in your server entry file
+- **Use Kysely** for all database queries, never raw SQL
+- **Ask the user** if you're unsure about the schema design or business logic
 `;
 }
 
@@ -1454,6 +1561,11 @@ export const ${pluginName}Plugin = createPlugin
 \`\`\`
 
 The migration will run automatically on server start.
+
+### ⚠️ Reminders
+- **Use Kysely schema builder** - never raw SQL in migrations
+- **Ask the user** if unsure about column types, relations, or schema design
+- **Test migrations** by running the server and checking for errors
 `;
 }
 
@@ -1532,6 +1644,11 @@ Routes added to this router will be named \`${prefix}.<routeName>\`:
 - ${prefix}.list
 - ${prefix}.get
 - ${prefix}.create
+
+### ⚠️ Reminders
+- **Don't forget** to register the router with \`server.use()\` in your server entry
+- **Run \`generate_client\`** after adding routes to update the typed client
+- **Keep routes thin** - delegate business logic to plugin service methods
 `;
 }
 
@@ -1679,8 +1796,14 @@ ${outputType ? `\n**Output:** ${outputType}` : ""}
 ### Next Steps
 
 1. ${useClassHandler ? "Implement the handler logic in the handler file" : "The route is ready to use"}
-2. Run \`donkeylabs generate\` to update types
+2. Run \`donkeylabs generate\` to update types and regenerate the API client
 3. Test the route
+
+### ⚠️ Reminders
+- **Run \`generate_client\`** to update the typed API client after adding routes
+- **Keep handler thin** - call plugin service methods for business logic
+- **Use Kysely** for database queries in your service methods, never raw SQL
+${projectConfig.adapter === "sveltekit" ? "- **SvelteKit:** Use \\`createApi({ locals })\\` in +page.server.ts for direct calls" : ""}
 `;
 }