@dongdev/fca-unofficial 3.0.7 → 3.0.9

package/CHANGELOG.md

@@ -149,3 +149,9 @@ Too lazy to write changelog, sorry! (will write changelog in the next release, t
 
 ## v3.0.6 - 2025-11-27
 - Hotfix / auto bump
+
+## v3.0.7 - 2025-11-27
+- Hotfix / auto bump
+
+## v3.0.8 - 2025-11-27
+- Hotfix / auto bump

package/module/login.js

@@ -3,10 +3,77 @@ const { setOptions } = require("./options");
 const { loadConfig } = require("./config");
 const { checkAndUpdateVersion } = require("../func/checkUpdate");
 const loginHelper = require("./loginHelper");
+const logger = require("../func/logger");
 
 const { config } = loadConfig();
 global.fca = { config };
 
+// Global error handlers to prevent bot crashes
+// Handle unhandled promise rejections (e.g., fetch timeouts, network errors)
+if (!global.fca._errorHandlersInstalled) {
+  global.fca._errorHandlersInstalled = true;
+
+  process.on("unhandledRejection", (reason, promise) => {
+    try {
+      // Check if it's a fetch/network timeout error
+      if (reason && typeof reason === "object") {
+        const errorCode = reason.code || reason.cause?.code;
+        const errorMessage = reason.message || String(reason);
+
+        // Handle fetch timeout errors gracefully
+        if (errorCode === "UND_ERR_CONNECT_TIMEOUT" ||
+            errorCode === "ETIMEDOUT" ||
+            errorMessage.includes("Connect Timeout") ||
+            errorMessage.includes("fetch failed")) {
+          logger(`Network timeout error caught (non-fatal): ${errorMessage}`, "warn");
+          return; // Don't crash, just log
+        }
+
+        // Handle other network errors
+        if (errorCode === "ECONNREFUSED" ||
+            errorCode === "ENOTFOUND" ||
+            errorCode === "ECONNRESET" ||
+            errorMessage.includes("ECONNREFUSED") ||
+            errorMessage.includes("ENOTFOUND")) {
+          logger(`Network connection error caught (non-fatal): ${errorMessage}`, "warn");
+          return; // Don't crash, just log
+        }
+      }
+
+      // For other unhandled rejections, log but don't crash
+      logger(`Unhandled promise rejection (non-fatal): ${reason && reason.message ? reason.message : String(reason)}`, "error");
+    } catch (e) {
+      // Fallback if logger fails
+      console.error("[FCA-ERROR] Unhandled promise rejection:", reason);
+    }
+  });
+
+  // Handle uncaught exceptions (last resort)
+  process.on("uncaughtException", (error) => {
+    try {
+      const errorMessage = error.message || String(error);
+      const errorCode = error.code;
+
+      // Handle fetch/network errors
+      if (errorCode === "UND_ERR_CONNECT_TIMEOUT" ||
+          errorCode === "ETIMEDOUT" ||
+          errorMessage.includes("Connect Timeout") ||
+          errorMessage.includes("fetch failed")) {
+        logger(`Uncaught network timeout error (non-fatal): ${errorMessage}`, "warn");
+        return; // Don't crash
+      }
+
+      // For other uncaught exceptions, log but try to continue
+      logger(`Uncaught exception (attempting to continue): ${errorMessage}`, "error");
+      // Note: We don't exit here to allow bot to continue running
+      // In production, you might want to restart the process instead
+    } catch (e) {
+      // Fallback if logger fails
+      console.error("[FCA-ERROR] Uncaught exception:", error);
+    }
+  });
+}
+
 function login(loginData, options, callback) {
   if (getType(options) === "Function" || getType(options) === "AsyncFunction") {
     callback = options;

package/module/loginHelper.js

@@ -465,7 +465,7 @@ async function hydrateJarFromDB(userID) {
   }
 }
 
-async function tryAutoLoginIfNeeded(currentHtml, currentCookies, globalOptions, ctxRef) {
+async function tryAutoLoginIfNeeded(currentHtml, currentCookies, globalOptions, ctxRef, hadAppStateInput = false) {
   const getUID = cs =>
     cs.find(c => c.key === "i_user")?.value ||
     cs.find(c => c.key === "c_user")?.value ||
@@ -473,6 +473,15 @@ async function tryAutoLoginIfNeeded(currentHtml, currentCookies, globalOptions,
     cs.find(c => c.name === "c_user")?.value;
   let userID = getUID(currentCookies);
   if (userID) return { html: currentHtml, cookies: currentCookies, userID };
+  // If appState/Cookie was provided and is not dead (not checkpointed), skip backup
+  if (hadAppStateInput) {
+    const isCheckpoint = currentHtml.includes("/checkpoint/block/?next");
+    if (!isCheckpoint) {
+      // AppState provided and not checkpointed, skip backup - just throw error
+      throw new Error("Missing user cookie from provided appState");
+    }
+    // AppState is dead (checkpointed), proceed to backup/email login
+  }
   const hydrated = await hydrateJarFromDB(null);
   if (hydrated) {
     logger("AppState backup live — proceeding to login", "info");
@@ -679,7 +688,8 @@ function loginHelper(appState, Cookie, email, password, globalOptions, callback)
           cookies.find(c => c.name === "i_user")?.value ||
           cookies.find(c => c.name === "c_user")?.value;
         if (!userID) {
-          const retried = await tryAutoLoginIfNeeded(html, cookies, globalOptions, ctx);
+          // Pass skipBackup=true if appState/Cookie was originally provided
+          const retried = await tryAutoLoginIfNeeded(html, cookies, globalOptions, ctx, !!(appState || Cookie));
           html = retried.html;
           cookies = retried.cookies;
           userID = retried.userID;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dongdev/fca-unofficial",
-  "version": "3.0.7",
+  "version": "3.0.9",
   "description": "Unofficial Facebook Chat API for Node.js - Interact with Facebook Messenger programmatically",
   "main": "index.js",
   "types": "index.d.ts",

package/src/api/threads/getThreadList.js

@@ -226,14 +226,59 @@ module.exports = function(defaultFuncs, api, ctx) {
       .post("https://www.facebook.com/api/graphqlbatch/", ctx.jar, form)
       .then(parseAndCheckLogin(ctx, defaultFuncs))
       .then(resData => {
-        if (resData[resData.length - 1].error_results > 0)
-          throw resData[0].o0.errors;
-        if (resData[resData.length - 1].successful_results === 0)
+        // Validate resData is an array and has elements
+        if (!resData || !Array.isArray(resData) || resData.length === 0) {
+          throw {
+            error: "getThreadList: Invalid response data - resData is not a valid array",
+            res: resData
+          };
+        }
+
+        // Validate last element exists and has required properties
+        const lastElement = resData[resData.length - 1];
+        if (!lastElement || typeof lastElement !== "object") {
+          throw {
+            error: "getThreadList: Invalid response data - last element is missing or invalid",
+            res: resData
+          };
+        }
+
+        if (lastElement.error_results > 0) {
+          // Check if first element and o0 exist before accessing errors
+          if (resData[0] && resData[0].o0 && resData[0].o0.errors) {
+            throw resData[0].o0.errors;
+          } else {
+            throw {
+              error: "getThreadList: Error results > 0 but error details not available",
+              res: resData
+            };
+          }
+        }
+
+        if (lastElement.successful_results === 0) {
           throw {
             error: "getThreadList: there was no successful_results",
             res: resData
           };
-        if (timestamp) resData[0].o0.data.viewer.message_threads.nodes.shift();
+        }
+
+        // Validate first element and nested data structure
+        if (!resData[0] || !resData[0].o0 || !resData[0].o0.data ||
+            !resData[0].o0.data.viewer || !resData[0].o0.data.viewer.message_threads ||
+            !Array.isArray(resData[0].o0.data.viewer.message_threads.nodes)) {
+          throw {
+            error: "getThreadList: Invalid response data structure - missing required fields",
+            res: resData
+          };
+        }
+
+        if (timestamp) {
+          const nodes = resData[0].o0.data.viewer.message_threads.nodes;
+          if (Array.isArray(nodes) && nodes.length > 0) {
+            nodes.shift();
+          }
+        }
+
         callback(
           null,
           formatThreadList(resData[0].o0.data.viewer.message_threads.nodes)