@dongdev/fca-unofficial 2.0.7 → 2.0.10

package/src/api/messaging/sendMessage.js

@@ -1,9 +1,6 @@
-"use strict";
-
 const fs = require("fs");
 const path = require("path");
 const { Readable } = require("stream");
-const utils = require("../../utils");
 const log = require("npmlog");
 const allowedProperties = {
   attachment: true,
@@ -16,38 +13,27 @@ const allowedProperties = {
   location: true,
   asPage: true
 };
+const { isReadableStream } = require("../../utils/constants");
+const { parseAndCheckLogin } = require("../../utils/client");
+const { getType, generateThreadingID, generateTimestampRelative, generateOfflineThreadingID, getSignatureID } = require("../../utils/format");
+
 module.exports = function (defaultFuncs, api, ctx) {
   function toReadable(input) {
-    if (utils.isReadableStream(input)) return input;
+    if (isReadableStream(input)) return input;
     if (Buffer.isBuffer(input)) return Readable.from(input);
     if (typeof input === "string" && fs.existsSync(input) && fs.statSync(input).isFile()) return fs.createReadStream(path.resolve(input));
     throw { error: "Unsupported attachment input. Use stream/buffer/filepath." };
   }
-  function normalizeAttachments(list) {
-    if (!Array.isArray(list)) list = [list];
-    return list.map(a => {
-      if (Array.isArray(a) && /_id$/.test(a[0])) return a;
-      if (a && typeof a === "object") {
-        if (a.id && a.type && /_id$/.test(a.type)) return [a.type, a.id];
-        if (a.image_id || a.file_id || a.video_id || a.audio_id || a.gif_id) {
-          const k = Object.keys(a).find(x => /_id$/.test(x));
-          return [k, a[k]];
-        }
-      }
-      return toReadable(a);
-    });
-  }
+
   function uploadAttachment(attachments, callback) {
     const uploads = [];
     for (let i = 0; i < attachments.length; i++) {
-      if (!utils.isReadableStream(attachments[i])) {
-        throw { error: "Attachment should be a readable stream and not " + utils.getType(attachments[i]) + "." };
-      }
+      if (!isReadableStream(attachments[i])) throw { error: "Attachment should be a readable stream and not " + getType(attachments[i]) + "." };
       const form = { upload_1024: attachments[i], voice_clip: "true" };
       uploads.push(
         defaultFuncs
           .postFormData("https://upload.facebook.com/ajax/mercury/upload.php", ctx.jar, form, {}, {})
-          .then(utils.parseAndCheckLogin(ctx, defaultFuncs))
+          .then(parseAndCheckLogin(ctx, defaultFuncs))
           .then(resData => {
             if (resData.error) throw resData;
             return resData.payload.metadata[0];
@@ -61,11 +47,12 @@ module.exports = function (defaultFuncs, api, ctx) {
         callback(err);
       });
   }
+
   function getUrl(url, callback) {
     const form = { image_height: 960, image_width: 960, uri: url };
     defaultFuncs
       .post("https://www.facebook.com/message_share_attachment/fromURI/", ctx.jar, form)
-      .then(utils.parseAndCheckLogin(ctx, defaultFuncs))
+      .then(parseAndCheckLogin(ctx, defaultFuncs))
       .then(resData => {
         if (resData.error) return callback(resData);
         if (!resData.payload) return callback({ error: "Invalid url" });
@@ -76,12 +63,16 @@ module.exports = function (defaultFuncs, api, ctx) {
         callback(err);
       });
   }
-  function sleep(ms) { return new Promise(r => setTimeout(r, ms)); }
+
+  function sleep(ms) {
+    return new Promise(r => setTimeout(r, ms));
+  }
+
   async function postWithRetry(url, jar, form, tries = 3) {
     let lastErr;
     for (let i = 0; i < tries; i++) {
       try {
-        const res = await defaultFuncs.post(url, jar, form).then(utils.parseAndCheckLogin(ctx, defaultFuncs));
+        const res = await defaultFuncs.post(url, jar, form).then(parseAndCheckLogin(ctx, defaultFuncs));
         if (res && !res.error) return res;
         lastErr = res;
         if (res && (res.error === 1545003 || res.error === 368)) await sleep(500 * (i + 1));
@@ -93,6 +84,7 @@ module.exports = function (defaultFuncs, api, ctx) {
     }
     throw lastErr || { error: "Send failed" };
   }
+
   function applyPageAuthor(form, msg) {
     const pageID = msg && msg.asPage ? msg.asPage : ctx.globalOptions.pageID;
     if (!pageID) return;
@@ -105,9 +97,16 @@ module.exports = function (defaultFuncs, api, ctx) {
     form["request_user_id"] = pageID;
     form["creator_info[profileURI]"] = "https://www.facebook.com/profile.php?id=" + ctx.userID;
   }
+
   function applyMentions(msg, form) {
     if (!msg.mentions || !msg.mentions.length) return;
-    const body = typeof msg.body === "string" ? msg.body : "";
+    let body = typeof msg.body === "string" ? msg.body : "";
+    const need = [];
+    for (const m of msg.mentions) {
+      const tag = String(m.tag || "");
+      if (tag && !body.includes(tag)) need.push(tag);
+    }
+    if (need.length) body = (body ? body + " " : "") + need.join(" ");
     const emptyChar = "\u200E";
     form["body"] = emptyChar + body;
     let searchFrom = 0;
@@ -122,16 +121,35 @@ module.exports = function (defaultFuncs, api, ctx) {
       searchFrom = off + tag.length;
     });
   }
+
   function finalizeHasAttachment(form) {
     const keys = ["image_ids", "gif_ids", "file_ids", "video_ids", "audio_ids", "sticker_id", "shareable_attachment[share_params]"];
     form.has_attachment = keys.some(k => k in form && (Array.isArray(form[k]) ? form[k].length > 0 : !!form[k]));
   }
+
+  function extractMessageInfo(resData, fallbackThreadID) {
+    let messageID = null;
+    let threadFBID = null;
+    let timestamp = null;
+    const actions = resData && resData.payload && Array.isArray(resData.payload.actions) ? resData.payload.actions : null;
+    if (actions && actions.length) {
+      const v = actions.find(x => x && x.message_id) || actions[0];
+      messageID = v && v.message_id ? v.message_id : null;
+      threadFBID = (v && (v.thread_fbid || v.thread_id)) || fallbackThreadID || null;
+      timestamp = v && v.timestamp ? v.timestamp : null;
+    }
+    if (!messageID) messageID = (resData && resData.payload && resData.payload.message_id) || resData.message_id || null;
+    if (!threadFBID) threadFBID = (resData && resData.payload && resData.payload.thread_id) || fallbackThreadID || null;
+    if (!timestamp) timestamp = (resData && resData.timestamp) || Date.now();
+    if (!messageID) return null;
+    return { threadID: threadFBID, messageID, timestamp };
+  }
+
   function sendContent(form, threadID, isSingleUser, messageAndOTID, callback) {
-    if (utils.getType(threadID) === "Array") {
+    if (getType(threadID) === "Array") {
       for (let i = 0; i < threadID.length; i++) form["specific_to_list[" + i + "]"] = "fbid:" + threadID[i];
       form["specific_to_list[" + threadID.length + "]"] = "fbid:" + ctx.userID;
       form["client_thread_id"] = "root:" + messageAndOTID;
-      log.verbose("sendMessage", "Sending message to multiple users: " + threadID);
     } else {
       if (isSingleUser) {
         form["specific_to_list[0]"] = "fbid:" + threadID;
@@ -149,25 +167,23 @@ module.exports = function (defaultFuncs, api, ctx) {
           else log.error("sendMessage", resData);
           return callback(resData);
         }
-        let messageInfo = null;
-        if (resData.payload && Array.isArray(resData.payload.actions)) {
-          for (const v of resData.payload.actions) {
-            if (v && v.message_id) messageInfo = { threadID: v.thread_fbid, messageID: v.message_id, timestamp: v.timestamp };
-          }
-        }
-        callback(null, messageInfo);
+        const info = extractMessageInfo(resData, getType(threadID) === "Array" ? null : String(threadID));
+        if (!info) return callback({ error: "Cannot parse message info." });
+        callback(null, info);
       })
       .catch(err => {
         log.error("sendMessage", err);
-        if (utils.getType(err) === "Object" && err.error === "Not logged in.") ctx.loggedIn = false;
+        if (getType(err) === "Object" && err.error === "Not logged in.") ctx.loggedIn = false;
         callback(err);
       });
   }
+
   function send(form, threadID, messageAndOTID, callback, isGroup) {
-    if (utils.getType(threadID) === "Array") return sendContent(form, threadID, false, messageAndOTID, callback);
-    if (utils.getType(isGroup) !== "Boolean") return sendContent(form, threadID, String(threadID).length === 15, messageAndOTID, callback);
+    if (getType(threadID) === "Array") return sendContent(form, threadID, false, messageAndOTID, callback);
+    if (getType(isGroup) !== "Boolean") return sendContent(form, threadID, String(threadID).length === 15, messageAndOTID, callback);
     return sendContent(form, threadID, !isGroup, messageAndOTID, callback);
   }
+
   function handleUrl(msg, form, callback, cb) {
     if (msg.url) {
       form["shareable_attachment[share_type]"] = "100";
@@ -178,6 +194,7 @@ module.exports = function (defaultFuncs, api, ctx) {
       });
     } else cb();
   }
+
   function handleLocation(msg, form, callback, cb) {
     if (msg.location) {
       if (msg.location.latitude == null || msg.location.longitude == null) return callback({ error: "location property needs both latitude and longitude" });
@@ -187,10 +204,12 @@ module.exports = function (defaultFuncs, api, ctx) {
     }
     cb();
   }
+
   function handleSticker(msg, form, callback, cb) {
     if (msg.sticker) form["sticker_id"] = msg.sticker;
     cb();
   }
+
   function handleEmoji(msg, form, callback, cb) {
     if (msg.emojiSize != null && msg.emoji == null) return callback({ error: "emoji property is empty" });
     if (msg.emoji) {
@@ -202,6 +221,32 @@ module.exports = function (defaultFuncs, api, ctx) {
     }
     cb();
   }
+
+  function splitAttachments(list) {
+    if (!Array.isArray(list)) list = [list];
+    const ids = [];
+    const streams = [];
+    for (const a of list) {
+      if (Array.isArray(a) && /_id$/.test(a[0])) {
+        ids.push([a[0], String(a[1])]);
+        continue;
+      }
+      if (a && typeof a === "object") {
+        if (a.id && a.type && /_id$/.test(a.type)) {
+          ids.push([a.type, String(a.id)]);
+          continue;
+        }
+        const k = Object.keys(a || {}).find(x => /_id$/.test(x));
+        if (k) {
+          ids.push([k, String(a[k])]);
+          continue;
+        }
+      }
+      streams.push(toReadable(a));
+    }
+    return { ids, streams };
+  }
+
   function handleAttachment(msg, form, callback, cb) {
     if (!msg.attachment) return cb();
     form["image_ids"] = [];
@@ -209,12 +254,10 @@ module.exports = function (defaultFuncs, api, ctx) {
     form["file_ids"] = [];
     form["video_ids"] = [];
     form["audio_ids"] = [];
-    const items = normalizeAttachments(msg.attachment);
-    if (items.every(e => Array.isArray(e) && /_id$/.test(e[0]))) {
-      items.forEach(e => form[`${e[0]}s`].push(e[1]));
-      return cb();
-    }
-    uploadAttachment(items, function (err, files) {
+    const { ids, streams } = splitAttachments(msg.attachment);
+    for (const [type, id] of ids) form[`${type}s`].push(id);
+    if (!streams.length) return cb();
+    uploadAttachment(streams, function (err, files) {
       if (err) return callback(err);
       files.forEach(function (file) {
         const type = Object.keys(file)[0];
@@ -223,16 +266,32 @@ module.exports = function (defaultFuncs, api, ctx) {
       cb();
     });
   }
+
   function handleMention(msg, form, callback, cb) {
-    try { applyMentions(msg, form); cb(); } catch (e) { callback(e); }
+    try {
+      applyMentions(msg, form);
+      cb();
+    } catch (e) {
+      callback(e);
+    }
   }
+
   return function sendMessage(msg, threadID, callback, replyToMessage, isGroup) {
+    const isFn = v => typeof v === "function";
+    const isStr = v => typeof v === "string";
+
     if (typeof isGroup === "undefined") isGroup = null;
-    if (!callback && (utils.getType(threadID) === "Function" || utils.getType(threadID) === "AsyncFunction")) return threadID({ error: "Pass a threadID as a second argument." });
-    if (!replyToMessage && utils.getType(callback) === "String") {
+    if (!callback && (getType(threadID) === "Function" || getType(threadID) === "AsyncFunction")) return threadID({ error: "Pass a threadID as a second argument." });
+
+    if (isStr(callback) && isFn(replyToMessage)) {
+      const t = callback;
+      callback = replyToMessage;
+      replyToMessage = t;
+    } else if (!replyToMessage && isStr(callback)) {
       replyToMessage = callback;
-      callback = function () { };
+      callback = null;
     }
+
     let resolveFunc = function () { };
     let rejectFunc = function () { };
     const returnPromise = new Promise(function (resolve, reject) {
@@ -245,62 +304,73 @@ module.exports = function (defaultFuncs, api, ctx) {
         resolveFunc(data);
       };
     }
-    const msgType = utils.getType(msg);
-    const threadIDType = utils.getType(threadID);
-    const messageIDType = utils.getType(replyToMessage);
-    if (msgType !== "String" && msgType !== "Object") return callback({ error: "Message should be of type string or object and not " + msgType + "." });
-    if (threadIDType !== "Array" && threadIDType !== "Number" && threadIDType !== "String") return callback({ error: "ThreadID should be of type number, string, or array and not " + threadIDType + "." });
-    if (replyToMessage && messageIDType !== "String") return callback({ error: "MessageID should be of type string and not " + threadIDType + "." });
-    if (msgType === "String") msg = { body: msg };
-    const disallowedProperties = Object.keys(msg).filter(prop => !allowedProperties[prop]);
-    if (disallowedProperties.length > 0) return callback({ error: "Disallowed props: `" + disallowedProperties.join(", ") + "`" });
-    const messageAndOTID = utils.generateOfflineThreadingID();
-    const form = {
-      client: "mercury",
-      action_type: "ma-type:user-generated-message",
-      author: "fbid:" + ctx.userID,
-      timestamp: Date.now(),
-      timestamp_absolute: "Today",
-      timestamp_relative: utils.generateTimestampRelative(),
-      timestamp_time_passed: "0",
-      is_unread: false,
-      is_cleared: false,
-      is_forward: false,
-      is_filtered_content: false,
-      is_filtered_content_bh: false,
-      is_filtered_content_account: false,
-      is_filtered_content_quasar: false,
-      is_filtered_content_invalid_app: false,
-      is_spoof_warning: false,
-      source: "source:chat:web",
-      "source_tags[0]": "source:chat",
-      body: msg.body ? msg.body.toString() : "",
-      html_body: false,
-      ui_push_phase: "V3",
-      status: "0",
-      offline_threading_id: messageAndOTID,
-      message_id: messageAndOTID,
-      threading_id: utils.generateThreadingID(ctx.clientID),
-      ephemeral_ttl_mode: "0",
-      manual_retry_cnt: "0",
-      signatureID: utils.getSignatureID(),
-      replied_to_message_id: replyToMessage
-    };
-    applyPageAuthor(form, msg);
-    handleLocation(msg, form, callback, () =>
-      handleSticker(msg, form, callback, () =>
-        handleAttachment(msg, form, callback, () =>
-          handleUrl(msg, form, callback, () =>
-            handleEmoji(msg, form, callback, () =>
-              handleMention(msg, form, callback, () => {
-                finalizeHasAttachment(form);
-                send(form, threadID, messageAndOTID, callback, isGroup);
-              })
+
+    try {
+      const msgType = getType(msg);
+      const threadIDType = getType(threadID);
+      const messageIDType = getType(replyToMessage);
+      if (msgType !== "String" && msgType !== "Object") return callback({ error: "Message should be of type string or object and not " + msgType + "." });
+      if (threadIDType !== "Array" && threadIDType !== "Number" && threadIDType !== "String") return callback({ error: "ThreadID should be of type number, string, or array and not " + threadIDType + "." });
+      if (replyToMessage && messageIDType !== "String") return callback({ error: "MessageID should be of type string and not " + threadIDType + "." });
+      if (msgType === "String") msg = { body: msg };
+
+      const disallowedProperties = Object.keys(msg).filter(prop => !allowedProperties[prop]);
+      if (disallowedProperties.length > 0) return callback({ error: "Disallowed props: `" + disallowedProperties.join(", ") + "`" });
+
+      const messageAndOTID = generateOfflineThreadingID();
+      const form = {
+        client: "mercury",
+        action_type: "ma-type:user-generated-message",
+        author: "fbid:" + ctx.userID,
+        timestamp: Date.now(),
+        timestamp_absolute: "Today",
+        timestamp_relative: generateTimestampRelative(),
+        timestamp_time_passed: "0",
+        is_unread: false,
+        is_cleared: false,
+        is_forward: false,
+        is_filtered_content: false,
+        is_filtered_content_bh: false,
+        is_filtered_content_account: false,
+        is_filtered_content_quasar: false,
+        is_filtered_content_invalid_app: false,
+        is_spoof_warning: false,
+        source: "source:chat:web",
+        "source_tags[0]": "source:chat",
+        body: msg.body ? msg.body.toString() : "",
+        html_body: false,
+        ui_push_phase: "V3",
+        status: "0",
+        offline_threading_id: messageAndOTID,
+        message_id: messageAndOTID,
+        threading_id: generateThreadingID(ctx.clientID),
+        ephemeral_ttl_mode: "0",
+        manual_retry_cnt: "0",
+        signatureID: getSignatureID(),
+        replied_to_message_id: replyToMessage ? replyToMessage.toString() : ""
+      };
+      applyPageAuthor(form, msg);
+      handleLocation(msg, form, callback, () =>
+        handleSticker(msg, form, callback, () =>
+          handleAttachment(msg, form, callback, () =>
+            handleUrl(msg, form, callback, () =>
+              handleEmoji(msg, form, callback, () =>
+                handleMention(msg, form, callback, () => {
+                  finalizeHasAttachment(form);
+                  send(form, threadID, messageAndOTID, callback, isGroup);
+                })
+              )
             )
           )
         )
-      )
-    );
+      );
+    } catch (e) {
+      log.error("sendMessage", e);
+      if (getType(e) === "Object" && e.error === "Not logged in.") ctx.loggedIn = false;
+      return callback(e);
+    }
+
     return returnPromise;
   };
+
 };

package/src/api/messaging/sendMessageMqtt.js

@@ -1,7 +1,9 @@
-const utils = require("../../utils");
+
 var log = require("npmlog");
 var bluebird = require("bluebird");
-
+const { parseAndCheckLogin } = require("../../utils/client");
+const { getType } = require("../../utils/format");
+const { isReadableStream } = require("../../utils/constants");
 module.exports = function(defaultFuncs, api, ctx) {
   function uploadAttachment(attachments, callback) {
     callback = callback || function() {};
@@ -9,11 +11,11 @@ module.exports = function(defaultFuncs, api, ctx) {
 
     // create an array of promises
     for (var i = 0; i < attachments.length; i++) {
-      if (!utils.isReadableStream(attachments[i])) {
+      if (!isReadableStream(attachments[i])) {
         throw {
           error:
             "Attachment should be a readable stream and not " +
-            utils.getType(attachments[i]) +
+            getType(attachments[i]) +
             "."
         };
       }
@@ -31,7 +33,7 @@ module.exports = function(defaultFuncs, api, ctx) {
             form,
             {}
           )
-          .then(utils.parseAndCheckLogin(ctx, defaultFuncs))
+          .then(parseAndCheckLogin(ctx, defaultFuncs))
           .then(function(resData) {
             if (resData.error) {
               throw resData;
@@ -105,7 +107,7 @@ module.exports = function(defaultFuncs, api, ctx) {
       form.payload.tasks[0].payload.attachment_fbids = [];
       if (form.payload.tasks[0].payload.text == "")
         form.payload.tasks[0].payload.text = null;
-      if (utils.getType(msg.attachment) !== "Array") {
+      if (getType(msg.attachment) !== "Array") {
         msg.attachment = [msg.attachment];
       }
 
@@ -228,12 +230,12 @@ module.exports = function(defaultFuncs, api, ctx) {
   return function sendMessageMqtt(msg, threadID, callback, replyToMessage) {
     if (
       !callback &&
-      (utils.getType(threadID) === "Function" ||
-        utils.getType(threadID) === "AsyncFunction")
+      (getType(threadID) === "Function" ||
+        getType(threadID) === "AsyncFunction")
     ) {
       return threadID({ error: "Pass a threadID as a second argument." });
     }
-    if (!replyToMessage && utils.getType(callback) === "String") {
+    if (!replyToMessage && getType(callback) === "String") {
       replyToMessage = callback;
       callback = function() {};
     }
@@ -242,9 +244,9 @@ module.exports = function(defaultFuncs, api, ctx) {
       callback = function(err, friendList) {};
     }
 
-    var msgType = utils.getType(msg);
-    var threadIDType = utils.getType(threadID);
-    var messageIDType = utils.getType(replyToMessage);
+    var msgType = getType(msg);
+    var threadIDType = getType(threadID);
+    var messageIDType = getType(replyToMessage);
 
     if (msgType !== "String" && msgType !== "Object") {
       return callback({

package/src/api/messaging/sendTypingIndicator.js

@@ -1,8 +1,8 @@
 "use strict";
 
-const utils = require("../../utils");
 const log = require("npmlog");
-
+const { getType } = require("../../utils/format");
+const { parseAndCheckLogin } = require("../../utils/client");
 module.exports = function(defaultFuncs, api, ctx) {
   function makeTypingIndicator(typ, threadID, callback, isGroup) {
     const form = {
@@ -14,13 +14,13 @@ module.exports = function(defaultFuncs, api, ctx) {
 
     // Check if thread is a single person chat or a group chat
     // More info on this is in api.sendMessage
-    if (utils.getType(isGroup) == "Boolean") {
+    if (getType(isGroup) == "Boolean") {
       if (!isGroup) {
         form.to = threadID;
       }
       defaultFuncs
         .post("https://www.facebook.com/ajax/messaging/typ.php", ctx.jar, form)
-        .then(utils.parseAndCheckLogin(ctx, defaultFuncs))
+        .then(parseAndCheckLogin(ctx, defaultFuncs))
         .then(function(resData) {
           if (resData.error) {
             throw resData;
@@ -30,7 +30,7 @@ module.exports = function(defaultFuncs, api, ctx) {
         })
         .catch(function(err) {
           log.error("sendTypingIndicator", err);
-          if (utils.getType(err) == "Object" && err.error === "Not logged in") {
+          if (getType(err) == "Object" && err.error === "Not logged in") {
             ctx.loggedIn = false;
           }
           return callback(err);
@@ -52,7 +52,7 @@ module.exports = function(defaultFuncs, api, ctx) {
             ctx.jar,
             form
           )
-          .then(utils.parseAndCheckLogin(ctx, defaultFuncs))
+          .then(parseAndCheckLogin(ctx, defaultFuncs))
           .then(function(resData) {
             if (resData.error) {
               throw resData;
@@ -63,7 +63,7 @@ module.exports = function(defaultFuncs, api, ctx) {
           .catch(function(err) {
             log.error("sendTypingIndicator", err);
             if (
-              utils.getType(err) == "Object" &&
+              getType(err) == "Object" &&
               err.error === "Not logged in."
             ) {
               ctx.loggedIn = false;
@@ -76,8 +76,8 @@ module.exports = function(defaultFuncs, api, ctx) {
 
   return function sendTypingIndicator(threadID, callback, isGroup) {
     if (
-      utils.getType(callback) !== "Function" &&
-      utils.getType(callback) !== "AsyncFunction"
+      getType(callback) !== "Function" &&
+      getType(callback) !== "AsyncFunction"
     ) {
       if (callback) {
         log.warn(
@@ -92,8 +92,8 @@ module.exports = function(defaultFuncs, api, ctx) {
 
     return function end(cb) {
       if (
-        utils.getType(cb) !== "Function" &&
-        utils.getType(cb) !== "AsyncFunction"
+        getType(cb) !== "Function" &&
+        getType(cb) !== "AsyncFunction"
       ) {
         if (cb) {
           log.warn(