@dommaker/harness 1.3.0 → 1.5.0

package/src/{__tests__ → core/constraints/checkers/__tests__}/governance-presence.test.ts

@@ -1,8 +1,11 @@
 /**
- * governance_presence checker 测试（studio #302，ADR 2026-08-21 落点模型）
+ * governance_presence 检查器旁测（studio #302，ADR 2026-08-21 落点模型）
  *
  * 在场守护：PRESERVE 只保「存在」不保「在场」——治理契约段被删除/掏空后
  * sync-docs 重新生成会静默丢失，本 checker 在 harness check 时校验在场性。
+ * 测试面 = evaluate(env)（架构评审候选4，自 src/__tests__/ 就近迁入）。
+ * 根由 src/test-setup/project-fixture 构造；本套件是 cwd 锚定用例，经
+ * parentDir: process.cwd() **显式** opt-out 保持原语义（harness#90 前置约束）。
  */
 
 import { describe, it, expect, beforeEach, afterEach, jest } from '@jest/globals';
@@ -12,8 +15,10 @@ import {
   governancePresence,
   hasGovernancePreserveBlock,
   hasClaudeGovernance,
-} from '../core/constraints/checkers/governance-presence';
-import type { CheckEnv } from '../core/constraints/checkers';
+} from '../governance-presence';
+import { detectInjectionDrift } from '../../injection-drift';
+import { createProjectFixture, writeProjectConfig } from '../../../../test-setup/project-fixture';
+import type { CheckEnv } from '../types';
 
 function makeEnv(projectPath: string): CheckEnv {
   return {
@@ -39,13 +44,13 @@ describe('governance_presence checker', () => {
   let tempDir: string;
   let errorSpy: jest.SpiedFunction<typeof console.error>;
 
-  const writeConfig = () => {
-    fs.mkdirSync(path.join(tempDir, '.harness'), { recursive: true });
-    fs.writeFileSync(path.join(tempDir, '.harness', 'config.yml'), 'preset: standard\n');
-  };
+  const writeConfig = () => writeProjectConfig(tempDir, 'preset: standard\n');
 
   beforeEach(() => {
-    tempDir = fs.mkdtempSync(path.join(process.cwd(), 'temp-test-gov-presence-'));
+    tempDir = createProjectFixture({
+      name: 'temp-test-gov-presence',
+      parentDir: process.cwd(),
+    });
     errorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
   });
 
@@ -70,6 +75,12 @@ describe('governance_presence checker', () => {
     expect(await governancePresence.evaluate(makeEnv(tempDir))).toBe(true);
   });
 
+  it('旧模型豁免：CLAUDE.md 标题双空格变体也认（宽松谓词，fail-open）→ pass', async () => {
+    writeConfig();
+    fs.writeFileSync(path.join(tempDir, 'CLAUDE.md'), '# CLAUDE.md\n\n##  Governance Rules\n\n条款\n');
+    expect(await governancePresence.evaluate(makeEnv(tempDir))).toBe(true);
+  });
+
   it('旧模型豁免：CLAUDE.md 有 HARNESS_CONSTRAINTS 标记 → pass', async () => {
     writeConfig();
     fs.writeFileSync(path.join(tempDir, 'CLAUDE.md'), '<!-- HARNESS_CONSTRAINTS_START -->\nx\n');
@@ -107,7 +118,10 @@ describe('hasGovernancePreserveBlock / hasClaudeGovernance 判定函数', () =>
   let tempDir: string;
 
   beforeEach(() => {
-    tempDir = fs.mkdtempSync(path.join(process.cwd(), 'temp-test-gov-helpers-'));
+    tempDir = createProjectFixture({
+      name: 'temp-test-gov-helpers',
+      parentDir: process.cwd(),
+    });
   });
 
   afterEach(() => {
@@ -126,4 +140,64 @@ describe('hasGovernancePreserveBlock / hasClaudeGovernance 判定函数', () =>
     fs.writeFileSync(p, `<!-- PRESERVE:governance -->\n条款一\n<!-- /PRESERVE:governance -->\n`);
     expect(hasGovernancePreserveBlock(p)).toBe(true);
   });
+
+  it('结束标记嵌在行中 = 畸形块 → false（显式收紧，#83：按契约丢失报警）', () => {
+    const p = path.join(tempDir, 'AGENTS.md');
+    fs.writeFileSync(
+      p,
+      '<!-- PRESERVE:governance -->\n条款一 <!-- /PRESERVE:governance --> 尾注\n'
+    );
+    expect(hasGovernancePreserveBlock(p)).toBe(false);
+  });
+});
+
+describe('governance_presence × detectInjectionDrift 同 fixture 一致性（#83）', () => {
+  let tempDir: string;
+
+  const writeConfig = () => writeProjectConfig(tempDir, 'preset: standard\n');
+
+  beforeEach(() => {
+    tempDir = createProjectFixture({
+      name: 'temp-test-gov-consistency',
+      parentDir: process.cwd(),
+    });
+  });
+
+  afterEach(() => {
+    fs.rmSync(tempDir, { recursive: true, force: true });
+  });
+
+  it('双空格标题：presence 认在场（pass），drift 严格计数 0 不报重复——两层不再互相矛盾', async () => {
+    writeConfig();
+    fs.writeFileSync(path.join(tempDir, 'CLAUDE.md'), '# CLAUDE.md\n\n##  Governance Rules\n\n条款\n');
+
+    expect(await governancePresence.evaluate(makeEnv(tempDir))).toBe(true);
+    const drift = detectInjectionDrift(tempDir);
+    expect(drift.notInjected).toBe(true);
+    expect(drift.duplicateHeading).toBe(false);
+    expect(drift.hasDrift).toBe(false);
+  });
+
+  it('精确拼写单标题：presence pass，drift 不报重复', async () => {
+    writeConfig();
+    fs.writeFileSync(path.join(tempDir, 'CLAUDE.md'), '# CLAUDE.md\n\n## Governance Rules\n\n条款\n');
+
+    expect(await governancePresence.evaluate(makeEnv(tempDir))).toBe(true);
+    const drift = detectInjectionDrift(tempDir);
+    expect(drift.notInjected).toBe(true);
+    expect(drift.duplicateHeading).toBe(false);
+  });
+
+  it('精确拼写双标题：presence 认在场，drift 报重复章节（计数是 drift 的独立职责）', async () => {
+    writeConfig();
+    fs.writeFileSync(
+      path.join(tempDir, 'CLAUDE.md'),
+      '# CLAUDE.md\n\n## Governance Rules\n\n甲\n\n## Governance Rules\n\n乙\n'
+    );
+
+    expect(await governancePresence.evaluate(makeEnv(tempDir))).toBe(true);
+    const drift = detectInjectionDrift(tempDir);
+    expect(drift.notInjected).toBe(true);
+    expect(drift.duplicateHeading).toBe(true);
+  });
 });

package/src/core/constraints/checkers/__tests__/iron-flags.test.ts

@@ -0,0 +1,50 @@
+/**
+ * 铁律层 flag 检查旁测（架构评审候选4，ADR-0009 同模式）
+ *
+ * 三个 flag 铁律均为 contextEvidenceFlag 构造，真实 bug 面 = 读错上下文字段
+ * 与三态语义（undefined→skip / false→fail / true→pass）。直接喂不同字段组合
+ * 钉死映射，不再经 engine facade（旧测在 skip-semantics/checker.test 间接打）。
+ */
+
+import { describe, it, expect } from '@jest/globals';
+import {
+  noCompletionWithoutVerification,
+  incrementalProgress,
+  noImplementationWithoutRequirement,
+} from '../iron-flags';
+import { buildCheckEnv } from '../types';
+import type { ConstraintContext } from '../../../../types/constraint';
+
+const evaluate = (
+  check: { evaluate: (env: any) => unknown },
+  ctx: Partial<ConstraintContext>
+) => check.evaluate(buildCheckEnv({ ...ctx, operation: 'code_implementation' }, 'none'));
+
+describe('iron flags — 三态与字段映射', () => {
+  it('no_completion_without_verification → 读 hasVerificationEvidence', async () => {
+    expect(await evaluate(noCompletionWithoutVerification, {})).toBe('skip');
+    expect(await evaluate(noCompletionWithoutVerification, { hasVerificationEvidence: false })).toBe(false);
+    expect(await evaluate(noCompletionWithoutVerification, { hasVerificationEvidence: true })).toBe(true);
+    // 相邻字段不串台：hasTest 不能顶替
+    expect(await evaluate(noCompletionWithoutVerification, { hasTest: true })).toBe('skip');
+  });
+
+  it('incremental_progress → 读 hasSingleTask', async () => {
+    expect(await evaluate(incrementalProgress, {})).toBe('skip');
+    expect(await evaluate(incrementalProgress, { hasSingleTask: false })).toBe(false);
+    expect(await evaluate(incrementalProgress, { hasSingleTask: true })).toBe(true);
+  });
+
+  it('no_implementation_without_requirement → 读 hasRequirement', async () => {
+    expect(await evaluate(noImplementationWithoutRequirement, {})).toBe('skip');
+    expect(await evaluate(noImplementationWithoutRequirement, { hasRequirement: false })).toBe(false);
+    expect(await evaluate(noImplementationWithoutRequirement, { hasRequirement: true })).toBe(true);
+  });
+
+  it('三 flag 各自独立判定（组合上下文互不影响）', async () => {
+    const ctx: Partial<ConstraintContext> = { hasVerificationEvidence: true, hasSingleTask: false };
+    expect(await evaluate(noCompletionWithoutVerification, ctx)).toBe(true);
+    expect(await evaluate(incrementalProgress, ctx)).toBe(false);
+    expect(await evaluate(noImplementationWithoutRequirement, ctx)).toBe('skip');
+  });
+});

package/src/core/constraints/checkers/__tests__/no-bypass-checkpoint.test.ts

@@ -0,0 +1,76 @@
+/**
+ * no_bypass_checkpoint 检查器旁测（架构评审候选4，ADR-0009 同模式）
+ *
+ * 测试面 = ConstraintCheck.evaluate(env)：判定只读 env.context.changedFiles
+ * 的文件内容，无需 git staging（旧 facade 测用真实 git add 属多余 fixture）。
+ * 自 checker-extra.test.ts 迁入并补齐 BYPASS_PATTERNS 全表用例。
+ * 违规样例字符串一律拼接构造，避免本文件被该检查器自身命中。
+ * 项目根由 src/test-setup/project-fixture 声明式构造（回收仍走 mkdtemp-cleanup）。
+ */
+
+import { describe, it, expect } from '@jest/globals';
+import * as os from 'os';
+import * as path from 'path';
+import { noBypassCheckpoint } from '../no-bypass-checkpoint';
+import { buildCheckEnv } from '../types';
+import { createProjectFixture } from '../../../../test-setup/project-fixture';
+import type { ConstraintContext } from '../../../../types/constraint';
+
+/** 与 BYPASS_PATTERNS 对齐的违规样例（拼接构造，源文本不含完整模式串） */
+const VIOLATIONS: Array<[string, string]> = [
+  ['jest/vitest skip 调用', 'test.' + 'skip("skipped", () => {});'],
+  ['bypass 标志赋值', 'config.byp' + 'ass = true;'],
+  ['skip 选项', '{ run: { skip' + ': true } }'],
+  ['显式 bypass 注释', '# bypa' + 'ss checkpoint for perf'],
+  ['行注释 skip', 'code(); // ' + 'skip this for now'],
+];
+
+function writeTemp(name: string, content: string): string {
+  const root = createProjectFixture({
+    name: `no-bypass-${name}`,
+    files: { 'subject.ts': content },
+  });
+  return path.join(root, 'subject.ts');
+}
+
+function evaluate(changedFiles: string[]) {
+  const context: ConstraintContext = {
+    operation: 'code_implementation',
+    projectPath: process.cwd(),
+    changedFiles,
+  };
+  return noBypassCheckpoint.evaluate(buildCheckEnv(context, 'none'));
+}
+
+describe('no_bypass_checkpoint', () => {
+  it('无变更文件 → pass（默认放行）', async () => {
+    expect(await evaluate([])).toBe(true);
+  });
+
+  for (const [label, content] of VIOLATIONS) {
+    it(`命中 bypass 模式（${label}）→ fail`, async () => {
+      expect(await evaluate([writeTemp('hit', content)])).toBe(false);
+    });
+  }
+
+  it('干净测试文件 → pass（旧 facade 对照用例）', async () => {
+    expect(
+      await evaluate([writeTemp('clean', 'test("clean", () => { expect(1).toBe(1); });')])
+    ).toBe(true);
+  });
+
+  it('变更文件已删除（不在 fs）→ 跳过该文件继续', async () => {
+    expect(await evaluate([path.join(os.tmpdir(), 'no-bypass-gone', 'ghost.ts')])).toBe(true);
+  });
+
+  it('文件不可读（目录当文件）→ 忽略不炸', async () => {
+    const dir = createProjectFixture({ name: 'no-bypass-dir' });
+    expect(await evaluate([dir])).toBe(true);
+  });
+
+  it('多文件任一命中即 fail', async () => {
+    const clean = writeTemp('multi-clean', 'export const x = 1;');
+    const dirty = writeTemp('multi-dirty', VIOLATIONS[0][1]);
+    expect(await evaluate([clean, dirty])).toBe(false);
+  });
+});

package/src/{__tests__ → core/constraints/checkers/__tests__}/no-hardcoded-credentials.test.ts

@@ -1,16 +1,17 @@
 /**
- * no_hardcoded_credentials checker 测试（ADR-0001）
+ * no_hardcoded_credentials 检查器旁测（ADR-0001）
  *
  * 注意：测试夹具中的假凭证一律用字符串拼接构造，
  * 避免本文件自身被凭证扫描（含 harness 自身 staged diff）命中。
+ * 测试面 = evaluate(env)（架构评审候选4，自 src/__tests__/ 就近迁入）。
  */
 
 import { describe, it, expect } from '@jest/globals';
 import {
   noHardcodedCredentials,
   containsHardcodedCredential,
-} from '../core/constraints/checkers/no-hardcoded-credentials';
-import type { CheckEnv } from '../core/constraints/checkers';
+} from '../no-hardcoded-credentials';
+import type { CheckEnv } from '../types';
 
 function makeEnv(stagedDiff: string): CheckEnv {
   return {

package/src/core/constraints/checkers/__tests__/no-test-simplification.test.ts

@@ -0,0 +1,58 @@
+/**
+ * no_test_simplification 检查器旁测（架构评审候选4，ADR-0009 同模式）
+ *
+ * 测试面 = ConstraintCheck.evaluate(env)：判定只吃 stagedDiff 文本，
+ * 证据经 providers 注入（旧 facade 测用真实非 git 目录触发 IO 失败，
+ * 旁测直接让 provider 抛错表达同一语义）。自 checker-extra.test.ts 迁入。
+ */
+
+import { describe, it, expect } from '@jest/globals';
+import { noTestSimplification } from '../no-test-simplification';
+import { buildCheckEnv } from '../types';
+import type { ConstraintContext } from '../../../../types/constraint';
+
+function evaluate(diff: string | (() => Promise<string>)) {
+  const context: ConstraintContext = { operation: 'test_creation', projectPath: '/nonexistent' };
+  const stagedDiff = typeof diff === 'function' ? diff : async () => diff;
+  return noTestSimplification.evaluate(
+    buildCheckEnv(context, {
+      stagedDiff,
+      stagedDiffNames: async () => '',
+      srcScan: () => [],
+    })
+  );
+}
+
+describe('no_test_simplification', () => {
+  it('删除 test/it/describe → fail', async () => {
+    expect(await evaluate('--- a/x.test.ts\n+++ b/x.test.ts\n@@\n-  test("gone", () => {});\n')).toBe(false);
+    expect(await evaluate('-  it("gone", () => {});')).toBe(false);
+    expect(await evaluate('-describe("suite", () => {});')).toBe(false);
+  });
+
+  it('删除 expect → fail', async () => {
+    expect(await evaluate('-    expect(x).toBe(y);')).toBe(false);
+  });
+
+  it('删除注释掉的 test → fail', async () => {
+    expect(await evaluate('-  // test pending case')).toBe(false);
+  });
+
+  it('仅新增/上下文行 → pass', async () => {
+    expect(
+      await evaluate('--- a/x.test.ts\n+++ b/x.test.ts\n@@\n+  test("added", () => {});\n   expect(1).toBe(1);\n')
+    ).toBe(true);
+  });
+
+  it('空 diff → pass', async () => {
+    expect(await evaluate('')).toBe(true);
+  });
+
+  it('git diff 失败 → 默认通过（fail-open，自 facade 测迁入）', async () => {
+    expect(
+      await evaluate(async () => {
+        throw new Error('not a git repository');
+      })
+    ).toBe(true);
+  });
+});

package/src/core/constraints/checkers/__tests__/three-state-consistency.test.ts

@@ -0,0 +1,153 @@
+/**
+ * context_files 三态对照测试（工单 84）
+ *
+ * 同一组 fixture 同时跑 context_doc_sync 与 docs_freshness 两条约束，
+ * 钉死 triage 裁决口径：未配置 / enabled 但无目标 → 约束 checker 一律 skip
+ * （ADR-0001 存在性探测同构）；enabled 且非空 → 两条约束按同一组 dirs
+ * 评估且判定一致。
+ *
+ * 附带 docs_freshness 评估段的行为变更钉子：enabled 但无目标 → skip，
+ * 不再静默放行（此前返回 true）。
+ * 项目根由 src/test-setup/project-fixture 声明式构造（回收仍走 mkdtemp-cleanup）。
+ */
+
+import { describe, it, expect } from '@jest/globals';
+import { contextDocSync } from '../context-doc-sync';
+import { docsFreshness } from '../docs-freshness';
+import { buildCheckEnv, normalizeCheckOutcome, type CheckOutcome } from '../types';
+import { collectSourceFiles } from '../../capabilities-reconcile';
+import { createProjectFixture } from '../../../../test-setup/project-fixture';
+import type { ConstraintContext } from '../../../../types/constraint';
+
+const TABLE_HEAD = '| 模块 | 文件 | 说明 |\n|------|------|------|\n';
+
+interface Fixture {
+  configYml?: string;
+  contextMdDirs?: string[];
+  files?: string[];
+  capabilitiesBody?: string;
+}
+
+function setupDir(name: string, fixture: Fixture = {}): string {
+  return createProjectFixture({
+    name: `three-state-${name}`,
+    config: fixture.configYml,
+    files: {
+      ...Object.fromEntries((fixture.files ?? []).map(f => [f, 'export const x = 1;'])),
+      ...Object.fromEntries((fixture.contextMdDirs ?? []).map(d => [`${d}/CONTEXT.md`, `# ${d}\n`])),
+      ...(fixture.capabilitiesBody === undefined
+        ? {}
+        : { 'CAPABILITIES.md': `# Capabilities\n\n${fixture.capabilitiesBody}` }),
+    },
+  });
+}
+
+const CTX_FILES = (enabled: boolean, dirs?: string[]) =>
+  `governance:\n  context_files:\n    enabled: ${enabled}\n` +
+  (dirs ? `    required_dirs: [${dirs.map(d => `'${d}'`).join(', ')}]\n` : '');
+
+function evalContextDocSync(dir: string) {
+  const context: ConstraintContext = { operation: 'module_modification', projectPath: dir };
+  return contextDocSync.evaluate(buildCheckEnv(context, 'none'));
+}
+
+function evalDocsFreshness(dir: string) {
+  const context: ConstraintContext = { operation: 'file_modification', projectPath: dir };
+  return docsFreshness.evaluate(
+    buildCheckEnv(context, {
+      stagedDiff: async () => '',
+      stagedDiffNames: async () => '',
+      srcScan: (root: string) => collectSourceFiles(dir, [root]),
+    })
+  );
+}
+
+/** 三态判定（比较判定结论本身，不比较返回形状——harness#119 后 checker 可带回证据） */
+function verdictOf(outcome: CheckOutcome): true | false | 'skip' {
+  const normalized = normalizeCheckOutcome(outcome);
+  return normalized.skipped ? 'skip' : normalized.satisfied;
+}
+
+/** 同一 fixture 上两条约束的判定必须一致（对照断言） */
+async function expectBoth(dir: string, verdict: true | false | 'skip'): Promise<void> {
+  expect(verdictOf(await evalContextDocSync(dir))).toBe(verdict);
+  expect(verdictOf(await evalDocsFreshness(dir))).toBe(verdict);
+}
+
+describe('context_files 三态对照 — context_doc_sync vs docs_freshness（工单 84）', () => {
+  it('未配置（无 config.yml）→ 双双 skip', async () => {
+    await expectBoth(setupDir('no-config'), 'skip');
+  });
+
+  it('governance.context_files 段缺失 → 双双 skip', async () => {
+    await expectBoth(setupDir('no-section', { configYml: 'preset: standard\n' }), 'skip');
+  });
+
+  it('enabled: false（约定未采用）→ 双双 skip', async () => {
+    await expectBoth(setupDir('disabled', { configYml: CTX_FILES(false, ['src']) }), 'skip');
+  });
+
+  it('enabled 但 required_dirs 缺失（约定已立但无目标）→ 双双 skip', async () => {
+    await expectBoth(setupDir('no-dirs', { configYml: CTX_FILES(true) }), 'skip');
+  });
+
+  it('enabled 但 required_dirs 为空数组 → 双双 skip', async () => {
+    await expectBoth(setupDir('empty-dirs', { configYml: CTX_FILES(true, []) }), 'skip');
+  });
+
+  it('enabled 但 required_dirs 含非字符串项（脏配置）→ 双双 skip 而非抛错', async () => {
+    await expectBoth(
+      setupDir('dirty-dirs', {
+        configYml: 'governance:\n  context_files:\n    enabled: true\n    required_dirs: [1, null]\n',
+      }),
+      'skip'
+    );
+  });
+
+  it('enabled 且非空 + CONTEXT.md 齐全 → 双双 pass（同一组 dirs 同一判定）', async () => {
+    await expectBoth(
+      setupDir('all-present', {
+        configYml: CTX_FILES(true, ['src', 'bin']),
+        contextMdDirs: ['src', 'bin'],
+      }),
+      true
+    );
+  });
+
+  it('enabled 且非空 + CONTEXT.md 缺失 → 双双 fail', async () => {
+    await expectBoth(
+      setupDir('missing-doc', { configYml: CTX_FILES(true, ['src', 'bin']) }),
+      false
+    );
+  });
+});
+
+describe('docs_freshness 评估段 skip 行为变更（工单 84：约定已立但无目标不再静默放行）', () => {
+  it('doc_freshness.checks 已配 + enabled 但 required_dirs 缺失 → skip（原为 true）', async () => {
+    const dir = setupDir('checks-plus-empty', {
+      configYml:
+        'governance:\n  doc_freshness:\n    checks:\n      - type: changelog_version\n  context_files:\n    enabled: true\n',
+    });
+    expect(await evalDocsFreshness(dir)).toBe('skip');
+  });
+
+  it('enabled 但空 + CAPABILITIES.md 健康 → skip（原为 true）', async () => {
+    const dir = setupDir('caps-healthy', {
+      configYml: CTX_FILES(true),
+      files: ['src/module.ts'],
+      capabilitiesBody: `${TABLE_HEAD}| module | src/module.ts | module |`,
+    });
+    expect(await evalDocsFreshness(dir)).toBe('skip');
+  });
+
+  it('enabled 但空 + CAPABILITIES.md 幽灵条目 → 仍 fail（Step 1 文件表判定不因 context_files 受影响）', async () => {
+    const dir = setupDir('caps-ghost', {
+      configYml: CTX_FILES(true),
+      files: ['src/old.ts'],
+      capabilitiesBody: `${TABLE_HEAD}| old | src/old.ts | 活 |\n| 遗魂 | src/gone/ | 已删 |`,
+    });
+    const outcome = await evalDocsFreshness(dir);
+    expect(verdictOf(outcome)).toBe(false);
+    expect(normalizeCheckOutcome(outcome).evidence.join('\n')).toContain('src/gone/');
+  });
+});