@dommaker/harness 0.13.0 → 0.13.2

package/src/__tests__/project-config-loader-extra.test.ts

@@ -0,0 +1,269 @@
+/**
+ * ProjectConfigLoader 补充测试
+ */
+
+import { describe, it, expect, beforeAll, afterAll } from '@jest/globals';
+import { ProjectConfigLoader } from '../core/project-config-loader';
+import * as fs from 'fs';
+import * as path from 'path';
+
+describe('ProjectConfigLoader - 补充覆盖', () => {
+  const tempDir = path.join(process.cwd(), 'temp-test-config-extra');
+  const harnessDir = path.join(tempDir, '.harness');
+
+  beforeAll(() => {
+    fs.mkdirSync(harnessDir, { recursive: true });
+  });
+
+  afterAll(() => {
+    try {
+      fs.rmSync(tempDir, { recursive: true, force: true });
+    } catch {
+      // ignore
+    }
+  });
+
+  describe('禁用约束', () => {
+    it('应该禁用指定约束', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+constraints:
+  no_any_type:
+    enabled: false
+  no_self_approval:
+    enabled: false
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+      const merged = loader.mergeConstraints();
+
+      expect(merged.disabled).toContain('no_any_type');
+      expect(merged.disabled).toContain('no_self_approval');
+    });
+  });
+
+  describe('自定义约束层级', () => {
+    it('应该正确分类 iron_law 级别约束', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+custom_constraints:
+  my_iron_law:
+    rule: MY IRON LAW
+    message: Iron law message
+    level: iron_law
+    trigger: commit
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+      const merged = loader.mergeConstraints();
+
+      expect(merged.ironLaws['my_iron_law']).toBeDefined();
+    });
+
+    it('应该正确分类 tip 级别约束', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+custom_constraints:
+  my_tip:
+    rule: MY TIP
+    message: Tip message
+    level: tip
+    trigger: commit
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+      const merged = loader.mergeConstraints();
+
+      expect(merged.tips['my_tip']).toBeDefined();
+    });
+
+    it('默认应该分类为 guideline', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+custom_constraints:
+  my_guideline:
+    rule: MY GUIDELINE
+    message: Guideline message
+    trigger: commit
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+      const merged = loader.mergeConstraints();
+
+      expect(merged.guidelines['my_guideline']).toBeDefined();
+    });
+  });
+
+  describe('约束扩展', () => {
+    it('应该扩展例外列表', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+custom_constraints:
+  extended_rule:
+    rule: EXTENDED RULE
+    message: Extended
+    level: guideline
+    trigger: commit
+    exceptions:
+      - simple_typo
+    extend_exceptions:
+      - config_change
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+      const merged = loader.mergeConstraints();
+
+      expect(merged.guidelines['extended_rule']?.exceptions).toBeDefined();
+      expect(merged.guidelines['extended_rule']?.exceptions).toContain('simple_typo');
+      expect(merged.guidelines['extended_rule']?.exceptions).toContain('config_change');
+    });
+  });
+
+  describe('isConstraintEnabled', () => {
+    it('启用的约束应该返回 true', () => {
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      expect(loader.isConstraintEnabled('no_bypass_checkpoint')).toBe(true);
+    });
+
+    it('禁用的约束应该返回 false', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+constraints:
+  test_disabled:
+    enabled: false
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      expect(loader.isConstraintEnabled('test_disabled')).toBe(false);
+    });
+  });
+
+  describe('getConstraintSource', () => {
+    it('内置约束应该返回 built-in', () => {
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      expect(loader.getConstraintSource('no_bypass_checkpoint')).toBe('built-in');
+    });
+
+    it('自定义约束应该返回 custom', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+custom_constraints:
+  custom_source_test:
+    rule: CUSTOM
+    message: Custom
+    trigger: commit
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      expect(loader.getConstraintSource('custom_source_test')).toBe('custom');
+    });
+
+    it('禁用约束应该返回 disabled', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+constraints:
+  source_disabled:
+    enabled: false
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      expect(loader.getConstraintSource('source_disabled')).toBe('disabled');
+    });
+  });
+
+  describe('hasCustomConfig', () => {
+    it('无自定义配置应该返回 false', () => {
+      // 清空配置
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `preset: standard`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      expect(loader.hasCustomConfig()).toBe(false);
+    });
+
+    it('有自定义约束应该返回 true', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+custom_constraints:
+  custom_for_has:
+    rule: CUSTOM
+    message: Custom
+    trigger: commit
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      expect(loader.hasCustomConfig()).toBe(true);
+    });
+  });
+
+  describe('getConfig', () => {
+    it('应该返回当前配置', () => {
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      const config = loader.getConfig();
+      expect(config).toBeDefined();
+      expect(config.preset).toBeDefined();
+    });
+  });
+
+  describe('getCustomConstraints', () => {
+    it('应该返回自定义约束', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+custom_constraints:
+  get_custom_test:
+    rule: TEST
+    message: Test
+    trigger: commit
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      const customs = loader.getCustomConstraints();
+      expect(customs['get_custom_test']).toBeDefined();
+    });
+  });
+});

package/src/__tests__/project-config-loader.test.ts

@@ -0,0 +1,127 @@
+/**
+ * ProjectConfigLoader 测试
+ */
+
+import { describe, it, expect, beforeAll, afterAll } from '@jest/globals';
+import { ProjectConfigLoader } from '../core/project-config-loader';
+import * as fs from 'fs';
+import * as path from 'path';
+
+describe('ProjectConfigLoader', () => {
+  const tempDir = path.join(process.cwd(), 'temp-test-config');
+  const harnessDir = path.join(tempDir, '.harness');
+
+  beforeAll(() => {
+    fs.mkdirSync(harnessDir, { recursive: true });
+  });
+
+  afterAll(() => {
+    try {
+      fs.rmSync(tempDir, { recursive: true, force: true });
+    } catch {
+      // ignore
+    }
+  });
+
+  describe('load', () => {
+    it('无配置文件时应该返回默认配置', () => {
+      const loader = new ProjectConfigLoader(tempDir);
+      const config = loader.load();
+
+      expect(config.preset).toBe('standard');
+      expect(config.custom_constraints_file).toBeDefined();
+    });
+
+    it('应该加载 config.yml', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `
+preset: custom
+custom_constraints_file: my-constraints.yml
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      const config = loader.load();
+
+      expect(config.preset).toBe('custom');
+      expect(config.custom_constraints_file).toBe('my-constraints.yml');
+    });
+  });
+
+  describe('mergeConstraints', () => {
+    it('应该合并内置约束', () => {
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      const merged = loader.mergeConstraints();
+
+      expect(merged.ironLaws).toBeDefined();
+      expect(merged.guidelines).toBeDefined();
+      expect(merged.tips).toBeDefined();
+      expect(Object.keys(merged.ironLaws).length).toBeGreaterThan(0);
+    });
+
+    it('应该加载自定义约束', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'custom-constraints.yml'),
+        `
+custom_rules:
+  my_rule:
+    rule: MY CUSTOM RULE
+    message: Custom message
+    level: guideline
+    trigger: commit
+`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      const merged = loader.mergeConstraints();
+      expect(merged.custom).toBeDefined();
+    });
+  });
+
+  describe('配置合并', () => {
+    it('应该正确合并默认配置和加载配置', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `preset: minimal`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      const config = loader.load();
+
+      expect(config.preset).toBe('minimal');
+      // 默认值应该保留
+      expect(config.custom_constraints_file).toBe('custom-constraints.yml');
+    });
+  });
+
+  describe('错误处理', () => {
+    it.skip('无效 YAML 应该抛出异常', () => {
+      // YAML 解析错误会直接抛出异常，这是预期行为
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `invalid: yaml: content: :::`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      expect(() => loader.load()).toThrow();
+    });
+
+    it('自定义约束文件不存在应该不崩溃', () => {
+      fs.writeFileSync(
+        path.join(harnessDir, 'config.yml'),
+        `custom_constraints_file: nonexistent.yml`
+      );
+
+      const loader = new ProjectConfigLoader(tempDir);
+      loader.load();
+
+      const merged = loader.mergeConstraints();
+      expect(merged).toBeDefined();
+    });
+  });
+});

package/src/__tests__/review-gate.test.ts

@@ -0,0 +1,92 @@
+/**
+ * ReviewGate 测试
+ */
+
+import { describe, it, expect, beforeAll, afterAll } from '@jest/globals';
+import { ReviewGate } from '../gates/review';
+import { mkdirSync, rmSync, writeFileSync } from 'fs';
+import { join } from 'path';
+import { execSync } from 'child_process';
+
+describe('ReviewGate', () => {
+  const tempDir = join(process.cwd(), 'temp-test-review-gate');
+  let gate: ReviewGate;
+
+  beforeAll(() => {
+    mkdirSync(tempDir, { recursive: true });
+    gate = new ReviewGate({ minReviewers: 1, requireApproval: true });
+    
+    // 初始化 git
+    try {
+      execSync('git init', { cwd: tempDir });
+      execSync('git config user.name "test"', { cwd: tempDir });
+      execSync('git config user.email "test@test.com"', { cwd: tempDir });
+      writeFileSync(join(tempDir, 'test.txt'), 'test');
+      execSync('git add .', { cwd: tempDir });
+      execSync('git commit -m "initial"', { cwd: tempDir });
+    } catch {
+      // git 可能不可用
+    }
+  });
+
+  afterAll(() => {
+    try {
+      rmSync(tempDir, { recursive: true, force: true });
+    } catch {
+      // ignore
+    }
+  });
+
+  describe('check', () => {
+    it('本地模式应该返回警告', async () => {
+      const result = await gate.check({
+        projectId: 'test-project',
+        projectPath: tempDir,
+      });
+      
+      expect(result.gate).toBe('review');
+      expect(result.passed).toBe(false);  // requireApproval=true
+      expect(result.message).toContain('本地模式');
+    });
+
+    it('禁用 requireApproval 应该通过', async () => {
+      const relaxedGate = new ReviewGate({ requireApproval: false });
+      
+      const result = await relaxedGate.check({
+        projectId: 'test-project',
+        projectPath: tempDir,
+      });
+      
+      expect(result.passed).toBe(true);
+      expect(result.message).toContain('审查要求未启用');
+    });
+  });
+
+  describe('配置', () => {
+    it('应该能设置最小审批人数', () => {
+      gate.setMinReviewers(2);
+      
+      const config = gate.getConfig();
+      expect(config.minReviewers).toBe(2);
+    });
+
+    it('应该能获取配置', () => {
+      const config = gate.getConfig();
+      
+      expect(config).toBeDefined();
+      expect(config.minReviewers).toBeDefined();
+      expect(config.requireApproval).toBeDefined();
+    });
+  });
+
+  describe('checkLocalGit', () => {
+    it('应该检查 git 状态', async () => {
+      const result = await gate.check({
+        projectId: 'test-project',
+        projectPath: tempDir,
+      });
+      
+      expect(result.details?.lastCommit).toBeDefined();
+    });
+  });
+});

package/src/__tests__/security-gate.test.ts

@@ -0,0 +1,100 @@
+/**
+ * SecurityGate 测试
+ */
+
+import { describe, it, expect, beforeAll, afterAll } from '@jest/globals';
+import { SecurityGate } from '../gates/security';
+import { mkdirSync, rmSync, writeFileSync } from 'fs';
+import { join } from 'path';
+
+describe('SecurityGate', () => {
+  const tempDir = join(process.cwd(), 'temp-test-security-gate');
+  let gate: SecurityGate;
+
+  beforeAll(() => {
+    mkdirSync(tempDir, { recursive: true });
+    
+    // 创建 package.json（无漏洞）
+    writeFileSync(join(tempDir, 'package.json'), JSON.stringify({
+      name: 'test-project',
+      dependencies: {},
+    }));
+    
+    gate = new SecurityGate({ enabled: true, severityThreshold: 'high' });
+  });
+
+  afterAll(() => {
+    try {
+      rmSync(tempDir, { recursive: true, force: true });
+    } catch {
+      // ignore
+    }
+  });
+
+  describe('scan', () => {
+    it('禁用时应该返回通过', async () => {
+      const disabledGate = new SecurityGate({ enabled: false });
+      
+      const result = await disabledGate.scan({
+        projectId: 'test-project',
+        projectPath: tempDir,
+      });
+      
+      expect(result.passed).toBe(true);
+      expect(result.message).toContain('安全门禁已禁用');
+    });
+
+    // 跳过：依赖真实 npm audit 结果，需要 mock 重构
+    it.skip('应该运行 npm audit', async () => {
+      const result = await gate.scan({
+        projectId: 'test-project',
+        projectPath: tempDir,
+      });
+      
+      expect(result.gate).toBe('security');
+      expect(result.details?.scanCommand).toBeDefined();
+    });
+
+    it.skip('应该返回漏洞分析', async () => {
+      const result = await gate.scan({
+        projectId: 'test-project',
+        projectPath: tempDir,
+      });
+      
+      expect(result.details).toBeDefined();
+      expect(result.details?.critical).toBeDefined();
+      expect(result.details?.high).toBeDefined();
+    });
+  });
+
+  describe('severityThreshold', () => {
+    it.skip('high 阈值应该检查 critical + high', async () => {
+      const result = await gate.scan({
+        projectId: 'test-project',
+        projectPath: tempDir,
+      });
+      
+      // 无漏洞时应该通过
+      expect(result.passed).toBe(true);
+    });
+
+    it('应该能设置严重程度阈值', () => {
+      gate.setSeverityThreshold('critical');
+      
+      const config = gate.getConfig();
+      expect(config.severityThreshold).toBe('critical');
+    });
+  });
+
+  describe('analyzeResult', () => {
+    it.skip('应该解析 npm audit JSON 或返回 passed', async () => {
+      const result = await gate.scan({
+        projectId: 'test-project',
+        projectPath: tempDir,
+      });
+      
+      // 无漏洞时可能没有 details.total
+      expect(result.passed).toBeDefined();
+    });
+  });
+});