@dolusoft/claude-collab 1.8.2 → 1.8.4

package/dist/cli.js

@@ -704,10 +704,17 @@ var HubManager = class {
     server.start(port);
     this.hubServer = server;
     this.currentPort = port;
-    await addFirewallRule(port);
     const advertiser = new MdnsAdvertiser();
     advertiser.start(port);
     this.advertiser = advertiser;
+    let firewallAdded = false;
+    try {
+      await addFirewallRule(port);
+      firewallAdded = true;
+    } catch (err) {
+      console.error("[hub-manager] firewall rule failed:", err);
+    }
+    return { firewallAdded };
   }
   async stop() {
     if (!this.isRunning) throw new Error("Hub is not running");
@@ -719,34 +726,51 @@ var HubManager = class {
     this.hubServer.stop();
     this.hubServer = null;
     this.currentPort = null;
-    await removeFirewallRule(port);
+    let firewallRemoved = false;
+    try {
+      await removeFirewallRule(port);
+      firewallRemoved = true;
+    } catch (err) {
+      console.error("[hub-manager] firewall rule removal failed:", err);
+    }
+    return { firewallRemoved };
   }
 };
-function runElevated(netshArgs) {
+function runElevated(argArray) {
+  const argList = argArray.map((a) => `"${a}"`).join(",");
+  const psCommand = `Start-Process -FilePath "netsh" -ArgumentList @(${argList}) -Verb RunAs -Wait`;
   return new Promise((resolve, reject) => {
-    const ps = spawn("powershell", [
-      "-NoProfile",
-      "-Command",
-      `Start-Process -FilePath "netsh" -ArgumentList "${netshArgs}" -Verb RunAs -Wait`
-    ]);
+    const ps = spawn("powershell", ["-NoProfile", "-Command", psCommand]);
     ps.on("close", (code) => {
       if (code === 0) resolve();
-      else reject(new Error(`Firewall command failed (exit code ${code}). User may have cancelled the UAC prompt.`));
+      else reject(new Error(`Firewall UAC prompt was cancelled or denied (exit code ${code}).`));
     });
     ps.on("error", (err) => {
-      reject(new Error(`Failed to launch PowerShell for firewall elevation: ${err.message}`));
+      reject(new Error(`Failed to launch PowerShell: ${err.message}`));
     });
   });
 }
 async function addFirewallRule(port) {
-  await runElevated(
-    `advfirewall firewall add rule name="claude-collab-${port}" protocol=TCP dir=in localport=${port} action=allow`
-  );
+  await runElevated([
+    "advfirewall",
+    "firewall",
+    "add",
+    "rule",
+    `name=claude-collab-${port}`,
+    "protocol=TCP",
+    "dir=in",
+    `localport=${port}`,
+    "action=allow"
+  ]);
 }
 async function removeFirewallRule(port) {
-  await runElevated(
-    `advfirewall firewall delete rule name="claude-collab-${port}"`
-  );
+  await runElevated([
+    "advfirewall",
+    "firewall",
+    "delete",
+    "rule",
+    `name=claude-collab-${port}`
+  ]);
 }
 var askSchema = {
   peer: z.string().describe('Name of the peer to ask (e.g., "alice", "backend")'),
@@ -923,15 +947,14 @@ function registerStartHubTool(server, client, hubManager) {
           }]
         };
       }
+      let firewallAdded = false;
       try {
-        await hubManager.start(port);
+        const result = await hubManager.start(port);
+        firewallAdded = result.firewallAdded;
       } catch (err) {
         const msg = err instanceof Error ? err.message : String(err);
         return {
-          content: [{
-            type: "text",
-            text: `Failed to start hub: ${msg}`
-          }]
+          content: [{ type: "text", text: `Failed to start hub: ${msg}` }]
         };
       }
       try {
@@ -939,22 +962,17 @@ function registerStartHubTool(server, client, hubManager) {
       } catch (err) {
         const msg = err instanceof Error ? err.message : String(err);
         return {
-          content: [{
-            type: "text",
-            text: `Hub started on port ${port}, but failed to self-connect: ${msg}`
-          }]
+          content: [{ type: "text", text: `Hub started on port ${port}, but failed to self-connect: ${msg}` }]
         };
       }
+      const lines = [
+        `Hub started on port ${port}.`,
+        firewallAdded ? `Firewall rule added (claude-collab-${port}) \u2014 LAN peers can connect.` : `WARNING: Firewall rule could not be added (UAC was cancelled or denied). Peers on other machines may be blocked by Windows Firewall. Run start_hub again and accept the UAC prompt to fix this.`,
+        `Others on the LAN will auto-discover and connect via mDNS.`,
+        `Use stop_hub when you are done.`
+      ];
       return {
-        content: [{
-          type: "text",
-          text: [
-            `Hub started on port ${port}.`,
-            `Firewall rule added (claude-collab-${port}).`,
-            `Others on the LAN will auto-discover and connect \u2014 no IP sharing needed.`,
-            `Use stop_hub when you are done to close the hub and remove the firewall rule.`
-          ].join("\n")
-        }]
+        content: [{ type: "text", text: lines.join("\n") }]
       };
     }
   );
@@ -976,26 +994,23 @@ function registerStopHubTool(server, hubManager) {
         };
       }
       const port = hubManager.port;
+      let firewallRemoved = false;
       try {
-        await hubManager.stop();
+        const result = await hubManager.stop();
+        firewallRemoved = result.firewallRemoved;
       } catch (err) {
         const msg = err instanceof Error ? err.message : String(err);
         return {
-          content: [{
-            type: "text",
-            text: `Failed to stop hub: ${msg}`
-          }]
+          content: [{ type: "text", text: `Failed to stop hub: ${msg}` }]
         };
       }
+      const lines = [
+        `Hub stopped (was on port ${port}).`,
+        firewallRemoved ? `Firewall rule removed (claude-collab-${port}).` : `WARNING: Firewall rule could not be removed (UAC was cancelled). Remove it manually: netsh advfirewall firewall delete rule name="claude-collab-${port}"`,
+        `All peers have been disconnected.`
+      ];
       return {
-        content: [{
-          type: "text",
-          text: [
-            `Hub stopped (was on port ${port}).`,
-            `Firewall rule removed (claude-collab-${port}).`,
-            `All peers have been disconnected.`
-          ].join("\n")
-        }]
+        content: [{ type: "text", text: lines.join("\n") }]
       };
     }
   );
@@ -1022,6 +1037,10 @@ async function startMcpServer(options) {
   await server.connect(transport);
 }
 var SERVICE_TYPE2 = "claude-collab";
+function resolveHost(svc) {
+  const ipv4 = svc.addresses?.find((a) => /^\d+\.\d+\.\d+\.\d+$/.test(a));
+  return ipv4 ?? svc.host;
+}
 function discoverHub(timeoutMs = 5e3) {
   return new Promise((resolve) => {
     const bonjour = new Bonjour();
@@ -1037,7 +1056,7 @@ function discoverHub(timeoutMs = 5e3) {
     };
     const timer = setTimeout(() => finish(null), timeoutMs);
     browser.on("up", (svc) => {
-      finish({ host: svc.host, port: svc.port });
+      finish({ host: resolveHost(svc), port: svc.port });
     });
   });
 }
@@ -1045,7 +1064,7 @@ function watchForHub(onFound) {
   const bonjour = new Bonjour();
   const browser = bonjour.find({ type: SERVICE_TYPE2 });
   browser.on("up", (svc) => {
-    onFound({ host: svc.host, port: svc.port });
+    onFound({ host: resolveHost(svc), port: svc.port });
   });
   return () => {
     browser.stop();