@doist/doistbot-cli 1.0.6 → 1.0.8

package/sandbox/dist/tasks/review/runner.js

@@ -1,8 +1,8 @@
 import { createHash } from 'crypto';
 import fs from 'fs';
 import { logger } from '../../core/logging.js';
-import { hasReviewProviderCredential } from '../../providers/credentials.js';
 import { runMultiFocusReviewEngine } from './engines/multi-focus.js';
+import { getEnabledReviewModels } from './engines/shared.js';
 import {} from './engines/types.js';
 import { buildAnnotatedDiff, buildDiffSection } from './diff.js';
 import { buildMultiFocusSharedPrompt } from './multi-focus-prompt.js';
@@ -49,9 +49,6 @@ function buildEnginePrompt({ input, diffSection, truncated, standardsSection, pr
         prompt: buildMultiFocusSharedPrompt(sharedPromptArgs),
     };
 }
-function getEnabledReviewModels({ apiKeys, reviewModelsEnabled, }) {
-    return reviewModelsEnabled.filter((model) => hasReviewProviderCredential(apiKeys[model]));
-}
 function getMissingRequiredReviewModels(availableModels, requiredReviewModels = []) {
     return requiredReviewModels.filter((model) => !availableModels.includes(model));
 }
@@ -92,10 +89,11 @@ export async function runSharedReview(input) {
             providerFailures: [],
         };
     }
-    const configuredAvailableModels = getEnabledReviewModels(input);
+    const configuredAvailableModels = getEnabledReviewModels(input.apiKeys, input.reviewModelsEnabled);
     if (configuredAvailableModels.length === 0) {
         logger.error('No enabled review models with API keys are available, skipping review', {
             review_models_enabled: input.reviewModelsEnabled,
+            review_focuses_enabled: input.reviewFocusesEnabled,
         });
         return {
             status: 'skipped',
@@ -110,6 +108,7 @@ export async function runSharedReview(input) {
     if (missingRequiredModels.length > 0) {
         logger.error('Required review models with API keys are unavailable, skipping review', {
             review_models_enabled: input.reviewModelsEnabled,
+            review_focuses_enabled: input.reviewFocusesEnabled,
             available_models: configuredAvailableModels,
             missing_required_models: missingRequiredModels,
         });
@@ -152,6 +151,11 @@ export async function runSharedReview(input) {
         workspaceDir: input.workspaceDir,
         apiKeys: input.apiKeys,
         reviewModelsEnabled: input.reviewModelsEnabled,
+        ...(input.reviewModelsByFocus ? { reviewModelsByFocus: input.reviewModelsByFocus } : {}),
+        ...(input.geminiFallbackFocuses
+            ? { geminiFallbackFocuses: input.geminiFallbackFocuses }
+            : {}),
+        ...(input.reviewSummaryModel ? { reviewSummaryModel: input.reviewSummaryModel } : {}),
         openRouterSessionId: buildOpenRouterReviewSessionId({
             owner: input.owner,
             repo: input.repo,
@@ -167,6 +171,7 @@ export async function runSharedReview(input) {
         prTitle: input.prTitle,
         prBody: input.prBody,
         lowPriorityFindingPlacement: input.lowPriorityFindingPlacement,
+        enabledFocuses: input.reviewFocusesEnabled,
         onProgress: input.onProgress,
     });
     if (availableModels.length === 0) {

package/sandbox/dist/tasks/review/summary-model.js

@@ -1,14 +1,14 @@
+import { SpanStatusCode } from '@opentelemetry/api';
 import { logger } from '../../core/logging.js';
-import { DEFAULT_OPENROUTER_MODELS, DEFAULT_PI_MODELS, invokePiPrompt, PI_PROVIDER_BY_DOISTBOT_PROVIDER, } from '../../core/pi.js';
+import { DEFAULT_GEMINI_FLASH_MODEL, DEFAULT_OPENROUTER_MODELS, DEFAULT_PI_MODELS, invokePiPrompt, PI_PROVIDER_BY_DOISTBOT_PROVIDER, } from '../../core/pi.js';
 import { WORKSPACE_DIR } from '../../core/shared.js';
+import { genAiProviderName, withPhase } from '../../core/tracing.js';
 import { resolveReviewProviderCredential } from '../../providers/credentials.js';
 import { extractJsonCandidatesFromResponse } from '../../providers/helpers.js';
 const REVIEW_SUMMARY_TIMEOUT_MS = 5 * 60 * 1000;
 const REVIEW_SUMMARY_THINKING_LEVEL = 'medium';
-const GEMINI_FLASH_SUMMARY_MODEL_BY_PI_PROVIDER = {
-    google: 'gemini-3-flash-preview',
-    openrouter: 'google/gemini-3-flash-preview',
-};
+// One model span per summary attempt; a fallback chain emits one span per model.
+const SUMMARY_PHASE = 'review.summary';
 const DIFF_SIDE = {
     LEFT: 'LEFT',
     RIGHT: 'RIGHT',
@@ -32,13 +32,10 @@ export function buildGeminiFlashReviewSummaryModel(credential) {
     if (!resolvedCredential) {
         return undefined;
     }
-    const piProviderId = resolvedCredential.piProviderId ?? 'google';
-    const modelName = GEMINI_FLASH_SUMMARY_MODEL_BY_PI_PROVIDER[piProviderId] ??
-        GEMINI_FLASH_SUMMARY_MODEL_BY_PI_PROVIDER.google;
     return {
         provider: 'gemini',
         credential,
-        modelName,
+        modelName: DEFAULT_GEMINI_FLASH_MODEL,
     };
 }
 function failedReviewSummaryRequest({ reason, error, timedOut, durationMs, outputChars, }) {
@@ -60,17 +57,42 @@ function getRequestFailureReason(result) {
         : 'request_failed';
 }
 export async function requestReviewSummary({ credential, provider = 'zai', modelName, prompt, workspaceDir, }) {
-    try {
-        const resolvedCredential = resolveReviewProviderCredential(credential);
-        if (!resolvedCredential) {
-            return failedReviewSummaryRequest({ reason: 'missing_credential' });
-        }
-        const resolvedModelName = modelName ?? resolvedCredential.modelName;
-        const logModelName = getReviewSummaryModelNameForLog({
+    const resolvedCredential = resolveReviewProviderCredential(credential);
+    if (!resolvedCredential) {
+        return failedReviewSummaryRequest({ reason: 'missing_credential' });
+    }
+    const resolvedModelName = modelName ?? resolvedCredential.modelName;
+    const logModelName = getReviewSummaryModelNameForLog({
+        provider,
+        piProviderId: resolvedCredential.piProviderId,
+        modelName: resolvedModelName,
+    });
+    // Span wraps the actual model invoke (after the credential check), so a
+    // missing-credential config error returns before any span and never shows a fake model attempt.
+    return withPhase(SUMMARY_PHASE, {
+        'gen_ai.operation.name': 'chat',
+        'gen_ai.provider.name': genAiProviderName(provider),
+        'gen_ai.request.model': logModelName,
+    }, async (span) => {
+        const result = await runReviewSummaryRequest({
             provider,
-            piProviderId: resolvedCredential.piProviderId,
-            modelName: resolvedModelName,
+            resolvedCredential,
+            resolvedModelName,
+            logModelName,
+            prompt,
+            workspaceDir,
         });
+        if (result.status === 'failed') {
+            span.setStatus({
+                code: SpanStatusCode.ERROR,
+                message: result.error ?? result.reason,
+            });
+        }
+        return result;
+    });
+}
+async function runReviewSummaryRequest({ provider, resolvedCredential, resolvedModelName, logModelName, prompt, workspaceDir, }) {
+    try {
         logger.info('Review summary model request', {
             provider,
             modelName: logModelName,

package/sandbox/node_modules/doistbot-repo-config/dist/index.d.ts

@@ -1,7 +1,7 @@
 import type { Logger } from 'doistbot-logging';
 import type { Octokit } from 'octokit';
 export declare const CONFIG_FILE_PATH = ".github/doistbot.yml";
-export declare const DEFAULT_REVIEW_MODELS: readonly ["gemini", "openai", "deepseek", "zai"];
+export declare const DEFAULT_REVIEW_MODELS: readonly ["openai", "deepseek", "zai"];
 export type DefaultReviewModel = (typeof DEFAULT_REVIEW_MODELS)[number];
 export type RepoConfig = {
     review?: {

package/sandbox/node_modules/doistbot-repo-config/dist/index.js

@@ -2,7 +2,7 @@ import fs from 'fs';
 import path from 'path';
 import { load as yamlLoad } from 'js-yaml';
 export const CONFIG_FILE_PATH = '.github/doistbot.yml';
-export const DEFAULT_REVIEW_MODELS = ['gemini', 'openai', 'deepseek', 'zai'];
+export const DEFAULT_REVIEW_MODELS = ['openai', 'deepseek', 'zai'];
 function parseRepoConfigContent(content) {
     return yamlLoad(content);
 }

package/sandbox/src/tasks/review/prompts/review-multi-focus-base-prompt.md

@@ -71,6 +71,7 @@ $DIFF_SECTION
 - Use one comment per distinct issue.
 - Ignore trivial style unless it obscures meaning or violates documented standards.
 - Keep code ranges tight and comments easy to understand without close reading.
+- **Do not flag dependency or tooling versions as nonexistent, outdated, or "too new."** Your training data has a cutoff, so you can't know which versions of GitHub Actions, npm/PyPI/etc. packages, or their APIs are currently published. Never tell the author a version doesn't exist, is wrong, or should be downgraded based on your own knowledge — and never claim a library feature or API is unavailable because you assume the project uses an older major version. Raise a version-related finding only when the diff or checked-out repo contains concrete contradicting evidence (e.g., the manifest/lockfile pins a different version, or the referenced symbol is absent from the dependency's actual source on disk).
 
 ## Writing Style