@doist/doistbot-cli 1.0.4 → 1.0.6

package/sandbox/dist/tasks/review/council/orchestrator.js

@@ -1,194 +0,0 @@
-/**
- * Orchestrator module for the multi-model code review council.
- * Coordinates parallel model reviews, normalization, and consensus voting.
- */
-import { logger } from '../../../core/logging.js';
-import { getProvider } from '../../../providers/index.js';
-import { REVIEW_SCHEMA } from '../../../providers/schemas.js';
-import { getReviewThinkingLevel } from '../thinking-level.js';
-import { normalizeFindings } from './normalizer.js';
-import { DeliveryProviderHealthTracker } from './provider-health.js';
-import { getApprovedFindings, runVoting } from './voter.js';
-/**
- * Runs a review with a single model.
- */
-async function runModelReview(model, prompt, apiKey, workspaceDir, onProgress) {
-    const provider = getProvider(model);
-    const config = {
-        apiKey,
-        workspaceDir,
-        jsonSchema: REVIEW_SCHEMA,
-        thinkingLevel: getReviewThinkingLevel(model),
-        onProgress,
-    };
-    return provider.review(prompt, config);
-}
-/**
- * Display names for models in review summaries.
- */
-const MODEL_DISPLAY_NAMES = {
-    gemini: 'GEMINI',
-    openai: 'CODEX',
-    anthropic: 'CLAUDE',
-};
-/**
- * Combines summaries from multiple models into a single summary.
- */
-function combineSummaries(results) {
-    const validSummaries = results
-        .filter((r) => !r.error && r.summary.trim())
-        .map((r) => `**${MODEL_DISPLAY_NAMES[r.model] || r.model.toUpperCase()}:** ${r.summary.trim()}`);
-    if (validSummaries.length === 0) {
-        return 'No valid summaries from any model.';
-    }
-    if (validSummaries.length === 1) {
-        // If only one model returned a valid summary, use it directly
-        return results.find((r) => !r.error && r.summary.trim())?.summary ?? '';
-    }
-    return validSummaries.join('\n\n---\n\n');
-}
-/**
- * Collects all findings from all model results.
- */
-function collectAllFindings(results) {
-    const allFindings = [];
-    for (const result of results) {
-        if (!result.error) {
-            allFindings.push(...result.findings);
-        }
-    }
-    return allFindings;
-}
-/**
- * Runs a full council review with multiple models, normalization, and voting.
- */
-export async function runCouncilReview({ prompt, apiKeys, repository, prNumber, workspaceDir, onProgress, }) {
-    const startTime = Date.now();
-    const providerHealth = new DeliveryProviderHealthTracker();
-    // Use all models that have API keys available
-    const modelsToUse = [];
-    if (apiKeys.gemini)
-        modelsToUse.push('gemini');
-    if (apiKeys.openai)
-        modelsToUse.push('openai');
-    if (apiKeys.anthropic)
-        modelsToUse.push('anthropic');
-    if (modelsToUse.length === 0) {
-        logger.error('No models available for council review', {
-            hasGeminiKey: Boolean(apiKeys.gemini),
-            hasOpenAIKey: Boolean(apiKeys.openai),
-            hasAnthropicKey: Boolean(apiKeys.anthropic),
-        });
-        return {
-            modelResults: [],
-            findingGroups: [],
-            consensusResults: [],
-            approvedFindings: [],
-            combinedSummary: 'No models available for review.',
-            totalDurationMs: Date.now() - startTime,
-            modelsUsed: [],
-            errors: [{ model: 'gemini', error: 'No models configured or API keys missing' }],
-        };
-    }
-    logger.info('Council review started', {
-        models: modelsToUse,
-        prNumber,
-        repository,
-    });
-    logger.info('Council models selected for review', { models: modelsToUse });
-    // Run all model reviews in parallel
-    const reviewPromises = modelsToUse.map((model) => {
-        const apiKey = apiKeys[model];
-        if (!apiKey) {
-            return Promise.resolve({
-                model,
-                summary: '',
-                findings: [],
-                error: `No API key for ${model}`,
-                durationMs: 0,
-            });
-        }
-        return runModelReview(model, prompt, apiKey, workspaceDir, onProgress);
-    });
-    const reviewResults = await Promise.allSettled(reviewPromises);
-    // Process results
-    const modelResults = [];
-    const errors = [];
-    reviewResults.forEach((result, index) => {
-        const model = modelsToUse[index];
-        if (result.status === 'fulfilled') {
-            modelResults.push(result.value);
-            if (result.value.error) {
-                errors.push({ model, error: result.value.error });
-                providerHealth.recordFailure({
-                    provider: model,
-                    stage: 'review',
-                    error: result.value.error,
-                    timedOut: result.value.timedOut,
-                });
-            }
-        }
-        else {
-            const error = result.reason instanceof Error ? result.reason.message : String(result.reason);
-            errors.push({ model, error });
-            modelResults.push({
-                model,
-                summary: '',
-                findings: [],
-                error,
-                durationMs: 0,
-            });
-        }
-    });
-    // Check if any models succeeded
-    const successfulModels = modelResults.filter((r) => !r.error);
-    if (successfulModels.length === 0) {
-        logger.error('All models failed in council review', { errors });
-        return {
-            modelResults,
-            findingGroups: [],
-            consensusResults: [],
-            approvedFindings: [],
-            combinedSummary: 'All models failed to review.',
-            totalDurationMs: Date.now() - startTime,
-            modelsUsed: [],
-            errors,
-        };
-    }
-    // Collect and normalize findings
-    const allFindings = collectAllFindings(modelResults);
-    onProgress?.({ type: 'council_findings_collected', findingCount: allFindings.length });
-    const findingGroups = normalizeFindings(allFindings);
-    onProgress?.({ type: 'council_consensus_check', findingGroupCount: findingGroups.length });
-    const successfulModelNames = successfulModels.map((result) => result.model);
-    // Run voting for consensus
-    const consensusResults = await runVoting({
-        findingGroups,
-        apiKeys,
-        workspaceDir,
-        availableModels: providerHealth.getHealthyProviders(successfulModelNames, {
-            stage: 'vote',
-        }),
-        providerHealth,
-    });
-    const approvedFindings = getApprovedFindings(consensusResults);
-    // Combine summaries
-    const combinedSummary = combineSummaries(modelResults);
-    const totalDurationMs = Date.now() - startTime;
-    logger.info('Council review completed', {
-        totalFindings: allFindings.length,
-        approvedFindings: approvedFindings.length,
-        modelsUsed: successfulModelNames,
-        totalDurationMs,
-    });
-    return {
-        modelResults,
-        findingGroups,
-        consensusResults,
-        approvedFindings,
-        combinedSummary,
-        totalDurationMs,
-        modelsUsed: successfulModelNames,
-        errors,
-    };
-}

package/sandbox/dist/tasks/review/council/provider-health.js

@@ -1,31 +0,0 @@
-import { logger } from '../../../core/logging.js';
-export class DeliveryProviderHealthTracker {
-    openCircuits = new Map();
-    getHealthyProviders(providers, { stage, findingId }) {
-        return providers.filter((provider) => {
-            const reason = this.openCircuits.get(provider);
-            if (!reason) {
-                return true;
-            }
-            logger.info('Council provider skipped due to open circuit', {
-                provider,
-                stage,
-                findingId,
-                reason,
-            });
-            return false;
-        });
-    }
-    recordFailure({ provider, stage, error, timedOut, findingId }) {
-        if (!timedOut || this.openCircuits.has(provider)) {
-            return;
-        }
-        this.openCircuits.set(provider, error);
-        logger.warn('Council provider circuit opened', {
-            provider,
-            stage,
-            findingId,
-            error,
-        });
-    }
-}

package/sandbox/dist/tasks/review/council/summary.js

@@ -1,192 +0,0 @@
-import { logger } from '../../../core/logging.js';
-import { formatPrAuthorForGreeting, normalizePrAuthor } from '../author-format.js';
-import { requestReviewSummary } from '../summary-model.js';
-export const MAX_SUMMARY_BODY_CHARS = 2000;
-const MAX_REVIEW_OBSERVATION_CHARS = 500;
-const REVIEW_SUMMARY_EMOJIS = ['😊', '😇', '🤗', '😄 🙌', '😎 👊'];
-const REVIEW_AUTHOR_PLACEHOLDER = 'PR_AUTHOR';
-const GENERIC_REVIEW_SUMMARY_GREETING = 'Thanks for your contribution.';
-function pickSummaryEmoji(prAuthor, seedContext) {
-    const normalizedAuthor = normalizePrAuthor(prAuthor);
-    const normalizedContext = seedContext?.trim();
-    const seed = [normalizedAuthor || 'doistbot-review', normalizedContext]
-        .filter(Boolean)
-        .join(':');
-    const hash = Array.from(seed).reduce((acc, char) => acc + char.charCodeAt(0), 0);
-    return REVIEW_SUMMARY_EMOJIS[hash % REVIEW_SUMMARY_EMOJIS.length];
-}
-function escapeRegExp(value) {
-    return value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-}
-function resolveAuthorGreetingName(prAuthor, prAuthorGreetingName) {
-    return formatPrAuthorForGreeting(prAuthorGreetingName) ?? formatPrAuthorForGreeting(prAuthor);
-}
-export function buildReviewSummaryGreeting(prAuthor, seedContext, prAuthorGreetingName, excludePrAuthorFromSummary = false) {
-    if (excludePrAuthorFromSummary) {
-        return '';
-    }
-    const authorForGreeting = resolveAuthorGreetingName(prAuthor, prAuthorGreetingName);
-    const emoji = pickSummaryEmoji(prAuthor, seedContext);
-    if (!authorForGreeting) {
-        return `Thanks for your contribution ${emoji}.`;
-    }
-    return `Thanks ${authorForGreeting} for your contribution ${emoji}.`;
-}
-export function withReviewSummaryGreeting(summary, prAuthor, prAuthorGreetingName, excludePrAuthorFromSummary = false) {
-    const trimmedSummary = summary.trim();
-    if (excludePrAuthorFromSummary) {
-        return trimmedSummary;
-    }
-    const greeting = buildReviewSummaryGreeting(prAuthor, trimmedSummary, prAuthorGreetingName, excludePrAuthorFromSummary);
-    return trimmedSummary ? `${greeting} ${trimmedSummary}` : greeting;
-}
-function splitOpeningLine(summary) {
-    const firstLineBreak = summary.indexOf('\n');
-    if (firstLineBreak === -1) {
-        return { openingLine: summary, remainingText: '' };
-    }
-    return {
-        openingLine: summary.slice(0, firstLineBreak),
-        remainingText: summary.slice(firstLineBreak),
-    };
-}
-function normalizeSummarySpacing(summary) {
-    return summary
-        .replace(/[ \t]{2,}/g, ' ')
-        .replace(/\s+([.!?,;:])/g, '$1')
-        .trimEnd();
-}
-function replaceUnsafeAuthorPlaceholder(summary) {
-    const placeholderPattern = escapeRegExp(REVIEW_AUTHOR_PLACEHOLDER);
-    const genericGreeting = GENERIC_REVIEW_SUMMARY_GREETING.replace(/[.!?]+$/, '');
-    return normalizeSummarySpacing(summary
-        .replace(new RegExp(`\\bThanks\\s+${placeholderPattern}(?=\\s+for\\b)`, 'g'), 'Thanks')
-        .replace(new RegExp(`\\bThanks\\s+${placeholderPattern}(?=[.!?])`, 'g'), genericGreeting)
-        .replace(new RegExp(`\\bThank you\\s+${placeholderPattern}(?=\\s+for\\b)`, 'g'), 'Thank you')
-        .replace(new RegExp(`\\bThank you\\s+${placeholderPattern}(?=[.!?])`, 'g'), 'Thank you for your contribution')
-        .split(REVIEW_AUTHOR_PLACEHOLDER)
-        .join('the contributor'));
-}
-function replaceAuthorPlaceholders(summary, greetingName) {
-    if (!summary.includes(REVIEW_AUTHOR_PLACEHOLDER)) {
-        return summary;
-    }
-    if (!greetingName) {
-        return replaceUnsafeAuthorPlaceholder(summary);
-    }
-    return summary.split(REVIEW_AUTHOR_PLACEHOLDER).join(greetingName);
-}
-function addEmojiToOpeningSentence(openingLine, emoji) {
-    const sentenceEndMatch = /[.!?](?=\s|$)/.exec(openingLine);
-    if (!sentenceEndMatch) {
-        return `${openingLine} ${emoji}`;
-    }
-    const sentenceEndIndex = sentenceEndMatch.index;
-    return `${openingLine.slice(0, sentenceEndIndex).trimEnd()} ${emoji}${openingLine.slice(sentenceEndIndex)}`;
-}
-export function ensureReviewSummaryApprovedEmoji(summary, prAuthor, prAuthorGreetingName, excludePrAuthorFromSummary = false) {
-    const trimmedSummary = summary.trim();
-    if (!trimmedSummary || excludePrAuthorFromSummary) {
-        return trimmedSummary;
-    }
-    const emoji = pickSummaryEmoji(prAuthor, trimmedSummary);
-    const greetingName = resolveAuthorGreetingName(prAuthor, prAuthorGreetingName);
-    const summaryWithAuthor = replaceAuthorPlaceholders(trimmedSummary, greetingName);
-    const { openingLine: firstLineWithAuthor, remainingText: finalRemainingText } = splitOpeningLine(summaryWithAuthor);
-    const firstLineWithEmoji = addEmojiToOpeningSentence(firstLineWithAuthor, emoji);
-    return firstLineWithEmoji + finalRemainingText;
-}
-export function buildCouncilSummaryPrompt({ prTitle, prBody, findings, excludePrAuthorFromSummary = false, reviewObservations = [], }) {
-    const safeTitle = prTitle.trim() || 'Untitled';
-    const safeAuthor = excludePrAuthorFromSummary ? 'unknown' : REVIEW_AUTHOR_PLACEHOLDER;
-    const safeBody = prBody.trim();
-    const condensedBody = safeBody
-        ? safeBody.slice(0, MAX_SUMMARY_BODY_CHARS)
-        : 'No PR description was provided.';
-    const findingsBlock = findings.length > 0
-        ? findings
-            .map((finding) => `<review-finding>\n${finding.trim()}\n</review-finding>`)
-            .join('\n\n')
-        : 'No issues were flagged in the inline comments.';
-    const observationsBlock = reviewObservations.length > 0
-        ? reviewObservations
-            .map((observation) => observation.trim())
-            .filter(Boolean)
-            .slice(0, 8)
-            .map((observation) => `<review-observation>\n${observation.slice(0, MAX_REVIEW_OBSERVATION_CHARS)}\n</review-observation>`)
-            .join('\n\n') || 'No additional review observations were captured.'
-        : 'No additional review observations were captured.';
-    return `You are an expert code review summarizer for the Doist engineering team.
-
-<pr_author>
-${safeAuthor}
-</pr_author>
-
-<pr_author_excluded_from_summary>
-${excludePrAuthorFromSummary ? 'true' : 'false'}
-</pr_author_excluded_from_summary>
-
-<pr_title>
-${safeTitle}
-</pr_title>
-
-<pr_description>
-${condensedBody}
-</pr_description>
-
-<review_findings>
-${findingsBlock}
-</review_findings>
-
-<review_observations>
-${observationsBlock}
-</review_observations>
-
-Write the complete GitHub review summary body for the PR author. Synthesize the findings into grouped themes—do not mirror every inline comment one-for-one or reference the reviewers, models, council, focus passes, or review observations. Do not mention issues not present in the <review-finding> blocks. If there are no <review-finding> blocks, state that no issues were flagged.
-
-If <pr_author_excluded_from_summary> is "true", do not thank, address, or name the PR author. Otherwise, start with a natural, concise thanks to the author using the literal placeholder ${REVIEW_AUTHOR_PLACEHOLDER}. Do not use a real user name, first name, login, handle, or @ mention. Vary the wording instead of always using the fixed template "Thanks ${REVIEW_AUTHOR_PLACEHOLDER} for your contribution".
-
-Do not include emojis in the summary. The caller will replace ${REVIEW_AUTHOR_PLACEHOLDER} locally and add one approved emoji after the author name for non-excluded PR authors.
-
-Structure:
-- Start with one short sentence. When the PR author is not excluded, include the thanks and ${REVIEW_AUTHOR_PLACEHOLDER} in that sentence. When the author is excluded, start with a concise overview of what changed.
-- If issues exist, add a blank line, then the exact heading "Few things worth tightening:", then 1-4 concise bullets grouping what to improve.
-- If no issues exist, do not add a heading or bullets.
-
-Keep it human and compact: the opener should be 1 sentence, or 2 only if the PR is large and the second sentence adds useful context. Use a kind, constructive, appreciative tone without generic praise. Bullets should be short fragments or single sentences, not paragraphs. Do not include any <review-finding> or <review-observation> tags in the output.
-
-Respond with only valid JSON in this exact shape:
-{"summary":"<your summary>","comments":[]}`;
-}
-export async function summarizeCouncilReviews({ apiKey, prTitle, prBody, findings, prAuthor, prAuthorGreetingName, excludePrAuthorFromSummary, reviewObservations, workspaceDir, requestReview = requestReviewSummary, }) {
-    const prompt = buildCouncilSummaryPrompt({
-        prTitle,
-        prBody,
-        findings,
-        prAuthor,
-        prAuthorGreetingName,
-        excludePrAuthorFromSummary,
-        reviewObservations,
-    });
-    logger.info('Summarizing council reviews with the review summary model', {
-        findingsCount: findings.length,
-        reviewObservationsCount: reviewObservations?.length ?? 0,
-    });
-    const result = await requestReview({ apiKey, prompt, workspaceDir });
-    const summary = result?.summary?.trim() ?? '';
-    if (!summary) {
-        logger.warn('Council summary model returned an empty summary', {
-            findingsCount: findings.length,
-        });
-        return null;
-    }
-    return ensureReviewSummaryApprovedEmoji(summary, prAuthor, prAuthorGreetingName, excludePrAuthorFromSummary);
-}
-export function buildFallbackSummary({ prTitle, findings, prAuthor, prAuthorGreetingName, excludePrAuthorFromSummary, }) {
-    const safeTitle = prTitle.trim();
-    const base = safeTitle ? `This PR updates ${safeTitle}.` : 'This PR updates the codebase.';
-    if (findings.length === 0) {
-        return withReviewSummaryGreeting(`${base} No issues were flagged in the reviewed diff.`, prAuthor, prAuthorGreetingName, excludePrAuthorFromSummary);
-    }
-    return withReviewSummaryGreeting(`${base}\n\nFew things worth tightening:\n- See the inline comments for the issues found in the review.`, prAuthor, prAuthorGreetingName, excludePrAuthorFromSummary);
-}

package/sandbox/dist/tasks/review/council/types.js

@@ -1,4 +0,0 @@
-/**
- * Types for the council (multi-model consensus) system.
- */
-export {};