@doist/doistbot-cli 1.0.10 → 1.0.12

package/sandbox/dist/tasks/review/engines/multi-focus.js

@@ -1,5 +1,6 @@
 import { SpanStatusCode } from '@opentelemetry/api';
 import { logger } from '../../../core/logging.js';
+import { toPiInvocationTelemetryFields } from '../../../core/pi.js';
 import { genAiProviderName, withPhase } from '../../../core/tracing.js';
 import { convertFindingsToComments } from '../comment-mapper.js';
 import { buildReviewOutputFindings } from '../finding-output.js';
@@ -7,16 +8,17 @@ import { buildMultiFocusPrompt, REVIEW_FOCUS_DEFINITIONS, } from '../multi-focus
 import { buildFallbackSummary, summarizeReviewFindings } from '../review-summary.js';
 import { parseSeverity } from '../severity.js';
 import { buildGeminiFlashReviewSummaryModel } from '../summary-model.js';
+import { filterTranslationSyncOnlyFindings } from '../translation-review-policy.js';
 import { dedupeMultiFocusFindings } from './dedupe.js';
 import { buildGeminiFlashCredential, getApiKeys, getAvailableModels, getEnabledReviewModels, getOpenRouterReviewCredential, getProviderFailures, requestModelReview, } from './shared.js';
 const DEFAULT_REVIEW_MODELS_BY_FOCUS = {
-    general: ['deepseek', 'grok', 'openai'],
-    security: ['deepseek', 'grok', 'openai'],
-    reuse: ['deepseek', 'grok', 'openai'],
-    quality: ['deepseek', 'grok', 'openai'],
-    efficiency: ['deepseek', 'grok', 'openai'],
-    tests: ['deepseek', 'grok'],
-    standards: ['deepseek', 'grok'],
+    general: ['deepseek', 'zai', 'openai'],
+    security: ['deepseek', 'zai', 'openai'],
+    reuse: ['deepseek', 'zai', 'openai'],
+    quality: ['deepseek', 'zai', 'openai'],
+    efficiency: ['deepseek', 'zai', 'openai'],
+    tests: ['deepseek', 'zai'],
+    standards: ['deepseek', 'zai'],
 };
 // Default Gemini-flash pass on failure. tests/standards keep no fallback unless
 // a caller opts into a wider fallback set.
@@ -28,7 +30,17 @@ const DEFAULT_GEMINI_FLASH_FALLBACK_FOCUSES = [
     'efficiency',
 ];
 // Open models whose failed pass triggers that fallback.
-const GEMINI_FLASH_FALLBACK_MODELS = ['deepseek', 'grok'];
+const GEMINI_FLASH_FALLBACK_MODELS = ['deepseek', 'zai'];
+function setReviewLatencyAttributes(span, result) {
+    const telemetry = result.telemetry;
+    if (!telemetry)
+        return;
+    const attributes = Object.fromEntries(Object.entries(toPiInvocationTelemetryFields(telemetry)).map(([name, value]) => [
+        `review.${name}`,
+        value,
+    ]));
+    span.setAttributes(attributes);
+}
 function lowPrioritySummaryNotice(count) {
     return count === 1
         ? 'I also left one optional follow-up note in the details below.'
@@ -60,6 +72,9 @@ async function runFocusPass({ focus, model, basePrompt, standardsSection, apiKey
         if (result?.requestModel) {
             span.setAttributes({ 'gen_ai.request.model': result.requestModel });
         }
+        if (result) {
+            setReviewLatencyAttributes(span, result);
+        }
         if (!result) {
             const error = `No review result returned for ${model}`;
             span.setStatus({ code: SpanStatusCode.ERROR, message: error });
@@ -326,8 +341,26 @@ export async function runMultiFocusReviewEngine({ ctx, prompt, lineLookup, prTit
                 providerFailures,
             };
         }
-        const allFindings = successfulRuns.flatMap((run) => run.findings);
-        const reviewObservations = collectReviewObservations(successfulRuns);
+        const modelFindings = successfulRuns.flatMap((run) => run.findings);
+        const { findings: allFindings, droppedFindings: translationSyncFindings } = filterTranslationSyncOnlyFindings({
+            repoOwner: ctx.owner,
+            repoName: ctx.repo,
+            findings: modelFindings,
+        });
+        if (translationSyncFindings.length > 0) {
+            logger.info('Filtered translation sync-only findings', {
+                repository: `${ctx.owner}/${ctx.repo}`,
+                droppedCount: translationSyncFindings.length,
+                droppedFindingIds: translationSyncFindings.map((finding) => finding.id),
+            });
+        }
+        const suppressedFindings = new Set(translationSyncFindings);
+        const reviewObservationRuns = successfulRuns.map((run) => {
+            const hasSuppressedFinding = run.findings.some((finding) => suppressedFindings.has(finding));
+            const hasKeptFinding = run.findings.some((finding) => !suppressedFindings.has(finding));
+            return hasSuppressedFinding && !hasKeptFinding ? { ...run, summary: '' } : run;
+        });
+        const reviewObservations = collectReviewObservations(reviewObservationRuns);
         let dedupedFindings = allFindings;
         try {
             dedupedFindings = await dedupeMultiFocusFindings({
@@ -347,7 +380,7 @@ export async function runMultiFocusReviewEngine({ ctx, prompt, lineLookup, prTit
         const routedFindings = routeLowPriorityFindings(dedupedFindings, lowPriorityFindingPlacement);
         const geminiSummaryFallback = buildGeminiFlashReviewSummaryModel(apiKeys.gemini);
         const summaryModel = ctx.reviewSummaryModel ??
-            (apiKeys.grok ? { provider: 'grok', credential: apiKeys.grok } : undefined);
+            (apiKeys.zai ? { provider: 'zai', credential: apiKeys.zai } : undefined);
         const review = await buildMultiFocusReviewOutput({
             inlineFindings: routedFindings.inlineFindings,
             summaryFindings: routedFindings.summaryFindings,
@@ -366,7 +399,9 @@ export async function runMultiFocusReviewEngine({ ctx, prompt, lineLookup, prTit
             supportModels: allAvailableModels,
             focuses: focusDefinitions.map((focus) => focus.name),
             successfulRuns: successfulRuns.length,
-            findingsCount: allFindings.length,
+            findingsCount: modelFindings.length,
+            findingsAfterPolicyCount: allFindings.length,
+            translationSyncFindingsCount: translationSyncFindings.length,
             dedupedFindingsCount: dedupedFindings.length,
             inlineFindingsCount: routedFindings.inlineFindings.length,
             summaryOnlyFindingsCount: routedFindings.summaryFindings.length,

package/sandbox/dist/tasks/review/local-git.js

@@ -1,14 +1,36 @@
 import { execFileSync } from 'child_process';
 import os from 'os';
 import path from 'path';
-import {} from './diff.js';
+import { MAX_DIFF_CHARS } from './diff.js';
 const GIT_MAX_BUFFER_BYTES = 50 * 1024 * 1024;
 export function createGitRunner(workspaceDir) {
-    return (args) => execFileSync('git', ['-C', workspaceDir, '-c', 'core.quotePath=false', ...args], {
-        encoding: 'utf8',
-        maxBuffer: GIT_MAX_BUFFER_BYTES,
-        stdio: ['ignore', 'pipe', 'pipe'],
-    });
+    return (args, options) => {
+        try {
+            return execFileSync('git', ['-C', workspaceDir, '-c', 'core.quotePath=false', ...args], {
+                encoding: 'utf8',
+                maxBuffer: options?.maxBufferBytes ?? GIT_MAX_BUFFER_BYTES,
+                stdio: ['ignore', 'pipe', 'pipe'],
+            });
+        }
+        catch (error) {
+            const failure = error;
+            const stdout = typeof failure.stdout === 'string'
+                ? failure.stdout
+                : Buffer.isBuffer(failure.stdout)
+                    ? failure.stdout.toString('utf8')
+                    : '';
+            if (failure.code === 'ENOBUFS' &&
+                options?.returnPartialOutputOnMaxBuffer === true &&
+                options.maxBufferBytes !== undefined) {
+                return stdout.slice(0, options.maxBufferBytes);
+            }
+            if (typeof failure.status === 'number' &&
+                options?.allowedExitCodes?.includes(failure.status)) {
+                return stdout;
+            }
+            throw error;
+        }
+    };
 }
 export function tryGit(runner, args) {
     try {
@@ -75,7 +97,7 @@ function unquoteGitPath(rawPath) {
             unquoted = trimmed.slice(1, -1);
         }
     }
-    return unquoted.replace(/^[ab]\//, '');
+    return unquoted.replace(/^[ab]\//, '').replace(/^\.\//, '');
 }
 function readDiffGitPath(input, startIndex) {
     let index = startIndex;
@@ -162,6 +184,38 @@ export function parseGitDiffToFiles(diff) {
     flushCurrent();
     return files;
 }
+function getUntrackedReviewFiles(runner) {
+    const untrackedPaths = runner(['ls-files', '--others', '--exclude-standard', '-z'])
+        .split('\0')
+        .filter(Boolean);
+    if (untrackedPaths.length === 0) {
+        return [];
+    }
+    const files = [];
+    let remainingDiffChars = MAX_DIFF_CHARS;
+    for (const filename of untrackedPaths) {
+        if (remainingDiffChars <= 0) {
+            break;
+        }
+        // The two-file form also works with Git versions before 2.51.
+        const diff = runner([
+            'diff',
+            '--no-index',
+            '--no-ext-diff',
+            '--no-color',
+            '--',
+            '/dev/null',
+            `./${filename}`,
+        ], {
+            allowedExitCodes: [1],
+            maxBufferBytes: remainingDiffChars,
+            returnPartialOutputOnMaxBuffer: true,
+        });
+        files.push(...parseGitDiffToFiles(diff));
+        remainingDiffChars -= diff.length;
+    }
+    return files;
+}
 export function getLocalReviewFiles({ runner, source, }) {
     if (source === 'staged') {
         const diff = runner(['diff', '--staged', '--no-ext-diff', '--no-color']);
@@ -183,7 +237,7 @@ export function getLocalReviewFiles({ runner, source, }) {
     const mergeBase = runner(['merge-base', baseBranch, 'HEAD']).trim();
     const diff = runner(['diff', '--no-ext-diff', '--no-color', mergeBase]);
     return {
-        files: parseGitDiffToFiles(diff),
+        files: [...parseGitDiffToFiles(diff), ...getUntrackedReviewFiles(runner)],
         baseBranch,
     };
 }

package/sandbox/dist/tasks/review/prompt.js

@@ -2,6 +2,7 @@ import fs from 'fs';
 import path from 'path';
 import { fileURLToPath } from 'url';
 import { logger } from '../../core/logging.js';
+import { buildTranslationReviewGuidance } from './translation-review-policy.js';
 const MAX_BODY_CHARS = 4000;
 let cachedStandardsSection = null;
 const REVIEW_TASK_DIR = path.dirname(fileURLToPath(import.meta.url));
@@ -75,5 +76,6 @@ export function buildReviewPromptVariables({ repoOwner, repoName, prNumber, prTi
         PR_CONVERSATION: formatPrConversation(prConversation),
         DIFF_SECTION: fullDiffSection,
         STANDARDS_SECTION: standardsSection,
+        TRANSLATION_REVIEW_GUIDANCE: buildTranslationReviewGuidance(repoOwner, repoName),
     };
 }

package/sandbox/dist/tasks/review/review-summary.js

@@ -51,7 +51,7 @@ Keep it human and compact: the opener should be 1 sentence, or 2 only if the PR
 Respond with only valid JSON in this exact shape:
 {"summary":"<your summary>","comments":[]}`;
 }
-export async function summarizeReviewFindings({ credential, provider = 'grok', modelName, fallbackModels = [], prTitle, prBody, findings, reviewObservations, workspaceDir, requestReview = requestReviewSummary, }) {
+export async function summarizeReviewFindings({ credential, provider = 'zai', modelName, fallbackModels = [], prTitle, prBody, findings, reviewObservations, workspaceDir, requestReview = requestReviewSummary, }) {
     const prompt = buildReviewSummaryPrompt({
         prTitle,
         prBody,

package/sandbox/dist/tasks/review/summary-model.js

@@ -56,7 +56,7 @@ function getRequestFailureReason(result) {
         ? 'no_assistant_response'
         : 'request_failed';
 }
-export async function requestReviewSummary({ credential, provider = 'grok', modelName, prompt, workspaceDir, }) {
+export async function requestReviewSummary({ credential, provider = 'zai', modelName, prompt, workspaceDir, }) {
     const resolvedCredential = resolveReviewProviderCredential(credential);
     if (!resolvedCredential) {
         return failedReviewSummaryRequest({ reason: 'missing_credential' });
@@ -93,7 +93,7 @@ export async function requestReviewSummary({ credential, provider = 'grok', mode
 }
 async function runReviewSummaryRequest({ provider, resolvedCredential, resolvedModelName, logModelName, prompt, workspaceDir, }) {
     try {
-        const thinkingLevel = provider === 'grok' ? 'high' : DEFAULT_REVIEW_SUMMARY_THINKING_LEVEL;
+        const thinkingLevel = provider === 'zai' ? 'high' : DEFAULT_REVIEW_SUMMARY_THINKING_LEVEL;
         logger.info('Review summary model request', {
             provider,
             modelName: logModelName,

package/sandbox/dist/tasks/review/translation-review-policy.js

@@ -0,0 +1,37 @@
+const ENGLISH_SOURCE_FIRST_REPOSITORIES = new Set([
+    'doist/todoist-web',
+    'doist/todoist-android',
+    'doist/todoist-ios',
+    'doist/todoist-electron',
+    'doist/todoist-macos',
+]);
+export function usesEnglishSourceFirstTranslations(repoOwner, repoName) {
+    return ENGLISH_SOURCE_FIRST_REPOSITORIES.has(`${repoOwner}/${repoName}`.toLowerCase());
+}
+export function buildTranslationReviewGuidance(repoOwner, repoName) {
+    if (!usesEnglishSourceFirstTranslations(repoOwner, repoName)) {
+        return '';
+    }
+    return `## Repository-specific Translation Workflow
+
+This repository uses an English-source-first workflow: feature PRs change the English source strings, automation sends them to the repository's translation service, and translated locale files arrive through a later automated sync.
+
+- Do not create a finding or summary note merely because translated locale files or generated locale bundles are unchanged in the feature PR.
+- Do not ask the author to pull, update, generate, or commit translations manually. If the PR description already mentions the translation-service follow-up, including Transifex, do not repeat it.
+- Continue to report concrete i18n implementation errors introduced by the diff, such as incorrect translation API or gettext usage, broken interpolation placeholders, pluralization or context mistakes, and patterns that prevent source-string extraction.`;
+}
+export function isTranslationSyncOnlyFinding(repoOwner, repoName, finding) {
+    return (usesEnglishSourceFirstTranslations(repoOwner, repoName) &&
+        finding.translationResolution === 'automated_sync_resolves');
+}
+export function filterTranslationSyncOnlyFindings({ repoOwner, repoName, findings, }) {
+    const keptFindings = [];
+    const droppedFindings = [];
+    for (const finding of findings) {
+        const destination = isTranslationSyncOnlyFinding(repoOwner, repoName, finding)
+            ? droppedFindings
+            : keptFindings;
+        destination.push(finding);
+    }
+    return { findings: keptFindings, droppedFindings };
+}

package/sandbox/node_modules/doistbot-repo-config/dist/index.d.ts

@@ -1,7 +1,7 @@
 import type { Logger } from 'doistbot-logging';
 import type { Octokit } from 'octokit';
 export declare const CONFIG_FILE_PATH = ".github/doistbot.yml";
-export declare const DEFAULT_REVIEW_MODELS: readonly ["openai", "deepseek", "grok"];
+export declare const DEFAULT_REVIEW_MODELS: readonly ["openai", "deepseek", "zai"];
 export type DefaultReviewModel = (typeof DEFAULT_REVIEW_MODELS)[number];
 export type RepoConfig = {
     review?: {

package/sandbox/node_modules/doistbot-repo-config/dist/index.js

@@ -2,7 +2,7 @@ import fs from 'fs';
 import path from 'path';
 import { load as yamlLoad } from 'js-yaml';
 export const CONFIG_FILE_PATH = '.github/doistbot.yml';
-export const DEFAULT_REVIEW_MODELS = ['openai', 'deepseek', 'grok'];
+export const DEFAULT_REVIEW_MODELS = ['openai', 'deepseek', 'zai'];
 function parseRepoConfigContent(content) {
     return yamlLoad(content);
 }

package/sandbox/src/tasks/review/prompts/review-multi-focus-base-prompt.md

@@ -73,6 +73,8 @@ $DIFF_SECTION
 - Keep code ranges tight and comments easy to understand without close reading.
 - **Do not flag dependency or tooling versions as nonexistent, outdated, or "too new."** Your training data has a cutoff, so you can't know which versions of GitHub Actions, npm/PyPI/etc. packages, or their APIs are currently published. Never tell the author a version doesn't exist, is wrong, or should be downgraded based on your own knowledge — and never claim a library feature or API is unavailable because you assume the project uses an older major version. Raise a version-related finding only when the diff or checked-out repo contains concrete contradicting evidence (e.g., the manifest/lockfile pins a different version, or the referenced symbol is absent from the dependency's actual source on disk).
 
+$TRANSLATION_REVIEW_GUIDANCE
+
 ## Writing Style
 
 - Write clearly, concisely, and directly. Be engaging without sounding generic.
@@ -97,6 +99,20 @@ At the beginning of each finding title, tag it with a priority level:
 
 ## Output Format
 
+For every finding, answer this internal classification question: assuming the repository's normal
+translation automation completes successfully, would the issue be fully resolved without changing
+application code, source-string keys, extraction configuration, lookup behavior, placeholders,
+pluralization, or locale context?
+
+- Use `automated_sync_resolves` only when the answer is clearly yes.
+- Use `code_change_required_or_uncertain` for all non-translation findings, concrete i18n
+  correctness problems, and any uncertain case.
+- Keep this classification out of the finding body.
+- Missing or stale translated content, requests to pull or commit locale artifacts, and advice to
+  wait for the automated sync are `automated_sync_resolves` when no code-level problem remains.
+- Broken extraction, keys, lookups, placeholders, pluralization, or locale handling are
+  `code_change_required_or_uncertain`, even when their symptom is a missing translation.
+
 Return strict JSON in this exact shape:
 
 ```json
@@ -107,7 +123,8 @@ Return strict JSON in this exact shape:
             "path": "relative file path exactly as shown in the diff above",
             "line": 42,
             "side": "RIGHT",
-            "body": "[P2] Brief description of the issue and actionable fix."
+            "body": "[P2] Brief description of the issue and actionable fix.",
+            "translationResolution": "code_change_required_or_uncertain"
         }
     ]
 }