@dogfood-lab/findings 1.8.0 → 1.9.0

package/cli.js

@@ -45,7 +45,8 @@ import {
   performAction,
   performMerge,
   getReviewQueue,
-  getEventsForFinding
+  getEventsForFinding,
+  EDITABLE_FIELDS
 } from './review/index.js';
 import {
   reviewArtifact,
@@ -291,7 +292,8 @@ Commands:
   accept <id>          Accept a finding (--actor, --reason)
   reject <id>          Reject a finding (--actor, --reason, --reject-reason)
   review <id>          Move finding to reviewed (--actor)
-  edit <id>            Edit finding fields (--actor, --set field=value)
+  edit <id>            Edit finding fields (--actor, --set field=value).
+                       Editable fields: ${EDITABLE_FIELDS.join(', ')}.
   merge <ids...>       Merge findings (--into <id>, --actor, --reason)
   reopen <id>          Reopen a rejected/accepted finding (--actor, --reason)
   invalidate <id>      Invalidate an accepted finding (--actor, --reason)
@@ -744,6 +746,7 @@ Structured output:
     const findingId = positional[0];
     if (!findingId) {
       console.error('Usage: dogfood findings edit <finding_id> --actor <name> --set field=value [--set field=value]');
+      console.error(`Editable fields: ${EDITABLE_FIELDS.join(', ')}`);
       process.exit(2);
     }
     // Parse --set flags
@@ -1323,6 +1326,20 @@ Structured output:
 }
 
 main().catch(err => {
-  console.error(err);
+  // F-26179cb8 (Stage C humanization): render the repo-wide structured envelope
+  // sibling bins use (report/cli.js emitError, report/init.js) instead of
+  // dumping the raw Error/stack. The raw stack is a triage aid, not a default —
+  // it stays behind DEBUG so a mis-rooted checkout or an un-caught throw gives
+  // the operator `ERROR [<CODE>]:` + a next step, not a bare Node stack.
+  const code = err && err.code ? err.code : 'UNEXPECTED';
+  const message = err && err.message ? err.message : String(err);
+  console.error(`ERROR [${code}]: ${message}`);
+  console.error(
+    '  Next: run from the testing-os repo root, or set FINDINGS_REPO_ROOT to it; ' +
+    'run `dogfood findings --help` for usage. Re-run with DEBUG=1 for the stack.'
+  );
+  if (process.env.DEBUG && err && err.stack) {
+    console.error(err.stack);
+  }
   process.exit(2);
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dogfood-lab/findings",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "type": "module",
   "description": "Finding contract spine for testing-os. Validates, reads, lists, and queries evidence-bound findings — the fourth contract alongside record, scenario, and policy.",
   "main": "index.js",
@@ -18,7 +18,7 @@
     "findings": "./cli.js"
   },
   "scripts": {
-    "test": "node --test findings.test.js derive/derive.test.js derive/load-records-skip.test.js derive/d2b-008-collision-guard.test.js derive/d2b-002-write-schema-gate.test.js review/review.test.js review/event-log-loader.test.js review/h4-engine-auto-reject-reason.test.js review/featF-intel-001-review-artifacts.test.js review/featF-intel-001-cli.test.js synthesis/synthesis.test.js synthesis/loaders-skip.test.js synthesis/d2b-001-derive-skipped-signal.test.js synthesis/featF-intel-002-preserve-operator-status.test.js synthesis/featF-intel-003-apply-recommendation.test.js advise/advise.test.js lib/atomic-write.test.js lib/safe-yaml-load.test.js lib/d1b-002-findings-sleepsync.test.js"
+    "test": "node --test"
   },
   "files": [
     "index.js",

package/review/index.js

@@ -3,4 +3,4 @@
  */
 export { isLawfulTransition, validateTransition, ACTION_TARGET_STATUS, REASON_REQUIRED } from './transitions.js';
 export { createEvent, appendEvent, getEventsForFinding, getAllEvents, getLogPath, generateEventId } from './event-log.js';
-export { performAction, performMerge, getReviewQueue } from './review-engine.js';
+export { performAction, performMerge, getReviewQueue, EDITABLE_FIELDS } from './review-engine.js';

package/review/review-engine.js

@@ -15,6 +15,29 @@ import { parseFinding, validateFinding } from '../validate.js';
 import { findById, loadFindings } from '../reader.js';
 import { atomicWriteFileSync } from '../lib/atomic-write.js';
 
+/**
+ * The prose + classification fields an operator may safely target with
+ * `edit --set field=value`. This is the human-facing subset of the finding
+ * contract: free-text prose and the four classification enums. Identity,
+ * lineage, and evidence fields (finding_id, schema_version, source_record_ids,
+ * evidence, status, …) are excluded — they are set by the pipeline, not edited
+ * in place. The downstream write gate (dogfood-finding.schema.json's
+ * additionalProperties:false + enum checks) is the enforcement boundary; this
+ * list is what the CLI help renders so the documented set and the gate's
+ * intent share one source. Editing an unlisted field is still refused post-hoc
+ * by the schema gate — this constant narrows the help, not the enforcement.
+ */
+export const EDITABLE_FIELDS = Object.freeze([
+  'title',
+  'summary',
+  'doctrine_statement',
+  'notes',
+  'issue_kind',
+  'root_cause_kind',
+  'remediation_kind',
+  'transfer_scope'
+]);
+
 /**
  * Perform a review action on a finding.
  *