@docusaurus/theme-classic 0.0.0-4435 → 0.0.0-4436

package/lib/index.js

@@ -101,8 +101,7 @@ function getInfimaCSSFile(direction) {
   return `infima/dist/css/default/default${direction === 'rtl' ? '-rtl' : ''}.css`;
 }
 
-function docusaurusThemeClassic(context, // TODO: LoadContext is missing some of properties
-options) {
+function docusaurusThemeClassic(context, options) {
   const {
     siteConfig: {
       themeConfig: roughlyTypedThemeConfig

package/lib-next/theme/CodeBlock/index.js

@@ -37,9 +37,9 @@ export default function CodeBlock({
 
   useEffect(() => {
     setMounted(true);
-  }, []); // TODO: the title is provided by MDX as props automatically
-  // so we probably don't need to parse the metastring
-  // (note: title="xyz" => title prop still has the quotes)
+  }, []); // We still parse the metastring in case we want to support more syntax in the
+  // future. Note that MDX doesn't strip quotes when parsing metastring:
+  // "title=\"xyz\"" => title: "\"xyz\""
 
   const codeBlockTitle = parseCodeBlockTitle(metastring) || title;
   const prismTheme = usePrismTheme(); // <pre> tags in markdown map to CodeBlocks and they may contain JSX children.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@docusaurus/theme-classic",
-  "version": "0.0.0-4435",
+  "version": "0.0.0-4436",
   "description": "Classic theme for Docusaurus",
   "main": "lib/index.js",
   "types": "src/theme-classic.d.ts",
@@ -23,14 +23,14 @@
     "update-code-translations": "node -e 'require(\"./update-code-translations.js\").run()'"
   },
   "dependencies": {
-    "@docusaurus/core": "0.0.0-4435",
-    "@docusaurus/plugin-content-blog": "0.0.0-4435",
-    "@docusaurus/plugin-content-docs": "0.0.0-4435",
-    "@docusaurus/plugin-content-pages": "0.0.0-4435",
-    "@docusaurus/theme-common": "0.0.0-4435",
-    "@docusaurus/theme-translations": "0.0.0-4435",
-    "@docusaurus/utils": "0.0.0-4435",
-    "@docusaurus/utils-validation": "0.0.0-4435",
+    "@docusaurus/core": "0.0.0-4436",
+    "@docusaurus/plugin-content-blog": "0.0.0-4436",
+    "@docusaurus/plugin-content-docs": "0.0.0-4436",
+    "@docusaurus/plugin-content-pages": "0.0.0-4436",
+    "@docusaurus/theme-common": "0.0.0-4436",
+    "@docusaurus/theme-translations": "0.0.0-4436",
+    "@docusaurus/utils": "0.0.0-4436",
+    "@docusaurus/utils-validation": "0.0.0-4436",
     "@mdx-js/mdx": "^1.6.21",
     "@mdx-js/react": "^1.6.21",
     "clsx": "^1.1.1",
@@ -45,8 +45,8 @@
     "rtlcss": "^3.3.0"
   },
   "devDependencies": {
-    "@docusaurus/module-type-aliases": "0.0.0-4435",
-    "@docusaurus/types": "0.0.0-4435",
+    "@docusaurus/module-type-aliases": "0.0.0-4436",
+    "@docusaurus/types": "0.0.0-4436",
     "@types/mdx-js__react": "^1.5.4",
     "@types/parse-numeric-range": "^0.0.1",
     "@types/rtlcss": "^3.1.1",
@@ -61,5 +61,5 @@
   "engines": {
     "node": ">=14"
   },
-  "gitHead": "41656dfd8207e4a9d80de20fa5d9591f197a12b6"
+  "gitHead": "3b2e15935a716c69bd530fe10942e1620b36ddc4"
 }

package/src/index.ts

@@ -5,11 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import type {
-  DocusaurusContext,
-  Plugin,
-  PostCssOptions,
-} from '@docusaurus/types';
+import type {LoadContext, Plugin, PostCssOptions} from '@docusaurus/types';
 import type {ThemeConfig} from '@docusaurus/theme-common';
 import {getTranslationFiles, translateThemeConfig} from './translations';
 import path from 'path';
@@ -95,7 +91,7 @@ function getInfimaCSSFile(direction: string) {
 }
 
 export default function docusaurusThemeClassic(
-  context: DocusaurusContext, // TODO: LoadContext is missing some of properties
+  context: LoadContext,
   options: Options,
 ): Plugin<void> {
   const {

package/src/theme/CodeBlock/index.tsx

@@ -44,9 +44,9 @@ export default function CodeBlock({
     setMounted(true);
   }, []);
 
-  // TODO: the title is provided by MDX as props automatically
-  // so we probably don't need to parse the metastring
-  // (note: title="xyz" => title prop still has the quotes)
+  // We still parse the metastring in case we want to support more syntax in the
+  // future. Note that MDX doesn't strip quotes when parsing metastring:
+  // "title=\"xyz\"" => title: "\"xyz\""
   const codeBlockTitle = parseCodeBlockTitle(metastring) || title;
   const prismTheme = usePrismTheme();
 

package/src/theme/NavbarItem/index.tsx

@@ -16,7 +16,7 @@ import type {Types, Props} from '@theme/NavbarItem';
 
 const NavbarItemComponents: Record<
   Exclude<Types, undefined>,
-  // TODO: properly type this
+  // Not really worth typing, as we pass all props down immediately
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   () => (props: any) => JSX.Element
 > = {