@docusaurus/theme-classic 0.0.0-4304 → 0.0.0-4305

package/lib/translations.js

@@ -69,14 +69,14 @@ function translateNavbar(navbar, navbarTranslations) {
 }
 
 function isMultiColumnFooterLinks(links) {
-  return 'title' in links[0];
+  return links.length > 0 && 'title' in links[0];
 }
 
 function getFooterTranslationFile(footer) {
-  const footerLinkTitles = isMultiColumnFooterLinks(footer.links) ? (0, _lodash.chain)(footer.links.filter(link => !!link.title)).keyBy(link => `link.title.${link.title}`).mapValues(link => ({
+  const footerLinkTitles = (0, _lodash.chain)(isMultiColumnFooterLinks(footer.links) ? footer.links.filter(link => !!link.title) : []).keyBy(link => `link.title.${link.title}`).mapValues(link => ({
     message: link.title,
     description: `The title of the footer links column with title=${link.title} in the footer`
-  })).value() : {};
+  })).value();
   const footerLinkLabels = (0, _lodash.chain)(isMultiColumnFooterLinks(footer.links) ? footer.links.flatMap(link => link.items).filter(link => !!link.label) : footer.links.filter(link => !!link.label)).keyBy(linkItem => `link.item.label.${linkItem.label}`).mapValues(linkItem => {
     var _linkItem$to;
 

package/lib/validateThemeConfig.js

@@ -263,9 +263,9 @@ const ThemeConfigSchema = _utilsValidation.Joi.object({
     links: _utilsValidation.Joi.alternatives(_utilsValidation.Joi.array().items(_utilsValidation.Joi.object({
       title: _utilsValidation.Joi.string().allow(null).default(null),
       items: _utilsValidation.Joi.array().items(FooterLinkItemSchema).default([])
-    })).default([]), _utilsValidation.Joi.array().items(FooterLinkItemSchema).default([])).messages({
+    })), _utilsValidation.Joi.array().items(FooterLinkItemSchema)).messages({
       'alternatives.match': `The footer must be either simple or multi-column, and not a mix of the two. See: https://docusaurus.io/docs/api/themes/configuration#footer-links`
-    })
+    }).default([])
   }).optional(),
   prism: _utilsValidation.Joi.object({
     theme: _utilsValidation.Joi.object({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@docusaurus/theme-classic",
-  "version": "0.0.0-4304",
+  "version": "0.0.0-4305",
   "description": "Classic theme for Docusaurus",
   "main": "lib/index.js",
   "types": "src/theme-classic.d.ts",
@@ -23,14 +23,14 @@
     "update-code-translations": "node -e 'require(\"./update-code-translations.js\").run()'"
   },
   "dependencies": {
-    "@docusaurus/core": "0.0.0-4304",
-    "@docusaurus/plugin-content-blog": "0.0.0-4304",
-    "@docusaurus/plugin-content-docs": "0.0.0-4304",
-    "@docusaurus/plugin-content-pages": "0.0.0-4304",
-    "@docusaurus/theme-common": "0.0.0-4304",
-    "@docusaurus/theme-translations": "0.0.0-4304",
-    "@docusaurus/utils": "0.0.0-4304",
-    "@docusaurus/utils-validation": "0.0.0-4304",
+    "@docusaurus/core": "0.0.0-4305",
+    "@docusaurus/plugin-content-blog": "0.0.0-4305",
+    "@docusaurus/plugin-content-docs": "0.0.0-4305",
+    "@docusaurus/plugin-content-pages": "0.0.0-4305",
+    "@docusaurus/theme-common": "0.0.0-4305",
+    "@docusaurus/theme-translations": "0.0.0-4305",
+    "@docusaurus/utils": "0.0.0-4305",
+    "@docusaurus/utils-validation": "0.0.0-4305",
     "@mdx-js/mdx": "^1.6.21",
     "@mdx-js/react": "^1.6.21",
     "clsx": "^1.1.1",
@@ -45,8 +45,8 @@
     "rtlcss": "^3.3.0"
   },
   "devDependencies": {
-    "@docusaurus/module-type-aliases": "0.0.0-4304",
-    "@docusaurus/types": "0.0.0-4304",
+    "@docusaurus/module-type-aliases": "0.0.0-4305",
+    "@docusaurus/types": "0.0.0-4305",
     "@types/mdx-js__react": "^1.5.4",
     "@types/parse-numeric-range": "^0.0.1",
     "@types/rtlcss": "^3.1.1",
@@ -61,5 +61,5 @@
   "engines": {
     "node": ">=14"
   },
-  "gitHead": "741cabdc2fdced32592aa340740e35a5b30de55e"
+  "gitHead": "4a85dc6ac221bf5771365cbb856daeb61fe24a33"
 }

package/src/translations.ts

@@ -74,21 +74,21 @@ function translateNavbar(
 function isMultiColumnFooterLinks(
   links: MultiColumnFooter['links'] | SimpleFooter['links'],
 ): links is MultiColumnFooter['links'] {
-  return 'title' in links[0];
+  return links.length > 0 && 'title' in links[0];
 }
 
 function getFooterTranslationFile(footer: Footer): TranslationFileContent {
-  const footerLinkTitles: TranslationFileContent = isMultiColumnFooterLinks(
-    footer.links,
+  const footerLinkTitles: TranslationFileContent = chain(
+    isMultiColumnFooterLinks(footer.links)
+      ? footer.links.filter((link) => !!link.title)
+      : [],
   )
-    ? chain(footer.links.filter((link) => !!link.title))
-        .keyBy((link) => `link.title.${link.title}`)
-        .mapValues((link) => ({
-          message: link.title!,
-          description: `The title of the footer links column with title=${link.title} in the footer`,
-        }))
-        .value()
-    : {};
+    .keyBy((link) => `link.title.${link.title}`)
+    .mapValues((link) => ({
+      message: link.title!,
+      description: `The title of the footer links column with title=${link.title} in the footer`,
+    }))
+    .value();
 
   const footerLinkLabels: TranslationFileContent = chain(
     isMultiColumnFooterLinks(footer.links)

package/src/validateThemeConfig.ts

@@ -312,18 +312,18 @@ const ThemeConfigSchema = Joi.object({
     }),
     copyright: Joi.string(),
     links: Joi.alternatives(
-      Joi.array()
-        .items(
-          Joi.object({
-            title: Joi.string().allow(null).default(null),
-            items: Joi.array().items(FooterLinkItemSchema).default([]),
-          }),
-        )
-        .default([]),
-      Joi.array().items(FooterLinkItemSchema).default([]),
-    ).messages({
-      'alternatives.match': `The footer must be either simple or multi-column, and not a mix of the two. See: https://docusaurus.io/docs/api/themes/configuration#footer-links`,
-    }),
+      Joi.array().items(
+        Joi.object({
+          title: Joi.string().allow(null).default(null),
+          items: Joi.array().items(FooterLinkItemSchema).default([]),
+        }),
+      ),
+      Joi.array().items(FooterLinkItemSchema),
+    )
+      .messages({
+        'alternatives.match': `The footer must be either simple or multi-column, and not a mix of the two. See: https://docusaurus.io/docs/api/themes/configuration#footer-links`,
+      })
+      .default([]),
   }).optional(),
   prism: Joi.object({
     theme: Joi.object({