@docusaurus/core 0.0.0-5814 → 0.0.0-5817

package/lib/client/exports/Link.js

@@ -99,8 +99,11 @@ function Link({ isNavLink, to, href, activeClassName, isActive, 'data-noBrokenLi
     }, [ioRef, targetLink, IOSupported, isInternal]);
     // It is simple local anchor link targeting current page?
     const isAnchorLink = targetLink?.startsWith('#') ?? false;
+    // See also RR logic:
+    // https://github.com/remix-run/react-router/blob/v5/packages/react-router-dom/modules/Link.js#L47
+    const hasInternalTarget = !props.target || props.target === '_self';
     // Should we use a regular <a> tag instead of React-Router Link component?
-    const isRegularHtmlLink = !targetLink || !isInternal || isAnchorLink;
+    const isRegularHtmlLink = !targetLink || !isInternal || !hasInternalTarget || isAnchorLink;
     if (!noBrokenLinkCheck && (isAnchorLink || !isRegularHtmlLink)) {
         brokenLinks.collectLink(targetLink);
     }

package/lib/server/brokenLinks.js

@@ -21,13 +21,33 @@ function matchRoutes(routeConfig, pathname) {
 }
 function createBrokenLinksHelper({ collectedLinks, routes, }) {
     const validPathnames = new Set(collectedLinks.keys());
+    // IMPORTANT: this is an optimization
+    // See https://github.com/facebook/docusaurus/issues/9754
     // Matching against the route array can be expensive
     // If the route is already in the valid pathnames,
-    // we can avoid matching against it as an optimization
-    const remainingRoutes = routes.filter((route) => !validPathnames.has(route.path));
+    // we can avoid matching against it
+    const remainingRoutes = (function filterRoutes() {
+        // Goal: unit tests should behave the same with this enabled or disabled
+        const disableOptimization = false;
+        if (disableOptimization) {
+            return routes;
+        }
+        // We must consider the "exact" and "strict" match attribute
+        // We can only infer pre-validated pathnames from a route from exact routes
+        const [validPathnameRoutes, otherRoutes] = lodash_1.default.partition(routes, (route) => route.exact && validPathnames.has(route.path));
+        // If a route is non-strict (non-sensitive to trailing slashes)
+        // We must pre-validate all possible paths
+        validPathnameRoutes.forEach((validPathnameRoute) => {
+            if (!validPathnameRoute.strict) {
+                validPathnames.add((0, utils_1.addTrailingSlash)(validPathnameRoute.path));
+                validPathnames.add((0, utils_1.removeTrailingSlash)(validPathnameRoute.path));
+            }
+        });
+        return otherRoutes;
+    })();
     function isPathnameMatchingAnyRoute(pathname) {
         if (matchRoutes(remainingRoutes, pathname).length > 0) {
-            // IMPORTANT: this is an optimization here
+            // IMPORTANT: this is an optimization
             // See https://github.com/facebook/docusaurus/issues/9754
             // Large Docusaurus sites have many routes!
             // We try to minimize calls to a possibly expensive matchRoutes function

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@docusaurus/core",
   "description": "Easy to Maintain Open Source Documentation Websites",
-  "version": "0.0.0-5814",
+  "version": "0.0.0-5817",
   "license": "MIT",
   "publishConfig": {
     "access": "public"
@@ -43,13 +43,13 @@
     "@babel/runtime": "^7.22.6",
     "@babel/runtime-corejs3": "^7.22.6",
     "@babel/traverse": "^7.22.8",
-    "@docusaurus/cssnano-preset": "0.0.0-5814",
-    "@docusaurus/logger": "0.0.0-5814",
-    "@docusaurus/mdx-loader": "0.0.0-5814",
+    "@docusaurus/cssnano-preset": "0.0.0-5817",
+    "@docusaurus/logger": "0.0.0-5817",
+    "@docusaurus/mdx-loader": "0.0.0-5817",
     "@docusaurus/react-loadable": "5.5.2",
-    "@docusaurus/utils": "0.0.0-5814",
-    "@docusaurus/utils-common": "0.0.0-5814",
-    "@docusaurus/utils-validation": "0.0.0-5814",
+    "@docusaurus/utils": "0.0.0-5817",
+    "@docusaurus/utils-common": "0.0.0-5817",
+    "@docusaurus/utils-validation": "0.0.0-5817",
     "@slorber/static-site-generator-webpack-plugin": "^4.0.7",
     "@svgr/webpack": "^6.5.1",
     "autoprefixer": "^10.4.14",
@@ -104,8 +104,8 @@
     "webpackbar": "^5.0.2"
   },
   "devDependencies": {
-    "@docusaurus/module-type-aliases": "0.0.0-5814",
-    "@docusaurus/types": "0.0.0-5814",
+    "@docusaurus/module-type-aliases": "0.0.0-5817",
+    "@docusaurus/types": "0.0.0-5817",
     "@types/detect-port": "^1.3.3",
     "@types/react-dom": "^18.2.7",
     "@types/react-router-config": "^5.0.7",
@@ -124,5 +124,5 @@
   "engines": {
     "node": ">=18.0"
   },
-  "gitHead": "67b273740f8d1404edf4307185f21ab3b4b37032"
+  "gitHead": "f2a043446c467462a95ace4fcd42e381562118f9"
 }