@documentation-robotics/cli 0.1.0 → 0.1.5

package/dist/validators/schema-validator.js.map

@@ -1,7 +1,7 @@
 {
   "version": 3,
   "sources": ["../../src/validators/schema-validator.ts"],
-  "sourcesContent": ["/**\n * Schema validation using AJV\n */\n\nimport Ajv, { ValidateFunction, ErrorObject } from 'ajv';\nimport addFormats from 'ajv-formats';\nimport { ValidationResult } from './types.js';\nimport type { Layer } from '../core/layer.js';\nimport { fileURLToPath } from 'url';\nimport path from 'path';\nimport { readFile } from '../utils/file-io.js';\nimport { startSpan, endSpan } from '../telemetry/index.js';\n\n// Fallback for runtime environments where TELEMETRY_ENABLED is not defined by esbuild\ndeclare const TELEMETRY_ENABLED: boolean | undefined;\nconst isTelemetryEnabled = typeof TELEMETRY_ENABLED !== 'undefined' ? TELEMETRY_ENABLED : false;\n\n/**\n * Validator for JSON Schema compliance\n */\nexport class SchemaValidator {\n  private ajv: Ajv;\n  private compiledSchemas: Map<string, ValidateFunction> = new Map();\n  private schemasLoaded: boolean = false;\n\n  constructor() {\n    this.ajv = new Ajv({\n      allErrors: true,\n      strict: false,\n      validateFormats: true,\n    });\n    addFormats(this.ajv);\n    // Note: schemas are loaded lazily on first validation\n  }\n\n  /**\n   * Ensure schemas are precompiled before validation\n   */\n  private async ensureSchemasLoaded(): Promise<void> {\n    if (this.schemasLoaded) {\n      return;\n    }\n\n    await this.precompileSchemas();\n    this.schemasLoaded = true;\n  }\n\n  /**\n   * Precompile all layer schemas for efficient validation\n   */\n  private async precompileSchemas(): Promise<void> {\n    const layerMappings = {\n      motivation: '01-motivation-layer.schema.json',\n      business: '02-business-layer.schema.json',\n      security: '03-security-layer.schema.json',\n      application: '04-application-layer.schema.json',\n      technology: '05-technology-layer.schema.json',\n      api: '06-api-layer.schema.json',\n      'data-model': '07-data-model-layer.schema.json',\n      'data-store': '08-datastore-layer.schema.json',\n      ux: '09-ux-layer.schema.json',\n      navigation: '10-navigation-layer.schema.json',\n      apm: '11-apm-observability-layer.schema.json',\n      testing: '12-testing-layer.schema.json',\n    };\n\n    const __dirname = path.dirname(fileURLToPath(import.meta.url));\n    const schemasDir = path.join(__dirname, '..', 'schemas', 'bundled');\n\n    // First, register all common schemas that other schemas reference\n    const commonSchemas = [\n      'common/source-references.schema.json',\n      'common/predicates.schema.json',\n      'common/relationships.schema.json',\n      'common/layer-extensions.schema.json',\n    ];\n\n    for (const commonSchemaFile of commonSchemas) {\n      try {\n        const schemaPath = path.join(schemasDir, commonSchemaFile);\n        const schemaContent = await readFile(schemaPath);\n        const schema = JSON.parse(schemaContent);\n        this.ajv.addSchema(schema);\n      } catch (error) {\n        // Common schemas not all layers may reference - warn but continue\n        console.warn(\n          `Warning: Failed to load common schema ${commonSchemaFile}:`,\n          error\n        );\n      }\n    }\n\n    for (const [layerName, schemaFileName] of Object.entries(layerMappings)) {\n      try {\n        // Try primary schema path first (development)\n        let schemaPath = path.join(schemasDir, schemaFileName);\n\n        let schemaContent: string;\n        try {\n          schemaContent = await readFile(schemaPath);\n        } catch {\n          // Fallback to alternative path for bundled deployments\n          schemaPath = path.join(\n            __dirname,\n            'schemas',\n            'bundled',\n            schemaFileName\n          );\n          schemaContent = await readFile(schemaPath);\n        }\n\n        const schema = JSON.parse(schemaContent);\n        const validate = this.ajv.compile(schema);\n        this.compiledSchemas.set(layerName, validate);\n      } catch (error) {\n        console.warn(`Failed to load schema for layer ${layerName}:`, error);\n      }\n    }\n  }\n\n  /**\n   * Validate a layer against its schema\n   */\n  async validateLayer(layer: Layer): Promise<ValidationResult> {\n    const span = isTelemetryEnabled ? startSpan('schema.validate', {\n      'schema.layer': layer.name,\n    }) : null;\n\n    try {\n      const result = new ValidationResult();\n\n      // Ensure schemas are loaded\n      await this.ensureSchemasLoaded();\n\n      const validate = this.compiledSchemas.get(layer.name);\n\n      if (!validate) {\n        // Schema not found - skip validation silently (matching Python CLI behavior)\n        // Some layers may not have schemas yet, which is acceptable\n        // Don't add warning - just return success\n        if (isTelemetryEnabled && span) {\n          span.setAttribute('schema.valid', true);\n          span.setAttribute('schema.skipped', true);\n        }\n\n        return result;\n      }\n\n      const layerData = layer.toJSON();\n      const valid = validate(layerData);\n\n      if (!valid && validate.errors) {\n        for (const error of validate.errors) {\n          result.addError({\n            layer: layer.name,\n            message: `Schema validation failed: ${this.formatAjvError(error)}`,\n            location: error.instancePath || '/',\n            fixSuggestion: this.generateFixSuggestion(error),\n          });\n        }\n      }\n\n      if (isTelemetryEnabled && span) {\n        span.setAttribute('schema.valid', valid);\n        span.setAttribute('schema.error_count', validate.errors?.length || 0);\n      }\n\n      return result;\n    } finally {\n      endSpan(span);\n    }\n  }\n\n  /**\n   * Format AJV error message\n   */\n  private formatAjvError(error: ErrorObject): string {\n    const keyword = error.keyword;\n    const dataPath = error.instancePath || '/';\n\n    switch (keyword) {\n      case 'type':\n        return `At ${dataPath}: expected ${error.params?.type}, got ${typeof error.data}`;\n      case 'required':\n        return `At ${dataPath}: missing required property '${error.params?.missingProperty}'`;\n      case 'enum':\n        return `At ${dataPath}: value must be one of [${error.params?.allowedValues?.join(', ')}]`;\n      case 'pattern':\n        return `At ${dataPath}: value must match pattern ${error.params?.pattern}`;\n      case 'minLength':\n        return `At ${dataPath}: string must be at least ${error.params?.limit} characters`;\n      case 'maxLength':\n        return `At ${dataPath}: string must be at most ${error.params?.limit} characters`;\n      case 'minimum':\n        return `At ${dataPath}: value must be >= ${error.params?.limit}`;\n      case 'maximum':\n        return `At ${dataPath}: value must be <= ${error.params?.limit}`;\n      case 'additionalProperties':\n        return `At ${dataPath}: unexpected property '${error.params?.additionalProperty}'`;\n      default:\n        return error.message || `Validation failed`;\n    }\n  }\n\n  /**\n   * Generate a fix suggestion based on the error\n   */\n  private generateFixSuggestion(error: ErrorObject): string | undefined {\n    const keyword = error.keyword;\n\n    switch (keyword) {\n      case 'required':\n        return `Add required field: ${error.params?.missingProperty}`;\n      case 'type':\n        return `Expected type ${error.params?.type}`;\n      case 'enum':\n        return `Use one of: ${error.params?.allowedValues?.join(', ')}`;\n      case 'pattern':\n        return `Value must match pattern: ${error.params?.pattern}`;\n      case 'additionalProperties':\n        return `Remove unexpected property: ${error.params?.additionalProperty}`;\n      default:\n        return undefined;\n    }\n  }\n}\n"],
-  "mappings": "AAIA,OAAO,SAA4C;AACnD,OAAO,gBAAgB;AACvB,SAAS,wBAAwB;AAEjC,SAAS,qBAAqB;AAC9B,OAAO,UAAU;AACjB,SAAS,gBAAgB;AACzB,SAAS,WAAW,eAAe;AAInC,MAAM,qBAAgE;AAKhE,MAAO,gBAAe;EAClB;EACA,kBAAiD,oBAAI,IAAG;EACxD,gBAAyB;EAEjC,cAAA;AACE,SAAK,MAAM,IAAI,IAAI;MACjB,WAAW;MACX,QAAQ;MACR,iBAAiB;KAClB,GACD,WAAW,KAAK,GAAG;EAErB;;;;EAKQ,MAAM,sBAAmB;AAC/B,IAAI,KAAK,kBAIT,MAAM,KAAK,kBAAiB,GAC5B,KAAK,gBAAgB;EACvB;;;;EAKQ,MAAM,oBAAiB;AAC7B,UAAM,gBAAgB;MACpB,YAAY;MACZ,UAAU;MACV,UAAU;MACV,aAAa;MACb,YAAY;MACZ,KAAK;MACL,cAAc;MACd,cAAc;MACd,IAAI;MACJ,YAAY;MACZ,KAAK;MACL,SAAS;OAGL,YAAY,KAAK,QAAQ,cAAc,YAAY,GAAG,CAAC,GACvD,aAAa,KAAK,KAAK,WAAW,MAAM,WAAW,SAAS,GAG5D,gBAAgB;MACpB;MACA;MACA;MACA;;AAGF,eAAW,oBAAoB;AAC7B,UAAI;AACF,cAAM,aAAa,KAAK,KAAK,YAAY,gBAAgB,GACnD,gBAAgB,MAAM,SAAS,UAAU,GACzC,SAAS,KAAK,MAAM,aAAa;AACvC,aAAK,IAAI,UAAU,MAAM;MAC3B,SAAS,OAAO;AAEd,gBAAQ,KACN,yCAAyC,gBAAgB,KACzD,KAAK;MAET;AAGF,eAAW,CAAC,WAAW,cAAc,KAAK,OAAO,QAAQ,aAAa;AACpE,UAAI;AAEF,YAAI,aAAa,KAAK,KAAK,YAAY,cAAc,GAEjD;AACJ,YAAI;AACF,0BAAgB,MAAM,SAAS,UAAU;QAC3C,QAAQ;AAEN,uBAAa,KAAK,KAChB,WACA,WACA,WACA,cAAc,GAEhB,gBAAgB,MAAM,SAAS,UAAU;QAC3C;AAEA,cAAM,SAAS,KAAK,MAAM,aAAa,GACjC,WAAW,KAAK,IAAI,QAAQ,MAAM;AACxC,aAAK,gBAAgB,IAAI,WAAW,QAAQ;MAC9C,SAAS,OAAO;AACd,gBAAQ,KAAK,mCAAmC,SAAS,KAAK,KAAK;MACrE;EAEJ;;;;EAKA,MAAM,cAAc,OAAY;AAC9B,UAAM,OAAO,qBAAqB,UAAU,mBAAmB;MAC7D,gBAAgB,MAAM;KACvB,IAAI;AAEL,QAAI;AACF,YAAM,SAAS,IAAI,iBAAgB;AAGnC,YAAM,KAAK,oBAAmB;AAE9B,YAAM,WAAW,KAAK,gBAAgB,IAAI,MAAM,IAAI;AAEpD,UAAI,CAAC;AAIH,eAAI,sBAAsB,SACxB,KAAK,aAAa,gBAAgB,EAAI,GACtC,KAAK,aAAa,kBAAkB,EAAI,IAGnC;AAGT,YAAM,YAAY,MAAM,OAAM,GACxB,QAAQ,SAAS,SAAS;AAEhC,UAAI,CAAC,SAAS,SAAS;AACrB,mBAAW,SAAS,SAAS;AAC3B,iBAAO,SAAS;YACd,OAAO,MAAM;YACb,SAAS,6BAA6B,KAAK,eAAe,KAAK,CAAC;YAChE,UAAU,MAAM,gBAAgB;YAChC,eAAe,KAAK,sBAAsB,KAAK;WAChD;AAIL,aAAI,sBAAsB,SACxB,KAAK,aAAa,gBAAgB,KAAK,GACvC,KAAK,aAAa,sBAAsB,SAAS,QAAQ,UAAU,CAAC,IAG/D;IACT;AACE,cAAQ,IAAI;IACd;EACF;;;;EAKQ,eAAe,OAAkB;AACvC,UAAM,UAAU,MAAM,SAChB,WAAW,MAAM,gBAAgB;AAEvC,YAAQ,SAAS;MACf,KAAK;AACH,eAAO,MAAM,QAAQ,cAAc,MAAM,QAAQ,IAAI,SAAS,OAAO,MAAM,IAAI;MACjF,KAAK;AACH,eAAO,MAAM,QAAQ,gCAAgC,MAAM,QAAQ,eAAe;MACpF,KAAK;AACH,eAAO,MAAM,QAAQ,2BAA2B,MAAM,QAAQ,eAAe,KAAK,IAAI,CAAC;MACzF,KAAK;AACH,eAAO,MAAM,QAAQ,8BAA8B,MAAM,QAAQ,OAAO;MAC1E,KAAK;AACH,eAAO,MAAM,QAAQ,6BAA6B,MAAM,QAAQ,KAAK;MACvE,KAAK;AACH,eAAO,MAAM,QAAQ,4BAA4B,MAAM,QAAQ,KAAK;MACtE,KAAK;AACH,eAAO,MAAM,QAAQ,sBAAsB,MAAM,QAAQ,KAAK;MAChE,KAAK;AACH,eAAO,MAAM,QAAQ,sBAAsB,MAAM,QAAQ,KAAK;MAChE,KAAK;AACH,eAAO,MAAM,QAAQ,0BAA0B,MAAM,QAAQ,kBAAkB;MACjF;AACE,eAAO,MAAM,WAAW;IAC5B;EACF;;;;EAKQ,sBAAsB,OAAkB;AAG9C,YAFgB,MAAM,SAEL;MACf,KAAK;AACH,eAAO,uBAAuB,MAAM,QAAQ,eAAe;MAC7D,KAAK;AACH,eAAO,iBAAiB,MAAM,QAAQ,IAAI;MAC5C,KAAK;AACH,eAAO,eAAe,MAAM,QAAQ,eAAe,KAAK,IAAI,CAAC;MAC/D,KAAK;AACH,eAAO,6BAA6B,MAAM,QAAQ,OAAO;MAC3D,KAAK;AACH,eAAO,+BAA+B,MAAM,QAAQ,kBAAkB;MACxE;AACE;IACJ;EACF;;",
+  "sourcesContent": ["/**\n * Schema validation using AJV\n *\n * Validates model elements against their corresponding spec node schemas.\n * Each element type has a dedicated schema in spec/schemas/nodes/{layer}/{type}.node.schema.json\n */\n\nimport Ajv, { ValidateFunction, ErrorObject } from \"ajv\";\nimport addFormats from \"ajv-formats\";\nimport { ValidationResult } from \"./types.js\";\nimport type { Layer } from \"../core/layer.js\";\nimport type { Element } from \"../core/element.js\";\nimport { fileURLToPath } from \"url\";\nimport path from \"path\";\nimport { readFile } from \"../utils/file-io.js\";\nimport { startActiveSpan } from \"../telemetry/index.js\";\nimport { existsSync } from \"fs\";\nimport {\n  validateSpecNode,\n  validateSpecNodeRelationship,\n  validateSourceReference,\n  validateAttributeSpec,\n} from \"../generated/compiled-validators.js\";\n\n// Fallback for runtime environments where TELEMETRY_ENABLED is not defined by esbuild\ndeclare const TELEMETRY_ENABLED: boolean | undefined;\nconst isTelemetryEnabled = typeof TELEMETRY_ENABLED !== \"undefined\" ? TELEMETRY_ENABLED : false;\n\n/**\n * Validator for JSON Schema compliance\n *\n * Validates model elements against spec node schemas. Each element is validated\n * against its type-specific schema (e.g., motivation.goal elements validate against\n * spec/schemas/nodes/motivation/goal.node.schema.json).\n */\nexport class SchemaValidator {\n  // Static shared AJV instance to avoid schema registry conflicts\n  // When multiple SchemaValidator instances are created, they all use the same\n  // AJV instance which maintains a single schema registry. This prevents\n  // \"schema with key or id already exists\" errors when loading the same schemas.\n  private static sharedAjv: Ajv | null = null;\n  private static baseSchemaLoadedInSharedInstance: boolean = false;\n  // Track schema IDs already registered in the shared AJV instance to avoid re-registering\n  private static registeredSchemaIds: Set<string> = new Set();\n  // Layer-level cache: layer ID \u2192 nodeSchemas map (avoids re-reading layer dist files)\n  private static layerCache: Map<string, Record<string, unknown>> = new Map();\n\n  private ajv: Ajv;\n  private compiledSchemas: Map<string, ValidateFunction> = new Map(); // Key: layer.type\n  private bundledDir: string;\n\n  constructor() {\n    // Initialize shared AJV instance once\n    if (!SchemaValidator.sharedAjv) {\n      SchemaValidator.sharedAjv = new Ajv({\n        allErrors: true,\n        strict: false,\n        validateFormats: true,\n        verbose: true,\n      });\n      addFormats(SchemaValidator.sharedAjv);\n    }\n    this.ajv = SchemaValidator.sharedAjv;\n\n    // Determine bundled directory (compiled spec dist files)\n    const __dirname = path.dirname(fileURLToPath(import.meta.url));\n    this.bundledDir = path.join(__dirname, \"..\", \"schemas\", \"bundled\");\n  }\n\n  /**\n   * Extract error message from unknown error type with proper type checking\n   */\n  private static getErrorMessage(error: unknown): string {\n    if (error instanceof Error) {\n      return error.message;\n    }\n    if (typeof error === \"object\" && error !== null && \"message\" in error) {\n      const msg = (error as Record<string, unknown>).message;\n      if (typeof msg === \"string\") {\n        return msg;\n      }\n    }\n    return \"Unknown error\";\n  }\n\n  /**\n   * Ensure base schemas are pre-compiled validators are initialized\n   * Loads base schemas from base.json and registers them with AJV for reference resolution.\n   * This allows per-type schemas to resolve $ref to base schemas during compilation.\n   */\n  private async ensureBaseSchemaLoaded(): Promise<void> {\n    // Check if already loaded in the shared AJV instance (applies to all instances)\n    if (SchemaValidator.baseSchemaLoadedInSharedInstance) {\n      return;\n    }\n\n    // Register pre-compiled validators with AJV\n    this.compiledSchemas.set(\"spec-node\", validateSpecNode);\n    this.compiledSchemas.set(\"spec-node-relationship\", validateSpecNodeRelationship);\n    this.compiledSchemas.set(\"source-references\", validateSourceReference);\n    this.compiledSchemas.set(\"attribute-spec\", validateAttributeSpec);\n\n    // Load base.json and register all schemas with AJV for $ref resolution\n    // Schemas use URN-style $ids like \"urn:dr:spec:base:spec-node\" after compilation\n    const baseJsonPath = path.join(this.bundledDir, \"base.json\");\n    try {\n      const baseContent = await readFile(baseJsonPath);\n      const baseData = JSON.parse(baseContent) as {\n        specVersion: string;\n        schemas: Record<string, unknown>;\n        predicates: unknown;\n      };\n\n      for (const [key, schema] of Object.entries(baseData.schemas)) {\n        const s = schema as Record<string, unknown>;\n        const schemaId = (s.$id as string) || `urn:dr:spec:base:${key}`;\n\n        // Skip if already registered\n        if (SchemaValidator.registeredSchemaIds.has(schemaId)) {\n          continue;\n        }\n\n        try {\n          this.ajv.addSchema(s, schemaId);\n          SchemaValidator.registeredSchemaIds.add(schemaId);\n        } catch (error: unknown) {\n          const errorMsg = SchemaValidator.getErrorMessage(error);\n          const isDuplicateSchemaError = /schema with key or id [^ ]+ already exists/.test(errorMsg);\n          if (isDuplicateSchemaError) {\n            SchemaValidator.registeredSchemaIds.add(schemaId);\n          } else {\n            console.warn(`[SCHEMA-LOAD-001] Failed to register base schema '${key}': ${errorMsg}`);\n          }\n        }\n      }\n    } catch (error: unknown) {\n      console.warn(\n        `[SCHEMA-LOAD-001] Failed to load base.json from ${baseJsonPath}: ${SchemaValidator.getErrorMessage(error)}`\n      );\n    }\n\n    // Mark base schemas as loaded in shared instance (applies to all instances)\n    SchemaValidator.baseSchemaLoadedInSharedInstance = true;\n  }\n\n  /**\n   * Load the nodeSchemas map for a layer, using a static layer-level cache.\n   * Reads bundled/{layer}.json once per layer and caches the nodeSchemas object.\n   */\n  private async loadLayerNodeSchemas(layer: string): Promise<Record<string, unknown> | null> {\n    // Return cached layer schemas if available\n    if (SchemaValidator.layerCache.has(layer)) {\n      return SchemaValidator.layerCache.get(layer)!;\n    }\n\n    const layerPath = path.join(this.bundledDir, `${layer}.json`);\n    if (!existsSync(layerPath)) {\n      return null;\n    }\n\n    try {\n      const content = await readFile(layerPath);\n      const layerData = JSON.parse(content) as { nodeSchemas: Record<string, unknown> };\n      const nodeSchemas = layerData.nodeSchemas || {};\n      SchemaValidator.layerCache.set(layer, nodeSchemas);\n      return nodeSchemas;\n    } catch (error: unknown) {\n      console.warn(\n        `[SCHEMA-LOAD-002] Failed to load layer file for '${layer}': ${SchemaValidator.getErrorMessage(error)}`\n      );\n      return null;\n    }\n  }\n\n  /**\n   * Load and compile a spec node schema for a specific element type\n   */\n  private async loadSpecNodeSchema(layer: string, type: string): Promise<ValidateFunction | null> {\n    const cacheKey = `${layer}.${type}`;\n\n    // Check compiled schema cache first\n    if (this.compiledSchemas.has(cacheKey)) {\n      return this.compiledSchemas.get(cacheKey)!;\n    }\n\n    // Ensure base schemas are loaded first (required for reference resolution)\n    await this.ensureBaseSchemaLoaded();\n\n    try {\n      // Load node schemas from layer dist file (layer-level cache)\n      const nodeSchemas = await this.loadLayerNodeSchemas(layer);\n      if (!nodeSchemas || !nodeSchemas[type]) {\n        // No schema for this type - acceptable for custom types\n        return null;\n      }\n\n      const schema = nodeSchemas[type] as Record<string, unknown>;\n      const schemaId = (schema.$id as string) || `urn:dr:spec:node:${layer}.${type}`;\n\n      // Check if schema with this $id is already registered to avoid duplicate compilation\n      if (SchemaValidator.registeredSchemaIds.has(schemaId)) {\n        // Schema already registered \u2014 return from compiled cache or null (fallback to base)\n        return this.compiledSchemas.get(cacheKey) || null;\n      }\n\n      try {\n        const validate = this.ajv.compile(schema);\n        this.compiledSchemas.set(cacheKey, validate);\n        SchemaValidator.registeredSchemaIds.add(schemaId);\n        return validate;\n      } catch (registrationError: unknown) {\n        const errorMsg = SchemaValidator.getErrorMessage(registrationError);\n        if (errorMsg.includes(\"already exists\")) {\n          SchemaValidator.registeredSchemaIds.add(schemaId);\n          return null;\n        }\n        throw registrationError;\n      }\n    } catch (error: unknown) {\n      const errorMsg = SchemaValidator.getErrorMessage(error);\n      if (errorMsg.includes(\"can't resolve reference\")) {\n        return null;\n      }\n      console.warn(`[SCHEMA-LOAD-002] Failed to load spec node schema for ${layer}.${type}: ${errorMsg}`);\n      return null;\n    }\n  }\n\n  /**\n   * Validate a layer against its spec node schemas\n   *\n   * This validates each element in the layer against its corresponding spec node schema.\n   */\n  async validateLayer(layer: Layer): Promise<ValidationResult> {\n    return startActiveSpan(\n      \"schema.validate\",\n      async (span) => {\n        const result = new ValidationResult();\n        let validatedCount = 0;\n        let skippedCount = 0;\n\n        // Validate each element individually\n        for (const element of layer.elements.values()) {\n          const elementResult = await this.validateElement(element, layer.name);\n\n          if (elementResult.hasErrors) {\n            // Add element-specific errors to layer result\n            for (const error of elementResult.errors) {\n              result.addError({\n                layer: layer.name,\n                elementId: element.path || element.id,\n                message: error.message,\n                location: error.location,\n                fixSuggestion: error.fixSuggestion,\n              });\n            }\n          }\n\n          if (elementResult.validated) {\n            validatedCount++;\n          } else {\n            skippedCount++;\n          }\n        }\n\n        if (isTelemetryEnabled) {\n          span.setAttribute(\"schema.valid\", result.isValid());\n          span.setAttribute(\"schema.error_count\", result.errors.length);\n          span.setAttribute(\"schema.validated_count\", validatedCount);\n          span.setAttribute(\"schema.skipped_count\", skippedCount);\n        }\n\n        return result;\n      },\n      { \"schema.layer\": layer.name }\n    );\n  }\n\n  /**\n   * Validate a single element against its spec node schema\n   */\n  private async validateElement(element: Element, layerName: string): Promise<{\n    validated: boolean;\n    hasErrors: boolean;\n    errors: Array<{ message: string; location: string; fixSuggestion?: string }>;\n  }> {\n    const result = {\n      validated: false,\n      hasErrors: false,\n      errors: [] as Array<{ message: string; location: string; fixSuggestion?: string }>,\n    };\n\n    const specNode = element.toSpecNode();\n\n    // First: Validate against base spec-node schema using pre-compiled validator\n    // This ensures all elements conform to the base structure before type-specific validation\n    await this.ensureBaseSchemaLoaded();\n    const baseValid = validateSpecNode(specNode);\n\n    if (!baseValid && validateSpecNode.errors) {\n      result.hasErrors = true;\n      result.validated = true;\n      for (const error of validateSpecNode.errors) {\n        result.errors.push({\n          message: `Element '${element.path || element.id}': ${this.formatAjvError(error)}`,\n          location: error.instancePath || \"/\",\n          fixSuggestion: this.generateFixSuggestion(error),\n        });\n      }\n      return result; // Fail fast on base schema violation\n    }\n\n    // Second: Load and validate against type-specific schema (lazy-loaded)\n    const validate = await this.loadSpecNodeSchema(layerName, element.type);\n\n    if (!validate) {\n      // No type-specific schema found - base schema validation passed\n      // This is acceptable for custom types or types without schemas yet\n      result.validated = true;\n      return result;\n    }\n\n    result.validated = true;\n\n    // Validate element against type-specific schema\n    const typeValid = validate(specNode);\n\n    if (!typeValid && validate.errors) {\n      result.hasErrors = true;\n      for (const error of validate.errors) {\n        result.errors.push({\n          message: `Element '${element.path || element.id}': ${this.formatAjvError(error)}`,\n          location: error.instancePath || \"/\",\n          fixSuggestion: this.generateFixSuggestion(error),\n        });\n      }\n    }\n\n    return result;\n  }\n\n  /**\n   * Format AJV error message\n   */\n  private formatAjvError(error: ErrorObject): string {\n    const keyword = error.keyword;\n    const dataPath = error.instancePath || \"/\";\n\n    switch (keyword) {\n      case \"type\":\n        return `At ${dataPath}: expected ${error.params?.type}, got ${error.data === null ? \"null\" : typeof error.data}`;\n      case \"required\":\n        return `At ${dataPath}: missing required property '${error.params?.missingProperty}'`;\n      case \"enum\":\n        return `At ${dataPath}: value must be one of [${error.params?.allowedValues?.join(\", \")}]`;\n      case \"pattern\":\n        return `At ${dataPath}: value must match pattern ${error.params?.pattern}`;\n      case \"minLength\":\n        return `At ${dataPath}: string must be at least ${error.params?.limit} characters`;\n      case \"maxLength\":\n        return `At ${dataPath}: string must be at most ${error.params?.limit} characters`;\n      case \"minimum\":\n        return `At ${dataPath}: value must be >= ${error.params?.limit}`;\n      case \"maximum\":\n        return `At ${dataPath}: value must be <= ${error.params?.limit}`;\n      case \"additionalProperties\":\n        return `At ${dataPath}: unexpected property '${error.params?.additionalProperty}'`;\n      case \"const\":\n        return `At ${dataPath}: value must be ${JSON.stringify(error.params?.allowedValue)}`;\n      default:\n        return error.message || `Validation failed`;\n    }\n  }\n\n  /**\n   * Generate a fix suggestion based on the error\n   */\n  private generateFixSuggestion(error: ErrorObject): string | undefined {\n    const keyword = error.keyword;\n\n    switch (keyword) {\n      case \"required\":\n        return `Add required field: ${error.params?.missingProperty}`;\n      case \"type\":\n        return `Expected type ${error.params?.type}`;\n      case \"enum\":\n        return `Use one of: ${error.params?.allowedValues?.join(\", \")}`;\n      case \"pattern\":\n        return `Value must match pattern: ${error.params?.pattern}`;\n      case \"additionalProperties\":\n        return `Remove unexpected property: ${error.params?.additionalProperty}`;\n      case \"const\":\n        return `Value must be exactly: ${JSON.stringify(error.params?.allowedValue)}`;\n      default:\n        return undefined;\n    }\n  }\n\n  /**\n   * Reset static state for test isolation\n   *\n   * Clears the shared AJV instance and schema registry, allowing tests\n   * to load schemas from a clean state without conflicts.\n   *\n   * Usage (in test setup):\n   *   beforeEach(() => {\n   *     SchemaValidator.reset();\n   *   });\n   */\n  static reset(): void {\n    SchemaValidator.sharedAjv = null;\n    SchemaValidator.baseSchemaLoadedInSharedInstance = false;\n    SchemaValidator.registeredSchemaIds.clear();\n    SchemaValidator.layerCache.clear();\n  }\n}\n"],
+  "mappings": "AAOA,OAAO,SAA4C;AACnD,OAAO,gBAAgB;AACvB,SAAS,wBAAwB;AAGjC,SAAS,qBAAqB;AAC9B,OAAO,UAAU;AACjB,SAAS,gBAAgB;AACzB,SAAS,uBAAuB;AAChC,SAAS,kBAAkB;AAC3B,SACE,kBACA,8BACA,yBACA,6BACK;AAIP,MAAM,qBAAgE;AAShE,MAAO,gBAAe;;;;;EAKlB,OAAO,YAAwB;EAC/B,OAAO,mCAA4C;;EAEnD,OAAO,sBAAmC,oBAAI,IAAG;;EAEjD,OAAO,aAAmD,oBAAI,IAAG;EAEjE;EACA,kBAAiD,oBAAI,IAAG;;EACxD;EAER,cAAA;AAEE,IAAK,gBAAgB,cACnB,gBAAgB,YAAY,IAAI,IAAI;MAClC,WAAW;MACX,QAAQ;MACR,iBAAiB;MACjB,SAAS;KACV,GACD,WAAW,gBAAgB,SAAS,IAEtC,KAAK,MAAM,gBAAgB;AAG3B,UAAM,YAAY,KAAK,QAAQ,cAAc,YAAY,GAAG,CAAC;AAC7D,SAAK,aAAa,KAAK,KAAK,WAAW,MAAM,WAAW,SAAS;EACnE;;;;EAKQ,OAAO,gBAAgB,OAAc;AAC3C,QAAI,iBAAiB;AACnB,aAAO,MAAM;AAEf,QAAI,OAAO,SAAU,YAAY,UAAU,QAAQ,aAAa,OAAO;AACrE,YAAM,MAAO,MAAkC;AAC/C,UAAI,OAAO,OAAQ;AACjB,eAAO;IAEX;AACA,WAAO;EACT;;;;;;EAOQ,MAAM,yBAAsB;AAElC,QAAI,gBAAgB;AAClB;AAIF,SAAK,gBAAgB,IAAI,aAAa,gBAAgB,GACtD,KAAK,gBAAgB,IAAI,0BAA0B,4BAA4B,GAC/E,KAAK,gBAAgB,IAAI,qBAAqB,uBAAuB,GACrE,KAAK,gBAAgB,IAAI,kBAAkB,qBAAqB;AAIhE,UAAM,eAAe,KAAK,KAAK,KAAK,YAAY,WAAW;AAC3D,QAAI;AACF,YAAM,cAAc,MAAM,SAAS,YAAY,GACzC,WAAW,KAAK,MAAM,WAAW;AAMvC,iBAAW,CAAC,KAAK,MAAM,KAAK,OAAO,QAAQ,SAAS,OAAO,GAAG;AAC5D,cAAM,IAAI,QACJ,WAAY,EAAE,OAAkB,oBAAoB,GAAG;AAG7D,YAAI,iBAAgB,oBAAoB,IAAI,QAAQ;AAIpD,cAAI;AACF,iBAAK,IAAI,UAAU,GAAG,QAAQ,GAC9B,gBAAgB,oBAAoB,IAAI,QAAQ;UAClD,SAAS,OAAgB;AACvB,kBAAM,WAAW,gBAAgB,gBAAgB,KAAK;AAEtD,YAD+B,6CAA6C,KAAK,QAAQ,IAEvF,gBAAgB,oBAAoB,IAAI,QAAQ,IAEhD,QAAQ,KAAK,qDAAqD,GAAG,MAAM,QAAQ,EAAE;UAEzF;MACF;IACF,SAAS,OAAgB;AACvB,cAAQ,KACN,mDAAmD,YAAY,KAAK,gBAAgB,gBAAgB,KAAK,CAAC,EAAE;IAEhH;AAGA,oBAAgB,mCAAmC;EACrD;;;;;EAMQ,MAAM,qBAAqB,OAAa;AAE9C,QAAI,gBAAgB,WAAW,IAAI,KAAK;AACtC,aAAO,gBAAgB,WAAW,IAAI,KAAK;AAG7C,UAAM,YAAY,KAAK,KAAK,KAAK,YAAY,GAAG,KAAK,OAAO;AAC5D,QAAI,CAAC,WAAW,SAAS;AACvB,aAAO;AAGT,QAAI;AACF,YAAM,UAAU,MAAM,SAAS,SAAS,GAElC,cADY,KAAK,MAAM,OAAO,EACN,eAAe,CAAA;AAC7C,6BAAgB,WAAW,IAAI,OAAO,WAAW,GAC1C;IACT,SAAS,OAAgB;AACvB,qBAAQ,KACN,oDAAoD,KAAK,MAAM,gBAAgB,gBAAgB,KAAK,CAAC,EAAE,GAElG;IACT;EACF;;;;EAKQ,MAAM,mBAAmB,OAAe,MAAY;AAC1D,UAAM,WAAW,GAAG,KAAK,IAAI,IAAI;AAGjC,QAAI,KAAK,gBAAgB,IAAI,QAAQ;AACnC,aAAO,KAAK,gBAAgB,IAAI,QAAQ;AAI1C,UAAM,KAAK,uBAAsB;AAEjC,QAAI;AAEF,YAAM,cAAc,MAAM,KAAK,qBAAqB,KAAK;AACzD,UAAI,CAAC,eAAe,CAAC,YAAY,IAAI;AAEnC,eAAO;AAGT,YAAM,SAAS,YAAY,IAAI,GACzB,WAAY,OAAO,OAAkB,oBAAoB,KAAK,IAAI,IAAI;AAG5E,UAAI,gBAAgB,oBAAoB,IAAI,QAAQ;AAElD,eAAO,KAAK,gBAAgB,IAAI,QAAQ,KAAK;AAG/C,UAAI;AACF,cAAM,WAAW,KAAK,IAAI,QAAQ,MAAM;AACxC,oBAAK,gBAAgB,IAAI,UAAU,QAAQ,GAC3C,gBAAgB,oBAAoB,IAAI,QAAQ,GACzC;MACT,SAAS,mBAA4B;AAEnC,YADiB,gBAAgB,gBAAgB,iBAAiB,EACrD,SAAS,gBAAgB;AACpC,iCAAgB,oBAAoB,IAAI,QAAQ,GACzC;AAET,cAAM;MACR;IACF,SAAS,OAAgB;AACvB,YAAM,WAAW,gBAAgB,gBAAgB,KAAK;AACtD,aAAI,SAAS,SAAS,yBAAyB,KAG/C,QAAQ,KAAK,yDAAyD,KAAK,IAAI,IAAI,KAAK,QAAQ,EAAE,GAC3F;IACT;EACF;;;;;;EAOA,MAAM,cAAc,OAAY;AAC9B,WAAO,gBACL,mBACA,OAAO,SAAQ;AACb,YAAM,SAAS,IAAI,iBAAgB;AACnC,UAAI,iBAAiB,GACjB,eAAe;AAGnB,iBAAW,WAAW,MAAM,SAAS,OAAM,GAAI;AAC7C,cAAM,gBAAgB,MAAM,KAAK,gBAAgB,SAAS,MAAM,IAAI;AAEpE,YAAI,cAAc;AAEhB,qBAAW,SAAS,cAAc;AAChC,mBAAO,SAAS;cACd,OAAO,MAAM;cACb,WAAW,QAAQ,QAAQ,QAAQ;cACnC,SAAS,MAAM;cACf,UAAU,MAAM;cAChB,eAAe,MAAM;aACtB;AAIL,QAAI,cAAc,YAChB,mBAEA;MAEJ;AAEA,aAAI,uBACF,KAAK,aAAa,gBAAgB,OAAO,QAAO,CAAE,GAClD,KAAK,aAAa,sBAAsB,OAAO,OAAO,MAAM,GAC5D,KAAK,aAAa,0BAA0B,cAAc,GAC1D,KAAK,aAAa,wBAAwB,YAAY,IAGjD;IACT,GACA,EAAE,gBAAgB,MAAM,KAAI,CAAE;EAElC;;;;EAKQ,MAAM,gBAAgB,SAAkB,WAAiB;AAK/D,UAAM,SAAS;MACb,WAAW;MACX,WAAW;MACX,QAAQ,CAAA;OAGJ,WAAW,QAAQ,WAAU;AAOnC,QAHA,MAAM,KAAK,uBAAsB,GAG7B,CAFc,iBAAiB,QAAQ,KAEzB,iBAAiB,QAAQ;AACzC,aAAO,YAAY,IACnB,OAAO,YAAY;AACnB,iBAAW,SAAS,iBAAiB;AACnC,eAAO,OAAO,KAAK;UACjB,SAAS,YAAY,QAAQ,QAAQ,QAAQ,EAAE,MAAM,KAAK,eAAe,KAAK,CAAC;UAC/E,UAAU,MAAM,gBAAgB;UAChC,eAAe,KAAK,sBAAsB,KAAK;SAChD;AAEH,aAAO;IACT;AAGA,UAAM,WAAW,MAAM,KAAK,mBAAmB,WAAW,QAAQ,IAAI;AAEtE,QAAI,CAAC;AAGH,oBAAO,YAAY,IACZ;AAQT,QALA,OAAO,YAAY,IAKf,CAFc,SAAS,QAAQ,KAEjB,SAAS,QAAQ;AACjC,aAAO,YAAY;AACnB,iBAAW,SAAS,SAAS;AAC3B,eAAO,OAAO,KAAK;UACjB,SAAS,YAAY,QAAQ,QAAQ,QAAQ,EAAE,MAAM,KAAK,eAAe,KAAK,CAAC;UAC/E,UAAU,MAAM,gBAAgB;UAChC,eAAe,KAAK,sBAAsB,KAAK;SAChD;IAEL;AAEA,WAAO;EACT;;;;EAKQ,eAAe,OAAkB;AACvC,UAAM,UAAU,MAAM,SAChB,WAAW,MAAM,gBAAgB;AAEvC,YAAQ,SAAS;MACf,KAAK;AACH,eAAO,MAAM,QAAQ,cAAc,MAAM,QAAQ,IAAI,SAAS,MAAM,SAAS,OAAO,SAAS,OAAO,MAAM,IAAI;MAChH,KAAK;AACH,eAAO,MAAM,QAAQ,gCAAgC,MAAM,QAAQ,eAAe;MACpF,KAAK;AACH,eAAO,MAAM,QAAQ,2BAA2B,MAAM,QAAQ,eAAe,KAAK,IAAI,CAAC;MACzF,KAAK;AACH,eAAO,MAAM,QAAQ,8BAA8B,MAAM,QAAQ,OAAO;MAC1E,KAAK;AACH,eAAO,MAAM,QAAQ,6BAA6B,MAAM,QAAQ,KAAK;MACvE,KAAK;AACH,eAAO,MAAM,QAAQ,4BAA4B,MAAM,QAAQ,KAAK;MACtE,KAAK;AACH,eAAO,MAAM,QAAQ,sBAAsB,MAAM,QAAQ,KAAK;MAChE,KAAK;AACH,eAAO,MAAM,QAAQ,sBAAsB,MAAM,QAAQ,KAAK;MAChE,KAAK;AACH,eAAO,MAAM,QAAQ,0BAA0B,MAAM,QAAQ,kBAAkB;MACjF,KAAK;AACH,eAAO,MAAM,QAAQ,mBAAmB,KAAK,UAAU,MAAM,QAAQ,YAAY,CAAC;MACpF;AACE,eAAO,MAAM,WAAW;IAC5B;EACF;;;;EAKQ,sBAAsB,OAAkB;AAG9C,YAFgB,MAAM,SAEL;MACf,KAAK;AACH,eAAO,uBAAuB,MAAM,QAAQ,eAAe;MAC7D,KAAK;AACH,eAAO,iBAAiB,MAAM,QAAQ,IAAI;MAC5C,KAAK;AACH,eAAO,eAAe,MAAM,QAAQ,eAAe,KAAK,IAAI,CAAC;MAC/D,KAAK;AACH,eAAO,6BAA6B,MAAM,QAAQ,OAAO;MAC3D,KAAK;AACH,eAAO,+BAA+B,MAAM,QAAQ,kBAAkB;MACxE,KAAK;AACH,eAAO,0BAA0B,KAAK,UAAU,MAAM,QAAQ,YAAY,CAAC;MAC7E;AACE;IACJ;EACF;;;;;;;;;;;;EAaA,OAAO,QAAK;AACV,oBAAgB,YAAY,MAC5B,gBAAgB,mCAAmC,IACnD,gBAAgB,oBAAoB,MAAK,GACzC,gBAAgB,WAAW,MAAK;EAClC;;",
   "names": []
 }

package/dist/validators/semantic-validator.js

@@ -1,77 +1,53 @@
 import { ValidationResult } from "./types.js";
-import { fileURLToPath } from "url";
-import path from "path";
+import { RELATIONSHIPS_BY_PREDICATE } from "../generated/relationship-index.js";
 class SemanticValidator {
-  relationshipCatalog = null;
-  catalogLoaded = !1;
-  constructor() {
-  }
-  /**
-   * Ensure relationship catalog is loaded
-   */
-  async ensureCatalogLoaded() {
-    this.catalogLoaded || (await this.loadRelationshipCatalog(), this.catalogLoaded = !0);
-  }
-  /**
-   * Load the relationship catalog for predicate validation
-   */
-  async loadRelationshipCatalog() {
-    try {
-      const __dirname = path.dirname(fileURLToPath(import.meta.url)), catalogPath = path.join(__dirname, "..", "schemas", "bundled", "relationship-catalog.json");
-      this.relationshipCatalog = await import(catalogPath, { assert: { type: "json" } }).then((m) => m.default);
-    } catch {
-      this.relationshipCatalog = null;
-    }
-  }
   /**
    * Validate semantic constraints of a model
    */
   async validateModel(model) {
     const result = new ValidationResult();
-    return await this.ensureCatalogLoaded(), this.validateUniqueIds(model, result), this.validateRelationshipPredicates(model, result), result;
+    return this.validateRelationshipPredicates(model, result), this.validateApmInferredWithoutSdk(model, result), result;
   }
   /**
-   * Validate that all element IDs are unique across layers
+   * Rule: apm_inferred_without_sdk
+   *
+   * When the APM layer contains MetricInstrument, Span, TraceConfiguration, or
+   * ExporterConfig elements and ALL of them have source_reference.provenance = "inferred",
+   * emit a WARNING suggesting OTel SDK verification.
+   *
+   * Rationale: The APM skill's checklist can cause Claude to add instrumentation
+   * elements without verifying that an OTel SDK is present. This validator surfaces
+   * the accuracy concern on every subsequent `dr validate` run.
    */
-  validateUniqueIds(model, result) {
-    const seenIds = /* @__PURE__ */ new Map();
-    for (const [layerName, layer] of model.layers)
-      for (const element of layer.listElements())
-        seenIds.has(element.id) ? result.addError({
-          layer: layerName,
-          elementId: element.id,
-          message: `Duplicate element ID: '${element.id}' already exists in layer '${seenIds.get(element.id)}'`,
-          fixSuggestion: "Element IDs must be unique across all layers"
-        }) : seenIds.set(element.id, layerName);
+  validateApmInferredWithoutSdk(model, result) {
+    const apmLayer = model.layers.get("apm");
+    if (!apmLayer)
+      return;
+    const instrumentationTypes = /* @__PURE__ */ new Set(["metricinstrument", "span", "traceconfiguration", "exporterconfig"]), instrumentationElements = apmLayer.listElements().filter((e) => instrumentationTypes.has(e.type));
+    if (instrumentationElements.length === 0)
+      return;
+    instrumentationElements.every((e) => e.source_reference?.provenance === "inferred") && result.addWarning({
+      layer: "apm",
+      elementId: "apm.*",
+      message: `All ${instrumentationElements.length} APM instrumentation element(s) have provenance: inferred. If no @opentelemetry SDK exists in package.json, these elements are aspirational rather than implemented. Consider marking them as such in their descriptions.`,
+      fixSuggestion: "Run: grep '@opentelemetry' package.json \u2014 if absent, update element descriptions to note that instrumentation is aspirational and no OTel export is implemented."
+    });
   }
   /**
-   * Validate relationship predicates against the catalog
+   * Validate relationship predicates against the generated spec relationship index.
+   * RELATIONSHIPS_BY_PREDICATE is compiled from all spec relationship schema files,
+   * so it is always consistent with the spec without manual synchronization.
    */
   validateRelationshipPredicates(model, result) {
-    if (this.relationshipCatalog)
-      for (const [layerName, layer] of model.layers) {
-        const allowedPredicates = this.getAllowedPredicates(layerName);
-        for (const element of layer.listElements())
-          for (const rel of element.relationships || [])
-            allowedPredicates.includes(rel.predicate) || result.addWarning({
-              layer: layerName,
-              elementId: element.id,
-              message: `Unknown relationship predicate '${rel.predicate}' for layer ${layerName}`,
-              fixSuggestion: allowedPredicates.length > 0 ? `Use one of: ${allowedPredicates.join(", ")}` : "Check relationship catalog for valid predicates"
-            });
-      }
-  }
-  /**
-   * Get allowed predicates for a layer from the catalog
-   */
-  getAllowedPredicates(layerName) {
-    if (!this.relationshipCatalog)
-      return [];
-    const layerCatalog = this.relationshipCatalog.layers?.[layerName];
-    if (!layerCatalog)
-      return [];
-    const predicates = layerCatalog.predicates || layerCatalog.relationships || [];
-    return Array.isArray(predicates) ? predicates : Object.keys(predicates || {});
+    for (const [layerName, layer] of model.layers)
+      for (const element of layer.listElements())
+        for (const rel of element.relationships || [])
+          RELATIONSHIPS_BY_PREDICATE.has(rel.predicate) || result.addWarning({
+            layer: layerName,
+            elementId: element.path || element.id,
+            message: `Relationship predicate '${rel.predicate}' is not defined in any spec relationship schema`,
+            fixSuggestion: `Run 'dr catalog types' to list valid predicates, or 'dr catalog search ${rel.predicate}' to find the correct predicate`
+          });
   }
 }
 export {

package/dist/validators/semantic-validator.js.map

@@ -1,7 +1,7 @@
 {
   "version": 3,
   "sources": ["../../src/validators/semantic-validator.ts"],
-  "sourcesContent": ["/**\n * Semantic validation for business rules\n */\n\nimport { ValidationResult } from './types.js';\nimport type { Model } from '../core/model.js';\nimport { fileURLToPath } from 'url';\nimport path from 'path';\n\n/**\n * Validator for semantic/business rule validation\n */\nexport class SemanticValidator {\n  private relationshipCatalog: Record<string, any> | null = null;\n  private catalogLoaded: boolean = false;\n\n  constructor() {\n    // Load catalog asynchronously on first use\n  }\n\n  /**\n   * Ensure relationship catalog is loaded\n   */\n  private async ensureCatalogLoaded(): Promise<void> {\n    if (this.catalogLoaded) {\n      return;\n    }\n\n    await this.loadRelationshipCatalog();\n    this.catalogLoaded = true;\n  }\n\n  /**\n   * Load the relationship catalog for predicate validation\n   */\n  private async loadRelationshipCatalog(): Promise<void> {\n    try {\n      const __dirname = path.dirname(fileURLToPath(import.meta.url));\n      const catalogPath = path.join(__dirname, '..', 'schemas', 'bundled', 'relationship-catalog.json');\n      this.relationshipCatalog = await import(catalogPath, { assert: { type: 'json' } }).then(\n        (m) => m.default\n      );\n    } catch {\n      // Catalog load failure is gracefully handled - validation continues without predicate checking\n      this.relationshipCatalog = null;\n    }\n  }\n\n  /**\n   * Validate semantic constraints of a model\n   */\n  async validateModel(model: Model): Promise<ValidationResult> {\n    const result = new ValidationResult();\n\n    await this.ensureCatalogLoaded();\n\n    this.validateUniqueIds(model, result);\n    this.validateRelationshipPredicates(model, result);\n\n    return result;\n  }\n\n  /**\n   * Validate that all element IDs are unique across layers\n   */\n  private validateUniqueIds(model: Model, result: ValidationResult): void {\n    const seenIds = new Map<string, string>(); // id -> layer name\n\n    for (const [layerName, layer] of model.layers) {\n      for (const element of layer.listElements()) {\n        if (seenIds.has(element.id)) {\n          result.addError({\n            layer: layerName,\n            elementId: element.id,\n            message: `Duplicate element ID: '${element.id}' already exists in layer '${seenIds.get(element.id)}'`,\n            fixSuggestion: 'Element IDs must be unique across all layers',\n          });\n        } else {\n          seenIds.set(element.id, layerName);\n        }\n      }\n    }\n  }\n\n  /**\n   * Validate relationship predicates against the catalog\n   */\n  private validateRelationshipPredicates(model: Model, result: ValidationResult): void {\n    if (!this.relationshipCatalog) {\n      // If we can't load the catalog, we can't validate predicates\n      return;\n    }\n\n    for (const [layerName, layer] of model.layers) {\n      const allowedPredicates = this.getAllowedPredicates(layerName);\n\n      for (const element of layer.listElements()) {\n        for (const rel of element.relationships || []) {\n          if (!allowedPredicates.includes(rel.predicate)) {\n            result.addWarning({\n              layer: layerName,\n              elementId: element.id,\n              message: `Unknown relationship predicate '${rel.predicate}' for layer ${layerName}`,\n              fixSuggestion:\n                allowedPredicates.length > 0\n                  ? `Use one of: ${allowedPredicates.join(', ')}`\n                  : 'Check relationship catalog for valid predicates',\n            });\n          }\n        }\n      }\n    }\n  }\n\n  /**\n   * Get allowed predicates for a layer from the catalog\n   */\n  private getAllowedPredicates(layerName: string): string[] {\n    if (!this.relationshipCatalog) {\n      return [];\n    }\n\n    const layerCatalog = this.relationshipCatalog.layers?.[layerName];\n    if (!layerCatalog) {\n      return [];\n    }\n\n    const predicates = layerCatalog.predicates || layerCatalog.relationships || [];\n    return Array.isArray(predicates) ? predicates : Object.keys(predicates || {});\n  }\n}\n"],
-  "mappings": "AAIA,SAAS,wBAAwB;AAEjC,SAAS,qBAAqB;AAC9B,OAAO,UAAU;AAKX,MAAO,kBAAiB;EACpB,sBAAkD;EAClD,gBAAyB;EAEjC,cAAA;EAEA;;;;EAKQ,MAAM,sBAAmB;AAC/B,IAAI,KAAK,kBAIT,MAAM,KAAK,wBAAuB,GAClC,KAAK,gBAAgB;EACvB;;;;EAKQ,MAAM,0BAAuB;AACnC,QAAI;AACF,YAAM,YAAY,KAAK,QAAQ,cAAc,YAAY,GAAG,CAAC,GACvD,cAAc,KAAK,KAAK,WAAW,MAAM,WAAW,WAAW,2BAA2B;AAChG,WAAK,sBAAsB,MAAM,OAAO,aAAa,EAAE,QAAQ,EAAE,MAAM,OAAM,EAAE,GAAI,KACjF,CAAC,MAAM,EAAE,OAAO;IAEpB,QAAQ;AAEN,WAAK,sBAAsB;IAC7B;EACF;;;;EAKA,MAAM,cAAc,OAAY;AAC9B,UAAM,SAAS,IAAI,iBAAgB;AAEnC,iBAAM,KAAK,oBAAmB,GAE9B,KAAK,kBAAkB,OAAO,MAAM,GACpC,KAAK,+BAA+B,OAAO,MAAM,GAE1C;EACT;;;;EAKQ,kBAAkB,OAAc,QAAwB;AAC9D,UAAM,UAAU,oBAAI,IAAG;AAEvB,eAAW,CAAC,WAAW,KAAK,KAAK,MAAM;AACrC,iBAAW,WAAW,MAAM,aAAY;AACtC,QAAI,QAAQ,IAAI,QAAQ,EAAE,IACxB,OAAO,SAAS;UACd,OAAO;UACP,WAAW,QAAQ;UACnB,SAAS,0BAA0B,QAAQ,EAAE,8BAA8B,QAAQ,IAAI,QAAQ,EAAE,CAAC;UAClG,eAAe;SAChB,IAED,QAAQ,IAAI,QAAQ,IAAI,SAAS;EAIzC;;;;EAKQ,+BAA+B,OAAc,QAAwB;AAC3E,QAAK,KAAK;AAKV,iBAAW,CAAC,WAAW,KAAK,KAAK,MAAM,QAAQ;AAC7C,cAAM,oBAAoB,KAAK,qBAAqB,SAAS;AAE7D,mBAAW,WAAW,MAAM,aAAY;AACtC,qBAAW,OAAO,QAAQ,iBAAiB,CAAA;AACzC,YAAK,kBAAkB,SAAS,IAAI,SAAS,KAC3C,OAAO,WAAW;cAChB,OAAO;cACP,WAAW,QAAQ;cACnB,SAAS,mCAAmC,IAAI,SAAS,eAAe,SAAS;cACjF,eACE,kBAAkB,SAAS,IACvB,eAAe,kBAAkB,KAAK,IAAI,CAAC,KAC3C;aACP;MAIT;EACF;;;;EAKQ,qBAAqB,WAAiB;AAC5C,QAAI,CAAC,KAAK;AACR,aAAO,CAAA;AAGT,UAAM,eAAe,KAAK,oBAAoB,SAAS,SAAS;AAChE,QAAI,CAAC;AACH,aAAO,CAAA;AAGT,UAAM,aAAa,aAAa,cAAc,aAAa,iBAAiB,CAAA;AAC5E,WAAO,MAAM,QAAQ,UAAU,IAAI,aAAa,OAAO,KAAK,cAAc,CAAA,CAAE;EAC9E;;",
+  "sourcesContent": ["/**\n * Semantic validation for business rules\n */\n\nimport { ValidationResult } from \"./types.js\";\nimport type { Model } from \"../core/model.js\";\nimport { RELATIONSHIPS_BY_PREDICATE } from \"../generated/relationship-index.js\";\n\n/**\n * Validator for semantic/business rule validation\n *\n * Validates model conformance to architectural business rules including:\n * - Relationship predicate validation against defined spec relationship schemas\n * - Cross-layer reference constraints\n * - Layer-specific validation rules\n */\nexport class SemanticValidator {\n  /**\n   * Validate semantic constraints of a model\n   */\n  async validateModel(model: Model): Promise<ValidationResult> {\n    const result = new ValidationResult();\n\n    this.validateRelationshipPredicates(model, result);\n    this.validateApmInferredWithoutSdk(model, result);\n\n    return result;\n  }\n\n  /**\n   * Rule: apm_inferred_without_sdk\n   *\n   * When the APM layer contains MetricInstrument, Span, TraceConfiguration, or\n   * ExporterConfig elements and ALL of them have source_reference.provenance = \"inferred\",\n   * emit a WARNING suggesting OTel SDK verification.\n   *\n   * Rationale: The APM skill's checklist can cause Claude to add instrumentation\n   * elements without verifying that an OTel SDK is present. This validator surfaces\n   * the accuracy concern on every subsequent `dr validate` run.\n   */\n  private validateApmInferredWithoutSdk(model: Model, result: ValidationResult): void {\n    const apmLayer = model.layers.get(\"apm\");\n    if (!apmLayer) {\n      return;\n    }\n\n    const instrumentationTypes = new Set([\"metricinstrument\", \"span\", \"traceconfiguration\", \"exporterconfig\"]);\n    const instrumentationElements = apmLayer.listElements().filter((e) =>\n      instrumentationTypes.has(e.type)\n    );\n\n    if (instrumentationElements.length === 0) {\n      return;\n    }\n\n    const allInferred = instrumentationElements.every(\n      (e) => e.source_reference?.provenance === \"inferred\"\n    );\n\n    if (allInferred) {\n      result.addWarning({\n        layer: \"apm\",\n        elementId: \"apm.*\",\n        message:\n          `All ${instrumentationElements.length} APM instrumentation element(s) have provenance: inferred. ` +\n          \"If no @opentelemetry SDK exists in package.json, these elements are aspirational rather than \" +\n          \"implemented. Consider marking them as such in their descriptions.\",\n        fixSuggestion:\n          \"Run: grep '@opentelemetry' package.json \u2014 if absent, update element descriptions to note \" +\n          \"that instrumentation is aspirational and no OTel export is implemented.\",\n      });\n    }\n  }\n\n  /**\n   * Validate relationship predicates against the generated spec relationship index.\n   * RELATIONSHIPS_BY_PREDICATE is compiled from all spec relationship schema files,\n   * so it is always consistent with the spec without manual synchronization.\n   */\n  private validateRelationshipPredicates(model: Model, result: ValidationResult): void {\n    for (const [layerName, layer] of model.layers) {\n      for (const element of layer.listElements()) {\n        for (const rel of element.relationships || []) {\n          if (!RELATIONSHIPS_BY_PREDICATE.has(rel.predicate)) {\n            result.addWarning({\n              layer: layerName,\n              elementId: element.path || element.id,\n              message: `Relationship predicate '${rel.predicate}' is not defined in any spec relationship schema`,\n              fixSuggestion: `Run 'dr catalog types' to list valid predicates, or 'dr catalog search ${rel.predicate}' to find the correct predicate`,\n            });\n          }\n        }\n      }\n    }\n  }\n}\n"],
+  "mappings": "AAIA,SAAS,wBAAwB;AAEjC,SAAS,kCAAkC;AAUrC,MAAO,kBAAiB;;;;EAI5B,MAAM,cAAc,OAAY;AAC9B,UAAM,SAAS,IAAI,iBAAgB;AAEnC,gBAAK,+BAA+B,OAAO,MAAM,GACjD,KAAK,8BAA8B,OAAO,MAAM,GAEzC;EACT;;;;;;;;;;;;EAaQ,8BAA8B,OAAc,QAAwB;AAC1E,UAAM,WAAW,MAAM,OAAO,IAAI,KAAK;AACvC,QAAI,CAAC;AACH;AAGF,UAAM,uBAAuB,oBAAI,IAAI,CAAC,oBAAoB,QAAQ,sBAAsB,gBAAgB,CAAC,GACnG,0BAA0B,SAAS,aAAY,EAAG,OAAO,CAAC,MAC9D,qBAAqB,IAAI,EAAE,IAAI,CAAC;AAGlC,QAAI,wBAAwB,WAAW;AACrC;AAOF,IAJoB,wBAAwB,MAC1C,CAAC,MAAM,EAAE,kBAAkB,eAAe,UAAU,KAIpD,OAAO,WAAW;MAChB,OAAO;MACP,WAAW;MACX,SACE,OAAO,wBAAwB,MAAM;MAGvC,eACE;KAEH;EAEL;;;;;;EAOQ,+BAA+B,OAAc,QAAwB;AAC3E,eAAW,CAAC,WAAW,KAAK,KAAK,MAAM;AACrC,iBAAW,WAAW,MAAM,aAAY;AACtC,mBAAW,OAAO,QAAQ,iBAAiB,CAAA;AACzC,UAAK,2BAA2B,IAAI,IAAI,SAAS,KAC/C,OAAO,WAAW;YAChB,OAAO;YACP,WAAW,QAAQ,QAAQ,QAAQ;YACnC,SAAS,2BAA2B,IAAI,SAAS;YACjD,eAAe,0EAA0E,IAAI,SAAS;WACvG;EAKX;;",
   "names": []
 }

package/dist/validators/types.js.map

@@ -1,7 +1,7 @@
 {
   "version": 3,
   "sources": ["../../src/validators/types.ts"],
-  "sourcesContent": ["/**\n * Validation result types and classes\n */\n\n/**\n * A single validation issue\n */\nexport interface ValidationIssue {\n  layer: string;\n  elementId?: string;\n  message: string;\n  severity: 'error' | 'warning';\n  location?: string;\n  fixSuggestion?: string;\n}\n\n/**\n * Result of a validation operation\n */\nexport class ValidationResult {\n  errors: ValidationIssue[] = [];\n  warnings: ValidationIssue[] = [];\n\n  /**\n   * Check if validation passed (no errors)\n   */\n  isValid(): boolean {\n    return this.errors.length === 0;\n  }\n\n  /**\n   * Add an error to the result\n   */\n  addError(issue: Omit<ValidationIssue, 'severity'>): void {\n    this.errors.push({ ...issue, severity: 'error' });\n  }\n\n  /**\n   * Add a warning to the result\n   */\n  addWarning(issue: Omit<ValidationIssue, 'severity'>): void {\n    this.warnings.push({ ...issue, severity: 'warning' });\n  }\n\n  /**\n   * Merge another validation result into this one\n   */\n  merge(other: ValidationResult, prefix?: string): void {\n    const addPrefix = (issue: ValidationIssue): ValidationIssue => ({\n      ...issue,\n      message: prefix ? `${prefix}: ${issue.message}` : issue.message,\n    });\n\n    this.errors.push(...other.errors.map(addPrefix));\n    this.warnings.push(...other.warnings.map(addPrefix));\n  }\n\n  /**\n   * Convert to dictionary representation\n   */\n  toDict(): Record<string, unknown> {\n    return {\n      valid: this.isValid(),\n      errors: this.errors,\n      warnings: this.warnings,\n      errorCount: this.errors.length,\n      warningCount: this.warnings.length,\n    };\n  }\n}\n"],
-  "mappings": "AAmBM,MAAO,iBAAgB;EAC3B,SAA4B,CAAA;EAC5B,WAA8B,CAAA;;;;EAK9B,UAAO;AACL,WAAO,KAAK,OAAO,WAAW;EAChC;;;;EAKA,SAAS,OAAwC;AAC/C,SAAK,OAAO,KAAK,EAAE,GAAG,OAAO,UAAU,QAAO,CAAE;EAClD;;;;EAKA,WAAW,OAAwC;AACjD,SAAK,SAAS,KAAK,EAAE,GAAG,OAAO,UAAU,UAAS,CAAE;EACtD;;;;EAKA,MAAM,OAAyB,QAAe;AAC5C,UAAM,YAAY,CAAC,WAA6C;MAC9D,GAAG;MACH,SAAS,SAAS,GAAG,MAAM,KAAK,MAAM,OAAO,KAAK,MAAM;;AAG1D,SAAK,OAAO,KAAK,GAAG,MAAM,OAAO,IAAI,SAAS,CAAC,GAC/C,KAAK,SAAS,KAAK,GAAG,MAAM,SAAS,IAAI,SAAS,CAAC;EACrD;;;;EAKA,SAAM;AACJ,WAAO;MACL,OAAO,KAAK,QAAO;MACnB,QAAQ,KAAK;MACb,UAAU,KAAK;MACf,YAAY,KAAK,OAAO;MACxB,cAAc,KAAK,SAAS;;EAEhC;;",
+  "sourcesContent": ["/**\n * Validation result types and classes\n */\n\n/**\n * A single validation issue\n */\nexport interface ValidationIssue {\n  layer: string;\n  elementId?: string;\n  message: string;\n  severity: \"error\" | \"warning\";\n  category?: \"orphan\" | \"schema\" | \"semantic\" | \"reference\";\n  location?: string;\n  fixSuggestion?: string;\n}\n\n/**\n * Result of a validation operation\n */\nexport class ValidationResult {\n  errors: ValidationIssue[] = [];\n  warnings: ValidationIssue[] = [];\n\n  /**\n   * Check if validation passed (no errors)\n   */\n  isValid(): boolean {\n    return this.errors.length === 0;\n  }\n\n  /**\n   * Add an error to the result\n   */\n  addError(issue: Omit<ValidationIssue, \"severity\">): void {\n    this.errors.push({ ...issue, severity: \"error\" });\n  }\n\n  /**\n   * Add a warning to the result\n   */\n  addWarning(issue: Omit<ValidationIssue, \"severity\">): void {\n    this.warnings.push({ ...issue, severity: \"warning\" });\n  }\n\n  /**\n   * Merge another validation result into this one\n   */\n  merge(other: ValidationResult, prefix?: string): void {\n    const addPrefix = (issue: ValidationIssue): ValidationIssue => ({\n      ...issue,\n      message: prefix ? `${prefix}: ${issue.message}` : issue.message,\n    });\n\n    this.errors.push(...other.errors.map(addPrefix));\n    this.warnings.push(...other.warnings.map(addPrefix));\n  }\n\n  /**\n   * Convert to dictionary representation\n   */\n  toDict(): Record<string, unknown> {\n    return {\n      valid: this.isValid(),\n      errors: this.errors,\n      warnings: this.warnings,\n      errorCount: this.errors.length,\n      warningCount: this.warnings.length,\n    };\n  }\n}\n"],
+  "mappings": "AAoBM,MAAO,iBAAgB;EAC3B,SAA4B,CAAA;EAC5B,WAA8B,CAAA;;;;EAK9B,UAAO;AACL,WAAO,KAAK,OAAO,WAAW;EAChC;;;;EAKA,SAAS,OAAwC;AAC/C,SAAK,OAAO,KAAK,EAAE,GAAG,OAAO,UAAU,QAAO,CAAE;EAClD;;;;EAKA,WAAW,OAAwC;AACjD,SAAK,SAAS,KAAK,EAAE,GAAG,OAAO,UAAU,UAAS,CAAE;EACtD;;;;EAKA,MAAM,OAAyB,QAAe;AAC5C,UAAM,YAAY,CAAC,WAA6C;MAC9D,GAAG;MACH,SAAS,SAAS,GAAG,MAAM,KAAK,MAAM,OAAO,KAAK,MAAM;;AAG1D,SAAK,OAAO,KAAK,GAAG,MAAM,OAAO,IAAI,SAAS,CAAC,GAC/C,KAAK,SAAS,KAAK,GAAG,MAAM,SAAS,IAAI,SAAS,CAAC;EACrD;;;;EAKA,SAAM;AACJ,WAAO;MACL,OAAO,KAAK,QAAO;MACnB,QAAQ,KAAK;MACb,UAAU,KAAK;MACf,YAAY,KAAK,OAAO;MACxB,cAAc,KAAK,SAAS;;EAEhC;;",
   "names": []
 }

package/dist/validators/validation-formatter.js

@@ -0,0 +1,159 @@
+import ansis from "ansis";
+import { formatLayerNameWithSuffix } from "../utils/layer-name-formatter.js";
+class ValidationFormatter {
+  /**
+   * Format validation result for display
+   */
+  static format(result, model, options = {}) {
+    return options.quiet ? this.formatQuiet(result) : options.verbose ? this.formatVerbose(result, model) : this.formatStandard(result, model);
+  }
+  /**
+   * Format quiet output (minimal)
+   */
+  static formatQuiet(result) {
+    if (result.isValid() && result.warnings.length === 0)
+      return ansis.green("\u2713 Validation passed");
+    const lines = [];
+    return result.errors.length > 0 && lines.push(ansis.red(`\u2717 ${result.errors.length} error(s)`)), result.warnings.length > 0 && lines.push(ansis.yellow(`\u26A0 ${result.warnings.length} warning(s)`)), lines.join(" ");
+  }
+  /**
+   * Format standard output (enhanced with stats)
+   */
+  static formatStandard(result, model) {
+    const lines = [];
+    lines.push(""), lines.push(ansis.bold("Validating Documentation Robotics Model")), lines.push(ansis.bold("========================================")), lines.push(""), lines.push(ansis.bold("Schema Validation:"));
+    const layerStats = this.getLayerStats(model);
+    for (const [layerName, count] of Object.entries(layerStats))
+      if (result.errors.some((e) => e.layer === layerName)) {
+        const errorCount = result.errors.filter((e) => e.layer === layerName).length;
+        lines.push(`${ansis.red("\u2717")} ${formatLayerNameWithSuffix(layerName)} (${count} elements) - ${errorCount} error(s)`);
+      } else
+        lines.push(`${ansis.green("\u2713")} ${formatLayerNameWithSuffix(layerName)} (${count} elements)`);
+    lines.push(""), lines.push(ansis.bold("Cross-Layer Validation:"));
+    const stats = this.calculateStats(model);
+    lines.push(`${ansis.green("\u2713")} ${stats.totalRelationships} relationships validated`), lines.push(""), result.errors.length > 0 && (lines.push(ansis.bold("Errors:")), lines.push(""), result.errors.forEach((error, index) => {
+      lines.push(`${index + 1}. ${error.message}`), error.location && lines.push(`   ${ansis.dim(`File: ${error.location}`)}`), error.elementId && lines.push(`   ${ansis.dim(`Element: ${error.elementId}`)}`), error.fixSuggestion && lines.push(`   ${ansis.dim(`\u2192 Suggestion: ${error.fixSuggestion}`)}`), lines.push("");
+    }));
+    const schemaWarnings = result.warnings.filter((w) => w.category !== "orphan"), orphanWarnings = result.warnings.filter((w) => w.category === "orphan");
+    return schemaWarnings.length > 0 && (lines.push(ansis.bold("Warnings:")), lines.push(""), schemaWarnings.forEach((warning, index) => {
+      lines.push(`${index + 1}. ${warning.message}`), warning.location && lines.push(`   ${ansis.dim(`File: ${warning.location}`)}`), warning.elementId && lines.push(`   ${ansis.dim(`Element: ${warning.elementId}`)}`), warning.fixSuggestion && lines.push(`   ${ansis.dim(`\u2192 Suggestion: ${warning.fixSuggestion}`)}`), lines.push("");
+    })), orphanWarnings.length > 0 && (lines.push(ansis.bold("Connectivity Warnings:")), lines.push(ansis.dim(`  ${orphanWarnings.length} element(s) have no cross-layer references or intra-layer relationships.`)), lines.push(ansis.dim("  These are connectivity gaps, not structural errors \u2014 the model schema is valid.")), lines.push(""), orphanWarnings.forEach((warning, index) => {
+      lines.push(`${index + 1}. ${warning.message}`), warning.elementId && lines.push(`   ${ansis.dim(`Element: ${warning.elementId}`)}`), warning.fixSuggestion && lines.push(`   ${ansis.dim(`\u2192 Suggestion: ${warning.fixSuggestion}`)}`), lines.push("");
+    })), lines.push(ansis.bold("Summary:")), lines.push(`${result.errors.length === 0 ? ansis.green("\u2713") : ansis.red("\u2717")} ${stats.totalElements} total elements validated`), lines.push(`${ansis.green("\u2713")} ${stats.totalRelationships} relationships validated`), lines.push(`${ansis.green("\u2713")} ${Object.keys(layerStats).length} layers validated`), lines.push(`${result.errors.length === 0 ? ansis.green("\u2713") : ansis.red("\u2717")} ${result.errors.length} error(s), ${result.warnings.length} warning(s)`), lines.push(""), result.isValid() ? result.warnings.length === 0 ? lines.push(ansis.green("Model is valid and ready for use.")) : lines.push(ansis.yellow("Model is valid but consider addressing warnings.")) : lines.push(ansis.red("Model validation failed. Please fix errors before proceeding.")), lines.push(""), lines.join(`
+`);
+  }
+  /**
+   * Format verbose output (detailed with relationship breakdown)
+   */
+  static formatVerbose(result, model) {
+    const lines = this.formatStandard(result, model).split(`
+`), crossLayerIndex = lines.findIndex((l) => l.includes("Cross-Layer Validation:"));
+    if (crossLayerIndex >= 0) {
+      const stats = this.calculateStats(model), relationshipLines = [];
+      if (Object.keys(stats.relationshipsByPredicate).length > 0) {
+        relationshipLines.push(""), relationshipLines.push(ansis.dim("Relationship breakdown:"));
+        for (const [predicate, count] of Object.entries(stats.relationshipsByPredicate).sort())
+          relationshipLines.push(ansis.dim(`  \u2022 ${predicate}: ${count} relationship(s)`));
+      }
+      lines.splice(crossLayerIndex + 4, 0, ...relationshipLines);
+    }
+    return lines.join(`
+`);
+  }
+  /**
+   * Get statistics about layers
+   */
+  static getLayerStats(model) {
+    const stats = {};
+    for (const [layerName, layer] of model.layers) {
+      const count = layer.listElements().length;
+      count > 0 && (stats[layerName] = count);
+    }
+    return stats;
+  }
+  /**
+   * Calculate validation statistics
+   */
+  static calculateStats(model) {
+    const stats = {
+      totalElements: 0,
+      totalRelationships: 0,
+      elementsPerLayer: {},
+      relationshipsByPredicate: {},
+      orphanedElements: []
+    }, elementIds = /* @__PURE__ */ new Set(), crossLayerRefCounts = /* @__PURE__ */ new Map();
+    for (const [layerName, layer] of model.layers) {
+      let layerCount = 0;
+      for (const element of layer.listElements()) {
+        elementIds.add(element.path || element.id), layerCount++, stats.totalElements++;
+        const refCount = (element.references || []).length;
+        crossLayerRefCounts.set(element.path || element.id, refCount), stats.totalRelationships += refCount;
+        for (const ref of element.references || []) {
+          const predicate = ref.type || "references";
+          stats.relationshipsByPredicate[predicate] = (stats.relationshipsByPredicate[predicate] || 0) + 1;
+        }
+      }
+      layerCount > 0 && (stats.elementsPerLayer[layerName] = layerCount);
+    }
+    const intraLayerRels = model.relationships.getAll();
+    stats.totalRelationships += intraLayerRels.length;
+    const connectedViaIntraLayer = /* @__PURE__ */ new Set();
+    for (const rel of intraLayerRels)
+      stats.relationshipsByPredicate[rel.predicate] = (stats.relationshipsByPredicate[rel.predicate] || 0) + 1, connectedViaIntraLayer.add(rel.source), connectedViaIntraLayer.add(rel.target);
+    for (const elementId of elementIds) {
+      if (connectedViaIntraLayer.has(elementId))
+        continue;
+      const outgoingCrossLayer = crossLayerRefCounts.get(elementId) || 0;
+      let incomingCrossLayer = 0;
+      for (const [, layer] of model.layers)
+        for (const element of layer.listElements())
+          for (const ref of element.references || [])
+            ref.target === elementId && incomingCrossLayer++;
+      outgoingCrossLayer === 0 && incomingCrossLayer === 0 && stats.orphanedElements.push(elementId);
+    }
+    return stats;
+  }
+  /**
+   * Export validation result as JSON
+   */
+  static toJSON(result, model) {
+    const stats = this.calculateStats(model), layerStats = this.getLayerStats(model);
+    return {
+      valid: result.isValid(),
+      summary: {
+        totalElements: stats.totalElements,
+        totalRelationships: stats.totalRelationships,
+        errorCount: result.errors.length,
+        warningCount: result.warnings.length,
+        orphanedCount: stats.orphanedElements.length,
+        layersValidated: Object.keys(layerStats).length
+      },
+      layerStats,
+      relationshipsByPredicate: stats.relationshipsByPredicate,
+      orphanedElements: stats.orphanedElements,
+      errors: result.errors,
+      warnings: result.warnings
+    };
+  }
+  /**
+   * Export validation result as Markdown
+   */
+  static toMarkdown(result, model) {
+    const lines = [], stats = this.calculateStats(model), layerStats = this.getLayerStats(model);
+    lines.push("# Validation Report"), lines.push(""), lines.push(`**Status**: ${result.isValid() ? "\u2713 Valid" : "\u2717 Invalid"}`), lines.push(`**Generated**: ${(/* @__PURE__ */ new Date()).toISOString()}`), lines.push(""), lines.push("## Summary"), lines.push(""), lines.push("| Metric | Value |"), lines.push("|--------|-------|"), lines.push(`| Total Elements | ${stats.totalElements} |`), lines.push(`| Total Relationships | ${stats.totalRelationships} |`), lines.push(`| Layers Validated | ${Object.keys(layerStats).length} |`), lines.push(`| Errors | ${result.errors.length} |`), lines.push(`| Warnings | ${result.warnings.length} |`), lines.push(`| Orphaned Elements | ${stats.orphanedElements.length} |`), lines.push(""), lines.push("## Layer Statistics"), lines.push("");
+    for (const [layerName, count] of Object.entries(layerStats)) {
+      const status = result.errors.some((e) => e.layer === layerName) ? "\u2717" : "\u2713";
+      lines.push(`- ${status} ${layerName}: ${count} elements`);
+    }
+    return lines.push(""), result.errors.length > 0 && (lines.push("## Errors"), lines.push(""), result.errors.forEach((error, index) => {
+      lines.push(`### ${index + 1}. ${error.message}`), lines.push(""), error.location && lines.push(`**File**: \`${error.location}\``), error.elementId && lines.push(`**Element**: \`${error.elementId}\``), error.fixSuggestion && lines.push(`**Suggestion**: ${error.fixSuggestion}`), lines.push("");
+    })), result.warnings.length > 0 && (lines.push("## Warnings"), lines.push(""), result.warnings.forEach((warning, index) => {
+      lines.push(`### ${index + 1}. ${warning.message}`), lines.push(""), warning.location && lines.push(`**File**: \`${warning.location}\``), warning.elementId && lines.push(`**Element**: \`${warning.elementId}\``), warning.fixSuggestion && lines.push(`**Suggestion**: ${warning.fixSuggestion}`), lines.push("");
+    })), lines.join(`
+`);
+  }
+}
+export {
+  ValidationFormatter
+};
+//# sourceMappingURL=validation-formatter.js.map

package/dist/validators/validation-formatter.js.map

@@ -0,0 +1,7 @@
+{
+  "version": 3,
+  "sources": ["../../src/validators/validation-formatter.ts"],
+  "sourcesContent": ["/**\n * Validation formatter for detailed and actionable output\n */\n\nimport ansis from \"ansis\";\nimport type { ValidationResult } from \"./types.js\";\nimport type { Model } from \"../core/model.js\";\nimport { formatLayerNameWithSuffix } from \"../utils/layer-name-formatter.js\";\n\ninterface ValidationStats {\n  totalElements: number;\n  totalRelationships: number;\n  elementsPerLayer: Record<string, number>;\n  relationshipsByPredicate: Record<string, number>;\n  orphanedElements: string[];\n}\n\n/**\n * Formats validation results into detailed, human-readable output\n */\nexport class ValidationFormatter {\n  /**\n   * Format validation result for display\n   */\n  static format(\n    result: ValidationResult,\n    model: Model,\n    options: {\n      verbose?: boolean;\n      quiet?: boolean;\n    } = {}\n  ): string {\n    if (options.quiet) {\n      return this.formatQuiet(result);\n    }\n\n    if (options.verbose) {\n      return this.formatVerbose(result, model);\n    }\n\n    return this.formatStandard(result, model);\n  }\n\n  /**\n   * Format quiet output (minimal)\n   */\n  private static formatQuiet(result: ValidationResult): string {\n    if (result.isValid() && result.warnings.length === 0) {\n      return ansis.green(\"\u2713 Validation passed\");\n    }\n\n    const lines: string[] = [];\n\n    if (result.errors.length > 0) {\n      lines.push(ansis.red(`\u2717 ${result.errors.length} error(s)`));\n    }\n\n    if (result.warnings.length > 0) {\n      lines.push(ansis.yellow(`\u26A0 ${result.warnings.length} warning(s)`));\n    }\n\n    return lines.join(\" \");\n  }\n\n  /**\n   * Format standard output (enhanced with stats)\n   */\n  private static formatStandard(result: ValidationResult, model: Model): string {\n    const lines: string[] = [];\n\n    lines.push(\"\");\n    lines.push(ansis.bold(\"Validating Documentation Robotics Model\"));\n    lines.push(ansis.bold(\"========================================\"));\n    lines.push(\"\");\n\n    // Layer-by-layer validation summary\n    lines.push(ansis.bold(\"Schema Validation:\"));\n    const layerStats = this.getLayerStats(model);\n    for (const [layerName, count] of Object.entries(layerStats)) {\n      const hasErrors = result.errors.some((e) => e.layer === layerName);\n      if (hasErrors) {\n        const errorCount = result.errors.filter((e) => e.layer === layerName).length;\n        lines.push(\n          `${ansis.red(\"\u2717\")} ${formatLayerNameWithSuffix(layerName)} (${count} elements) - ${errorCount} error(s)`\n        );\n      } else {\n        lines.push(`${ansis.green(\"\u2713\")} ${formatLayerNameWithSuffix(layerName)} (${count} elements)`);\n      }\n    }\n\n    lines.push(\"\");\n\n    // Cross-layer validation\n    lines.push(ansis.bold(\"Cross-Layer Validation:\"));\n    const stats = this.calculateStats(model);\n    lines.push(\n      `${ansis.green(\"\u2713\")} ${stats.totalRelationships} relationships validated`\n    );\n\n    // Orphaned element warnings are injected into result.warnings in validate.ts\n    // so they appear in the warnings section and are counted in the summary.\n    // Do not display a separate orphan count here to avoid double-reporting.\n\n    lines.push(\"\");\n\n    // Error details\n    if (result.errors.length > 0) {\n      lines.push(ansis.bold(\"Errors:\"));\n      lines.push(\"\");\n      result.errors.forEach((error, index) => {\n        lines.push(`${index + 1}. ${error.message}`);\n        if (error.location) {\n          lines.push(`   ${ansis.dim(`File: ${error.location}`)}`);\n        }\n        if (error.elementId) {\n          lines.push(`   ${ansis.dim(`Element: ${error.elementId}`)}`);\n        }\n        if (error.fixSuggestion) {\n          lines.push(`   ${ansis.dim(`\u2192 Suggestion: ${error.fixSuggestion}`)}`);\n        }\n        lines.push(\"\");\n      });\n    }\n\n    // Warning details \u2014 split schema/semantic warnings from connectivity (orphan) warnings\n    const schemaWarnings = result.warnings.filter((w) => w.category !== \"orphan\");\n    const orphanWarnings = result.warnings.filter((w) => w.category === \"orphan\");\n\n    if (schemaWarnings.length > 0) {\n      lines.push(ansis.bold(\"Warnings:\"));\n      lines.push(\"\");\n      schemaWarnings.forEach((warning, index) => {\n        lines.push(`${index + 1}. ${warning.message}`);\n        if (warning.location) {\n          lines.push(`   ${ansis.dim(`File: ${warning.location}`)}`);\n        }\n        if (warning.elementId) {\n          lines.push(`   ${ansis.dim(`Element: ${warning.elementId}`)}`);\n        }\n        if (warning.fixSuggestion) {\n          lines.push(`   ${ansis.dim(`\u2192 Suggestion: ${warning.fixSuggestion}`)}`);\n        }\n        lines.push(\"\");\n      });\n    }\n\n    if (orphanWarnings.length > 0) {\n      lines.push(ansis.bold(\"Connectivity Warnings:\"));\n      lines.push(\n        ansis.dim(\n          `  ${orphanWarnings.length} element(s) have no cross-layer references or intra-layer relationships.`\n        )\n      );\n      lines.push(\n        ansis.dim(\"  These are connectivity gaps, not structural errors \u2014 the model schema is valid.\")\n      );\n      lines.push(\"\");\n      orphanWarnings.forEach((warning, index) => {\n        lines.push(`${index + 1}. ${warning.message}`);\n        if (warning.elementId) {\n          lines.push(`   ${ansis.dim(`Element: ${warning.elementId}`)}`);\n        }\n        if (warning.fixSuggestion) {\n          lines.push(`   ${ansis.dim(`\u2192 Suggestion: ${warning.fixSuggestion}`)}`);\n        }\n        lines.push(\"\");\n      });\n    }\n\n    // Summary\n    lines.push(ansis.bold(\"Summary:\"));\n    lines.push(\n      `${result.errors.length === 0 ? ansis.green(\"\u2713\") : ansis.red(\"\u2717\")} ${stats.totalElements} total elements validated`\n    );\n    lines.push(`${ansis.green(\"\u2713\")} ${stats.totalRelationships} relationships validated`);\n    lines.push(`${ansis.green(\"\u2713\")} ${Object.keys(layerStats).length} layers validated`);\n    lines.push(\n      `${result.errors.length === 0 ? ansis.green(\"\u2713\") : ansis.red(\"\u2717\")} ${result.errors.length} error(s), ${result.warnings.length} warning(s)`\n    );\n    lines.push(\"\");\n\n    if (result.isValid()) {\n      if (result.warnings.length === 0) {\n        lines.push(ansis.green(\"Model is valid and ready for use.\"));\n      } else {\n        lines.push(ansis.yellow(\"Model is valid but consider addressing warnings.\"));\n      }\n    } else {\n      lines.push(ansis.red(\"Model validation failed. Please fix errors before proceeding.\"));\n    }\n\n    lines.push(\"\");\n\n    return lines.join(\"\\n\");\n  }\n\n  /**\n   * Format verbose output (detailed with relationship breakdown)\n   */\n  private static formatVerbose(result: ValidationResult, model: Model): string {\n    const standard = this.formatStandard(result, model);\n    const lines = standard.split(\"\\n\");\n\n    // Find the \"Cross-Layer Validation:\" section and expand it\n    const crossLayerIndex = lines.findIndex((l) => l.includes(\"Cross-Layer Validation:\"));\n    if (crossLayerIndex >= 0) {\n      const stats = this.calculateStats(model);\n      const relationshipLines: string[] = [];\n\n      // Add breakdown by relationship type\n      if (Object.keys(stats.relationshipsByPredicate).length > 0) {\n        relationshipLines.push(\"\");\n        relationshipLines.push(ansis.dim(\"Relationship breakdown:\"));\n        for (const [predicate, count] of Object.entries(stats.relationshipsByPredicate).sort()) {\n          relationshipLines.push(ansis.dim(`  \u2022 ${predicate}: ${count} relationship(s)`));\n        }\n      }\n\n      // Insert after the cross-layer section\n      lines.splice(crossLayerIndex + 4, 0, ...relationshipLines);\n    }\n\n    return lines.join(\"\\n\");\n  }\n\n  /**\n   * Get statistics about layers\n   */\n  private static getLayerStats(model: Model): Record<string, number> {\n    const stats: Record<string, number> = {};\n\n    for (const [layerName, layer] of model.layers) {\n      const count = layer.listElements().length;\n      if (count > 0) {\n        stats[layerName] = count;\n      }\n    }\n\n    return stats;\n  }\n\n  /**\n   * Calculate validation statistics\n   */\n  static calculateStats(model: Model): ValidationStats {\n    const stats: ValidationStats = {\n      totalElements: 0,\n      totalRelationships: 0,\n      elementsPerLayer: {},\n      relationshipsByPredicate: {},\n      orphanedElements: [],\n    };\n\n    const elementIds = new Set<string>();\n    const crossLayerRefCounts = new Map<string, number>();\n\n    // Count elements and cross-layer references (element.references[])\n    for (const [layerName, layer] of model.layers) {\n      let layerCount = 0;\n      for (const element of layer.listElements()) {\n        elementIds.add(element.path || element.id);\n        layerCount++;\n        stats.totalElements++;\n\n        const refCount = (element.references || []).length;\n        crossLayerRefCounts.set(element.path || element.id, refCount);\n        stats.totalRelationships += refCount;\n\n        for (const ref of element.references || []) {\n          const predicate = ref.type || \"references\";\n          stats.relationshipsByPredicate[predicate] =\n            (stats.relationshipsByPredicate[predicate] || 0) + 1;\n        }\n      }\n\n      if (layerCount > 0) {\n        stats.elementsPerLayer[layerName] = layerCount;\n      }\n    }\n\n    // Also count intra-layer relationships from relationships.yaml\n    const intraLayerRels = model.relationships.getAll();\n    stats.totalRelationships += intraLayerRels.length;\n    const connectedViaIntraLayer = new Set<string>();\n    for (const rel of intraLayerRels) {\n      stats.relationshipsByPredicate[rel.predicate] =\n        (stats.relationshipsByPredicate[rel.predicate] || 0) + 1;\n      connectedViaIntraLayer.add(rel.source);\n      connectedViaIntraLayer.add(rel.target);\n    }\n\n    // Find orphaned elements: no cross-layer refs and not touched by any intra-layer relationship\n    for (const elementId of elementIds) {\n      if (connectedViaIntraLayer.has(elementId)) {\n        continue;\n      }\n\n      const outgoingCrossLayer = crossLayerRefCounts.get(elementId) || 0;\n      let incomingCrossLayer = 0;\n      for (const [, layer] of model.layers) {\n        for (const element of layer.listElements()) {\n          for (const ref of element.references || []) {\n            if (ref.target === elementId) {\n              incomingCrossLayer++;\n            }\n          }\n        }\n      }\n\n      if (outgoingCrossLayer === 0 && incomingCrossLayer === 0) {\n        stats.orphanedElements.push(elementId);\n      }\n    }\n\n    return stats;\n  }\n\n  /**\n   * Export validation result as JSON\n   */\n  static toJSON(result: ValidationResult, model: Model): Record<string, unknown> {\n    const stats = this.calculateStats(model);\n    const layerStats = this.getLayerStats(model);\n\n    return {\n      valid: result.isValid(),\n      summary: {\n        totalElements: stats.totalElements,\n        totalRelationships: stats.totalRelationships,\n        errorCount: result.errors.length,\n        warningCount: result.warnings.length,\n        orphanedCount: stats.orphanedElements.length,\n        layersValidated: Object.keys(layerStats).length,\n      },\n      layerStats,\n      relationshipsByPredicate: stats.relationshipsByPredicate,\n      orphanedElements: stats.orphanedElements,\n      errors: result.errors,\n      warnings: result.warnings,\n    };\n  }\n\n  /**\n   * Export validation result as Markdown\n   */\n  static toMarkdown(result: ValidationResult, model: Model): string {\n    const lines: string[] = [];\n    const stats = this.calculateStats(model);\n    const layerStats = this.getLayerStats(model);\n\n    lines.push(\"# Validation Report\");\n    lines.push(\"\");\n    lines.push(`**Status**: ${result.isValid() ? \"\u2713 Valid\" : \"\u2717 Invalid\"}`);\n    lines.push(`**Generated**: ${new Date().toISOString()}`);\n    lines.push(\"\");\n\n    lines.push(\"## Summary\");\n    lines.push(\"\");\n    lines.push(`| Metric | Value |`);\n    lines.push(`|--------|-------|`);\n    lines.push(`| Total Elements | ${stats.totalElements} |`);\n    lines.push(`| Total Relationships | ${stats.totalRelationships} |`);\n    lines.push(`| Layers Validated | ${Object.keys(layerStats).length} |`);\n    lines.push(`| Errors | ${result.errors.length} |`);\n    lines.push(`| Warnings | ${result.warnings.length} |`);\n    lines.push(`| Orphaned Elements | ${stats.orphanedElements.length} |`);\n    lines.push(\"\");\n\n    lines.push(\"## Layer Statistics\");\n    lines.push(\"\");\n    for (const [layerName, count] of Object.entries(layerStats)) {\n      const hasErrors = result.errors.some((e) => e.layer === layerName);\n      const status = hasErrors ? \"\u2717\" : \"\u2713\";\n      lines.push(`- ${status} ${layerName}: ${count} elements`);\n    }\n    lines.push(\"\");\n\n    if (result.errors.length > 0) {\n      lines.push(\"## Errors\");\n      lines.push(\"\");\n      result.errors.forEach((error, index) => {\n        lines.push(`### ${index + 1}. ${error.message}`);\n        lines.push(\"\");\n        if (error.location) {\n          lines.push(`**File**: \\`${error.location}\\``);\n        }\n        if (error.elementId) {\n          lines.push(`**Element**: \\`${error.elementId}\\``);\n        }\n        if (error.fixSuggestion) {\n          lines.push(`**Suggestion**: ${error.fixSuggestion}`);\n        }\n        lines.push(\"\");\n      });\n    }\n\n    if (result.warnings.length > 0) {\n      lines.push(\"## Warnings\");\n      lines.push(\"\");\n      result.warnings.forEach((warning, index) => {\n        lines.push(`### ${index + 1}. ${warning.message}`);\n        lines.push(\"\");\n        if (warning.location) {\n          lines.push(`**File**: \\`${warning.location}\\``);\n        }\n        if (warning.elementId) {\n          lines.push(`**Element**: \\`${warning.elementId}\\``);\n        }\n        if (warning.fixSuggestion) {\n          lines.push(`**Suggestion**: ${warning.fixSuggestion}`);\n        }\n        lines.push(\"\");\n      });\n    }\n\n    return lines.join(\"\\n\");\n  }\n}\n"],
+  "mappings": "AAIA,OAAO,WAAW;AAGlB,SAAS,iCAAiC;AAapC,MAAO,oBAAmB;;;;EAI9B,OAAO,OACL,QACA,OACA,UAGI,CAAA,GAAE;AAEN,WAAI,QAAQ,QACH,KAAK,YAAY,MAAM,IAG5B,QAAQ,UACH,KAAK,cAAc,QAAQ,KAAK,IAGlC,KAAK,eAAe,QAAQ,KAAK;EAC1C;;;;EAKQ,OAAO,YAAY,QAAwB;AACjD,QAAI,OAAO,QAAO,KAAM,OAAO,SAAS,WAAW;AACjD,aAAO,MAAM,MAAM,0BAAqB;AAG1C,UAAM,QAAkB,CAAA;AAExB,WAAI,OAAO,OAAO,SAAS,KACzB,MAAM,KAAK,MAAM,IAAI,UAAK,OAAO,OAAO,MAAM,WAAW,CAAC,GAGxD,OAAO,SAAS,SAAS,KAC3B,MAAM,KAAK,MAAM,OAAO,UAAK,OAAO,SAAS,MAAM,aAAa,CAAC,GAG5D,MAAM,KAAK,GAAG;EACvB;;;;EAKQ,OAAO,eAAe,QAA0B,OAAY;AAClE,UAAM,QAAkB,CAAA;AAExB,UAAM,KAAK,EAAE,GACb,MAAM,KAAK,MAAM,KAAK,yCAAyC,CAAC,GAChE,MAAM,KAAK,MAAM,KAAK,0CAA0C,CAAC,GACjE,MAAM,KAAK,EAAE,GAGb,MAAM,KAAK,MAAM,KAAK,oBAAoB,CAAC;AAC3C,UAAM,aAAa,KAAK,cAAc,KAAK;AAC3C,eAAW,CAAC,WAAW,KAAK,KAAK,OAAO,QAAQ,UAAU;AAExD,UADkB,OAAO,OAAO,KAAK,CAAC,MAAM,EAAE,UAAU,SAAS,GAClD;AACb,cAAM,aAAa,OAAO,OAAO,OAAO,CAAC,MAAM,EAAE,UAAU,SAAS,EAAE;AACtE,cAAM,KACJ,GAAG,MAAM,IAAI,QAAG,CAAC,IAAI,0BAA0B,SAAS,CAAC,KAAK,KAAK,gBAAgB,UAAU,WAAW;MAE5G;AACE,cAAM,KAAK,GAAG,MAAM,MAAM,QAAG,CAAC,IAAI,0BAA0B,SAAS,CAAC,KAAK,KAAK,YAAY;AAIhG,UAAM,KAAK,EAAE,GAGb,MAAM,KAAK,MAAM,KAAK,yBAAyB,CAAC;AAChD,UAAM,QAAQ,KAAK,eAAe,KAAK;AACvC,UAAM,KACJ,GAAG,MAAM,MAAM,QAAG,CAAC,IAAI,MAAM,kBAAkB,0BAA0B,GAO3E,MAAM,KAAK,EAAE,GAGT,OAAO,OAAO,SAAS,MACzB,MAAM,KAAK,MAAM,KAAK,SAAS,CAAC,GAChC,MAAM,KAAK,EAAE,GACb,OAAO,OAAO,QAAQ,CAAC,OAAO,UAAS;AACrC,YAAM,KAAK,GAAG,QAAQ,CAAC,KAAK,MAAM,OAAO,EAAE,GACvC,MAAM,YACR,MAAM,KAAK,MAAM,MAAM,IAAI,SAAS,MAAM,QAAQ,EAAE,CAAC,EAAE,GAErD,MAAM,aACR,MAAM,KAAK,MAAM,MAAM,IAAI,YAAY,MAAM,SAAS,EAAE,CAAC,EAAE,GAEzD,MAAM,iBACR,MAAM,KAAK,MAAM,MAAM,IAAI,sBAAiB,MAAM,aAAa,EAAE,CAAC,EAAE,GAEtE,MAAM,KAAK,EAAE;IACf,CAAC;AAIH,UAAM,iBAAiB,OAAO,SAAS,OAAO,CAAC,MAAM,EAAE,aAAa,QAAQ,GACtE,iBAAiB,OAAO,SAAS,OAAO,CAAC,MAAM,EAAE,aAAa,QAAQ;AAE5E,WAAI,eAAe,SAAS,MAC1B,MAAM,KAAK,MAAM,KAAK,WAAW,CAAC,GAClC,MAAM,KAAK,EAAE,GACb,eAAe,QAAQ,CAAC,SAAS,UAAS;AACxC,YAAM,KAAK,GAAG,QAAQ,CAAC,KAAK,QAAQ,OAAO,EAAE,GACzC,QAAQ,YACV,MAAM,KAAK,MAAM,MAAM,IAAI,SAAS,QAAQ,QAAQ,EAAE,CAAC,EAAE,GAEvD,QAAQ,aACV,MAAM,KAAK,MAAM,MAAM,IAAI,YAAY,QAAQ,SAAS,EAAE,CAAC,EAAE,GAE3D,QAAQ,iBACV,MAAM,KAAK,MAAM,MAAM,IAAI,sBAAiB,QAAQ,aAAa,EAAE,CAAC,EAAE,GAExE,MAAM,KAAK,EAAE;IACf,CAAC,IAGC,eAAe,SAAS,MAC1B,MAAM,KAAK,MAAM,KAAK,wBAAwB,CAAC,GAC/C,MAAM,KACJ,MAAM,IACJ,KAAK,eAAe,MAAM,0EAA0E,CACrG,GAEH,MAAM,KACJ,MAAM,IAAI,wFAAmF,CAAC,GAEhG,MAAM,KAAK,EAAE,GACb,eAAe,QAAQ,CAAC,SAAS,UAAS;AACxC,YAAM,KAAK,GAAG,QAAQ,CAAC,KAAK,QAAQ,OAAO,EAAE,GACzC,QAAQ,aACV,MAAM,KAAK,MAAM,MAAM,IAAI,YAAY,QAAQ,SAAS,EAAE,CAAC,EAAE,GAE3D,QAAQ,iBACV,MAAM,KAAK,MAAM,MAAM,IAAI,sBAAiB,QAAQ,aAAa,EAAE,CAAC,EAAE,GAExE,MAAM,KAAK,EAAE;IACf,CAAC,IAIH,MAAM,KAAK,MAAM,KAAK,UAAU,CAAC,GACjC,MAAM,KACJ,GAAG,OAAO,OAAO,WAAW,IAAI,MAAM,MAAM,QAAG,IAAI,MAAM,IAAI,QAAG,CAAC,IAAI,MAAM,aAAa,2BAA2B,GAErH,MAAM,KAAK,GAAG,MAAM,MAAM,QAAG,CAAC,IAAI,MAAM,kBAAkB,0BAA0B,GACpF,MAAM,KAAK,GAAG,MAAM,MAAM,QAAG,CAAC,IAAI,OAAO,KAAK,UAAU,EAAE,MAAM,mBAAmB,GACnF,MAAM,KACJ,GAAG,OAAO,OAAO,WAAW,IAAI,MAAM,MAAM,QAAG,IAAI,MAAM,IAAI,QAAG,CAAC,IAAI,OAAO,OAAO,MAAM,cAAc,OAAO,SAAS,MAAM,aAAa,GAE5I,MAAM,KAAK,EAAE,GAET,OAAO,QAAO,IACZ,OAAO,SAAS,WAAW,IAC7B,MAAM,KAAK,MAAM,MAAM,mCAAmC,CAAC,IAE3D,MAAM,KAAK,MAAM,OAAO,kDAAkD,CAAC,IAG7E,MAAM,KAAK,MAAM,IAAI,+DAA+D,CAAC,GAGvF,MAAM,KAAK,EAAE,GAEN,MAAM,KAAK;CAAI;EACxB;;;;EAKQ,OAAO,cAAc,QAA0B,OAAY;AAEjE,UAAM,QADW,KAAK,eAAe,QAAQ,KAAK,EAC3B,MAAM;CAAI,GAG3B,kBAAkB,MAAM,UAAU,CAAC,MAAM,EAAE,SAAS,yBAAyB,CAAC;AACpF,QAAI,mBAAmB,GAAG;AACxB,YAAM,QAAQ,KAAK,eAAe,KAAK,GACjC,oBAA8B,CAAA;AAGpC,UAAI,OAAO,KAAK,MAAM,wBAAwB,EAAE,SAAS,GAAG;AAC1D,0BAAkB,KAAK,EAAE,GACzB,kBAAkB,KAAK,MAAM,IAAI,yBAAyB,CAAC;AAC3D,mBAAW,CAAC,WAAW,KAAK,KAAK,OAAO,QAAQ,MAAM,wBAAwB,EAAE,KAAI;AAClF,4BAAkB,KAAK,MAAM,IAAI,YAAO,SAAS,KAAK,KAAK,kBAAkB,CAAC;MAElF;AAGA,YAAM,OAAO,kBAAkB,GAAG,GAAG,GAAG,iBAAiB;IAC3D;AAEA,WAAO,MAAM,KAAK;CAAI;EACxB;;;;EAKQ,OAAO,cAAc,OAAY;AACvC,UAAM,QAAgC,CAAA;AAEtC,eAAW,CAAC,WAAW,KAAK,KAAK,MAAM,QAAQ;AAC7C,YAAM,QAAQ,MAAM,aAAY,EAAG;AACnC,MAAI,QAAQ,MACV,MAAM,SAAS,IAAI;IAEvB;AAEA,WAAO;EACT;;;;EAKA,OAAO,eAAe,OAAY;AAChC,UAAM,QAAyB;MAC7B,eAAe;MACf,oBAAoB;MACpB,kBAAkB,CAAA;MAClB,0BAA0B,CAAA;MAC1B,kBAAkB,CAAA;OAGd,aAAa,oBAAI,IAAG,GACpB,sBAAsB,oBAAI,IAAG;AAGnC,eAAW,CAAC,WAAW,KAAK,KAAK,MAAM,QAAQ;AAC7C,UAAI,aAAa;AACjB,iBAAW,WAAW,MAAM,aAAY,GAAI;AAC1C,mBAAW,IAAI,QAAQ,QAAQ,QAAQ,EAAE,GACzC,cACA,MAAM;AAEN,cAAM,YAAY,QAAQ,cAAc,CAAA,GAAI;AAC5C,4BAAoB,IAAI,QAAQ,QAAQ,QAAQ,IAAI,QAAQ,GAC5D,MAAM,sBAAsB;AAE5B,mBAAW,OAAO,QAAQ,cAAc,CAAA,GAAI;AAC1C,gBAAM,YAAY,IAAI,QAAQ;AAC9B,gBAAM,yBAAyB,SAAS,KACrC,MAAM,yBAAyB,SAAS,KAAK,KAAK;QACvD;MACF;AAEA,MAAI,aAAa,MACf,MAAM,iBAAiB,SAAS,IAAI;IAExC;AAGA,UAAM,iBAAiB,MAAM,cAAc,OAAM;AACjD,UAAM,sBAAsB,eAAe;AAC3C,UAAM,yBAAyB,oBAAI,IAAG;AACtC,eAAW,OAAO;AAChB,YAAM,yBAAyB,IAAI,SAAS,KACzC,MAAM,yBAAyB,IAAI,SAAS,KAAK,KAAK,GACzD,uBAAuB,IAAI,IAAI,MAAM,GACrC,uBAAuB,IAAI,IAAI,MAAM;AAIvC,eAAW,aAAa,YAAY;AAClC,UAAI,uBAAuB,IAAI,SAAS;AACtC;AAGF,YAAM,qBAAqB,oBAAoB,IAAI,SAAS,KAAK;AACjE,UAAI,qBAAqB;AACzB,iBAAW,CAAC,EAAE,KAAK,KAAK,MAAM;AAC5B,mBAAW,WAAW,MAAM,aAAY;AACtC,qBAAW,OAAO,QAAQ,cAAc,CAAA;AACtC,YAAI,IAAI,WAAW,aACjB;AAMR,MAAI,uBAAuB,KAAK,uBAAuB,KACrD,MAAM,iBAAiB,KAAK,SAAS;IAEzC;AAEA,WAAO;EACT;;;;EAKA,OAAO,OAAO,QAA0B,OAAY;AAClD,UAAM,QAAQ,KAAK,eAAe,KAAK,GACjC,aAAa,KAAK,cAAc,KAAK;AAE3C,WAAO;MACL,OAAO,OAAO,QAAO;MACrB,SAAS;QACP,eAAe,MAAM;QACrB,oBAAoB,MAAM;QAC1B,YAAY,OAAO,OAAO;QAC1B,cAAc,OAAO,SAAS;QAC9B,eAAe,MAAM,iBAAiB;QACtC,iBAAiB,OAAO,KAAK,UAAU,EAAE;;MAE3C;MACA,0BAA0B,MAAM;MAChC,kBAAkB,MAAM;MACxB,QAAQ,OAAO;MACf,UAAU,OAAO;;EAErB;;;;EAKA,OAAO,WAAW,QAA0B,OAAY;AACtD,UAAM,QAAkB,CAAA,GAClB,QAAQ,KAAK,eAAe,KAAK,GACjC,aAAa,KAAK,cAAc,KAAK;AAE3C,UAAM,KAAK,qBAAqB,GAChC,MAAM,KAAK,EAAE,GACb,MAAM,KAAK,eAAe,OAAO,QAAO,IAAK,iBAAY,gBAAW,EAAE,GACtE,MAAM,KAAK,mBAAkB,oBAAI,KAAI,GAAG,YAAW,CAAE,EAAE,GACvD,MAAM,KAAK,EAAE,GAEb,MAAM,KAAK,YAAY,GACvB,MAAM,KAAK,EAAE,GACb,MAAM,KAAK,oBAAoB,GAC/B,MAAM,KAAK,oBAAoB,GAC/B,MAAM,KAAK,sBAAsB,MAAM,aAAa,IAAI,GACxD,MAAM,KAAK,2BAA2B,MAAM,kBAAkB,IAAI,GAClE,MAAM,KAAK,wBAAwB,OAAO,KAAK,UAAU,EAAE,MAAM,IAAI,GACrE,MAAM,KAAK,cAAc,OAAO,OAAO,MAAM,IAAI,GACjD,MAAM,KAAK,gBAAgB,OAAO,SAAS,MAAM,IAAI,GACrD,MAAM,KAAK,yBAAyB,MAAM,iBAAiB,MAAM,IAAI,GACrE,MAAM,KAAK,EAAE,GAEb,MAAM,KAAK,qBAAqB,GAChC,MAAM,KAAK,EAAE;AACb,eAAW,CAAC,WAAW,KAAK,KAAK,OAAO,QAAQ,UAAU,GAAG;AAE3D,YAAM,SADY,OAAO,OAAO,KAAK,CAAC,MAAM,EAAE,UAAU,SAAS,IACtC,WAAM;AACjC,YAAM,KAAK,KAAK,MAAM,IAAI,SAAS,KAAK,KAAK,WAAW;IAC1D;AACA,iBAAM,KAAK,EAAE,GAET,OAAO,OAAO,SAAS,MACzB,MAAM,KAAK,WAAW,GACtB,MAAM,KAAK,EAAE,GACb,OAAO,OAAO,QAAQ,CAAC,OAAO,UAAS;AACrC,YAAM,KAAK,OAAO,QAAQ,CAAC,KAAK,MAAM,OAAO,EAAE,GAC/C,MAAM,KAAK,EAAE,GACT,MAAM,YACR,MAAM,KAAK,eAAe,MAAM,QAAQ,IAAI,GAE1C,MAAM,aACR,MAAM,KAAK,kBAAkB,MAAM,SAAS,IAAI,GAE9C,MAAM,iBACR,MAAM,KAAK,mBAAmB,MAAM,aAAa,EAAE,GAErD,MAAM,KAAK,EAAE;IACf,CAAC,IAGC,OAAO,SAAS,SAAS,MAC3B,MAAM,KAAK,aAAa,GACxB,MAAM,KAAK,EAAE,GACb,OAAO,SAAS,QAAQ,CAAC,SAAS,UAAS;AACzC,YAAM,KAAK,OAAO,QAAQ,CAAC,KAAK,QAAQ,OAAO,EAAE,GACjD,MAAM,KAAK,EAAE,GACT,QAAQ,YACV,MAAM,KAAK,eAAe,QAAQ,QAAQ,IAAI,GAE5C,QAAQ,aACV,MAAM,KAAK,kBAAkB,QAAQ,SAAS,IAAI,GAEhD,QAAQ,iBACV,MAAM,KAAK,mBAAmB,QAAQ,aAAa,EAAE,GAEvD,MAAM,KAAK,EAAE;IACf,CAAC,IAGI,MAAM,KAAK;CAAI;EACxB;;",
+  "names": []
+}

package/dist/validators/validator.js

@@ -3,62 +3,48 @@ import { SchemaValidator } from "./schema-validator.js";
 import { NamingValidator } from "./naming-validator.js";
 import { ReferenceValidator } from "./reference-validator.js";
 import { SemanticValidator } from "./semantic-validator.js";
-import { startSpan, endSpan } from "../telemetry/index.js";
-const isTelemetryEnabled = !1;
+import { RelationshipValidator } from "./relationship-schema-validator.js";
+import { startActiveSpan } from "../telemetry/index.js";
 class Validator {
   schemaValidator;
   namingValidator;
   referenceValidator;
   semanticValidator;
+  relationshipValidator;
   constructor() {
-    this.schemaValidator = new SchemaValidator(), this.namingValidator = new NamingValidator(), this.referenceValidator = new ReferenceValidator(), this.semanticValidator = new SemanticValidator();
+    this.schemaValidator = new SchemaValidator(), this.namingValidator = new NamingValidator(), this.referenceValidator = new ReferenceValidator(), this.semanticValidator = new SemanticValidator(), this.relationshipValidator = new RelationshipValidator();
   }
   /**
-   * Validate a complete model through all 4 stages
+   * Validate a complete model through all 5 stages
    */
   async validateModel(model) {
-    const rootSpan = isTelemetryEnabled ? startSpan("model.validate", {
-      "model.path": model.rootPath
-    }) : null, result = new ValidationResult();
-    try {
-      const schemaStageSpan = isTelemetryEnabled ? startSpan("validation.stage.schema") : null;
-      try {
-        for (const layer of model.layers.values()) {
+    return startActiveSpan("model.validate", async (rootSpan) => {
+      const result = new ValidationResult();
+      return await startActiveSpan("validation.stage.schema", async (stageSpan) => {
+        await Promise.all(Array.from(model.layers.values()).map(async (layer) => {
           const schemaResult = await this.schemaValidator.validateLayer(layer);
           result.merge(schemaResult, `[Schema/${layer.name}]`);
-        }
-        isTelemetryEnabled && schemaStageSpan && schemaStageSpan.setAttribute("validation.error_count", result.errors.length);
-      } finally {
-        endSpan(schemaStageSpan);
-      }
-      const namingStageSpan = isTelemetryEnabled ? startSpan("validation.stage.naming") : null;
-      try {
+        })), stageSpan.setAttribute("validation.error_count", result.errors.length);
+      }), await startActiveSpan("validation.stage.naming", async (stageSpan) => {
         for (const layer of model.layers.values()) {
           const namingResult = this.namingValidator.validateLayer(layer);
           result.merge(namingResult, `[Naming/${layer.name}]`);
         }
-        isTelemetryEnabled && namingStageSpan && namingStageSpan.setAttribute("validation.error_count", result.errors.length);
-      } finally {
-        endSpan(namingStageSpan);
-      }
-      const refStageSpan = isTelemetryEnabled ? startSpan("validation.stage.reference") : null;
-      try {
+        stageSpan.setAttribute("validation.error_count", result.errors.length);
+      }), await startActiveSpan("validation.stage.reference", async (stageSpan) => {
         const referenceResult = this.referenceValidator.validateModel(model);
-        result.merge(referenceResult, "[References]"), isTelemetryEnabled && refStageSpan && refStageSpan.setAttribute("validation.error_count", result.errors.length);
-      } finally {
-        endSpan(refStageSpan);
-      }
-      const semanticStageSpan = isTelemetryEnabled ? startSpan("validation.stage.semantic") : null;
-      try {
+        result.merge(referenceResult, "[References]"), stageSpan.setAttribute("validation.error_count", result.errors.length);
+      }), await startActiveSpan("validation.stage.semantic", async (stageSpan) => {
         const semanticResult = await this.semanticValidator.validateModel(model);
-        result.merge(semanticResult, "[Semantic]"), isTelemetryEnabled && semanticStageSpan && semanticStageSpan.setAttribute("validation.error_count", result.errors.length);
-      } finally {
-        endSpan(semanticStageSpan);
-      }
-      return isTelemetryEnabled && rootSpan && (rootSpan.setAttribute("validation.valid", result.isValid()), rootSpan.setAttribute("validation.error_count", result.errors.length)), result;
-    } finally {
-      endSpan(rootSpan);
-    }
+        result.merge(semanticResult, "[Semantic]"), stageSpan.setAttribute("validation.error_count", result.errors.length);
+      }), await startActiveSpan("validation.stage.relationship-schema", async (stageSpan) => {
+        await this.relationshipValidator.initialize();
+        const relationshipResult = await this.relationshipValidator.validateModel(model);
+        result.merge(relationshipResult, "[Relationship Schema]"), stageSpan.setAttribute("validation.error_count", result.errors.length);
+      }), rootSpan.setAttribute("validation.valid", result.isValid()), rootSpan.setAttribute("validation.error_count", result.errors.length), result;
+    }, {
+      "model.path": model.rootPath
+    });
   }
 }
 export {