@dmsdc-ai/aigentry-telepty 0.5.8 → 0.5.9

package/CHANGELOG.md

@@ -4,6 +4,29 @@ All notable changes to `@dmsdc-ai/aigentry-telepty` are documented here.
 
 ## [Unreleased]
 
+## [0.5.9] - 2026-06-08
+
+### Fixed — managed service install never started the daemon (#41)
+
+- **The launchd/systemd/Windows service install generated an `env: node`
+  invocation that exited 127** under a minimal service-manager PATH (the daemon
+  never started when managed by launchd/systemd). **Fix:** `install.js` now uses
+  the absolute `process.execPath` + `cli.js` path for launchd/systemd/Windows
+  service generation, sets the daemon `PATH` via EnvironmentVariables, and adds
+  managed-instance live assertions so a managed daemon actually starts. Landed on
+  `main` at commit `7b2ab92`.
+
+### Changed — CI test wiring
+
+- Wired `test/install-service-generation.test.js` (the #41 regression test) into
+  the `test`, `test:ci`, and `test:watch` script file lists so CI's
+  `npm run test:ci` actually exercises the service-install generation.
+
+### Docs
+
+- Landed the #42 cross-machine relay/broker (hub) mode ADR and MVP
+  implementation spec.
+
 ## [0.5.2] - 2026-06-06
 
 ### Fixed — submit handshake confirmation (#507-B / #508)

package/install.js

@@ -5,9 +5,6 @@ const os = require('os');
 const fs = require('fs');
 const path = require('path');
 const { cleanupDaemonProcesses } = require('./daemon-control');
-const { runInteractiveSkillInstaller } = require('./skill-installer');
-
-console.log("🚀 Installing @dmsdc-ai/aigentry-telepty...");
 
 function run(cmd) {
   try {
@@ -18,6 +15,10 @@ function run(cmd) {
   }
 }
 
+function shellQuote(value) {
+  return `'${String(value).replace(/'/g, "'\\''")}'`;
+}
+
 function resolveInstalledPackageRoot() {
   try {
     const globalRoot = execSync('npm root -g', { encoding: 'utf8' }).trim();
@@ -27,6 +28,15 @@ function resolveInstalledPackageRoot() {
   }
 }
 
+function resolveDaemonLaunchOptions(options = {}) {
+  const packageRoot = options.packageRoot || __dirname;
+  const nodeBin = options.nodeBin || process.execPath;
+  const cliJs = options.cliJs || path.join(packageRoot, 'cli.js');
+  const logDir = options.logDir || path.join(os.homedir(), '.telepty', 'logs');
+
+  return { nodeBin, cliJs, logDir };
+}
+
 function cleanupLocalDaemons() {
   console.log('🧹 Cleaning up existing telepty daemons...');
   const results = cleanupDaemonProcesses();
@@ -36,6 +46,161 @@ function cleanupLocalDaemons() {
   }
 }
 
+function escapeXml(value) {
+  return String(value)
+    .replace(/&/g, '&')
+    .replace(/</g, '&lt;')
+    .replace(/>/g, '&gt;')
+    .replace(/"/g, '&quot;')
+    .replace(/'/g, '&apos;');
+}
+
+function uniquePathEntries(entries) {
+  const seen = new Set();
+  const result = [];
+
+  for (const entry of entries) {
+    if (!entry || seen.has(entry)) {
+      continue;
+    }
+    seen.add(entry);
+    result.push(entry);
+  }
+
+  return result;
+}
+
+function buildDaemonPath(nodeBin, baseEntries) {
+  return uniquePathEntries([path.dirname(nodeBin), ...baseEntries]).join(':');
+}
+
+function systemdExecArg(value) {
+  const text = String(value);
+  if (/^[A-Za-z0-9_@%+=:,./-]+$/.test(text)) {
+    return text;
+  }
+  return `"${text.replace(/\\/g, '\\\\').replace(/"/g, '\\"')}"`;
+}
+
+function quoteWindowsArg(value) {
+  return `"${String(value).replace(/"/g, '\\"')}"`;
+}
+
+function buildLaunchdPlist(options = {}) {
+  const label = options.label || 'com.aigentry.telepty';
+  const nodeBin = options.nodeBin || process.execPath;
+  const cliJs = options.cliJs || path.join(__dirname, 'cli.js');
+  const logDir = options.logDir || path.join(os.homedir(), '.telepty', 'logs');
+  const daemonPath = buildDaemonPath(nodeBin, ['/usr/local/bin', '/usr/bin', '/bin', '/usr/sbin', '/sbin']);
+  const stdoutPath = path.join(logDir, 'launchd.out.log');
+  const stderrPath = path.join(logDir, 'launchd.err.log');
+
+  return `<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+    <key>Label</key>
+    <string>${escapeXml(label)}</string>
+    <key>ProgramArguments</key>
+    <array>
+        <string>${escapeXml(nodeBin)}</string>
+        <string>${escapeXml(cliJs)}</string>
+        <string>daemon</string>
+    </array>
+    <key>EnvironmentVariables</key>
+    <dict>
+        <key>PATH</key>
+        <string>${escapeXml(daemonPath)}</string>
+    </dict>
+    <key>StandardOutPath</key>
+    <string>${escapeXml(stdoutPath)}</string>
+    <key>StandardErrorPath</key>
+    <string>${escapeXml(stderrPath)}</string>
+    <key>RunAtLoad</key>
+    <true/>
+    <key>KeepAlive</key>
+    <true/>
+</dict>
+</plist>`;
+}
+
+function buildSystemdService(options = {}) {
+  const nodeBin = options.nodeBin || process.execPath;
+  const cliJs = options.cliJs || path.join(__dirname, 'cli.js');
+  const user = options.user;
+  const userLine = user ? `User=${user}\n` : '';
+  const daemonPath = buildDaemonPath(nodeBin, ['/usr/local/bin', '/usr/bin', '/bin']);
+  const wantedBy = options.wantedBy || 'multi-user.target';
+
+  return `[Unit]
+Description=Telepty Daemon
+After=network.target
+
+[Service]
+ExecStart=${systemdExecArg(nodeBin)} ${systemdExecArg(cliJs)} daemon
+Restart=always
+${userLine}Environment=PATH=${daemonPath}
+Environment=NODE_ENV=production
+
+[Install]
+WantedBy=${wantedBy}`;
+}
+
+function buildWindowsAutostartCommand(options = {}) {
+  const nodeBin = options.nodeBin || process.execPath;
+  const cliJs = options.cliJs || path.join(__dirname, 'cli.js');
+  const taskName = options.taskName || 'telepty-daemon';
+  const taskCommand = `${quoteWindowsArg(nodeBin)} ${quoteWindowsArg(cliJs)} daemon`;
+
+  return `schtasks /create /tn ${quoteWindowsArg(taskName)} /sc onlogon /rl LIMITED /f /tr ${quoteWindowsArg(taskCommand)}`;
+}
+
+function buildWindowsRunTaskCommand(options = {}) {
+  const taskName = options.taskName || 'telepty-daemon';
+  return `schtasks /run /tn ${quoteWindowsArg(taskName)}`;
+}
+
+function buildWindowsQueryTaskCommand(options = {}) {
+  const taskName = options.taskName || 'telepty-daemon';
+  return `schtasks /query /tn ${quoteWindowsArg(taskName)} /fo LIST`;
+}
+
+function assertLaunchdServiceLive(label = 'com.aigentry.telepty') {
+  let output = '';
+  try {
+    output = execSync(`launchctl list ${shellQuote(label)}`, { encoding: 'utf8' });
+  } catch (e) {
+    throw new Error(`launchd service ${label} was not found after load`);
+  }
+
+  const pidMatch = output.match(/"PID"\s*=\s*([0-9]+)/);
+  if (!pidMatch || Number(pidMatch[1]) <= 0) {
+    throw new Error(`launchd service ${label} loaded but has no live PID. launchctl output:\n${output}`);
+  }
+}
+
+function assertSystemdServiceLive(serviceName = 'telepty', options = {}) {
+  const scope = options.user ? '--user ' : '';
+  try {
+    execSync(`systemctl ${scope}is-active --quiet ${serviceName}`, { stdio: 'ignore' });
+  } catch (e) {
+    throw new Error(`systemd service ${serviceName} is not active after start`);
+  }
+}
+
+function assertWindowsTaskRunning(taskName = 'telepty-daemon') {
+  let output = '';
+  try {
+    output = execSync(buildWindowsQueryTaskCommand({ taskName }), { encoding: 'utf8' });
+  } catch (e) {
+    throw new Error(`Windows scheduled task ${taskName} was not found after creation`);
+  }
+
+  if (!/^Status:\s*Running$/im.test(output)) {
+    throw new Error(`Windows scheduled task ${taskName} started but is not running. schtasks output:\n${output}`);
+  }
+}
+
 async function installSkills() {
   if (!process.stdin.isTTY || !process.stdout.isTTY) {
     console.log('⏭️  Skipping interactive skill installation (no TTY).');
@@ -46,6 +211,7 @@ async function installSkills() {
   console.log('\n📋 Telepty skill installation');
 
   try {
+    const { runInteractiveSkillInstaller } = require('./skill-installer');
     await runInteractiveSkillInstaller({
       packageRoot: resolveInstalledPackageRoot(),
       cwd: process.cwd()
@@ -55,7 +221,9 @@ async function installSkills() {
   }
 }
 
-(async () => {
+async function main() {
+  console.log("🚀 Installing @dmsdc-ai/aigentry-telepty...");
+
   // 1. Install globally via npm
   console.log("📦 Installing package globally...");
   run("npm install -g @dmsdc-ai/aigentry-telepty");
@@ -63,12 +231,10 @@ async function installSkills() {
   // 2. Install telepty skills for supported clients
   await installSkills();
 
-  // 3. Find executable
-  let teleptyPath = '';
-  try {
-    teleptyPath = execSync(os.platform() === 'win32' ? 'where telepty' : 'which telepty', { encoding: 'utf8' }).split('\n')[0].trim();
-  } catch (e) {
-    teleptyPath = 'telepty'; // fallback
+  // 3. Resolve daemon entrypoint without relying on service-manager PATH.
+  const launchOptions = resolveDaemonLaunchOptions({ packageRoot: resolveInstalledPackageRoot() });
+  if (!fs.existsSync(launchOptions.cliJs)) {
+    throw new Error(`Cannot find daemon entrypoint: ${launchOptions.cliJs}`);
   }
 
   // 4. Setup OS-specific autostart or background daemon
@@ -76,86 +242,95 @@ async function installSkills() {
 
   if (platform === 'win32') {
     cleanupLocalDaemons();
-    console.log("⚙️ Setting up Windows background process...");
-    const subprocess = spawn(teleptyPath, ['daemon'], {
-      detached: true,
-      stdio: 'ignore',
-      windowsHide: true
-    });
-    subprocess.unref();
-    console.log("✅ Windows daemon started in background.");
+    console.log("⚙️ Setting up Windows scheduled task...");
+    run(buildWindowsAutostartCommand(launchOptions));
+    run(buildWindowsRunTaskCommand());
+    assertWindowsTaskRunning();
+    console.log("✅ Windows scheduled task installed and started.");
 
   } else if (platform === 'darwin') {
     console.log("⚙️ Setting up macOS launchd service...");
     const plistPath = path.join(os.homedir(), 'Library', 'LaunchAgents', 'com.aigentry.telepty.plist');
     fs.mkdirSync(path.dirname(plistPath), { recursive: true });
-    try { execSync(`launchctl unload "${plistPath}" 2>/dev/null`); } catch(e){}
+    fs.mkdirSync(launchOptions.logDir, { recursive: true });
+    try { execSync(`launchctl unload ${shellQuote(plistPath)} 2>/dev/null`); } catch(e){}
     cleanupLocalDaemons();
 
-    const plistContent = `<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
-    <key>Label</key>
-    <string>com.aigentry.telepty</string>
-    <key>ProgramArguments</key>
-    <array>
-        <string>${teleptyPath}</string>
-        <string>daemon</string>
-    </array>
-    <key>RunAtLoad</key>
-    <true/>
-    <key>KeepAlive</key>
-    <true/>
-</dict>
-</plist>`;
+    const plistContent = buildLaunchdPlist(launchOptions);
 
     fs.writeFileSync(plistPath, plistContent);
-    run(`launchctl load "${plistPath}"`);
+    run(`launchctl load ${shellQuote(plistPath)}`);
+    assertLaunchdServiceLive();
     console.log("✅ macOS LaunchAgent installed and started.");
 
   } else {
     // Linux
+    let hasSystemd = false;
     try {
       execSync('systemctl --version', { stdio: 'ignore' });
+      hasSystemd = true;
+    } catch(e) {}
+
+    if (hasSystemd) {
       if (process.getuid && process.getuid() === 0) {
         console.log("⚙️ Setting up systemd service for Linux...");
         try { execSync('systemctl stop telepty', { stdio: 'ignore' }); } catch(e) {}
         cleanupLocalDaemons();
-        const serviceContent = `[Unit]
-Description=Telepty Daemon
-After=network.target
-
-[Service]
-ExecStart=${teleptyPath} daemon
-Restart=always
-User=${process.env.SUDO_USER || process.env.USER || 'root'}
-Environment=PATH=/usr/bin:/usr/local/bin:$PATH
-Environment=NODE_ENV=production
-
-[Install]
-WantedBy=multi-user.target`;
+        const serviceContent = buildSystemdService({
+          ...launchOptions,
+          user: process.env.SUDO_USER || process.env.USER || 'root'
+        });
 
         fs.writeFileSync('/etc/systemd/system/telepty.service', serviceContent);
         run('systemctl daemon-reload');
         run('systemctl enable telepty');
         run('systemctl start telepty');
+        assertSystemdServiceLive();
         console.log("✅ Systemd service installed and started.");
         process.exit(0);
       }
-    } catch(e) {}
 
-    // Fallback for Linux without systemd or non-root
-    console.log("⚠️ Skipping systemd (no root or no systemd). Starting in background...");
+      console.log("⚙️ Setting up user systemd service for Linux...");
+      const userServicePath = path.join(os.homedir(), '.config', 'systemd', 'user', 'telepty.service');
+      fs.mkdirSync(path.dirname(userServicePath), { recursive: true });
+      cleanupLocalDaemons();
+      fs.writeFileSync(userServicePath, buildSystemdService({
+        ...launchOptions,
+        wantedBy: 'default.target'
+      }));
+      run('systemctl --user daemon-reload');
+      run('systemctl --user enable telepty');
+      run('systemctl --user start telepty');
+      assertSystemdServiceLive('telepty', { user: true });
+      console.log("✅ User systemd service installed and started.");
+      process.exit(0);
+    }
+
+    // Fallback for Linux without systemd
+    console.log("⚠️ Skipping persistent systemd setup. Starting daemon for this session only...");
     cleanupLocalDaemons();
-    const subprocess = spawn(teleptyPath, ['daemon'], {
+    const subprocess = spawn(launchOptions.nodeBin, [launchOptions.cliJs, 'daemon'], {
       detached: true,
       stdio: 'ignore'
     });
     subprocess.unref();
-    console.log("✅ Linux daemon started in background using nohup equivalent.");
+    console.log("✅ Linux daemon started in background for the current session.");
   }
 
   console.log("\n🎉 Installation complete! Telepty daemon is running.");
   console.log("👉 Try running: telepty attach\n");
-})();
+}
+
+if (require.main === module) {
+  main().catch((e) => {
+    console.error('❌ Installation failed:', e.message);
+    process.exit(1);
+  });
+}
+
+module.exports = {
+  buildLaunchdPlist,
+  buildSystemdService,
+  buildWindowsAutostartCommand,
+  resolveDaemonLaunchOptions,
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dmsdc-ai/aigentry-telepty",
-  "version": "0.5.8",
+  "version": "0.5.9",
   "main": "daemon.js",
   "bin": {
     "aigentry-telepty": "install.js",
@@ -35,9 +35,9 @@
   ],
   "scripts": {
     "postinstall": "node scripts/postinstall.js",
-    "test": "node --require ./test-support/setup-env.js --test test/auth.test.js test/http-auth.test.js test/daemon.test.js test/daemon-singleton.test.js test/integration/daemon-launch.test.js test/cli.test.js test/telepty-kill.test.js test/idle-ttl.test.js test/telepty-clean-older-than.test.js test/lifecycle-transport-agnostic.test.js test/skill-installer.test.js test/interactive-terminal.test.js test/runtime-info.test.js test/session-routing.test.js test/session-state.test.js test/session-store-persistence.test.js test/mailbox-lock.test.js test/report-enforcement.test.js test/enforce-report.test.js test/peer-inject-validator.test.js test/enforce-submit-gate.test.js test/submit-gate.test.js test/submit-via-pty.test.js test/prompt-symbol-registry.test.js test/inject-submit-flags.test.js test/inject-submit-force-env.test.js test/host-spec.test.js test/cross-host-inject.test.js test/cross-machine-ssh-routing.test.js test/init.test.js test/win-resolve-executable.test.js test/version-handshake.test.js test/win-kill-process.test.js test/daemon-control-port-owner.test.js test/banner-stderr-jq-safety.test.js test/bridge-supervisor-ipc.test.js test/bridge-j3-shim.test.js test/bridge-e2e.test.js test/release-0.4.5-bugfixes.test.js && git diff --exit-code tests/snippet-protocol/v1/",
-    "test:watch": "node --require ./test-support/setup-env.js --test --watch test/auth.test.js test/http-auth.test.js test/daemon.test.js test/daemon-singleton.test.js test/integration/daemon-launch.test.js test/cli.test.js test/telepty-kill.test.js test/idle-ttl.test.js test/telepty-clean-older-than.test.js test/lifecycle-transport-agnostic.test.js test/skill-installer.test.js test/interactive-terminal.test.js test/runtime-info.test.js test/session-routing.test.js test/session-state.test.js test/session-store-persistence.test.js test/mailbox-lock.test.js test/report-enforcement.test.js test/enforce-report.test.js test/peer-inject-validator.test.js test/enforce-submit-gate.test.js test/submit-gate.test.js test/submit-via-pty.test.js test/prompt-symbol-registry.test.js test/inject-submit-flags.test.js test/inject-submit-force-env.test.js test/host-spec.test.js test/cross-host-inject.test.js test/cross-machine-ssh-routing.test.js test/init.test.js test/win-resolve-executable.test.js test/version-handshake.test.js test/win-kill-process.test.js test/daemon-control-port-owner.test.js test/banner-stderr-jq-safety.test.js test/bridge-supervisor-ipc.test.js test/bridge-j3-shim.test.js test/bridge-e2e.test.js test/release-0.4.5-bugfixes.test.js",
-    "test:ci": "node --require ./test-support/setup-env.js --test --test-reporter=spec test/auth.test.js test/http-auth.test.js test/daemon.test.js test/daemon-singleton.test.js test/integration/daemon-launch.test.js test/cli.test.js test/telepty-kill.test.js test/idle-ttl.test.js test/telepty-clean-older-than.test.js test/lifecycle-transport-agnostic.test.js test/skill-installer.test.js test/interactive-terminal.test.js test/runtime-info.test.js test/session-routing.test.js test/session-state.test.js test/session-store-persistence.test.js test/mailbox-lock.test.js test/report-enforcement.test.js test/enforce-report.test.js test/peer-inject-validator.test.js test/enforce-submit-gate.test.js test/submit-gate.test.js test/submit-via-pty.test.js test/prompt-symbol-registry.test.js test/inject-submit-flags.test.js test/inject-submit-force-env.test.js test/host-spec.test.js test/cross-host-inject.test.js test/cross-machine-ssh-routing.test.js test/init.test.js test/win-resolve-executable.test.js test/version-handshake.test.js test/win-kill-process.test.js test/daemon-control-port-owner.test.js test/banner-stderr-jq-safety.test.js test/bridge-supervisor-ipc.test.js test/bridge-j3-shim.test.js test/bridge-e2e.test.js test/release-0.4.5-bugfixes.test.js && git diff --exit-code tests/snippet-protocol/v1/",
+    "test": "node --require ./test-support/setup-env.js --test test/auth.test.js test/http-auth.test.js test/daemon.test.js test/daemon-singleton.test.js test/integration/daemon-launch.test.js test/cli.test.js test/telepty-kill.test.js test/idle-ttl.test.js test/telepty-clean-older-than.test.js test/lifecycle-transport-agnostic.test.js test/skill-installer.test.js test/interactive-terminal.test.js test/runtime-info.test.js test/session-routing.test.js test/session-state.test.js test/session-store-persistence.test.js test/mailbox-lock.test.js test/report-enforcement.test.js test/enforce-report.test.js test/peer-inject-validator.test.js test/enforce-submit-gate.test.js test/submit-gate.test.js test/submit-via-pty.test.js test/prompt-symbol-registry.test.js test/inject-submit-flags.test.js test/inject-submit-force-env.test.js test/host-spec.test.js test/cross-host-inject.test.js test/cross-machine-ssh-routing.test.js test/init.test.js test/install-service-generation.test.js test/win-resolve-executable.test.js test/version-handshake.test.js test/win-kill-process.test.js test/daemon-control-port-owner.test.js test/banner-stderr-jq-safety.test.js test/bridge-supervisor-ipc.test.js test/bridge-j3-shim.test.js test/bridge-e2e.test.js test/release-0.4.5-bugfixes.test.js && git diff --exit-code tests/snippet-protocol/v1/",
+    "test:watch": "node --require ./test-support/setup-env.js --test --watch test/auth.test.js test/http-auth.test.js test/daemon.test.js test/daemon-singleton.test.js test/integration/daemon-launch.test.js test/cli.test.js test/telepty-kill.test.js test/idle-ttl.test.js test/telepty-clean-older-than.test.js test/lifecycle-transport-agnostic.test.js test/skill-installer.test.js test/interactive-terminal.test.js test/runtime-info.test.js test/session-routing.test.js test/session-state.test.js test/session-store-persistence.test.js test/mailbox-lock.test.js test/report-enforcement.test.js test/enforce-report.test.js test/peer-inject-validator.test.js test/enforce-submit-gate.test.js test/submit-gate.test.js test/submit-via-pty.test.js test/prompt-symbol-registry.test.js test/inject-submit-flags.test.js test/inject-submit-force-env.test.js test/host-spec.test.js test/cross-host-inject.test.js test/cross-machine-ssh-routing.test.js test/init.test.js test/install-service-generation.test.js test/win-resolve-executable.test.js test/version-handshake.test.js test/win-kill-process.test.js test/daemon-control-port-owner.test.js test/banner-stderr-jq-safety.test.js test/bridge-supervisor-ipc.test.js test/bridge-j3-shim.test.js test/bridge-e2e.test.js test/release-0.4.5-bugfixes.test.js",
+    "test:ci": "node --require ./test-support/setup-env.js --test --test-reporter=spec test/auth.test.js test/http-auth.test.js test/daemon.test.js test/daemon-singleton.test.js test/integration/daemon-launch.test.js test/cli.test.js test/telepty-kill.test.js test/idle-ttl.test.js test/telepty-clean-older-than.test.js test/lifecycle-transport-agnostic.test.js test/skill-installer.test.js test/interactive-terminal.test.js test/runtime-info.test.js test/session-routing.test.js test/session-state.test.js test/session-store-persistence.test.js test/mailbox-lock.test.js test/report-enforcement.test.js test/enforce-report.test.js test/peer-inject-validator.test.js test/enforce-submit-gate.test.js test/submit-gate.test.js test/submit-via-pty.test.js test/prompt-symbol-registry.test.js test/inject-submit-flags.test.js test/inject-submit-force-env.test.js test/host-spec.test.js test/cross-host-inject.test.js test/cross-machine-ssh-routing.test.js test/init.test.js test/install-service-generation.test.js test/win-resolve-executable.test.js test/version-handshake.test.js test/win-kill-process.test.js test/daemon-control-port-owner.test.js test/banner-stderr-jq-safety.test.js test/bridge-supervisor-ipc.test.js test/bridge-j3-shim.test.js test/bridge-e2e.test.js test/release-0.4.5-bugfixes.test.js && git diff --exit-code tests/snippet-protocol/v1/",
     "typecheck": "tsc --noEmit",
     "regen-fixtures": "node scripts/regen-snippet-fixtures.js"
   },