@dmitryrechkin/eslint-standard 1.5.4 → 1.5.6

package/eslint.config.mjs

@@ -111,7 +111,43 @@ export default function ({
 				'@stylistic/quotes': 'off', // Handled by prettier (singleQuote: true)
 				semi: 'off', // Handled by prettier (semi: true)
 				'@stylistic/semi': 'off', // Handled by prettier (semi: true)
-				'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
+				'@typescript-eslint/no-unused-vars': ['error', {
+					argsIgnorePattern: '^_',
+					varsIgnorePattern: '^_',
+					caughtErrorsIgnorePattern: '^_',
+					destructuredArrayIgnorePattern: '^_',
+					ignoreRestSiblings: true
+				}],
+
+				// Enhanced local dead code cleanup rules
+				'@typescript-eslint/no-useless-constructor': 'error',
+				'@typescript-eslint/no-empty-function': 'warn',
+				'@typescript-eslint/no-empty-interface': 'warn',
+				'@typescript-eslint/no-invalid-this': 'error',
+				'no-unused-private-class-members': 'error', // Catches unused #private ES2022 fields
+				'no-undef-init': 'error',
+				'no-unreachable': 'error',
+				'no-constant-condition': 'error',
+				'no-else-return': 'error',
+				'no-return-assign': 'error',
+				'no-var': 'error',
+
+				// Code spacing rules (autofix) - prevents dense code
+				'@stylistic/padding-line-between-statements': [
+					'error',
+					{ blankLine: 'always', prev: '*', next: 'return' },
+					{ blankLine: 'always', prev: ['const', 'let', 'var'], next: '*' },
+					{ blankLine: 'any', prev: ['const', 'let', 'var'], next: ['const', 'let', 'var'] },
+					{ blankLine: 'always', prev: 'directive', next: '*' },
+					{ blankLine: 'always', prev: ['case', 'default'], next: '*' },
+					{ blankLine: 'always', prev: '*', next: ['if', 'switch', 'try', 'while', 'for', 'do'] },
+					{ blankLine: 'always', prev: ['if', 'switch', 'try', 'while', 'for', 'do'], next: '*' },
+					{ blankLine: 'always', prev: '*', next: 'function' },
+					{ blankLine: 'always', prev: 'function', next: '*' },
+					{ blankLine: 'always', prev: 'import', next: '*' },
+					{ blankLine: 'any', prev: 'import', next: 'import' }
+				],
+				'@stylistic/lines-between-class-members': ['error', 'always', { exceptAfterSingleLine: true }],
 				'no-trailing-spaces': 'off', // Handled by prettier
 				'@stylistic/no-trailing-spaces': 'off', // Handled by prettier
 				'eol-last': 'off', // Handled by prettier
@@ -692,7 +728,7 @@ export default function ({
 				'unicorn/no-unnecessary-await': 'error',
 				'unicorn/no-unreadable-array-destructuring': 'error',
 				'unicorn/no-unreadable-iife': 'error',
-				'unicorn/no-unsafe-regex': 'error',
+				// 'unicorn/no-unsafe-regex' removed in v62 - covered by regexp/no-super-linear-backtracking
 				'unicorn/no-unused-properties': 'off',
 				'unicorn/no-useless-fallback-in-spread': 'error',
 				'unicorn/no-useless-length-check': 'error',

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@dmitryrechkin/eslint-standard",
 	"description": "This package provides a shared ESLint configuration which includes TypeScript support and a set of specific linting rules designed to ensure high-quality and consistent code style across projects.",
-	"version": "1.5.4",
+	"version": "1.5.6",
 	"main": "eslint.config.mjs",
 	"exports": {
 		".": "./eslint.config.mjs"
@@ -28,6 +28,7 @@
 		"test:security": "node tests/test-security-rules.mjs",
 		"test:sonarjs": "node tests/test-sonarjs-rules.mjs",
 		"test:unicorn": "node tests/test-unicorn-rules.mjs",
+		"test:spacing": "node tests/test-spacing-rules.mjs",
 		"test:switch-case": "node tests/test-switch-case-simple.mjs",
 		"test:cli": "node tests/test-cli.mjs",
 		"test:install": "node tests/test-install-simulation.mjs"
@@ -36,35 +37,35 @@
 	"author": "",
 	"license": "MIT",
 	"dependencies": {
-		"@stylistic/eslint-plugin": "^5.2.2",
-		"@typescript-eslint/eslint-plugin": "^8.38.0",
-		"@typescript-eslint/parser": "^8.38.0",
+		"@stylistic/eslint-plugin": "^5.6.1",
+		"@typescript-eslint/eslint-plugin": "^8.50.0",
+		"@typescript-eslint/parser": "^8.50.0",
 		"eslint-config-prettier": "^10.1.8",
-		"eslint-plugin-functional": "^7.3.0",
+		"eslint-import-resolver-typescript": "^4.4.4",
+		"eslint-plugin-functional": "^9.0.2",
 		"eslint-plugin-import": "^2.32.0",
-		"eslint-import-resolver-typescript": "^3.6.3",
-		"eslint-plugin-jsdoc": "^50.8.0",
+		"eslint-plugin-jsdoc": "^61.5.0",
 		"eslint-plugin-jsx-a11y": "^6.10.2",
-		"eslint-plugin-no-secrets": "^1.1.2",
-		"eslint-plugin-perfectionist": "^4.15.0",
+		"eslint-plugin-no-secrets": "^2.2.1",
+		"eslint-plugin-perfectionist": "^4.15.1",
 		"eslint-plugin-prettier": "^5.5.3",
 		"eslint-plugin-promise": "^7.2.1",
-		"eslint-plugin-regexp": "^2.9.0",
+		"eslint-plugin-regexp": "^2.10.0",
 		"eslint-plugin-security": "^3.0.1",
 		"eslint-plugin-simple-import-sort": "^12.1.1",
-		"eslint-plugin-sonarjs": "^3.0.4",
-		"eslint-plugin-unicorn": "^56.0.1",
-		"eslint-plugin-unused-imports": "^4.1.4",
+		"eslint-plugin-sonarjs": "^3.0.5",
+		"eslint-plugin-unicorn": "^62.0.0",
+		"eslint-plugin-unused-imports": "^4.3.0",
 		"prettier-plugin-astro": "^0.14.1",
-		"prettier-plugin-brace-style": "^0.8.1",
-		"prettier-plugin-merge": "^0.8.0"
+		"prettier-plugin-brace-style": "^0.8.2"
 	},
 	"peerDependencies": {
 		"eslint": "^9.0.0",
 		"prettier": "^3.0.0"
 	},
 	"devDependencies": {
-		"eslint": "^9.32.0",
-		"prettier": "^3.6.2"
+		"eslint": "^9.39.2",
+		"prettier": "^3.7.4",
+		"prettier-plugin-merge": "^0.8.0"
 	}
 }

package/src/plugins/interface-brace.mjs

@@ -1,5 +1,9 @@
 /**
  * Custom ESLint plugin to enforce Allman brace style for TypeScript interfaces
+ *
+ * Note: Only handles interface declarations, not type aliases.
+ * Type aliases are left to prettier-plugin-brace-style which keeps short
+ * object types on a single line (by design).
  */
 
 const interfaceBraceRule = {
@@ -23,7 +27,7 @@ const interfaceBraceRule = {
 				const interfaceId = node.id;
 				const typeParams = node.typeParameters;
 				const extendsClause = node.extends;
-				
+
 				// Find the opening brace
 				let tokenBeforeBrace;
 				if (node.heritage && node.heritage.length > 0) {
@@ -39,16 +43,16 @@ const interfaceBraceRule = {
 					// Simple interface
 					tokenBeforeBrace = interfaceId;
 				}
-				
+
 				// Get the opening brace token
 				const openingBrace = sourceCode.getTokenAfter(tokenBeforeBrace, token => token.type === 'Punctuator' && token.value === '{');
-				
+
 				if (!openingBrace) return;
-				
+
 				// Check if there's a newline before the opening brace
 				const tokenBefore = sourceCode.getTokenBefore(openingBrace);
 				const textBetween = sourceCode.text.slice(tokenBefore.range[1], openingBrace.range[0]);
-				
+
 				// Check if brace is on the same line
 				if (!textBetween.includes('\n')) {
 					context.report({
@@ -59,57 +63,18 @@ const interfaceBraceRule = {
 							const interfaceLine = sourceCode.getLines()[node.loc.start.line - 1];
 							const baseIndentMatch = interfaceLine.match(/^(\s*)/);
 							const baseIndent = baseIndentMatch ? baseIndentMatch[1] : '';
-							
+
 							// Replace the space before the brace with a newline and proper indentation
 							return fixer.replaceTextRange(
-								[tokenBefore.range[1], openingBrace.range[0]], 
+								[tokenBefore.range[1], openingBrace.range[0]],
 								'\n' + baseIndent
 							);
 						}
 					});
 				}
-			},
-			
-			// Also handle TSTypeAliasDeclaration with object type
-			TSTypeAliasDeclaration(node) {
-				if (node.typeAnnotation && node.typeAnnotation.type === 'TSTypeLiteral') {
-					const typeParams = node.typeParameters;
-					const tokenBeforeBrace = typeParams ? typeParams : node.id;
-					
-					// Find the equals sign
-					const equalsToken = sourceCode.getTokenAfter(tokenBeforeBrace, token => token.type === 'Punctuator' && token.value === '=');
-					
-					if (!equalsToken) return;
-					
-					// Get the opening brace token
-					const openingBrace = sourceCode.getTokenAfter(equalsToken, token => token.type === 'Punctuator' && token.value === '{');
-					
-					if (!openingBrace) return;
-					
-					// Check if there's a newline before the opening brace
-					const textBetween = sourceCode.text.slice(equalsToken.range[1], openingBrace.range[0]);
-					
-					// Check if brace is on the same line
-					if (!textBetween.includes('\n')) {
-						context.report({
-							node: openingBrace,
-							message: 'Opening brace should be on a new line (Allman style)',
-							fix(fixer) {
-								// Get the base indentation
-								const typeLine = sourceCode.getLines()[node.loc.start.line - 1];
-								const baseIndentMatch = typeLine.match(/^(\s*)/);
-								const baseIndent = baseIndentMatch ? baseIndentMatch[1] : '';
-								
-								// Replace the space before the brace with a newline and proper indentation
-								return fixer.replaceTextRange(
-									[equalsToken.range[1], openingBrace.range[0]], 
-									'\n' + baseIndent
-								);
-							}
-						});
-					}
-				}
 			}
+			// Note: TSTypeAliasDeclaration handling removed to avoid conflict with prettier-plugin-brace-style
+			// which keeps short object type literals on a single line
 		};
 	}
 };