@djangocfg/layouts 2.1.607 → 2.1.608

package/src/layouts/PrivateLayout/components/PrivateSidebarAccount.tsx

@@ -11,27 +11,18 @@
 
 'use client';
 
-import { ChevronDown } from 'lucide-react';
 import { Link } from '@djangocfg/ui-core/components';
 import React, { memo } from 'react';
 
-import { useAuth } from '@djangocfg/api/auth';
-import {
-  Avatar,
-  AvatarFallback,
-  AvatarImage,
-  Button,
-  MenuBuilder,
-} from '@djangocfg/ui-core/components';
-import type { MenuItem } from '@djangocfg/ui-core/components';
-import { cn, isDev } from '@djangocfg/ui-core/lib';
 import { useSidebar } from '@djangocfg/ui-core/components';
+import { cn, isDev } from '@djangocfg/ui-core/lib';
+import { useAuth } from '@djangocfg/api/auth';
 
 import { LucideIcon as LucideIconRender } from '../../../components';
+import { AccountFooterTrigger, AccountMenu } from '../../../components/account';
 import { usePeekPin } from '../hooks';
 import { usePrivateLayoutContext } from '../context';
 import { SIDEBAR_SPACING } from '../geometry';
-import { useAccountMenuItems } from '../../SettingsLayout/hooks';
 
 import type { HeaderConfig } from '../types';
 
@@ -39,72 +30,18 @@ interface PrivateSidebarAccountProps {
   header?: HeaderConfig;
 }
 
-interface AccountView {
-  source: 'user' | 'dev-fallback';
-  displayName: string;
-  email: string | null;
-  avatarUrl: string;
-  plan: string | null;
-}
-
 function PrivateSidebarAccountRaw({ header }: PrivateSidebarAccountProps) {
-  const { user } = useAuth();
   const { setOpen: setSidebarOpen } = useSidebar();
   const { isMobile } = usePrivateLayoutContext();
   const [isAccountMenuOpen, setIsAccountMenuOpen] = React.useState(false);
   usePeekPin(isAccountMenuOpen);
 
-  const accountLinks = React.useMemo(() => {
-    if (!header?.groups?.length) return [];
-    return header.groups.flatMap((g) => g.items.filter((i) => i.href));
-  }, [header?.groups]);
-
-  /**
-   * Single source of truth for what the footer renders. When `useAuth` returns
-   * a real user we use it; otherwise (in dev only) we fall back to a placeholder
-   * so the menu stays reachable for debugging. Production stays strict and the
-   * component returns null below.
-   */
-  const account = React.useMemo<AccountView>(() => {
-    if (user) {
-      return {
-        source: 'user',
-        displayName: user.display_username || user.email || 'User',
-        email: user.email ?? null,
-        avatarUrl: user.avatar ?? '',
-        plan: header?.userPlan ?? null,
-      };
-    }
-    return {
-      source: 'dev-fallback',
-      displayName: 'Guest (dev)',
-      email: null,
-      avatarUrl: '',
-      plan: header?.userPlan ?? 'No session',
-    };
-  }, [user, header?.userPlan]);
+  const { user } = useAuth();
 
   const onSecondaryExpand = React.useCallback(() => {
     setSidebarOpen(true);
   }, [setSidebarOpen]);
 
-  const headerLabelText = account.email ?? (account.source === 'dev-fallback' ? 'No active session' : null);
-
-  // The app's account links sit between the shared Settings shortcuts and Sign out.
-  const extraItems = React.useMemo<MenuItem[]>(() => {
-    const items: MenuItem[] = [];
-    if (accountLinks.length > 0) {
-      items.push({ kind: 'separator', id: 'sep-links' });
-      for (const link of accountLinks) {
-        items.push({ kind: 'item', id: link.href!, label: link.label, icon: link.icon, href: link.href });
-      }
-    }
-    return items;
-  }, [accountLinks]);
-
-  // Shared with every host: email, Settings, section shortcuts, Sign out (logout confirm opens over a CLOSED menu).
-  const menuItems = useAccountMenuItems({ extra: extraItems, label: headerLabelText });
-
   // Hide entirely in production when there's no user (auth still loading or
   // /me failed and the parent guard hasn't redirected yet). In dev keep a
   // placeholder so the footer + Log out are reachable for debugging.
@@ -118,77 +55,33 @@ function PrivateSidebarAccountRaw({ header }: PrivateSidebarAccountProps) {
   // production because `isDev` makes this guard statically dead in development.
   if (!user && !isDev) return null;
 
-  const userInitial = (account.displayName.charAt(0) || '?').toUpperCase();
   const secondary = header?.footerSecondaryAction;
 
-  const triggerClassName = cn(
-    'group h-8 min-w-0 max-w-full justify-start gap-2 rounded-lg px-2 text-left font-normal select-none',
-    // Full-width row unless a secondary action shares the footer.
-    !secondary && 'w-full',
-    'hover:bg-sidebar-accent/70 hover:text-sidebar-foreground',
-    // No focus ring on the menu trigger — the open menu is the affordance.
-    'focus-visible:outline-none focus-visible:ring-0 focus-visible:ring-offset-0',
-    isMobile && 'h-11',
-  );
-
   const secondaryButton = secondary ? (
     <SecondaryAction action={secondary} onParentExpand={onSecondaryExpand} />
   ) : null;
 
-  const dropdownContentClass = 'w-60 p-1.5';
-  // Always open UPWARD over the avatar (Claude pattern). The footer sits at the
-  // bottom of the rail in both expanded and collapsed states, so `top` reads
-  // correctly either way (vs. `right`, which floated off to the side).
-  const dropdownSide = 'top' as const;
-  const avatarClass = cn('shrink-0', isMobile ? 'size-7' : 'size-6');
-
-  // Like Claude: "Name · Plan ⌄". The email lives in the menu header.
-  const expandedMeta = (
-    <>
-      <span className="flex min-w-0 items-baseline gap-1 text-left">
-        <span className="truncate text-sm text-sidebar-foreground">{account.displayName}</span>
-        {account.plan ? (
-          <span className="shrink-0 text-xs text-sidebar-foreground/50">· {account.plan}</span>
-        ) : null}
-      </span>
-      <ChevronDown
-        className={cn(
-          'size-4 shrink-0 text-sidebar-foreground/40 transition-transform duration-150 group-data-[state=open]:rotate-180',
-          !secondary && 'ml-auto',
-        )}
-        aria-hidden
-      />
-    </>
-  );
-
-  const triggerButton = (
-    <Button type="button" variant="ghost" className={triggerClassName}>
-      <Avatar className={avatarClass}>
-        <AvatarImage src={account.avatarUrl} alt={account.displayName} />
-        <AvatarFallback className="text-xs font-medium">{userInitial}</AvatarFallback>
-      </Avatar>
-      {expandedMeta}
-    </Button>
-  );
-
   const wrapperClass = cn(
-    'flex w-full min-w-0 shrink-0 items-center justify-between gap-1 border-t border-sidebar-border/60',
+    'flex w-full min-w-0 shrink-0 items-center justify-between gap-1 border-t border-sidebar-border/60 bg-sidebar',
     SIDEBAR_SPACING[isMobile ? 'mobile' : 'desktop'].footer,
   );
 
   return (
     <div className={wrapperClass}>
-      <MenuBuilder
-        items={menuItems}
-        open={isAccountMenuOpen}
-        onOpenChange={setIsAccountMenuOpen}
-        side={dropdownSide}
+      {/* Always opens UPWARD over the avatar (Claude pattern): the footer sits at the bottom of the rail. */}
+      <AccountMenu
+        groups={header?.groups}
+        plan={header?.userPlan}
+        signIn="none"
+        devFallback
+        side="top"
         align="start"
         sideOffset={8}
-        contentClassName={dropdownContentClass}
+        open={isAccountMenuOpen}
+        onOpenChange={setIsAccountMenuOpen}
       >
-        {triggerButton}
-      </MenuBuilder>
+        <AccountFooterTrigger hasSecondary={Boolean(secondary)} className={isMobile ? 'h-10 px-2.5' : undefined} avatarClassName={isMobile ? 'size-7' : undefined} />
+      </AccountMenu>
       {secondaryButton}
     </div>
   );

package/src/layouts/PrivateLayout/components/PrivateSidebarTrigger.tsx

@@ -1,7 +1,8 @@
 /**
  * The one sidebar button: same box, icon and position rules on mobile and desktop.
- * Floating over the content it opens the sidebar; inside the sidebar header it closes or
- * collapses it. Both are `toggleSidebar`.
+ * In the top bar it opens the sidebar; inside the sidebar header it closes or collapses it. Both are
+ * `toggleSidebar`. No tooltip (the Cmd/Ctrl+B binding lives in ui-core's sidebar provider). The labels are plain
+ * English: the layouts have no message catalogue (only a locale hook).
  */
 
 'use client';
@@ -29,7 +30,6 @@ export const PrivateSidebarTrigger = React.forwardRef<
       data-sidebar="trigger"
       variant="ghost"
       size="icon"
-      title={label}
       aria-label={label}
       className={cn(TRIGGER_CLASS, className)}
       onClick={(event) => {

package/src/layouts/PrivateLayout/components/PrivateTopBarAccount.tsx

@@ -0,0 +1,27 @@
+/**
+ * Account avatar for the top bar: the shared `AccountMenu` (the same items as the sidebar footer) opened downward
+ * and aligned to the right edge. Rendered only for a signed-in user; the caller decides whether the bar shows it.
+ */
+
+'use client';
+
+import React from 'react';
+
+import { AccountAvatarTrigger, AccountMenu } from '../../../components/account';
+
+import type { HeaderConfig } from '../types';
+
+export function PrivateTopBarAccount({ header }: { header?: HeaderConfig }) {
+  return (
+    <AccountMenu
+      groups={header?.groups}
+      plan={header?.userPlan}
+      signIn="none"
+      side="bottom"
+      align="end"
+      sideOffset={6}
+    >
+      <AccountAvatarTrigger />
+    </AccountMenu>
+  );
+}

package/src/layouts/PrivateLayout/components/SidebarBody.test.tsx

@@ -0,0 +1,73 @@
+// @vitest-environment jsdom
+import React, { act } from 'react';
+import { createRoot, type Root } from 'react-dom/client';
+import { afterEach, beforeAll, describe, expect, it, vi } from 'vitest';
+
+import { SidebarProvider } from '@djangocfg/ui-core/components';
+
+import { PrivateLayoutProvider } from '../context';
+import { SIDEBAR_SPACING } from '../geometry';
+import { SidebarBody } from './SidebarBody';
+
+vi.mock('@djangocfg/api/auth', async () => ({
+  AuthContext: (await import('react')).createContext(undefined),
+  useAuth: () => ({ user: { email: 'a@b.c', display_username: 'Mark' } }),
+}));
+
+(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
+
+let host: HTMLElement | null = null;
+let root: Root | null = null;
+
+beforeAll(() => {
+  window.matchMedia ??= ((query: string) => ({
+    matches: false, media: query, onchange: null,
+    addEventListener: () => {}, removeEventListener: () => {}, addListener: () => {}, removeListener: () => {}, dispatchEvent: () => false,
+  })) as typeof window.matchMedia;
+});
+afterEach(() => {
+  act(() => root?.unmount());
+  host?.remove();
+  host = root = null;
+});
+
+function render(isMobile: boolean) {
+  host = document.createElement('div');
+  document.body.appendChild(host);
+  root = createRoot(host);
+  act(() =>
+    root!.render(
+      <SidebarProvider>
+        <PrivateLayoutProvider sidebar={{ groups: [{ label: 'A', items: [{ label: 'Home', href: '/' }] }] }} header={undefined} pathname="/" isMobile={isMobile}>
+          <SidebarBody />
+        </PrivateLayoutProvider>
+      </SidebarProvider>,
+    ),
+  );
+  return host;
+}
+
+describe('SidebarBody zones', () => {
+  it.each([true, false])('header and footer are pinned (shrink-0), only the nav scrolls (mobile %s)', (isMobile) => {
+    const el = render(isMobile);
+    const header = el.querySelector<HTMLElement>('[data-sidebar="header"]')!;
+    const nav = el.querySelector<HTMLElement>('[data-sidebar="content"]')!;
+    const footer = nav.nextElementSibling as HTMLElement;
+    expect(header.className).toMatch(/\bshrink-0\b/);
+    expect(header.className).toContain('bg-sidebar');
+    expect(nav.className).toMatch(/\bmin-h-0\b/);
+    expect(nav.className).toMatch(/\bflex-1\b/);
+    expect(nav.className).toMatch(/\boverflow-y-auto\b/);
+    expect(nav.className).toMatch(/\boverscroll-contain\b/);
+    expect(footer.className).toMatch(/\bshrink-0\b/);
+    expect(footer.className).toMatch(/\bborder-t\b/);
+    expect(footer.className).toContain('bg-sidebar');
+    // Nothing else in the body scrolls.
+    expect(header.className).not.toMatch(/overflow-y-auto/);
+    expect(footer.className).not.toMatch(/overflow-y-auto/);
+  });
+
+  it('mobile footer respects the home indicator', () => {
+    expect(SIDEBAR_SPACING.mobile.footer).toContain('--safe-bottom');
+  });
+});

package/src/layouts/PrivateLayout/components/SidebarBody.tsx

@@ -17,7 +17,7 @@ import { SidebarNavGroup } from './SidebarNavGroup';
 import { SidebarSlots } from './SidebarSlots';
 
 export function SidebarBody() {
-  const { sidebar, header, isMobile } = usePrivateLayoutContext();
+  const { sidebar, header, isMobile, accountInBar } = usePrivateLayoutContext();
 
   const groups = useMemo(
     () =>
@@ -33,20 +33,29 @@ export function SidebarBody() {
     [sidebar?.groups],
   );
 
+  // Three zones: pinned header, the ONLY scroller (nav), pinned footer. The header gets a border once the nav scrolls.
+  const [scrolled, setScrolled] = React.useState(false);
+  const onScroll = React.useCallback((e: React.UIEvent<HTMLDivElement>) => {
+    const next = e.currentTarget.scrollTop > 0;
+    setScrolled((prev) => (prev === next ? prev : next));
+  }, []);
+
   return (
     <>
-      <SidebarBrand />
+      <SidebarBrand bordered={scrolled} />
       <div
         data-sidebar="content"
+        onScroll={onScroll}
         className={cn(
-          'flex min-h-0 flex-1 flex-col overflow-y-auto overflow-x-hidden',
+          'flex min-h-0 flex-1 flex-col overflow-y-auto overflow-x-hidden overscroll-contain',
           SIDEBAR_SPACING[isMobile ? 'mobile' : 'desktop'].body,
         )}
       >
         <SidebarSlots />
         {groups}
       </div>
-      <PrivateSidebarAccount header={header} />
+      {/* On a phone the account lives in the top bar when it shows the avatar; no second entry point here. */}
+      {isMobile && accountInBar ? null : <PrivateSidebarAccount header={header} />}
     </>
   );
 }

package/src/layouts/PrivateLayout/components/SidebarBrand.tsx

@@ -7,7 +7,7 @@
 
 import React, { memo } from 'react';
 
-import { Link } from '@djangocfg/ui-core/components';
+import { Link, useSidebar } from '@djangocfg/ui-core/components';
 import { cn } from '@djangocfg/ui-core/lib';
 
 import { LucideIcon } from '../../../components';
@@ -17,41 +17,48 @@ import { PrivateSidebarTrigger } from './PrivateSidebarTrigger';
 import { SidebarBrandSwitcher } from './SidebarBrandSwitcher';
 
 const BRAND_LINK =
-  'flex min-w-0 items-center gap-2.5 rounded-lg py-1 outline-none ring-sidebar-ring focus-visible:ring-2';
+  'flex min-w-0 items-center gap-2.5 rounded-lg py-1 text-sidebar-foreground no-underline outline-none ring-sidebar-ring transition-opacity hover:no-underline hover:opacity-80 focus-visible:ring-2';
 
-function SidebarBrandRaw() {
+/** Brand name: semibold, one step larger on desktop (18px), 16px on a phone; one line, truncated. */
+const BRAND_NAME = 'truncate text-base font-semibold tracking-tight md:text-lg';
+
+function SidebarBrandRaw({ bordered = false }: { bordered?: boolean }) {
   const { header, homeHref, brandTitle, brandMonogram, isMobile } = usePrivateLayoutContext();
 
+  const { isMobile: drawer, setOpenMobile } = useSidebar();
+  // On a phone the drawer closes on click, also when the target is the current page (no pathname change).
+  const closeDrawer = React.useCallback(() => {
+    if (drawer) setOpenMobile(false);
+  }, [drawer, setOpenMobile]);
+
   const customBrand = header?.brand;
 
   const brand =
     customBrand != null && customBrand !== false ? (
       typeof customBrand === 'string' ? (
-        <Link href={homeHref} className={BRAND_LINK}>
-          <span className="truncate text-base font-medium tracking-tight">{customBrand}</span>
+        <Link href={homeHref} className={BRAND_LINK} aria-label={customBrand} onClick={closeDrawer}>
+          <span className={BRAND_NAME}>{customBrand}</span>
         </Link>
       ) : (
         customBrand
       )
     ) : (
-      <Link href={homeHref} className={BRAND_LINK}>
+      <Link href={homeHref} className={BRAND_LINK} aria-label={brandTitle || 'Home'} onClick={closeDrawer}>
         <span
           className={cn(
             'flex shrink-0 items-center justify-center rounded-lg bg-sidebar-primary',
-            isMobile ? 'size-8' : 'size-7',
+            isMobile ? 'size-7' : 'size-8',
           )}
         >
           {header?.brandIcon ? (
-            <LucideIcon icon={header.brandIcon} className="size-4 text-sidebar-primary-foreground" />
+            <LucideIcon icon={header.brandIcon} className="size-4 text-sidebar-primary-foreground md:size-[18px]" />
           ) : (
-            <span className="text-[11px] font-bold leading-none text-sidebar-primary-foreground">
+            <span className="text-xs font-bold leading-none text-sidebar-primary-foreground">
               {brandMonogram}
             </span>
           )}
         </span>
-        <span className={'truncate text-base font-medium tracking-tight'}>
-          {brandTitle}
-        </span>
+        {brandTitle ? <span className={BRAND_NAME}>{brandTitle}</span> : null}
       </Link>
     );
 
@@ -62,12 +69,16 @@ function SidebarBrandRaw() {
   return (
     <div
       data-sidebar="header"
-      className={cn('flex shrink-0 items-center gap-2', SIDEBAR_SPACING[isMobile ? 'mobile' : 'desktop'].header)}
+      className={cn(
+        'flex shrink-0 items-center gap-2 bg-sidebar shadow-[0_1px_0_0_transparent] transition-shadow',
+        bordered && 'shadow-[0_1px_0_0_color-mix(in_oklab,var(--sidebar-border)_60%,transparent)]',
+        SIDEBAR_SPACING[isMobile ? 'mobile' : 'desktop'].header)}
     >
       <div className="min-w-0 flex-1">
         {header?.switcher ? <SidebarBrandSwitcher config={header.switcher} showCollapseTrigger /> : brand}
       </div>
-      {trailing}
+      {/* The desktop toggle collapses the pinned sidebar. The phone drawer has none: it closes by backdrop, swipe, Escape, or navigating. */}
+      {isMobile ? null : trailing}
     </div>
   );
 }

package/src/layouts/PrivateLayout/components/SidebarNavGroup.tsx

@@ -27,10 +27,15 @@ import { isSettingsItem, isSidebarGroupVisible, sidebarItemKey, visibleSidebarIt
 import type { SidebarGroupConfig } from '../types';
 import { SidebarNavItem } from './SidebarNavItem';
 
-const groupClassFor = (inset: string) =>
+const groupClassFor = (inset: string, insetRule: boolean) =>
   cn(
-    `gap-0 ${inset} py-1.5`,
-    '[&:not(:first-child)]:mt-1.5 [&:not(:first-child)]:border-t [&:not(:first-child)]:border-sidebar-border/60 [&:not(:first-child)]:pt-3',
+    // Phone drawer (insetRule): half the air between groups.
+    `gap-0 ${inset} ${insetRule ? 'py-1' : 'py-1.5'}`,
+    insetRule ? '[&:not(:first-child)]:mt-0.5 [&:not(:first-child)]:pt-1.5' : '[&:not(:first-child)]:mt-1.5 [&:not(:first-child)]:pt-3',
+    // Phone drawer: the hairline is inset to the row gutter (8px). Desktop keeps its full-width border.
+    insetRule
+      ? '[&:not(:first-child)]:before:absolute [&:not(:first-child)]:before:inset-x-2 [&:not(:first-child)]:before:top-0 [&:not(:first-child)]:before:h-px [&:not(:first-child)]:before:bg-sidebar-border/60'
+      : '[&:not(:first-child)]:border-t [&:not(:first-child)]:border-sidebar-border/60',
   );
 
 /** A `separated` group draws its own, stronger divider (below), so it drops the hairline and takes more air. */
@@ -49,7 +54,7 @@ function GroupDivider({ inset }: { inset: string }) {
 }
 
 function SidebarNavGroupRaw({ group }: { group: SidebarGroupConfig }) {
-  const { isActive, geometry } = usePrivateLayoutContext();
+  const { isActive, geometry, isMobile } = usePrivateLayoutContext();
 
   const hasLabel = group.label.trim().length > 0;
   const isCollapsible = Boolean(group.collapsible) && hasLabel;
@@ -84,7 +89,7 @@ function SidebarNavGroupRaw({ group }: { group: SidebarGroupConfig }) {
   ));
   if (!visible) return null;
 
-  const groupClass = group.separated ? separatedGroupClassFor(geometry.inset) : groupClassFor(geometry.inset);
+  const groupClass = group.separated ? separatedGroupClassFor(geometry.inset) : groupClassFor(geometry.inset, isMobile);
   const divider = group.separated ? <GroupDivider inset={geometry.dividerInset} /> : null;
 
   if (isCollapsible) {

package/src/layouts/PrivateLayout/components/SidebarPeek.tsx

@@ -1,6 +1,6 @@
 /**
  * Peek panel: the full sidebar floated over the page while it is collapsed.
- * Opened by hover intent on the left edge (or the trigger zone), held by `SidebarPeekProvider`,
+ * Opened by hover intent on the left screen edge strip (the toggle button itself does not open it), held by `SidebarPeekProvider`,
  * slides in and out (it stays mounted while the exit animation runs).
  */
 

package/src/layouts/PrivateLayout/context.tsx

@@ -7,6 +7,8 @@
 
 'use client';
 
+import { useLandingRoute } from './hooks/useLandingRoute';
+import { useProjectName } from '../../shared/ProjectContext';
 import React, { createContext, useContext, useMemo } from 'react';
 
 import { NAV_GEOMETRY } from './geometry';
@@ -19,6 +21,8 @@ export interface PrivateLayoutContextValue {
   header: HeaderConfig | undefined;
   pathname: string;
   isMobile: boolean;
+  /** The top bar carries the account avatar, so the phone drawer drops its footer account (one entry point). */
+  accountInBar: boolean;
   geometry: NavGeometry;
   /** The route rows; Settings launchers have no route and take no part in the active-route check. */
   allItems: SidebarLinkItem[];
@@ -44,6 +48,7 @@ interface PrivateLayoutProviderProps {
   header: HeaderConfig | undefined;
   pathname: string;
   isMobile: boolean;
+  accountInBar?: boolean;
 }
 
 export function PrivateLayoutProvider({
@@ -52,9 +57,15 @@ export function PrivateLayoutProvider({
   header,
   pathname,
   isMobile,
+  accountInBar = false,
 }: PrivateLayoutProviderProps) {
-  const homeHref = sidebar?.homeHref || '/';
-  const brandTitle = header?.title?.trim() || 'Dashboard';
+  // header.href > sidebar.homeHref > the private landing route AppLayout/BaseApp configures (`auth.routes.defaultCallback`,
+  // resolved by the auth provider; `undefined` outside it) > '/'.
+  const landing = useLandingRoute();
+  const homeHref = header?.href || sidebar?.homeHref || landing || '/';
+  // header.title > the project name from BaseApp > nothing (monogram only).
+  const projectName = useProjectName();
+  const brandTitle = header?.title?.trim() || projectName || '';
   const brandMonogram = (
     header?.brandLetter?.trim().charAt(0) ||
     brandTitle.charAt(0) ||
@@ -87,6 +98,7 @@ export function PrivateLayoutProvider({
       header,
       pathname,
       isMobile,
+      accountInBar,
       geometry: isMobile ? NAV_GEOMETRY.mobile : NAV_GEOMETRY.desktop,
       allItems,
       isActive,
@@ -94,7 +106,7 @@ export function PrivateLayoutProvider({
       brandTitle,
       brandMonogram,
     }),
-    [sidebar, header, pathname, isMobile, allItems, isActive, homeHref, brandTitle, brandMonogram],
+    [sidebar, header, pathname, isMobile, accountInBar, allItems, isActive, homeHref, brandTitle, brandMonogram],
   );
 
   return <PrivateLayoutContext.Provider value={value}>{children}</PrivateLayoutContext.Provider>;

package/src/layouts/PrivateLayout/geometry.test.ts

@@ -1,27 +1,27 @@
 import { describe, expect, it } from 'vitest';
 
-import { NAV_GEOMETRY, SIDEBAR_SPACING } from './geometry';
+import { NAV_GEOMETRY, SHELL_CLASS, SIDEBAR_SPACING } from './geometry';
 
 const SIZES = /\btext-(base|lg|xl|2xl)\b/;
 
 describe('sidebar geometry', () => {
   for (const form of ['desktop', 'mobile'] as const) {
-    it(`${form}: rows use 14px text and a 16-18px icon, not a large font`, () => {
+    it(`${form}: rows use 14px text and a 16-20px icon, not a large font`, () => {
       expect(NAV_GEOMETRY[form].item).toMatch(/\btext-sm\b/);
       expect(NAV_GEOMETRY[form].item).not.toMatch(SIZES);
-      expect(NAV_GEOMETRY[form].item).toMatch(/\[&>svg\]:size-(4|\[18px\])/);
+      expect(NAV_GEOMETRY[form].item).toMatch(/\[&>svg\]:size-(4|5)/);
       expect(NAV_GEOMETRY[form].label).toMatch(/\btext-xs\b/);
     });
 
     it(`${form}: horizontal inset is tight (8px), vertical body padding is roomier`, () => {
       expect(NAV_GEOMETRY[form].inset).toBe('px-2');
-      expect(NAV_GEOMETRY[form].item).toMatch(/\bpx-2\b/);
-      expect(SIDEBAR_SPACING[form].body).toMatch(/\bpy-3\b/);
+      expect(NAV_GEOMETRY[form].item).toMatch(form === 'mobile' ? /\bpx-2\.5\b/ : /\bpx-2\b/);
+      expect(SIDEBAR_SPACING[form].body).toMatch(form === 'mobile' ? /\bpy-2\b/ : /\bpy-3\b/);
     });
   }
 
-  it('mobile rows keep a 44px touch target; desktop rows are 36px', () => {
-    expect(NAV_GEOMETRY.mobile.item).toMatch(/\bh-11\b/);
+  it('mobile rows are 40px with a 44px hit area (see touch-safe.css); desktop rows are 36px', () => {
+    expect(NAV_GEOMETRY.mobile.item).toMatch(/\bh-10\b/);
     expect(NAV_GEOMETRY.desktop.item).toMatch(/\bh-9\b/);
   });
 
@@ -29,4 +29,16 @@ describe('sidebar geometry', () => {
     expect(SIDEBAR_SPACING.mobile.header).toContain('env(safe-area-inset-top');
     expect(SIDEBAR_SPACING.mobile.footer).toContain('env(safe-area-inset-bottom');
   });
+
+  it('the shell is one dynamic viewport tall and clips, so the document never scrolls', () => {
+    expect(SHELL_CLASS).toContain('h-[var(--app-height,100dvh)]');
+    expect(SHELL_CLASS).toContain('overflow-hidden');
+    expect(SHELL_CLASS).toContain('min-h-0');
+    expect(SHELL_CLASS).not.toMatch(/min-h-(screen|svh)/);
+  });
+
+  it('mobile header and footer also respect the side safe areas (landscape notch)', () => {
+    expect(SIDEBAR_SPACING.mobile.header).toContain('env(safe-area-inset-left');
+    expect(SIDEBAR_SPACING.mobile.footer).toContain('env(safe-area-inset-right');
+  });
 });