@dizzlkheinz/ynab-mcpb 0.26.2 → 0.26.4

package/dist/tools/schemas/outputs/reconciliationOutputs.js

@@ -257,6 +257,31 @@ export const ExecutionActionRecordSchema = z.discriminatedUnion("type", [
         reason: z.string(),
         bulk_chunk_index: z.number(),
     }),
+    z.object({
+        type: z.literal("batch_update_failed"),
+        transaction: z.null(),
+        reason: z.string(),
+    }),
+    z.object({
+        type: z.literal("batch_reconcile_failed"),
+        transaction: z.null(),
+        reason: z.string(),
+    }),
+    z.object({
+        type: z.literal("reconciliation_complete"),
+        transaction: z.null(),
+        reason: z.string(),
+    }),
+    z.object({
+        type: z.literal("diagnostic_step3_entry"),
+        transaction: z.null(),
+        reason: z.string(),
+    }),
+    z.object({
+        type: z.literal("diagnostic_unmatched_ynab"),
+        transaction: z.record(z.string(), z.unknown()),
+        reason: z.string(),
+    }),
 ]);
 export const ExecutionSummarySchema = z.object({
     bank_transactions_count: z.number(),
@@ -319,78 +344,25 @@ export const CsvFormatMetadataSchema = z.object({
     amount_column: z.string().nullable(),
     payee_column: z.string().nullable(),
 });
-const StructuredReconciliationDataBaseSchema = z.object({
-    version: z.string(),
-    schema_url: z.string(),
-    generated_at: z.string(),
-    account: z.object({
-        id: z.string().optional(),
-        name: z.string().optional(),
-    }),
-    summary: ReconciliationSummarySchema,
-    balance: BalanceInfoSchema.extend({
-        discrepancy_direction: z.enum(["balanced", "ynab_higher", "bank_higher"]),
-    }),
-    insights: z.array(ReconciliationInsightSchema),
-    next_steps: z.array(z.string()),
-    matches: z.object({
-        auto: z.array(TransactionMatchSchema),
-        suggested: z.array(TransactionMatchSchema),
-    }),
-    unmatched: z.object({
-        bank: z.array(BankTransactionSchema),
-        ynab: z.array(YNABTransactionSimpleSchema),
-        ynab_outside_date_range: z.array(YNABTransactionSimpleSchema).optional(),
-    }),
-    recommendations: z.array(ActionableRecommendationSchema).optional(),
-    csv_format: CsvFormatMetadataSchema.optional(),
-    execution: ExecutionResultSchema.optional(),
-    audit: AuditMetadataSchema.optional(),
+export const ExecutionSummaryOutputSchema = z.object({
+    transactions_created: z.number().int(),
+    transactions_updated: z.number().int(),
+    dates_adjusted: z.number().int(),
+    dry_run: z.boolean(),
+    balance_status: z.enum(["balanced", "unbalanced", "not_verified"]).optional(),
+    recommendations: z.array(z.string()).optional(),
 });
 export const StructuredReconciliationUnmatchedOnlySchema = z
     .object({
     unmatched_bank: z.array(BankTransactionSchema),
     unmatched_ynab: z.array(YNABTransactionSimpleSchema),
     suggestions: z.array(TransactionMatchSchema),
+    execution_summary: ExecutionSummaryOutputSchema.optional(),
 })
     .strict();
 export const ReconcileAccountOutputSchema = z
-    .union([
-    z
-        .object({
-        human: z.string(),
-        structured: z.union([
-            StructuredReconciliationDataBaseSchema,
-            StructuredReconciliationUnmatchedOnlySchema,
-        ]),
-    })
-        .strict(),
-    z
-        .object({
-        human: z.string(),
-    })
-        .strict(),
-])
-    .refine((data) => {
-    if ("structured" in data &&
-        data.structured &&
-        "balance" in data.structured &&
-        typeof data.structured.balance === "object" &&
-        data.structured.balance !== null) {
-        const discrepancyAmount = data.structured.balance.discrepancy.value;
-        const direction = data.structured.balance.discrepancy_direction;
-        if (Math.abs(discrepancyAmount) < 0.01) {
-            return direction === "balanced";
-        }
-        if (discrepancyAmount > 0) {
-            return direction === "ynab_higher";
-        }
-        if (discrepancyAmount < 0) {
-            return direction === "bank_higher";
-        }
-    }
-    return true;
-}, {
-    message: "Discrepancy direction mismatch: direction must match the numeric discrepancy amount",
-    path: ["balance", "discrepancy_direction"],
-});
+    .object({
+    human: z.string(),
+    structured: StructuredReconciliationUnmatchedOnlySchema,
+})
+    .strict();

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@dizzlkheinz/ynab-mcpb",
-	"version": "0.26.2",
+	"version": "0.26.4",
 	"mcpName": "io.github.dizzlkheinz/ynab-mcpb",
 	"description": "Model Context Protocol server for YNAB (You Need A Budget) integration",
 	"main": "dist/index.js",

package/src/__tests__/performance.test.ts

@@ -242,16 +242,14 @@ function buildPerformanceParams(
 		account_id: "account-performance",
 		csv_data: "Date,Description,Amount",
 		statement_balance: statementBalance,
-		statement_date: "2025-08-31",
+		statement_end_date: "2025-08-31",
 		date_tolerance_days: 1,
-		auto_match_threshold: 90,
-		suggestion_threshold: 60,
+		match_strictness: "strict" as const,
 		auto_create_transactions: true,
 		auto_update_cleared_status: false,
 		auto_unclear_missing: false,
 		auto_adjust_dates: false,
 		dry_run: false,
-		include_structured_data: false,
 		...overrides,
 	};
 }

package/src/tools/reconciliation/__tests__/executor.integration.test.ts

@@ -376,16 +376,14 @@ function buildIntegrationParams(
 		account_id: accountId,
 		csv_data: "Date,Description,Amount",
 		statement_balance: statementBalance,
-		statement_date: new Date().toISOString().slice(0, 10),
+		statement_end_date: new Date().toISOString().slice(0, 10),
 		date_tolerance_days: 1,
-		auto_match_threshold: 90,
-		suggestion_threshold: 60,
+		match_strictness: "strict" as const,
 		auto_create_transactions: true,
 		auto_update_cleared_status: false,
 		auto_unclear_missing: false,
 		auto_adjust_dates: false,
 		dry_run: false,
-		include_structured_data: false,
 		...overrides,
 	};
 }

package/src/tools/reconciliation/__tests__/executor.test.ts

@@ -155,10 +155,9 @@ const buildBulkParams = (
 	account_id: "account-bulk",
 	csv_data: "Date,Payee,Amount",
 	statement_balance: statementBalance.value, // Use decimal value for params
-	statement_date: "2025-10-31",
+	statement_end_date: "2025-10-31",
 	date_tolerance_days: 1,
-	auto_match_threshold: 90,
-	suggestion_threshold: 60,
+	match_strictness: "strict" as const,
 	auto_create_transactions: true,
 	auto_update_cleared_status: false,
 	auto_unclear_missing: false,
@@ -240,8 +239,7 @@ describe("executeReconciliation (dry run)", () => {
 			csv_data: "Date,Description,Amount",
 			statement_balance: -921.24,
 			date_tolerance_days: 2,
-			auto_match_threshold: 90,
-			suggestion_threshold: 60,
+			match_strictness: "strict" as const,
 			auto_create_transactions: true,
 			auto_update_cleared_status: true,
 			auto_unclear_missing: true,
@@ -284,10 +282,9 @@ describe("executeReconciliation (apply mode)", () => {
 			account_id: "account-apply",
 			csv_data: "Date,Description,Amount",
 			statement_balance: -921.24,
-			statement_date: "2025-10-31",
+			statement_end_date: "2025-10-31",
 			date_tolerance_days: 2,
-			auto_match_threshold: 90,
-			suggestion_threshold: 60,
+			match_strictness: "strict" as const,
 			auto_create_transactions: true,
 			auto_update_cleared_status: true,
 			auto_unclear_missing: true,
@@ -448,8 +445,7 @@ describe("executeReconciliation (ordered halting)", () => {
 			csv_data: "Date,Description,Amount",
 			statement_balance: 100,
 			date_tolerance_days: 2,
-			auto_match_threshold: 90,
-			suggestion_threshold: 60,
+			match_strictness: "strict" as const,
 			auto_create_transactions: false,
 			auto_update_cleared_status: true,
 			auto_unclear_missing: false,

package/src/tools/reconciliation/__tests__/index.test.ts

@@ -4,7 +4,7 @@ import { DeltaFetcher } from "../../deltaFetcher.js";
 import { handleReconcileAccount, ReconcileAccountSchema } from "../index.js";
 
 describe("ReconcileAccountSchema", () => {
-	it("parses new response options and defaults structured_content to full", () => {
+	it("parses params and respects max_suggestions_in_output", () => {
 		const result = ReconcileAccountSchema.parse({
 			budget_id: "budget-1",
 			account_id: "account-1",
@@ -13,7 +13,6 @@ describe("ReconcileAccountSchema", () => {
 			max_suggestions_in_output: 3,
 		});
 
-		expect(result.structured_content).toBe("full");
 		expect(result.max_suggestions_in_output).toBe(3);
 	});
 
@@ -48,7 +47,7 @@ describe("ReconcileAccountSchema", () => {
 });
 
 describe("handleReconcileAccount", () => {
-	it('returns filtered structured content for "unmatched_only"', async () => {
+	it("always returns unmatched_only structured content", async () => {
 		const ynabAPI = {
 			accounts: {
 				getAccounts: async () => ({
@@ -96,10 +95,7 @@ describe("handleReconcileAccount", () => {
 			account_id: "account-1",
 			csv_data: "Date,Description,Amount\n2025-01-01,Coffee,-10.00",
 			statement_balance: -10,
-			include_structured_data: true,
-			structured_content: "unmatched_only",
 			auto_unclear_missing: false,
-			force_full_refresh: true,
 		});
 
 		const structured = (result.structuredContent as Record<string, unknown>)
@@ -115,5 +111,13 @@ describe("handleReconcileAccount", () => {
 		expect(Array.isArray(structured["unmatched_bank"])).toBe(true);
 		expect(Array.isArray(structured["unmatched_ynab"])).toBe(true);
 		expect(Array.isArray(structured["suggestions"])).toBe(true);
+		expect(structured).toHaveProperty("execution_summary");
+		expect(
+			(
+				structured["execution_summary"] as {
+					balance_status?: string;
+				}
+			).balance_status,
+		).toBe("unbalanced");
 	});
 });

package/src/tools/reconciliation/__tests__/reconciliation.delta.integration.test.ts

@@ -1,4 +1,3 @@
-import type { CallToolResult } from "@modelcontextprotocol/sdk/types.js";
 import {
 	afterEach,
 	beforeAll,
@@ -34,50 +33,6 @@ describeIntegration("Reconciliation delta isolation", () => {
 	let deltaFetcher: DeltaFetcher;
 	let previousNodeEnv: string | undefined;
 	let setupRateLimited = false;
-	const parseStructuredPayload = (result: CallToolResult) => {
-		if (result.isError) {
-			const errorContent = result.content?.find(
-				(entry) => entry.type === "text",
-			);
-			throw new Error(
-				errorContent && errorContent.type === "text"
-					? errorContent.text
-					: "Unexpected reconciliation error response",
-			);
-		}
-
-		// Find the last text entry that contains valid JSON with an "audit" key
-		const textEntries =
-			result.content?.filter((entry) => entry.type === "text") ?? [];
-		for (let i = textEntries.length - 1; i >= 0; i--) {
-			const entry = textEntries[i];
-			if (entry.type === "text") {
-				try {
-					const parsed = JSON.parse(entry.text);
-					if (parsed && typeof parsed === "object") {
-						// Check if audit is at top level (old format)
-						if ("audit" in parsed) {
-							return parsed;
-						}
-						// Check if audit is nested under structured (current format: { human, structured: { audit, ... } })
-						const structured = (parsed as any).structured;
-						if (
-							structured &&
-							typeof structured === "object" &&
-							"audit" in structured
-						) {
-							return structured;
-						}
-					}
-				} catch {
-					// Not valid JSON, continue searching
-				}
-			}
-		}
-		throw new Error(
-			'Expected structured reconciliation payload with "audit" key to be present',
-		);
-	};
 
 	beforeAll(async () => {
 		try {
@@ -161,7 +116,6 @@ describeIntegration("Reconciliation delta isolation", () => {
 				account_id: testAccountId,
 				csv_data: csvData,
 				statement_balance: 0,
-				include_structured_data: true,
 			};
 
 			const accountsFullSpy = vi.spyOn(deltaFetcher, "fetchAccountsFull");
@@ -171,11 +125,7 @@ describeIntegration("Reconciliation delta isolation", () => {
 			);
 			const txDeltaSpy = vi.spyOn(deltaFetcher, "fetchTransactionsByAccount");
 
-			const result = await handleReconcileAccount(
-				ynabAPI,
-				deltaFetcher,
-				params,
-			);
+			await handleReconcileAccount(ynabAPI, deltaFetcher, params);
 
 			expect(accountsFullSpy).toHaveBeenCalledWith(testBudgetId);
 			expect(txFullSpy).toHaveBeenCalledWith(
@@ -184,65 +134,6 @@ describeIntegration("Reconciliation delta isolation", () => {
 				expect.any(String),
 			);
 			expect(txDeltaSpy).not.toHaveBeenCalled();
-
-			const structuredPayload = parseStructuredPayload(result);
-			expect(structuredPayload.audit).toMatchObject({
-				data_freshness: "guaranteed_fresh",
-				data_source: "full_api_fetch_no_delta",
-			});
-			expect(structuredPayload.audit).toHaveProperty("server_knowledge");
-			expect(structuredPayload.audit).toHaveProperty("transactions_count");
-		});
-	});
-
-	it("can opt into delta-backed fetches when force_full_refresh is false", {
-		meta: { tier: "domain", domain: "delta" },
-	}, async (ctx) => {
-		await withRateLimitSkip(ctx, async () => {
-			const csvData = ["Date,Amount,Description", "2024-01-01,10,Coffee"].join(
-				"\n",
-			);
-			const params = {
-				budget_id: testBudgetId,
-				account_id: testAccountId,
-				csv_data: csvData,
-				statement_balance: 0,
-				include_structured_data: true,
-				force_full_refresh: false,
-			};
-
-			const accountsFullSpy = vi.spyOn(deltaFetcher, "fetchAccountsFull");
-			const txFullSpy = vi.spyOn(
-				deltaFetcher,
-				"fetchTransactionsByAccountFull",
-			);
-			const accountsDeltaSpy = vi.spyOn(deltaFetcher, "fetchAccounts");
-			const txDeltaSpy = vi.spyOn(deltaFetcher, "fetchTransactionsByAccount");
-
-			const result = await handleReconcileAccount(
-				ynabAPI,
-				deltaFetcher,
-				params,
-			);
-
-			expect(accountsFullSpy).not.toHaveBeenCalled();
-			expect(txFullSpy).not.toHaveBeenCalled();
-			expect(accountsDeltaSpy).toHaveBeenCalledWith(testBudgetId);
-			expect(txDeltaSpy).toHaveBeenCalledWith(
-				testBudgetId,
-				testAccountId,
-				expect.any(String),
-			);
-
-			const structuredPayload = parseStructuredPayload(result);
-			expect(structuredPayload.audit).toMatchObject({
-				data_source: expect.stringMatching(/^delta_fetch_/),
-			});
-			expect(structuredPayload.audit.cache_status).toMatchObject({
-				accounts_cached: expect.any(Boolean),
-				transactions_cached: expect.any(Boolean),
-				delta_merge_applied: expect.any(Boolean),
-			});
 		});
 	});
 });

package/src/tools/reconciliation/executor.ts

@@ -130,17 +130,10 @@ function resolveStatementWindow(
 	params: ReconcileAccountRequest,
 	analysisDateRange?: string | undefined,
 ): StatementWindow | undefined {
-	const start = parseISODate(params.statement_start_date);
-	const end =
-		parseISODate(params.statement_end_date ?? params.statement_date) ??
-		// If only start provided, end stays undefined
-		undefined;
-
-	if (start || end) {
-		const window: StatementWindow = {};
-		if (start) window.start = start;
-		if (end) window.end = end;
-		return window;
+	const end = parseISODate(params.statement_end_date);
+
+	if (end) {
+		return { end };
 	}
 
 	if (analysisDateRange?.includes(" to ")) {
@@ -941,12 +934,12 @@ export async function executeReconciliation(
 
 	// STEP 5: Balance reconciliation snapshot (only once per execution)
 	let balance_reconciliation: ExecutionResult["balance_reconciliation"];
-	if (params.statement_balance !== undefined && params.statement_date) {
+	if (params.statement_balance !== undefined && params.statement_end_date) {
 		balance_reconciliation = await buildBalanceReconciliation({
 			ynabAPI,
 			budgetId,
 			accountId,
-			statementDate: params.statement_date,
+			statementDate: params.statement_end_date,
 			statementBalanceMilli: statementTargetMilli,
 			analysis,
 		});