@dizzlkheinz/ynab-mcpb 0.18.2 → 0.18.3

package/dist/tools/transactionTools.js

@@ -749,20 +749,31 @@ export async function handleCreateTransaction(ynabAPI, deltaCacheOrParams, knowl
         return handleTransactionError(error, 'Failed to create transaction');
     }
 }
+const BIG_TICKET_THRESHOLD_MILLIUNITS = 50000;
+const COLLAPSE_THRESHOLD = 5;
+const MAX_ITEMS_PER_MEMO = 5;
+const MAX_MEMO_LENGTH = 150;
+function truncateToLength(str, maxLength) {
+    if (str.length <= maxLength) {
+        return str;
+    }
+    const ellipsis = '...';
+    return str.substring(0, maxLength - ellipsis.length) + ellipsis;
+}
 function buildItemMemo(item) {
     const quantitySuffix = item.quantity ? ` (x${item.quantity})` : '';
+    let result;
     if (item.memo && item.memo.trim().length > 0) {
-        return `${item.name}${quantitySuffix} - ${item.memo}`;
+        result = `${item.name}${quantitySuffix} - ${item.memo}`;
     }
-    if (quantitySuffix) {
-        return `${item.name}${quantitySuffix}`;
+    else if (quantitySuffix) {
+        result = `${item.name}${quantitySuffix}`;
+    }
+    else {
+        result = item.name;
     }
-    return item.name;
+    return truncateToLength(result, MAX_MEMO_LENGTH);
 }
-const BIG_TICKET_THRESHOLD_MILLIUNITS = 50000;
-const COLLAPSE_THRESHOLD = 5;
-const MAX_ITEMS_PER_MEMO = 5;
-const MAX_MEMO_LENGTH = 150;
 function applySmartCollapseLogic(categoryCalculations, taxMilliunits) {
     const specialItems = [];
     const remainingItemsByCategory = [];
@@ -891,6 +902,14 @@ function collapseItemsByCategory(categoryGroup) {
     }
     return subtransactions;
 }
+function truncateItemName(name, amountSuffix, maxLength) {
+    const ellipsis = '...';
+    const availableForName = maxLength - ellipsis.length - amountSuffix.length;
+    if (availableForName <= 0) {
+        return amountSuffix.substring(0, maxLength);
+    }
+    return name.substring(0, availableForName) + ellipsis + amountSuffix;
+}
 function buildCollapsedMemo(items) {
     const parts = [];
     let currentLength = 0;
@@ -899,8 +918,12 @@ function buildCollapsedMemo(items) {
         if (!item)
             continue;
         const amount = milliunitsToAmount(item.amount_milliunits);
-        const itemStr = `${item.name} $${amount.toFixed(2)}`;
+        const amountSuffix = ` $${amount.toFixed(2)}`;
+        let itemStr = `${item.name}${amountSuffix}`;
         const separator = i > 0 ? ', ' : '';
+        if (parts.length === 0 && itemStr.length > MAX_MEMO_LENGTH) {
+            itemStr = truncateItemName(item.name, amountSuffix, MAX_MEMO_LENGTH);
+        }
         const testLength = currentLength + separator.length + itemStr.length;
         if (parts.length > 0 && testLength + 4 > MAX_MEMO_LENGTH) {
             break;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dizzlkheinz/ynab-mcpb",
-  "version": "0.18.2",
+  "version": "0.18.3",
   "description": "Model Context Protocol server for YNAB (You Need A Budget) integration",
   "main": "dist/index.js",
   "type": "module",

package/src/tools/__tests__/transactionTools.test.ts

@@ -2107,6 +2107,89 @@ describe('transactionTools', () => {
           expect(collapsedSub.memo).toContain('Cheap Item');
           expect(collapsedSub.amount).toBe(25); // dry_run returns dollars
         });
+
+        it('should truncate single very long item name in itemized mode', async () => {
+          // Create a name that's way longer than 150 chars
+          const veryLongName = 'A'.repeat(200);
+          const params = {
+            budget_id: 'budget-123',
+            account_id: 'account-456',
+            payee_name: 'Store',
+            date: '2025-10-13',
+            receipt_tax: 1.0,
+            receipt_total: 11.0,
+            categories: [
+              {
+                category_id: 'category-groceries',
+                category_name: 'Groceries',
+                items: [{ name: veryLongName, amount: 10.0 }],
+              },
+            ],
+            receipt_subtotal: 10.0,
+            dry_run: true,
+          } as const;
+
+          const result = await handleCreateReceiptSplitTransaction(mockYnabAPI, params);
+          const parsed = JSON.parse(result.content[0].text);
+
+          // Should have 2 subtransactions: 1 itemized + 1 tax
+          // (only 1 item, so no collapse, but name gets truncated)
+          expect(parsed.subtransactions).toHaveLength(2);
+
+          const itemMemo = parsed.subtransactions[0].memo;
+          // Memo should be truncated to exactly 150 chars
+          expect(itemMemo.length).toBeLessThanOrEqual(150);
+          // Should contain truncation indicator
+          expect(itemMemo).toContain('...');
+          // Should start with part of the original name
+          expect(itemMemo.startsWith('AAA')).toBe(true);
+        });
+
+        it('should truncate very long item name in collapsed mode while preserving amount', async () => {
+          // Create a name that's way longer than 150 chars
+          const veryLongName = 'B'.repeat(200);
+          const params = {
+            budget_id: 'budget-123',
+            account_id: 'account-456',
+            payee_name: 'Store',
+            date: '2025-10-13',
+            receipt_tax: 1.0,
+            receipt_total: 61.0,
+            categories: [
+              {
+                category_id: 'category-groceries',
+                category_name: 'Groceries',
+                items: [
+                  { name: veryLongName, amount: 10.0 }, // This one has very long name
+                  { name: 'Item2', amount: 10.0 },
+                  { name: 'Item3', amount: 10.0 },
+                  { name: 'Item4', amount: 10.0 },
+                  { name: 'Item5', amount: 10.0 },
+                  { name: 'Item6', amount: 10.0 },
+                ],
+              },
+            ],
+            receipt_subtotal: 60.0,
+            dry_run: true,
+          } as const;
+
+          const result = await handleCreateReceiptSplitTransaction(mockYnabAPI, params);
+          const parsed = JSON.parse(result.content[0].text);
+
+          // 6 items -> collapse mode, long item first creates its own subtransaction
+          // that gets truncated
+          expect(parsed.subtransactions.length).toBeGreaterThanOrEqual(2);
+
+          // First subtransaction should be the truncated long item
+          const firstMemo = parsed.subtransactions[0].memo;
+          expect(firstMemo.length).toBeLessThanOrEqual(150);
+          // In collapsed mode, should preserve the amount
+          expect(firstMemo).toContain('$10.00');
+          // Should contain truncation indicator
+          expect(firstMemo).toContain('...');
+          // Should start with part of the original name
+          expect(firstMemo.startsWith('BBB')).toBe(true);
+        });
       });
     });
   });

package/src/tools/transactionTools.ts

@@ -1112,29 +1112,43 @@ interface SubtransactionInput {
   memo?: string;
 }
 
+/**
+ * Constants for smart collapse logic
+ */
+const BIG_TICKET_THRESHOLD_MILLIUNITS = 50000; // $50.00
+const COLLAPSE_THRESHOLD = 5; // Collapse if 5 or more remaining items
+const MAX_ITEMS_PER_MEMO = 5;
+const MAX_MEMO_LENGTH = 150;
+
+/**
+ * Truncates a string to fit within maxLength, adding ellipsis if truncated
+ */
+function truncateToLength(str: string, maxLength: number): string {
+  if (str.length <= maxLength) {
+    return str;
+  }
+  const ellipsis = '...';
+  return str.substring(0, maxLength - ellipsis.length) + ellipsis;
+}
+
 function buildItemMemo(item: {
   name: string;
   quantity: number | undefined;
   memo: string | undefined;
 }): string | undefined {
   const quantitySuffix = item.quantity ? ` (x${item.quantity})` : '';
+  let result: string;
   if (item.memo && item.memo.trim().length > 0) {
-    return `${item.name}${quantitySuffix} - ${item.memo}`;
-  }
-  if (quantitySuffix) {
-    return `${item.name}${quantitySuffix}`;
+    result = `${item.name}${quantitySuffix} - ${item.memo}`;
+  } else if (quantitySuffix) {
+    result = `${item.name}${quantitySuffix}`;
+  } else {
+    result = item.name;
   }
-  return item.name;
+  // Truncate to MAX_MEMO_LENGTH if needed
+  return truncateToLength(result, MAX_MEMO_LENGTH);
 }
 
-/**
- * Constants for smart collapse logic
- */
-const BIG_TICKET_THRESHOLD_MILLIUNITS = 50000; // $50.00
-const COLLAPSE_THRESHOLD = 5; // Collapse if 5 or more remaining items
-const MAX_ITEMS_PER_MEMO = 5;
-const MAX_MEMO_LENGTH = 150;
-
 /**
  * Applies smart collapse logic to receipt items according to the specification:
  * 1. Extract special items (big ticket, returns, discounts)
@@ -1327,10 +1341,27 @@ function collapseItemsByCategory(categoryGroup: {
   return subtransactions;
 }
 
+/**
+ * Truncates an item name to fit within available space
+ * Preserves the amount suffix and adds "..." to indicate truncation
+ */
+function truncateItemName(name: string, amountSuffix: string, maxLength: number): string {
+  const ellipsis = '...';
+  // We need: truncatedName + ellipsis + amountSuffix <= maxLength
+  const availableForName = maxLength - ellipsis.length - amountSuffix.length;
+
+  if (availableForName <= 0) {
+    // Edge case: amount suffix alone is too long, just return what we can
+    return amountSuffix.substring(0, maxLength);
+  }
+
+  return name.substring(0, availableForName) + ellipsis + amountSuffix;
+}
+
 /**
  * Builds a collapsed memo from a list of items
  * Format: "Item1 $X.XX, Item2 $Y.YY, Item3 $Z.ZZ"
- * Truncates with "..." if needed
+ * Truncates with "..." if needed (either individual items or the list)
  */
 function buildCollapsedMemo(items: ReceiptCategoryCalculation['items'][0][]): string {
   const parts: string[] = [];
@@ -1340,8 +1371,15 @@ function buildCollapsedMemo(items: ReceiptCategoryCalculation['items'][0][]): st
     const item = items[i];
     if (!item) continue;
     const amount = milliunitsToAmount(item.amount_milliunits);
-    const itemStr = `${item.name} $${amount.toFixed(2)}`;
+    const amountSuffix = ` $${amount.toFixed(2)}`;
+    let itemStr = `${item.name}${amountSuffix}`;
     const separator = i > 0 ? ', ' : '';
+
+    // For the first item, check if it alone exceeds the limit
+    if (parts.length === 0 && itemStr.length > MAX_MEMO_LENGTH) {
+      itemStr = truncateItemName(item.name, amountSuffix, MAX_MEMO_LENGTH);
+    }
+
     const testLength = currentLength + separator.length + itemStr.length;
 
     // Check if adding this item would exceed limit