@dizzlkheinz/ynab-mcpb 0.18.0 → 0.18.1

package/dist/tools/reconciliation/executor.js

@@ -1,4 +1,3 @@
-import { createHash } from 'crypto';
 import { YNABAPIError } from '../../server/errorHandler.js';
 import { toMilli, toMoneyValue, addMilli } from '../../utils/money.js';
 import { generateCorrelationKey, correlateResults, toCorrelationPayload, } from '../transactionTools.js';
@@ -29,12 +28,6 @@ function truncateMemo(memo) {
         return memo;
     return memo.substring(0, MAX_MEMO_LENGTH - 3) + '...';
 }
-function generateBulkImportId(accountId, date, amountMilli, payee) {
-    const normalizedPayee = (payee ?? '').trim().toLowerCase();
-    const raw = `${accountId}|${date}|${amountMilli}|${normalizedPayee}`;
-    const digest = createHash('sha256').update(raw).digest('hex').slice(0, 24);
-    return `YNAB:bulk:${digest}`;
-}
 function parseISODate(dateStr) {
     if (!dateStr)
         return undefined;
@@ -160,7 +153,6 @@ export async function executeReconciliation(options) {
                 memo: truncateMemo(bankTxn.memo),
                 cleared: 'cleared',
                 approved: true,
-                import_id: generateBulkImportId(accountId, bankTxn.date, amountMilli, bankTxn.payee),
             };
             const correlationKey = generateCorrelationKey(toCorrelationPayload(saveTransaction));
             return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dizzlkheinz/ynab-mcpb",
-  "version": "0.18.0",
+  "version": "0.18.1",
   "description": "Model Context Protocol server for YNAB (You Need A Budget) integration",
   "main": "dist/index.js",
   "type": "module",

package/src/tools/reconciliation/__tests__/executor.integration.test.ts

@@ -78,9 +78,12 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
   );
 
   it(
-    'reports duplicates when import IDs already exist',
+    'creates transactions without import_id to allow bank matching',
     { meta: { tier: 'domain', domain: 'reconciliation' } },
     async function () {
+      // Note: import_id is intentionally omitted from reconciliation-created transactions
+      // so they can match with bank-imported transactions. YNAB-side duplicate detection
+      // is no longer used; the reconciliation matcher handles duplicate prevention.
       const analysis = buildIntegrationAnalysis(accountSnapshot, 2, 9);
       const params = buildIntegrationParams(
         accountId,
@@ -88,23 +91,7 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
         analysis.summary.target_statement_balance,
       );
 
-      const firstRun = await skipOnRateLimit(
-        () =>
-          executeReconciliation({
-            ynabAPI,
-            analysis,
-            params,
-            budgetId,
-            accountId,
-            initialAccount: accountSnapshot,
-            currencyCode: 'USD',
-          }),
-        this,
-      );
-      if (!firstRun) return;
-      trackCreatedTransactions(firstRun);
-
-      const duplicateAttempt = await skipOnRateLimit(
+      const result = await skipOnRateLimit(
         () =>
           executeReconciliation({
             ynabAPI,
@@ -117,15 +104,14 @@ describeIntegration('Reconciliation Executor - Bulk Create Integration', () => {
           }),
         this,
       );
-      if (!duplicateAttempt) return;
-      if (containsRateLimitFailure(duplicateAttempt)) return;
+      if (!result) return;
+      trackCreatedTransactions(result);
+      if (containsRateLimitFailure(result)) return;
 
-      const duplicateActions = duplicateAttempt.actions_taken.filter(
-        (action) => action.duplicate === true,
-      );
-      expect(duplicateActions.length).toBeGreaterThan(0);
-      expect(duplicateAttempt.bulk_operation_details?.duplicates_detected).toBeGreaterThan(0);
-      expect(duplicateAttempt.summary.transactions_created).toBe(0);
+      // Verify transactions were created successfully
+      expect(result.summary.transactions_created).toBe(2);
+      // Verify no YNAB-side duplicate detection occurred (because no import_id)
+      expect(result.bulk_operation_details?.duplicates_detected).toBe(0);
     },
     60000,
   );

package/src/tools/reconciliation/__tests__/executor.test.ts

@@ -484,9 +484,10 @@ describe('executeReconciliation - bulk create mode', () => {
         account_id: txn.account_id,
         amount: txn.amount,
         date: txn.date,
+        payee_name: txn.payee_name,
+        memo: txn.memo,
         cleared: 'cleared',
         approved: true,
-        import_id: txn.import_id, // Include import_id for correlation
       }));
       return { data: { transactions, duplicate_import_ids: [] } };
     });
@@ -638,11 +639,12 @@ describe('executeReconciliation - bulk create mode', () => {
         account_id: txn.account_id,
         amount: txn.amount,
         date: txn.date,
+        payee_name: txn.payee_name,
+        memo: txn.memo,
         cleared: 'cleared',
         approved: true,
-        import_id: txn.import_id, // Include import_id for correlation
       }));
-      return { data: { transactions } };
+      return { data: { transactions, duplicate_import_ids: [] } };
     });
 
     const result = await executeReconciliation({
@@ -690,33 +692,35 @@ describe('executeReconciliation - bulk create mode', () => {
     ).rejects.toMatchObject({ status: 404 });
   });
 
-  it('flags duplicate transactions returned by YNAB API', async () => {
-    const analysis = buildBulkAnalysis(3, 7);
+  it('creates all transactions without import_id (no YNAB-side duplicate detection)', async () => {
+    // Note: import_id is intentionally omitted from reconciliation-created transactions
+    // so they can match with bank-imported transactions. This means YNAB won't detect
+    // duplicates via import_id - the reconciliation matcher is responsible for that.
+    // Use amount of 100 to avoid early balance halting (tolerance is 10 milliunits)
+    const analysis = buildBulkAnalysis(3, 100);
     const params = buildBulkParams(analysis.summary.target_statement_balance);
     const initialAccount = { ...defaultAccountSnapshot };
     const { api, mocks } = createMockYnabAPI(initialAccount);
 
     mocks.createTransactions.mockImplementation(async (_budgetId, body: any) => {
-      const transactions = (body.transactions ?? []).map((txn: any, index: number) => {
-        if (index === 1) {
-          return undefined;
-        }
-        return {
-          id: `created-${index}`,
-          account_id: txn.account_id,
-          amount: txn.amount,
-          date: txn.date,
-          cleared: 'cleared',
-          approved: true,
-          import_id: txn.import_id, // Include import_id for correlation
-        };
-      });
-      const filtered = transactions.filter(Boolean);
-      const duplicateImportId = body.transactions?.[1]?.import_id;
+      const transactions = (body.transactions ?? []).map((txn: any, index: number) => ({
+        id: `created-${index}`,
+        account_id: txn.account_id,
+        amount: txn.amount,
+        date: txn.date,
+        payee_name: txn.payee_name,
+        memo: txn.memo,
+        cleared: 'cleared',
+        approved: true,
+      }));
+      // Verify no import_id is being sent
+      for (const txn of body.transactions ?? []) {
+        expect(txn.import_id).toBeUndefined();
+      }
       return {
         data: {
-          transactions: filtered,
-          duplicate_import_ids: duplicateImportId ? [duplicateImportId] : [],
+          transactions,
+          duplicate_import_ids: [],
         },
       };
     });
@@ -731,10 +735,9 @@ describe('executeReconciliation - bulk create mode', () => {
       currencyCode: 'USD',
     });
 
-    const duplicateActions = result.actions_taken.filter((action) => action.duplicate === true);
-    expect(duplicateActions).toHaveLength(1);
-    expect(result.bulk_operation_details?.duplicates_detected).toBe(1);
-    expect(result.summary.transactions_created).toBe(2);
+    // Without import_id, YNAB creates all transactions (no duplicate detection)
+    expect(result.bulk_operation_details?.duplicates_detected).toBe(0);
+    expect(result.summary.transactions_created).toBe(3);
   });
 
   it('honors halting logic when balance aligns mid-batch', async () => {
@@ -749,11 +752,12 @@ describe('executeReconciliation - bulk create mode', () => {
         account_id: txn.account_id,
         amount: txn.amount,
         date: txn.date,
+        payee_name: txn.payee_name,
+        memo: txn.memo,
         cleared: 'cleared',
         approved: true,
-        import_id: txn.import_id, // Include import_id for correlation
       }));
-      return { data: { transactions } };
+      return { data: { transactions, duplicate_import_ids: [] } };
     });
 
     const result = await executeReconciliation({
@@ -794,11 +798,12 @@ describe('executeReconciliation - bulk create mode', () => {
         account_id: txn.account_id,
         amount: txn.amount,
         date: txn.date,
+        payee_name: txn.payee_name,
+        memo: txn.memo,
         cleared: 'cleared',
         approved: true,
-        import_id: txn.import_id,
       }));
-      return { data: { transactions } };
+      return { data: { transactions, duplicate_import_ids: [] } };
     });
 
     const result = await executeReconciliation({

package/src/tools/reconciliation/executor.ts

@@ -1,4 +1,3 @@
-import { createHash } from 'crypto';
 import type * as ynab from 'ynab';
 import type { SaveTransaction } from 'ynab/dist/models/SaveTransaction.js';
 import { YNABAPIError, YNABErrorCode } from '../../server/errorHandler.js';
@@ -131,30 +130,6 @@ interface PreparedBulkCreateEntry {
   correlationKey: string;
 }
 
-/**
- * Generates a deterministic import_id for reconciliation-created transactions.
- *
- * Uses a dedicated `YNAB:bulk:` prefix to distinguish reconciliation-created transactions
- * from manual bulk creates. This namespace separation is intentional:
- * - Reconciliation operations are automated and system-generated
- * - Manual bulk creates via create_transactions tool can use custom import_id formats
- * - Both interact with YNAB's global duplicate detection via the same import_id mechanism
- *
- * The hash-based correlation in transactionTools.ts uses `hash:` prefix for correlation
- * (when no import_id provided), which is separate from this import_id generation.
- */
-function generateBulkImportId(
-  accountId: string,
-  date: string,
-  amountMilli: number,
-  payee?: string | null,
-): string {
-  const normalizedPayee = (payee ?? '').trim().toLowerCase();
-  const raw = `${accountId}|${date}|${amountMilli}|${normalizedPayee}`;
-  const digest = createHash('sha256').update(raw).digest('hex').slice(0, 24);
-  return `YNAB:bulk:${digest}`;
-}
-
 function parseISODate(dateStr: string | undefined): Date | undefined {
   if (!dateStr) return undefined;
   const d = new Date(dateStr);
@@ -313,7 +288,7 @@ export async function executeReconciliation(options: ExecutionOptions): Promise<
         memo: truncateMemo(bankTxn.memo),
         cleared: 'cleared',
         approved: true,
-        import_id: generateBulkImportId(accountId, bankTxn.date, amountMilli, bankTxn.payee),
+        // Note: import_id intentionally omitted so transactions can match with bank imports
       };
       const correlationKey = generateCorrelationKey(toCorrelationPayload(saveTransaction));
       return {