@dizzlkheinz/ynab-mcpb 0.16.1 → 0.17.1

package/src/tools/utilityTools.ts

@@ -1,20 +1,11 @@
 import { CallToolResult } from '@modelcontextprotocol/sdk/types.js';
 import * as ynab from 'ynab';
-import { z } from 'zod/v4';
-import { withToolErrorHandling } from '../types/index.js';
 import { responseFormatter } from '../server/responseFormatter.js';
-
-/**
- * Schema for ynab:convert_amount tool parameters
- */
-export const ConvertAmountSchema = z
-  .object({
-    amount: z.number().finite(),
-    to_milliunits: z.boolean(),
-  })
-  .strict();
-
-export type ConvertAmountParams = z.infer<typeof ConvertAmountSchema>;
+import { withToolErrorHandling } from '../types/index.js';
+import { createAdapters } from './adapters.js';
+import { emptyObjectSchema } from './schemas/common.js';
+import { ToolAnnotationPresets } from './toolCategories.js';
+import type { ToolFactory } from '../types/toolRegistration.js';
 
 /**
  * Handles the ynab:get_user tool call
@@ -45,46 +36,24 @@ export async function handleGetUser(ynabAPI: ynab.API): Promise<CallToolResult>
 }
 
 /**
- * Handles the ynab:convert_amount tool call
- * Converts between dollars and milliunits with integer arithmetic for precision
+ * Registers utility tools (get_user) using the shared factory pattern.
+ *
+ * Note: convert_amount was removed because all tool responses already return
+ * amounts in dollars (converted from YNAB milliunits internally).
  */
-export async function handleConvertAmount(params: ConvertAmountParams): Promise<CallToolResult> {
-  return await withToolErrorHandling(
-    async () => {
-      const { amount, to_milliunits } = params;
-
-      let result: number;
-      let description: string;
-
-      if (to_milliunits) {
-        // Convert from dollars to milliunits
-        // Use integer arithmetic to avoid floating-point precision issues
-        result = Math.round(amount * 1000);
-        description = `$${amount.toFixed(2)} = ${result} milliunits`;
-      } else {
-        // Convert from milliunits to dollars
-        // Assume input amount is in milliunits
-        result = amount / 1000;
-        description = `${amount} milliunits = $${result.toFixed(2)}`;
-      }
-
-      return {
-        content: [
-          {
-            type: 'text',
-            text: responseFormatter.format({
-              conversion: {
-                original_amount: amount,
-                converted_amount: result,
-                to_milliunits,
-                description,
-              },
-            }),
-          },
-        ],
-      };
+export const registerUtilityTools: ToolFactory = (registry, context) => {
+  const { adaptNoInput } = createAdapters(context);
+
+  registry.register({
+    name: 'get_user',
+    description: 'Get information about the authenticated user',
+    inputSchema: emptyObjectSchema,
+    handler: adaptNoInput(handleGetUser),
+    metadata: {
+      annotations: {
+        ...ToolAnnotationPresets.READ_ONLY_EXTERNAL,
+        title: 'YNAB: Get User Information',
+      },
     },
-    'ynab:convert_amount',
-    'converting amount',
-  );
-}
+  });
+};

package/src/types/index.ts

@@ -65,3 +65,6 @@ export type { MCPToolAnnotations } from './toolAnnotations.js';
 
 // Re-export tool registry types for convenience
 export type { ToolDefinition } from '../server/toolRegistry.js';
+
+// Re-export tool registration factory types
+export type { ToolContext, ToolFactory, BudgetIdResolverFactory } from './toolRegistration.js';

package/src/types/toolRegistration.ts

@@ -0,0 +1,88 @@
+/**
+ * @fileoverview Type definitions for the tool factory registration pattern.
+ * Provides ToolContext for dependency injection and typed handler signatures
+ * used by domain-specific tool factory functions.
+ * @module types/toolRegistration
+ */
+
+import type { CallToolResult } from '@modelcontextprotocol/sdk/types.js';
+import * as ynab from 'ynab';
+import type {
+  ToolRegistry,
+  ToolExecutionPayload,
+  DefaultArgumentResolver,
+} from '../server/toolRegistry.js';
+import type { DeltaFetcher } from '../tools/deltaFetcher.js';
+import type { DeltaCache } from '../server/deltaCache.js';
+import type { ServerKnowledgeStore } from '../server/serverKnowledgeStore.js';
+import type { DiagnosticManager } from '../server/diagnostics.js';
+import type { CacheManager } from '../server/cacheManager.js';
+
+/**
+ * Context object passed to tool factory functions. Contains the dependencies
+ * required by tool adapters and handlers.
+ *
+ * @stable This interface is part of the public tool registration contract.
+ * Changes to this interface may affect all domain tool factories.
+ */
+export interface ToolContext {
+  ynabAPI: ynab.API;
+  deltaFetcher: DeltaFetcher;
+  deltaCache: DeltaCache;
+  serverKnowledgeStore: ServerKnowledgeStore;
+  getDefaultBudgetId: () => string | undefined;
+  setDefaultBudget: (budgetId: string) => void;
+  cacheManager: CacheManager;
+  diagnosticManager?: DiagnosticManager;
+}
+
+/**
+ * Factory function signature for registering a domain's tools.
+ */
+export type ToolFactory = (registry: ToolRegistry, context: ToolContext) => void;
+
+/**
+ * Common adapter signature used within tool factories.
+ */
+export type Adapter<TInput extends Record<string, unknown>> = (
+  payload: ToolExecutionPayload<TInput>,
+) => Promise<CallToolResult>;
+
+/**
+ * Generic handler signature used by adapter helpers.
+ */
+export type Handler<TInput extends Record<string, unknown>> = (
+  api: ynab.API,
+  params: TInput,
+) => Promise<CallToolResult>;
+
+/**
+ * Handler signature for operations that require delta fetching.
+ */
+export type DeltaHandler<TInput extends Record<string, unknown>> = (
+  api: ynab.API,
+  deltaFetcher: DeltaFetcher,
+  params: TInput,
+) => Promise<CallToolResult>;
+
+/**
+ * Handler signature for write operations that update caches and knowledge stores.
+ */
+export type WriteHandler<TInput extends Record<string, unknown>> = (
+  api: ynab.API,
+  deltaCache: DeltaCache,
+  serverKnowledgeStore: ServerKnowledgeStore,
+  params: TInput,
+) => Promise<CallToolResult>;
+
+/**
+ * Handler signature for tools that do not accept input parameters.
+ */
+export type NoInputHandler = (api: ynab.API) => Promise<CallToolResult>;
+
+/**
+ * Helper type for default argument resolver factories.
+ */
+export type BudgetIdResolverFactory = <
+  TInput extends { budget_id?: string | undefined },
+>() => DefaultArgumentResolver<TInput>;

package/vitest.config.ts

@@ -1,6 +1,7 @@
 import { defineConfig } from 'vitest/config';
 
 const integrationFiles = ['src/**/*.integration.test.ts'];
+const isVerbose = !!process.env['VERBOSE_TESTS'];
 
 export default defineConfig({
   test: {
@@ -83,7 +84,7 @@ export default defineConfig({
         },
       },
     },
-    reporters: ['verbose', 'html', './vitest-reporters/split-json-reporter.ts'],
+    reporters: [isVerbose ? 'verbose' : 'dot', 'html', './vitest-reporters/split-json-reporter.ts'],
     outputFile: {
       html: './test-results/index.html',
     },

package/.chunkhound.json

@@ -1,11 +0,0 @@
-{
-  "embedding": {
-    "provider": "voyageai",
-    "model": "voyage-3.5",
-    "api_key": "pa-Q1WewxKAEUA6QeYTmreQmY11ufEk9mKIK0DfoqqZhV6",
-    "rerank_model": "rerank-2.5"
-  },
-  "llm": {
-    "provider": "claude-code-cli"
-  }
-}

package/.code/agents/01a13ef4-3f23-4f52-b33b-3585b73cfa60/error.txt

@@ -1,3 +0,0 @@
-Command failed: Error loading configuration: config profile `From the repo root, list top-level files and directories using ls or dir, then exit. No file writes or edits.
-
-[Running in read-only mode - no modifications allowed]` not found

package/.code/agents/084fd32f-e298-4728-9103-a78d7dc39613/error.txt

@@ -1,3 +0,0 @@
-Command failed: Error loading configuration: config profile `From the repo root, just run `pwd` and then exit. Do not modify any files.
-
-[Running in read-only mode - no modifications allowed]` not found

package/.code/agents/0fed51e1-a943-4b97-a2a8-a6f0f27c844d/status.txt

@@ -1 +0,0 @@
-Agent cancelled

package/.code/agents/1059b6bd-5ccd-4d83-a12c-7c9d89137399/error.txt

@@ -1,5 +0,0 @@
-Command failed: ParserError: 
-Line |
-   5 |  [Running in read-only mode - no modifications allowed]
-     |          ~
-     | Missing ] at end of attribute or type literal.