@dizzlkheinz/ynab-mcpb 0.16.0 → 0.17.0

package/.code/agents/335aa031-466d-4fb7-925f-3cd864e264d0/result.txt

@@ -0,0 +1,191 @@
+I now have comprehensive information about the tool registrations. Let me compile the report:
+
+## MCP Tool Registration Catalogue Report
+
+### Summary Statistics
+- **Total Tools:** 30
+- **Domain Groups:** 8 (Budget, Account, Transaction, Category, Payee, Month, Reconciliation, Utility)
+- **Adapter Types:** 4 (adapt, adaptWithDelta, adaptWrite, adaptNoInput/custom)
+
+---
+
+### Complete Tool Registry
+
+| # | Tool Name | Domain | Adapter Type | Input Schema Location | Output Schema | Migrate? |
+|---|-----------|--------|--------------|----------------------|---------------|----------|
+| 1 | `list_budgets` | Budget | delta | inline (empty) | ✅ | No |
+| 2 | `get_budget` | Budget | read-only | `budgetTools.ts` | ✅ | ⚠️ Yes |
+| 3 | `set_default_budget` | Budget | custom (server) | inline | ✅ | No |
+| 4 | `get_default_budget` | Budget | custom (server) | inline (empty) | ✅ | No |
+| 5 | `list_accounts` | Account | delta | `accountTools.ts` | ✅ | ⚠️ Yes |
+| 6 | `get_account` | Account | read-only | `accountTools.ts` | ✅ | ⚠️ Yes |
+| 7 | `create_account` | Account | write | `accountTools.ts` | Loose | ⚠️ Yes |
+| 8 | `list_transactions` | Transaction | delta | `transactionTools.ts` | Loose | ⚠️ Yes |
+| 9 | `get_transaction` | Transaction | read-only | `transactionTools.ts` | ✅ | ⚠️ Yes |
+| 10 | `create_transaction` | Transaction | write | `transactionTools.ts` | Loose | ⚠️ Yes |
+| 11 | `create_transactions` | Transaction | write | `transactionTools.ts` | Loose | ⚠️ Yes |
+| 12 | `update_transaction` | Transaction | write | `transactionTools.ts` | Loose | ⚠️ Yes |
+| 13 | `update_transactions` | Transaction | write | `transactionTools.ts` | Loose | ⚠️ Yes |
+| 14 | `delete_transaction` | Transaction | write | `transactionTools.ts` | Loose | ⚠️ Yes |
+| 15 | `create_receipt_split_transaction` | Transaction | write | `transactionTools.ts` | Loose | ⚠️ Yes |
+| 16 | `export_transactions` | Transaction | read-only | `exportTransactions.ts` | ✅ | ⚠️ Yes |
+| 17 | `compare_transactions` | Transaction | read-only | `compareTransactions/index.ts` | ✅ | ⚠️ Yes |
+| 18 | `reconcile_account` | Reconciliation | delta | `reconciliation/index.ts` | Loose | ⚠️ Yes |
+| 19 | `list_categories` | Category | delta | `categoryTools.ts` | ✅ | ⚠️ Yes |
+| 20 | `get_category` | Category | read-only | `categoryTools.ts` | ✅ | ⚠️ Yes |
+| 21 | `update_category` | Category | write | `categoryTools.ts` | Loose | ⚠️ Yes |
+| 22 | `list_payees` | Payee | delta | `payeeTools.ts` | ✅ | ⚠️ Yes |
+| 23 | `get_payee` | Payee | read-only | `payeeTools.ts` | ✅ | ⚠️ Yes |
+| 24 | `get_month` | Month | read-only | `monthTools.ts` | ✅ | ⚠️ Yes |
+| 25 | `list_months` | Month | delta | `monthTools.ts` | ✅ | ⚠️ Yes |
+| 26 | `get_user` | Utility | no-input | inline (empty) | ✅ | No |
+| 27 | `convert_amount` | Utility | custom | `utilityTools.ts` | ✅ | ⚠️ Yes |
+| 28 | `diagnostic_info` | Utility | custom (server) | inline | ✅ | No |
+| 29 | `clear_cache` | Utility | custom (server) | inline (empty) | ✅ | No |
+| 30 | `set_output_format` | Utility | custom (server) | inline | ✅ | No |
+
+---
+
+### Adapter Type Breakdown
+
+| Adapter | Tools | Description |
+|---------|-------|-------------|
+| **`adapt`** (read-only) | 8 | Standard adapter for read operations without delta support |
+| **`adaptWithDelta`** (delta) | 7 | Delta caching with server knowledge tracking |
+| **`adaptWrite`** (write) | 8 | Write operations with cache invalidation |
+| **`adaptNoInput`** (no-input) | 1 | Tools with empty input schema |
+| **custom (server)** | 6 | Server-owned tools with inline handlers |
+
+---
+
+### Inline Schemas in `YNABMCPServer.ts` (Server-owned - KEEP INLINE)
+
+These schemas are intentionally inline because they:
+1. Are simple utility schemas used only by server-owned tools
+2. Tightly coupled to server configuration logic
+3. Have no need for reuse in external contexts
+
+| Schema | Tool | Rationale |
+|--------|------|-----------|
+| `emptyObjectSchema` | `list_budgets`, `get_default_budget`, `clear_cache`, `get_user` | Generic empty schema, no domain logic |
+| `setDefaultBudgetSchema` | `set_default_budget` | Server state management |
+| `diagnosticInfoSchema` | `diagnostic_info` | Server internals exposure |
+| `setOutputFormatSchema` | `set_output_format` | Server response configuration |
+| `LooseObjectSchema` | 10 mutation tools | Permissive output passthrough |
+
+---
+
+### Schemas Recommended for Migration
+
+**Target location:** `src/tools/schemas/inputs/` (mirroring existing `outputs/` structure)
+
+#### High Priority - Complex Schemas with Shared Patterns
+
+| Schema | Current Location | Complexity | Shared Patterns |
+|--------|-----------------|------------|-----------------|
+| `CreateTransactionSchema` | transactionTools.ts:169-211 | High (superRefine, nested subtransactions) | `date`, `cleared`, `flag_color`, `amount` |
+| `UpdateTransactionSchema` | transactionTools.ts:621-640 | Medium | Same as above |
+| `CreateTransactionsSchema` | transactionTools.ts:238-248 | High (bulk, nested) | Reuses `BulkTransactionInputSchema` |
+| `UpdateTransactionsSchema` | transactionTools.ts:677-687 | High (bulk) | Reuses `BulkUpdateTransactionInputSchema` |
+| `CreateReceiptSplitTransactionSchema` | transactionTools.ts:555-612 | Very High (nested, superRefine) | `date`, `cleared`, `flag_color` |
+| `ReconcileAccountSchema` | reconciliation/index.ts:71-132 | Very High (many optional params) | `csv_format`, matching config |
+| `CompareTransactionsSchema` | compareTransactions/index.ts:16-56 | High (nested csv_format) | `csv_format` |
+
+#### Medium Priority - Domain Entity Schemas
+
+| Schema | Current Location | Rationale |
+|--------|-----------------|-----------|
+| `GetBudgetSchema` | budgetTools.ts:12-16 | Simple but follows pattern |
+| `ListAccountsSchema` | accountTools.ts:17-22 | Simple with `limit` |
+| `GetAccountSchema` | accountTools.ts:29-34 | Standard get pattern |
+| `CreateAccountSchema` | accountTools.ts:41-57 | Enum types reusable |
+| `ListTransactionsSchema` | transactionTools.ts:139-151 | Filter params |
+| `GetTransactionSchema` | transactionTools.ts:157-163 | Standard get pattern |
+| `DeleteTransactionSchema` | transactionTools.ts:716-722 | Standard delete pattern |
+| `ListCategoriesSchema` | categoryTools.ts:17-21 | Simple budget_id |
+| `GetCategorySchema` | categoryTools.ts:28-33 | Standard get pattern |
+| `UpdateCategorySchema` | categoryTools.ts:40-47 | Milliunits amount |
+| `ListPayeesSchema` | payeeTools.ts:14-19 | Simple with `limit` |
+| `GetPayeeSchema` | payeeTools.ts:26-31 | Standard get pattern |
+| `GetMonthSchema` | monthTools.ts:15-20 | Date format regex |
+| `ListMonthsSchema` | monthTools.ts:27-31 | Simple budget_id |
+| `ExportTransactionsSchema` | exportTransactions.ts:14-27 | Filter params |
+
+#### Low Priority - Utility Schemas
+
+| Schema | Current Location | Rationale |
+|--------|-----------------|-----------|
+| `ConvertAmountSchema` | utilityTools.ts:10-15 | Simple, self-contained |
+
+---
+
+### Identified Reusable Schema Fragments
+
+These patterns appear in multiple schemas and could be extracted to `src/tools/schemas/shared/`:
+
+```typescript
+// src/tools/schemas/shared/commonInputs.ts
+
+// Budget ID - appears in 20+ schemas
+export const BudgetIdSchema = z.string().min(1, 'Budget ID is required');
+
+// ISO Date - appears in 8+ schemas
+export const ISODateSchema = z.string()
+  .regex(/^\d{4}-\d{2}-\d{2}$/, 'Date must be in ISO format (YYYY-MM-DD)');
+
+// Cleared Status - appears in 5+ schemas
+export const ClearedStatusSchema = z.enum(['cleared', 'uncleared', 'reconciled']);
+
+// Flag Color - appears in 5+ schemas
+export const FlagColorSchema = z.enum(['red', 'orange', 'yellow', 'green', 'blue', 'purple']);
+
+// Account Type - appears in create_account
+export const AccountTypeSchema = z.enum([
+  'checking', 'savings', 'creditCard', 'cash',
+  'lineOfCredit', 'otherAsset', 'otherLiability'
+]);
+
+// Milliunits Amount - appears in 6+ schemas
+export const MilliunitsAmountSchema = z.number().int('Amount must be an integer in milliunits');
+
+// CSV Format - appears in compare_transactions, reconcile_account
+export const CSVFormatSchema = z.object({
+  date_column: z.union([z.string(), z.number()]).optional(),
+  amount_column: z.union([z.string(), z.number()]).optional(),
+  debit_column: z.union([z.string(), z.number()]).optional(),
+  credit_column: z.union([z.string(), z.number()]).optional(),
+  description_column: z.union([z.string(), z.number()]).optional(),
+  date_format: z.string().optional(),
+  has_header: z.boolean().optional(),
+  delimiter: z.string().optional(),
+}).strict();
+```
+
+---
+
+### Recommended Migration Strategy
+
+1. **Phase 1:** Create `src/tools/schemas/shared/commonInputs.ts` with reusable fragments
+2. **Phase 2:** Create `src/tools/schemas/inputs/` directory structure:
+   - `budgetInputs.ts`
+   - `accountInputs.ts`
+   - `transactionInputs.ts`
+   - `categoryInputs.ts`
+   - `payeeInputs.ts`
+   - `monthInputs.ts`
+   - `reconciliationInputs.ts`
+   - `comparisonInputs.ts`
+   - `utilityInputs.ts`
+   - `index.ts` (central export)
+3. **Phase 3:** Migrate high-complexity schemas first (transactions, reconciliation)
+4. **Phase 4:** Update tool files to import from new schema locations
+5. **Phase 5:** Keep server-owned schemas inline (5 schemas in YNABMCPServer.ts)
+
+---
+
+### Summary
+
+- **22 schemas** are candidates for migration to a common inputs module
+- **5 schemas** should remain inline in `YNABMCPServer.ts` (server-owned)
+- **7 reusable fragments** can be extracted to reduce duplication
+- The existing `src/tools/schemas/outputs/` structure provides a proven pattern to follow