@dizzlkheinz/ynab-mcpb 0.15.0 → 0.15.1

package/dist/tools/reconciliation/analyzer.d.ts

@@ -2,4 +2,8 @@ import type * as ynab from 'ynab';
 import { type ParseCSVOptions, type CSVParseResult } from './csvParser.js';
 import { type MatchingConfig } from './matcher.js';
 import type { ReconciliationAnalysis } from './types.js';
-export declare function analyzeReconciliation(csvContentOrParsed: string | CSVParseResult, _csvFilePath: string | undefined, ynabTransactions: ynab.TransactionDetail[], statementBalance: number, config?: MatchingConfig, currency?: string, accountId?: string, budgetId?: string, invertBankAmounts?: boolean, csvOptions?: ParseCSVOptions): ReconciliationAnalysis;
+export declare function analyzeReconciliation(csvContentOrParsed: string | CSVParseResult, _csvFilePath: string | undefined, ynabTransactions: ynab.TransactionDetail[], statementBalance: number, config?: MatchingConfig, currency?: string, accountId?: string, budgetId?: string, invertBankAmounts?: boolean, csvOptions?: ParseCSVOptions, accountSnapshot?: {
+    balance?: number;
+    cleared_balance?: number;
+    uncleared_balance?: number;
+}): ReconciliationAnalysis;

package/dist/tools/reconciliation/analyzer.js

@@ -29,20 +29,22 @@ function mapToTransactionMatch(result) {
     }
     return match;
 }
-function calculateBalances(ynabTransactions, statementBalanceDecimal, currency) {
-    let clearedBalance = 0;
-    let unclearedBalance = 0;
+function calculateBalances(ynabTransactions, statementBalanceDecimal, currency, accountSnapshot) {
+    let computedCleared = 0;
+    let computedUncleared = 0;
     for (const txn of ynabTransactions) {
         const amount = txn.amount;
         if (txn.cleared === 'cleared' || txn.cleared === 'reconciled') {
-            clearedBalance += amount;
+            computedCleared += amount;
         }
         else {
-            unclearedBalance += amount;
+            computedUncleared += amount;
         }
     }
+    const clearedBalance = accountSnapshot?.cleared_balance ?? computedCleared;
+    const unclearedBalance = accountSnapshot?.uncleared_balance ?? computedUncleared;
+    const totalBalance = accountSnapshot?.balance ?? clearedBalance + unclearedBalance;
     const statementBalanceMilli = Math.round(statementBalanceDecimal * 1000);
-    const totalBalance = clearedBalance + unclearedBalance;
     const discrepancy = clearedBalance - statementBalanceMilli;
     return {
         current_cleared: toMoneyValue(clearedBalance, currency),
@@ -220,7 +222,7 @@ function detectInsights(unmatchedBank, _summary, balances, currency, csvErrors =
     }
     return insights.slice(0, 5);
 }
-export function analyzeReconciliation(csvContentOrParsed, _csvFilePath, ynabTransactions, statementBalance, config = DEFAULT_CONFIG, currency = 'USD', accountId, budgetId, invertBankAmounts = false, csvOptions) {
+export function analyzeReconciliation(csvContentOrParsed, _csvFilePath, ynabTransactions, statementBalance, config = DEFAULT_CONFIG, currency = 'USD', accountId, budgetId, invertBankAmounts = false, csvOptions, accountSnapshot) {
     let parseResult;
     if (typeof csvContentOrParsed === 'string') {
         parseResult = parseCSV(csvContentOrParsed, {
@@ -254,7 +256,7 @@ export function analyzeReconciliation(csvContentOrParsed, _csvFilePath, ynabTran
             matchedYnabIds.add(m.ynabTransaction.id);
     });
     const unmatchedYNAB = newYNABTransactions.filter((t) => !matchedYnabIds.has(t.id));
-    const balances = calculateBalances(newYNABTransactions, statementBalance, currency);
+    const balances = calculateBalances(newYNABTransactions, statementBalance, currency, accountSnapshot);
     const summary = generateSummary(matches.map((m) => m.bankTransaction), newYNABTransactions, autoMatches, suggestedMatches, unmatchedBank, unmatchedYNAB, balances);
     const nextSteps = generateNextSteps(summary);
     const insights = detectInsights(unmatchedBank, summary, balances, currency, csvParseErrors, csvParseWarnings);

package/dist/tools/reconciliation/index.js

@@ -230,12 +230,12 @@ export async function handleReconcileAccount(ynabAPI, deltaFetcherOrParams, mayb
                 delta_merge_applied: transactionsResult.usedDelta,
             },
         };
-        const analysis = analyzeReconciliation(parseResult ?? csvContent, params.csv_file_path, ynabTransactions, adjustedStatementBalance, config, currencyCode, params.account_id, params.budget_id, finalInvertAmounts, csvOptions);
         const initialAccount = {
             balance: accountData.balance,
             cleared_balance: accountData.cleared_balance,
             uncleared_balance: accountData.uncleared_balance,
         };
+        const analysis = analyzeReconciliation(parseResult ?? csvContent, params.csv_file_path, ynabTransactions, adjustedStatementBalance, config, currencyCode, params.account_id, params.budget_id, finalInvertAmounts, csvOptions, initialAccount);
         let executionData;
         const wantsBalanceVerification = Boolean(params.statement_date);
         const shouldExecute = params.auto_create_transactions ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dizzlkheinz/ynab-mcpb",
-  "version": "0.15.0",
+  "version": "0.15.1",
   "description": "Model Context Protocol server for YNAB (You Need A Budget) integration",
   "main": "dist/index.js",
   "type": "module",

package/src/tools/reconciliation/analyzer.ts

@@ -61,22 +61,28 @@ function calculateBalances(
   ynabTransactions: YNABTransaction[],
   statementBalanceDecimal: number,
   currency: string,
+  accountSnapshot?: { balance?: number; cleared_balance?: number; uncleared_balance?: number },
 ): BalanceInfo {
-  let clearedBalance = 0;
-  let unclearedBalance = 0;
+  // Compute from the fetched transactions, but prefer the authoritative account snapshot
+  // because we usually fetch a limited date window.
+  let computedCleared = 0;
+  let computedUncleared = 0;
 
   for (const txn of ynabTransactions) {
     const amount = txn.amount; // Milliunits
 
     if (txn.cleared === 'cleared' || txn.cleared === 'reconciled') {
-      clearedBalance += amount;
+      computedCleared += amount;
     } else {
-      unclearedBalance += amount;
+      computedUncleared += amount;
     }
   }
 
+  const clearedBalance = accountSnapshot?.cleared_balance ?? computedCleared;
+  const unclearedBalance = accountSnapshot?.uncleared_balance ?? computedUncleared;
+  const totalBalance = accountSnapshot?.balance ?? clearedBalance + unclearedBalance;
+
   const statementBalanceMilli = Math.round(statementBalanceDecimal * 1000);
-  const totalBalance = clearedBalance + unclearedBalance;
   const discrepancy = clearedBalance - statementBalanceMilli;
 
   return {
@@ -342,6 +348,7 @@ export function analyzeReconciliation(
   budgetId?: string,
   invertBankAmounts: boolean = false,
   csvOptions?: ParseCSVOptions,
+  accountSnapshot?: { balance?: number; cleared_balance?: number; uncleared_balance?: number },
 ): ReconciliationAnalysis {
   // Step 1: Parse bank CSV using new Parser (or use provided result)
   let parseResult: CSVParseResult;
@@ -398,7 +405,12 @@ export function analyzeReconciliation(
   const unmatchedYNAB = newYNABTransactions.filter((t) => !matchedYnabIds.has(t.id));
 
   // Step 6: Calculate balances
-  const balances = calculateBalances(newYNABTransactions, statementBalance, currency);
+  const balances = calculateBalances(
+    newYNABTransactions,
+    statementBalance,
+    currency,
+    accountSnapshot,
+  );
 
   // Step 7: Generate summary
   const summary = generateSummary(

package/src/tools/reconciliation/index.ts

@@ -349,6 +349,12 @@ export async function handleReconcileAccount(
         },
       };
 
+      const initialAccount: AccountSnapshot = {
+        balance: accountData.balance,
+        cleared_balance: accountData.cleared_balance,
+        uncleared_balance: accountData.uncleared_balance,
+      };
+
       // Perform analysis
       const analysis = analyzeReconciliation(
         parseResult ?? csvContent,
@@ -361,14 +367,9 @@ export async function handleReconcileAccount(
         params.budget_id,
         finalInvertAmounts, // Use smart-detected value
         csvOptions,
+        initialAccount,
       );
 
-      const initialAccount: AccountSnapshot = {
-        balance: accountData.balance,
-        cleared_balance: accountData.cleared_balance,
-        uncleared_balance: accountData.uncleared_balance,
-      };
-
       let executionData: LegacyReconciliationResult | undefined;
       const wantsBalanceVerification = Boolean(params.statement_date);
       const shouldExecute =