@dizzlkheinz/ynab-mcpb 0.13.1 → 0.15.1

package/src/tools/reconciliation/__tests__/matcher.test.ts

@@ -7,11 +7,19 @@ describe('matcher', () => {
 
   beforeEach(() => {
     config = {
+      weights: {
+        amount: 0.5,
+        date: 0.15,
+        payee: 0.35,
+      },
+      amountToleranceMilliunits: 10,
       dateToleranceDays: 2,
-      amountToleranceCents: 1,
-      descriptionSimilarityThreshold: 0.8,
       autoMatchThreshold: 90,
-      suggestionThreshold: 60,
+      suggestedMatchThreshold: 60,
+      minimumCandidateScore: 40,
+      exactAmountBonus: 10,
+      exactDateBonus: 5,
+      exactPayeeBonus: 10,
     };
   });
 
@@ -21,7 +29,7 @@ describe('matcher', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -45.23,
+          amount: -45230, // milliunits (-45.23)
           payee: 'Shell Gas Station',
           original_csv_row: 2,
         };
@@ -41,15 +49,15 @@ describe('matcher', () => {
         const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
 
         expect(match.confidence).toBe('high');
-        expect(match.confidence_score).toBeGreaterThanOrEqual(90);
-        expect(match.ynab_transaction).toEqual(ynabTxns[0]);
+        expect(match.confidenceScore).toBeGreaterThanOrEqual(90);
+        expect(match.bestMatch?.ynabTransaction).toEqual(ynabTxns[0]);
       });
 
       it('should return high confidence for normalized payee match', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -100.0,
+          amount: -100000, // milliunits (-100.00)
           payee: 'NETFLIX.COM',
           original_csv_row: 2,
         };
@@ -69,14 +77,14 @@ describe('matcher', () => {
         const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
 
         expect(match.confidence).toBe('high');
-        expect(match.confidence_score).toBeGreaterThanOrEqual(90);
+        expect(match.confidenceScore).toBeGreaterThanOrEqual(90);
       });
 
       it('should handle date within tolerance', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -50.0,
+          amount: -50000, // milliunits (-50.00)
           payee: 'Restaurant',
           original_csv_row: 2,
         };
@@ -86,8 +94,8 @@ describe('matcher', () => {
             id: 'y1',
             date: '2025-10-14', // 1 day difference
             amount: -50000,
-            payee_name: 'Restaurant',
-            category_name: 'Dining',
+            payee: 'Restaurant',
+            categoryName: 'Dining',
             cleared: 'uncleared',
             approved: true,
           },
@@ -96,16 +104,14 @@ describe('matcher', () => {
         const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
 
         expect(match.confidence).toBe('high');
-        expect(match.confidence_score).toBeGreaterThanOrEqual(90);
+        expect(match.confidenceScore).toBeGreaterThanOrEqual(90);
       });
-    });
 
-    describe('medium confidence matches (60-89%)', () => {
-      it('should return medium confidence for fuzzy payee match', () => {
+      it('should return high confidence for fuzzy payee match', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-20',
-          amount: -127.43,
+          amount: -127430, // milliunits (-127.43)
           payee: 'AMAZON.COM',
           original_csv_row: 2,
         };
@@ -124,18 +130,19 @@ describe('matcher', () => {
 
         const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
 
-        expect(match.confidence).toBe('medium');
-        expect(match.confidence_score).toBeGreaterThanOrEqual(60);
-        expect(match.confidence_score).toBeLessThan(90);
+        expect(match.confidence).toBe('high');
+        expect(match.confidenceScore).toBeGreaterThanOrEqual(90);
         expect(match.candidates).toBeDefined();
         expect(match.candidates!.length).toBeGreaterThan(0);
       });
+    });
 
+    describe('medium confidence matches (60-89%)', () => {
       it('should provide multiple candidates for medium confidence', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -50.0,
+          amount: -50000,
           payee: 'Restaurant',
           original_csv_row: 2,
         };
@@ -174,7 +181,7 @@ describe('matcher', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -45.23,
+          amount: -45230,
           payee: 'Shell',
           original_csv_row: 2,
         };
@@ -194,15 +201,15 @@ describe('matcher', () => {
         const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
 
         expect(match.confidence).toBe('none');
-        expect(match.confidence_score).toBe(0);
-        expect(match.action_hint).toBe('add_to_ynab');
+        expect(match.confidenceScore).toBe(0);
+        expect(match.bestMatch).toBeNull();
       });
 
       it('should not match opposite-signed transactions', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: 50.0, // Positive (refund)
+          amount: 50000, // Positive (refund) in milliunits
           payee: 'Amazon',
           original_csv_row: 2,
         };
@@ -222,7 +229,7 @@ describe('matcher', () => {
         const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
 
         expect(match.confidence).toBe('none');
-        expect(match.ynab_transaction).toBeUndefined();
+        expect(match.bestMatch).toBeNull();
       });
     });
 
@@ -231,7 +238,7 @@ describe('matcher', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -50.0,
+          amount: -50000,
           payee: 'Coffee Shop',
           original_csv_row: 2,
         };
@@ -260,14 +267,14 @@ describe('matcher', () => {
         const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
 
         // Should prefer uncleared transaction
-        expect(match.ynab_transaction?.id).toBe('y2');
+        expect(match.bestMatch?.ynabTransaction.id).toBe('y2');
       });
 
       it('should use date proximity as tiebreaker', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -50.0,
+          amount: -50000,
           payee: 'Store',
           original_csv_row: 2,
         };
@@ -296,7 +303,7 @@ describe('matcher', () => {
         const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
 
         // Should prefer closer date
-        expect(match.ynab_transaction?.id).toBe('y2');
+        expect(match.bestMatch?.ynabTransaction.id).toBe('y2');
       });
     });
 
@@ -305,7 +312,7 @@ describe('matcher', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -45.23,
+          amount: -45230,
           payee: 'Shell',
           original_csv_row: 2,
         };
@@ -325,16 +332,16 @@ describe('matcher', () => {
         const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
 
         expect(match.confidence).not.toBe('none');
-        expect(match.ynab_transaction).toBeDefined();
+        expect(match.bestMatch?.ynabTransaction).toBeDefined();
       });
 
       it('should not match outside amount tolerance', () => {
-        config.amountToleranceCents = 1;
+        config.amountToleranceMilliunits = 10; // 1 cent
 
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -45.0,
+          amount: -45000,
           payee: 'Shell',
           original_csv_row: 2,
         };
@@ -362,7 +369,7 @@ describe('matcher', () => {
         const bankTxn: BankTransaction = {
           id: 'b1',
           date: '2025-10-15',
-          amount: -50.0,
+          amount: -50000,
           payee: 'Store',
           original_csv_row: 2,
         };
@@ -383,7 +390,7 @@ describe('matcher', () => {
         const match = findBestMatch(bankTxn, ynabTxns, usedIds, config);
 
         expect(match.confidence).toBe('none');
-        expect(match.ynab_transaction).toBeUndefined();
+        expect(match.bestMatch).toBeNull();
       });
     });
   });
@@ -394,14 +401,14 @@ describe('matcher', () => {
         {
           id: 'b1',
           date: '2025-10-15',
-          amount: -45.23,
+          amount: -45230,
           payee: 'Shell',
           original_csv_row: 2,
         },
         {
           id: 'b2',
           date: '2025-10-16',
-          amount: -100.0,
+          amount: -100000,
           payee: 'Netflix',
           original_csv_row: 3,
         },
@@ -431,8 +438,8 @@ describe('matcher', () => {
       const matches = findMatches(bankTxns, ynabTxns, config);
 
       expect(matches).toHaveLength(2);
-      expect(matches[0].bank_transaction.id).toBe('b1');
-      expect(matches[1].bank_transaction.id).toBe('b2');
+      expect(matches[0].bankTransaction.id).toBe('b1');
+      expect(matches[1].bankTransaction.id).toBe('b2');
     });
 
     it('should prevent duplicate matching of YNAB transactions', () => {
@@ -440,14 +447,14 @@ describe('matcher', () => {
         {
           id: 'b1',
           date: '2025-10-15',
-          amount: -50.0,
+          amount: -50000,
           payee: 'Store',
           original_csv_row: 2,
         },
         {
           id: 'b2',
           date: '2025-10-15',
-          amount: -50.0,
+          amount: -50000,
           payee: 'Store',
           original_csv_row: 3,
         },
@@ -471,7 +478,7 @@ describe('matcher', () => {
 
       // First should match
       expect(matches[0].confidence).toBe('high');
-      expect(matches[0].ynab_transaction?.id).toBe('y1');
+      expect(matches[0].bestMatch?.ynabTransaction.id).toBe('y1');
 
       // Second should not match (y1 already used)
       expect(matches[1].confidence).toBe('none');
@@ -482,14 +489,14 @@ describe('matcher', () => {
         {
           id: 'b1',
           date: '2025-10-15',
-          amount: -45.23,
+          amount: -45230,
           payee: 'Shell',
           original_csv_row: 2,
         },
         {
           id: 'b2',
           date: '2025-10-16',
-          amount: -15.99,
+          amount: -15990,
           payee: 'NewStore',
           original_csv_row: 3,
         },
@@ -512,23 +519,31 @@ describe('matcher', () => {
       expect(matches).toHaveLength(2);
       expect(matches[0].confidence).toBe('high');
       expect(matches[1].confidence).toBe('none');
-      expect(matches[1].action_hint).toBe('add_to_ynab');
+      expect(matches[1].bestMatch).toBeNull();
     });
 
     it('should use custom configuration', () => {
       const customConfig: MatchingConfig = {
+        weights: {
+          amount: 0.5,
+          date: 0.15,
+          payee: 0.35,
+        },
+        amountToleranceMilliunits: 100, // 10 cents
         dateToleranceDays: 5,
-        amountToleranceCents: 10,
-        descriptionSimilarityThreshold: 0.6,
         autoMatchThreshold: 85,
-        suggestionThreshold: 50,
+        suggestedMatchThreshold: 50,
+        minimumCandidateScore: 40,
+        exactAmountBonus: 10,
+        exactDateBonus: 5,
+        exactPayeeBonus: 10,
       };
 
       const bankTxns: BankTransaction[] = [
         {
           id: 'b1',
           date: '2025-10-15',
-          amount: -50.0,
+          amount: -50000,
           payee: 'Store',
           original_csv_row: 2,
         },
@@ -565,14 +580,14 @@ describe('matcher', () => {
       const match = findBestMatch(bankTxn, [], new Set(), config);
 
       expect(match.confidence).toBe('none');
-      expect(match.recommendation).toContain('not in YNAB');
+      expect(match.bestMatch).toBeNull();
     });
 
     it('should handle null payee names', () => {
       const bankTxn: BankTransaction = {
         id: 'b1',
         date: '2025-10-15',
-        amount: -50.0,
+        amount: -50000,
         payee: 'Store',
         original_csv_row: 2,
       };
@@ -599,7 +614,7 @@ describe('matcher', () => {
       const bankTxn: BankTransaction = {
         id: 'b1',
         date: '2025-10-15',
-        amount: -0.01,
+        amount: -10, // 1 cent in milliunits
         payee: 'Micro Transaction',
         original_csv_row: 2,
       };
@@ -617,7 +632,6 @@ describe('matcher', () => {
       ];
 
       const match = findBestMatch(bankTxn, ynabTxns, new Set(), config);
-
       expect(match.confidence).toBe('high');
     });
 
@@ -625,7 +639,7 @@ describe('matcher', () => {
       const bankTxn: BankTransaction = {
         id: 'b1',
         date: '2025-10-15',
-        amount: -10000.0,
+        amount: -10000000, // $10,000 in milliunits
         payee: 'Large Purchase',
         original_csv_row: 2,
       };

package/src/tools/reconciliation/__tests__/recommendationEngine.test.ts

@@ -71,15 +71,22 @@ const createMockContext = (overrides?: Partial<RecommendationContext>): Recommen
 };
 
 // Helper to create mock bank transaction
-const createBankTransaction = (overrides?: Partial<BankTransaction>): BankTransaction => ({
-  id: 'bank-txn-1',
-  date: '2024-01-15',
-  amount: -50.0,
-  payee: 'Test Store',
-  memo: 'Test memo',
-  original_csv_row: 1,
-  ...overrides,
-});
+// NOTE: amount overrides are provided in DECIMAL units (dollars) and converted to milliunits
+const createBankTransaction = (overrides?: Partial<BankTransaction>): BankTransaction => {
+  const { amount, ...restOverrides } = overrides ?? {};
+  const baseAmount = amount ?? -50.0; // dollars
+  const amountMilli = Math.round(baseAmount * 1000); // milliunits
+
+  return {
+    id: 'bank-txn-1',
+    date: '2024-01-15',
+    amount: amountMilli,
+    payee: 'Test Store',
+    memo: 'Test memo',
+    original_csv_row: 1,
+    ...restOverrides,
+  };
+};
 
 // Helper to create mock YNAB transaction
 const createYNABTransaction = (overrides?: Partial<YNABTransaction>): YNABTransaction => ({
@@ -406,11 +413,11 @@ describe('recommendationEngine', () => {
         const ynabTxn = createYNABTransaction();
 
         const suggestedMatch: TransactionMatch = {
-          bank_transaction: bankTxn,
-          ynab_transaction: ynabTxn,
+          bankTransaction: bankTxn,
+          ynabTransaction: ynabTxn,
           confidence: 'medium',
-          confidence_score: 75,
-          match_reason: 'Fuzzy payee match',
+          confidenceScore: 75,
+          matchReason: 'Fuzzy payee match',
         };
 
         const context = createMockContext({
@@ -435,10 +442,10 @@ describe('recommendationEngine', () => {
         const bankTxn = createBankTransaction({ amount: -45.0 });
 
         const suggestedMatch: TransactionMatch = {
-          bank_transaction: bankTxn,
+          bankTransaction: bankTxn,
           confidence: 'none',
-          confidence_score: 0,
-          match_reason: 'No match found',
+          confidenceScore: 0,
+          matchReason: 'No match found',
         };
 
         const context = createMockContext({
@@ -472,7 +479,7 @@ describe('recommendationEngine', () => {
         });
 
         const suggestedMatch: TransactionMatch = {
-          bank_transaction: bankTxn,
+          bankTransaction: bankTxn,
           candidates: [
             {
               ynab_transaction: ynabTxn1,
@@ -488,8 +495,8 @@ describe('recommendationEngine', () => {
             },
           ],
           confidence: 'medium',
-          confidence_score: 60,
-          match_reason: 'combination_match',
+          confidenceScore: 60,
+          matchReason: 'combination_match',
         };
 
         const context = createMockContext({
@@ -575,10 +582,10 @@ describe('recommendationEngine', () => {
         const bankTxn = createBankTransaction({ amount: -99.99 });
 
         const suggestedMatch: TransactionMatch = {
-          bank_transaction: bankTxn,
+          bankTransaction: bankTxn,
           confidence: 'none',
-          confidence_score: 0,
-          match_reason: 'No match',
+          confidenceScore: 0,
+          matchReason: 'No match',
         };
 
         const context = createMockContext({
@@ -662,11 +669,11 @@ describe('recommendationEngine', () => {
         const bankTxn = createBankTransaction();
         const ynabTxn = createYNABTransaction({ cleared: 'uncleared' });
         const suggestedMatch: TransactionMatch = {
-          bank_transaction: bankTxn,
-          ynab_transaction: ynabTxn,
+          bankTransaction: bankTxn,
+          ynabTransaction: ynabTxn,
           confidence: 'medium',
-          confidence_score: 75,
-          match_reason: 'Suggested',
+          confidenceScore: 75,
+          matchReason: 'Suggested',
         };
 
         const insights = [
@@ -967,11 +974,11 @@ describe('recommendationEngine', () => {
         const bankTxn = createBankTransaction({ id: 'b1' });
         const ynabTxn = createYNABTransaction({ id: 'y1', cleared: 'uncleared' });
         const suggestedMatch: TransactionMatch = {
-          bank_transaction: createBankTransaction({ id: 'b2' }),
-          ynab_transaction: createYNABTransaction({ id: 'y2' }),
+          bankTransaction: createBankTransaction({ id: 'b2' }),
+          ynabTransaction: createYNABTransaction({ id: 'y2' }),
           confidence: 'medium',
-          confidence_score: 75,
-          match_reason: 'Suggested',
+          confidenceScore: 75,
+          matchReason: 'Suggested',
         };
         const insights = [
           createInsight('near_match', 'warning'),

package/src/tools/reconciliation/__tests__/reportFormatter.test.ts

@@ -76,7 +76,7 @@ const createBankTransaction = (
 ): BankTransaction => ({
   id,
   date,
-  amount,
+  amount: Math.round(amount * 1000),
   payee,
   original_csv_row: 1,
 });
@@ -278,12 +278,13 @@ describe('reportFormatter', () => {
       const analysis = createTestAnalysis({
         suggested_matches: [
           {
-            bank_transaction: createBankTransaction('bank-1', -60.0, 'Amazon', '2025-10-20'),
+            bankTransaction: createBankTransaction('bank-1', -60.0, 'Amazon', '2025-10-20'),
+            ynabTransaction: undefined,
             candidates: [],
             confidence: 'medium',
-            confidence_score: 75,
-            match_reason: 'amount_and_date_fuzzy_payee',
-            top_confidence: 75,
+            confidenceScore: 75,
+            matchReason: 'amount_and_date_fuzzy_payee',
+            topConfidence: 75,
           },
         ],
       });

package/src/tools/reconciliation/__tests__/scenarios/extremes.scenario.test.ts

@@ -1,11 +1,10 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest';
 import { analyzeReconciliation } from '../../analyzer.js';
 import type { TransactionDetail } from 'ynab';
-import * as parser from '../../../compareTransactions/parser.js';
+import * as csvParser from '../../csvParser.js';
 
-vi.mock('../../../compareTransactions/parser.js', () => ({
-  parseBankCSV: vi.fn(),
-  readCSVFile: vi.fn(),
+vi.mock('../../csvParser.js', () => ({
+  parseCSV: vi.fn(),
 }));
 
 describe('scenario: zero, negative, and large statements', () => {
@@ -14,16 +13,36 @@ describe('scenario: zero, negative, and large statements', () => {
   });
 
   it('handles zero and negative statement balances with mixed unmatched items', () => {
-    vi.mocked(parser.parseBankCSV).mockReturnValue({
+    vi.mocked(csvParser.parseCSV).mockReturnValue({
       transactions: [
-        { date: '2025-11-01', amount: 0, payee: 'Zero Adjustment', memo: '' },
-        { date: '2025-11-02', amount: 2500, payee: 'Interest', memo: '' },
+        {
+          id: 'b1',
+          date: '2025-11-01',
+          amount: 0,
+          payee: 'Zero Adjustment',
+          memo: '',
+          sourceRow: 2,
+          raw: { date: '2025-11-01', amount: '0', description: 'Zero Adjustment' },
+        },
+        {
+          id: 'b2',
+          date: '2025-11-02',
+          amount: 2500000,
+          payee: 'Interest',
+          memo: '',
+          sourceRow: 3,
+          raw: { date: '2025-11-02', amount: '2500.00', description: 'Interest' },
+        },
       ],
-      format_detected: 'standard',
-      delimiter: ',',
-      total_rows: 2,
-      valid_rows: 2,
       errors: [],
+      warnings: [],
+      meta: {
+        detectedDelimiter: ',',
+        detectedColumns: ['Date', 'Description', 'Amount'],
+        totalRows: 2,
+        validRows: 2,
+        skippedRows: 0,
+      },
     });
 
     const ynabTxns: TransactionDetail[] = [